Repository navigation
Add support for plain control types - #1487
Conversation
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
So overall this looks good, however it's a breaking change due to the addition of the union type. I'm personally fine with that, but it will necessitate a major version change.
|
Failed a formatting check: |
|
If you have an idea how I can make non-breaking change I’m willing to make change. I only learning F# so maybe I do not see some obvious change. Also second selfish question. What are usual release cadence for this lib? Or maybe if nightly available from main branch somewhere? |
|
Yeah, I don't know of a way to make this non-breaking, so it's fine. I doubt most people rely on this type and pattern match on it. Release schedule is whenever I cut a release, heh. I'll probably do that soon once this lands, assuming CI gets green. |
|
I think I done with formatting.
I like this spirit. Now I can take a look, and shop for fun up for grabs. |
|
Let me wrestle with Fake. 😢 |
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Alrighty, re-review looks good -- I'll merge this puppy in and see what all else is needed for another update this week.
| run: dotnet paket restore | ||
| - name: Build and test (Release) | ||
| env: | ||
| FAKE_DETAILED_ERRORS: true |
|
Most of issues which I have is that I being unable to make Fake run. So I really should either fix Fake somehow or beg for babysitting me by somebody. |
|
@cartermp can I have some fresh and tasty release please ? ) |
|
Done! |
|
Thank you!!!! |
2 participants
Closes: #1193