Fix FavourSingleton rule false negatives - #883
Merged
Merged
Conversation
For lists that are not right-hand side of a binding.
Made it fire on single-item lists in all positions, not only in let bindings.
For single-item lists where item is not a constant or an identifier.
Made it fire on single-item lists where item is not a constant or an identifier.
knocte
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously FavourSingleton rule would only fire on lists that are right-hand side of let binding, and only on single-item lists where item is a constant or an identifier.
Extended FavourSingleton to consider all single-item lists and arrays, and added regression tests.