Repository navigation
Conversation
Signed-off-by: Greg Allen <gallen@redhat.com>
|
Opened in error; this was intended as a local persistent instruction, not a pull request. |
PR Summary by QodoRequire direct replies to existing GitHub review threads
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo
1. Review bots cannot reply to threads
|
| When responding to an existing inline pull request review thread, always use | ||
| `POST /repos/{owner}/{repo}/pulls/{pull_number}/comments/{comment_id}/replies` | ||
| with the top-level review comment ID. Do not use a review creation/submission | ||
| operation or the GraphQL `addPullRequestReviewThreadReply` mutation for thread |
There was a problem hiding this comment.
1. Review bots cannot reply to threads 🐞 Bug ≡ Correctness
The new instruction requires agents to perform a writable GitHub REST mutation, but the review agent only has read-only REST and GraphQL permissions. Whenever the review agent handles a fixed existing thread, it cannot use the mandated endpoint from its sandbox, and the post-review path still publishes through the generic review operation instead.
Agent Prompt
Issue description
The new repository instruction mandates direct REST replies to existing GitHub review threads, but the review agent runs with read-only forge permissions and the post-review workflow publishes through the generic review operation. As a result, the required behavior cannot be performed by the agent that is expected to follow this instruction.
Fix Focus Areas
- AGENTS.md[173-179]
- agents/review.md[235-242]
- scripts/post-review.sh[123-129]
Recommended Fix
Implement the direct-reply and separate-thread-resolution behavior in the trusted post-review workflow, passing the top-level comment ID and reply body from validated agent output, or explicitly scope this instruction to an agent with a writable GitHub API path. Ensure unfixed threads remain open and avoid creating or submitting pending reviews for replies.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| When responding to an existing inline pull request review thread, always use | ||
| `POST /repos/{owner}/{repo}/pulls/{pull_number}/comments/{comment_id}/replies` | ||
| with the top-level review comment ID. Do not use a review creation/submission | ||
| operation or the GraphQL `addPullRequestReviewThreadReply` mutation for thread |
There was a problem hiding this comment.
2. Thread replies skew review audits 🔗 Cross-repo conflict ≡ Correctness
The new guidance makes agents reply through the direct REST endpoint, which GitHub may record as a COMMENTED review, while autonomy-analysis classifies every review authored by fullsend-ai-review[bot] as a verdict. Those reply records can be paired with the latest finding and counted by the verdict-mismatch audit, distorting review measurements for PRs using this workflow.
Agent Prompt
## Issue description
Direct GitHub thread replies may create `COMMENTED` review records, but autonomy-analysis currently classifies every review from `fullsend-ai-review[bot]` as a review verdict. This can make a reply appear to be an additional verdict and can produce incorrect verdict-mismatch audit results.
## Fix Focus Areas
- skills/gather-review-observations/scripts/fetch-pr-activity.sh[48-54]
- skills/audit-pr-review-gap/scripts/check-verdict-mismatch.py[81-122]
## Recommended Fix
Update autonomy-analysis to identify and exclude review records created as a consequence of direct inline-thread replies, or otherwise distinguish actual post-review verdicts from `COMMENTED` reply records before classifying them as `review_agent_verdict`. Add a fixture covering a bot-authored direct thread reply that produces a `COMMENTED` review and verify it does not create an extra verdict or mismatch pair.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
🤖 Finished Review · ✅ Success · Started 11:45 PM UTC · Completed 11:50 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.94 |
|
Review skipped — this PR is already closed. The Posted by fullsend pre-review check |
|
Review skipped — this PR is already closed. The Posted by fullsend post-review check |
Summary
Require agents to reply to existing GitHub inline review threads through the dedicated REST reply endpoint using the top-level comment ID. Resolve threads separately only after verifying the finding is fixed, and leave unfixed threads open.
The instruction also avoids explicit review creation/submission and the GraphQL thread-reply mutation, which produced separate
COMMENTEDreview records during PR #8441 cleanup.Verification
make lintpassed.