Repository navigation
test: /ok-to-test fork-path validation (do not merge) - #1980
waynesun09 wants to merge 1 commit into
Conversation
Draft PR from a fork to confirm ok-to-test.yml runs both suites with real secrets after fullsend-ai#1976. Refs fullsend-ai#1975. Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
|
/ok-to-test 74337a1 |
|
Functional and behaviour tests authorized for |
|
🤖 Finished Review · ✅ Success · Started 10:44 PM UTC · Completed 10:51 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.10 |
|
Risk Assessment: moderate (2/5) DetailsWhile the PR is a minimal two-line validation probe, moderate risk (score 2) is driven by modifying a protected agent path coupled with elevated regression history and change coupling in git history. |
ReviewFindingsMedium
Low
|
| - Write in second person ("you") addressing the reporter. Do not use first person ("I") — the comment is from the triage system, not an individual. | ||
| - If you include `label_actions` or `component_actions`, do not discuss current or recommended labels or components in the `comment` field. The pipeline appends the reasons after applying the actions. | ||
|
|
||
| <!-- /ok-to-test fork-path validation for #1975; do not merge --> |
There was a problem hiding this comment.
[low] scope-exceeded
The appended HTML comment is outside the scope of #1975, which does not cover agent definition changes. The PR is a disclosed draft marked do not merge, so this only matters if merged by mistake.
Suggested fix: Do not merge; close the PR when the fork-path validation finishes, as the author states.
|
Validation done: /ok-to-test run 43322281969 ran functional (triage) and behaviour with real secrets on 74337a1; both checks succeeded on this sha. Closing. |
Validation only, do not merge. Refs #1975.
This draft PR checks the fork path added in #1976 with real secrets: a fork PR gets no Functional or Behaviour run on
pull_request, and then a/ok-to-test <sha>comment from a writer runs both suites and reportsfunctional-tests-completeandbehaviouron that sha.The only change is an HTML comment at the end of
agents/triage.md, which selects the triage functional eval and the behaviour suite. I will close this PR when the check finishes.