Skip to content

test: /ok-to-test fork-path validation (do not merge) - #1980

Closed
waynesun09 wants to merge 1 commit into
fullsend-ai:mainfrom
waynesun09:ok-to-test-fork-check
Closed

waynesun09 wants to merge 1 commit into
fullsend-ai:mainfrom
waynesun09:ok-to-test-fork-check

Conversation

@waynesun09

Copy link
Copy Markdown
Member

Validation only, do not merge. Refs #1975.

This draft PR checks the fork path added in #1976 with real secrets: a fork PR gets no Functional or Behaviour run on pull_request, and then a /ok-to-test <sha> comment from a writer runs both suites and reports functional-tests-complete and behaviour on that sha.

The only change is an HTML comment at the end of agents/triage.md, which selects the triage functional eval and the behaviour suite. I will close this PR when the check finishes.

Draft PR from a fork to confirm ok-to-test.yml runs both suites with real secrets after fullsend-ai#1976. Refs fullsend-ai#1975.

Assisted-by: Claude
Signed-off-by: Wayne Sun <gsun@redhat.com>
@waynesun09

Copy link
Copy Markdown
Member Author

/ok-to-test 74337a1

@github-actions

Copy link
Copy Markdown

Functional and behaviour tests authorized for 74337a13a42b759e210b7b37ff975237db0fbf0a (run). A new push needs a new /ok-to-test <sha>.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:44 PM UTC · Completed 10:51 PM UTC

Commit: 74337a1 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.10

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Nov 12, 2026
@fullsend-ai-review

Copy link
Copy Markdown

Risk Assessment: moderate (2/5)

Details

While the PR is a minimal two-line validation probe, moderate risk (score 2) is driven by modifying a protected agent path coupled with elevated regression history and change coupling in git history.

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Medium

Low

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

Comment thread agents/triage.md
- Write in second person ("you") addressing the reporter. Do not use first person ("I") — the comment is from the triage system, not an individual.
- If you include `label_actions` or `component_actions`, do not discuss current or recommended labels or components in the `comment` field. The pipeline appends the reasons after applying the actions.

<!-- /ok-to-test fork-path validation for #1975; do not merge -->

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] scope-exceeded

The appended HTML comment is outside the scope of #1975, which does not cover agent definition changes. The PR is a disclosed draft marked do not merge, so this only matters if merged by mistake.

Suggested fix: Do not merge; close the PR when the fork-path validation finishes, as the author states.

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Nov 12, 2026
@waynesun09

Copy link
Copy Markdown
Member Author

Validation done: /ok-to-test run 43322281969 ran functional (triage) and behaviour with real secrets on 74337a1; both checks succeeded on this sha. Closing.

@waynesun09 waynesun09 closed this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-manual-review Review requires human judgment risk/moderate PR risk: moderate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant