Repository navigation
Conversation
When triage adds ready-to-code, following the manual start hint can cancel the code run that the label already triggered. Explain the automatic path and reserve the command for a deliberate new run with different instructions. Keep the manual hint for other sufficient issues. Signed-off-by: Ben Kapner <benkapner@gmail.com>
PR Summary by QodoClarify code-run hints after triage auto-promotion
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Code Review by Qodo
1. Footer fails to say code run started
|
| if [[ "${DEFERRED_LABEL}" == "ready-to-code" ]]; then | ||
| NEXT_STEPS='- With automatic dispatch enabled, the `ready-to-code` label starts the code agent. No command is needed. | ||
| - To start a new run with different instructions, use `/fs-code <your instruction>`.' |
There was a problem hiding this comment.
1. Footer fails to say code run started 📎 Requirement gap ≡ Correctness
The ready-to-code footer in scripts/post-triage.src.sh begins with the conditional phrase "With automatic dispatch enabled ... starts the code agent", even though that branch only runs after AUTO_CODE_ALLOWED is true and DEFERRED_LABEL is set, so dispatch is already known. Because the wording is conditional and future-tense, maintainers cannot tell whether a run has started and may invoke /fs-code, cancelling it; the same text is copied into the generated scripts/post-triage.sh.
Agent Prompt
## Issue description
The sufficient-triage footer in `scripts/post-triage.src.sh` (and the generated `scripts/post-triage.sh`) uses conditional wording, "With automatic dispatch enabled ... starts the code agent", when the `ready-to-code` label is applied. That branch only runs after `AUTO_CODE_ALLOWED` is true and `DEFERRED_LABEL` is set, so dispatch is already known. The footer should state as fact that the code agent has already been dispatched, matching checklist item 4134520, so maintainers do not cancel a run by invoking `/fs-code`.
## Fix Focus Areas
- scripts/post-triage.src.sh[894-899]
- scripts/post-triage.sh[2360-2366]
- scripts/post-triage-test.sh[1054-1058]
## Recommended Fix
In the `ready-to-code` branch of `scripts/post-triage.src.sh`, replace the conditional opening with a direct statement such as `🚀 Code agent automatically dispatched to create a PR`. Keep the second bullet offering `/fs-code <your instruction>` only as a way to add guidance or start a new run. Optionally add a line on what to do if the run does not appear. Regenerate `scripts/post-triage.sh` from the source with `make script-build` and confirm with `make check-bundle`. Update the regression check in `scripts/post-triage-test.sh` so it asserts the dispatched wording rather than only the `ready-to-code` label phrase.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
🤖 Finished Review · ✅ Success · Started 4:21 PM UTC · Completed 4:27 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.25 |
|
Risk Assessment: moderate (2/5) DetailsSmall 36-line triage footer update in protected scripts path with elevated churn and regression history, but tight issue alignment and accompanying unit tests keep risk moderate. Previous runRisk Assessment: moderate (2/5) DetailsSmall 33-line triage footer update in protected scripts path with elevated churn and regression history, but tight issue alignment and accompanying unit tests keep risk moderate. |
ReviewFindingsMedium
Previous run<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJjb21tZW50IiwiZmluZGluZ3MiOltdfQ== --> ReviewFindingsMedium
Labels: PR fixes a bug in triage footer messaging |
Signed-off-by: Ben Kapner <benkapner@gmail.com>
|
🤖 Finished Review · ✅ Success · Started 5:22 PM UTC · Completed 5:29 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.53 |
Summary
When triage adds
ready-to-code, the label can start a code run automatically. The triage comment still told the maintainer to post/fs-code. In the case reported in #1965, following that hint cancelled the active run and started a second one.Related Issue
Closes #1965.
Changes
ready-to-code, explain that repositories with automatic dispatch start the code agent from that label./fs-code <your instruction>as a way to start a new run with different instructions.Testing
bash scripts/post-triage-test.sh --bundledpassed all 305 checks.make testmake script-buildandmake check-bundlemake lint,pre-commit run --all-files, andgit diff --checkThe ten-issue production check in #1965 is a follow-up after rollout.
Checklist