Skip to content

Move gcp-vertex.env to common/env/ - #7

Merged
ggallen merged 1 commit into
mainfrom
move-gcp-vertex-to-common
Jul 1, 2026
Merged

ggallen merged 1 commit into
mainfrom
move-gcp-vertex-to-common

Conversation

@ggallen

@ggallen ggallen commented Jul 1, 2026

Copy link
Copy Markdown
Member

Summary

  • Move env/gcp-vertex.env → common/env/gcp-vertex.env
  • Update triage harness host_files path to match

Shared infrastructure env files (used by all agents) belong under common/ to distinguish them from agent-specific files like env/triage.env.

Test plan

  • After merging, update ggallen-sandbox/.fullsend config SHA and re-run /fs-triage

🤖 Generated with Claude Code

Shared infrastructure env files belong under common/ to distinguish
them from agent-specific env files. Update triage harness path.

Signed-off-by: Claude <noreply@anthropic.com>
Signed-off-by: Greg Allen <gallen@redhat.com>
@ggallen
ggallen merged commit 9f06328 into main Jul 1, 2026
3 checks passed
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Move gcp-vertex env file to common/env and update triage harness path

⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

AI Description

• Relocate shared GCP Vertex env file from agent-specific env/ to common/env/.
• Update triage harness host_files mapping to reference the new env path.
Diagram

graph TD
  A["harness/triage.yaml"] --> B["common/env/gcp-vertex.env"] --> C["/sandbox/.../.env.d/gcp-vertex.env"]
  A --> D["${GOOGLE_APPLICATION_CREDENTIALS}"]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Keep file in env/ and document shared vs agent-specific usage
  • ➕ No path changes required for existing harnesses/scripts
  • ➕ Avoids churn for downstream repos that reference env/ directly
  • ➖ Blurs ownership/intent (shared infra vs agent-specific)
  • ➖ Encourages further mixing of common and agent-scoped env files
2. Add a compatibility shim (copy or symlink) at env/gcp-vertex.env
  • ➕ Preserves backwards compatibility for external consumers
  • ➕ Allows gradual migration to common/env
  • ➖ Adds duplication or symlink handling complexity across platforms/tools
  • ➖ Risk of drift if a copied file isn’t kept in sync

Recommendation: The chosen approach (moving to common/env and updating the harness reference) is the cleanest long-term organization for shared infrastructure env files. If there are known external consumers that still read env/gcp-vertex.env, consider a temporary compatibility shim; otherwise, the direct move is preferable to prevent further mixing of shared vs agent-specific configuration.

Files changed (2) +1 / -1

Other (2) +1 / -1
gcp-vertex.envRelocate shared GCP Vertex environment file under common/env +0/-0

Relocate shared GCP Vertex environment file under common/env

• Introduces the shared GCP Vertex environment file at common/env/gcp-vertex.env to reflect that it is infrastructure-wide rather than agent-specific.

common/env/gcp-vertex.env

triage.yamlUpdate triage harness to mount env file from common/env +1/-1

Update triage harness to mount env file from common/env

• Updates host_files to reference common/env/gcp-vertex.env instead of env/gcp-vertex.env so the triage sandbox mounts the relocated shared env file correctly.

harness/triage.yaml

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@fullsend-ai-review

fullsend-ai-review Bot commented Jul 1, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 12:49 PM UTC · Completed 12:51 PM UTC
Commit: f987474 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review skipped — this PR is already merged.

The /fs-review command only reviews open pull requests.

Posted by fullsend pre-review check

@fullsend-ai-retro

fullsend-ai-retro Bot commented Jul 1, 2026 •

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 12:50 PM UTC · Completed 12:56 PM UTC
Commit: f987474 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review skipped — this PR is already merged.

The /fs-review command only reviews open pull requests.

Posted by fullsend post-review check

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #7 — Move gcp-vertex.env to common/env/

Workflow went well overall. This was a trivial human-authored refactoring PR (file rename + one-line path update) that was merged 20 seconds after creation. The review agent was dispatched via pull_request_target, correctly detected the PR was already merged, and posted a skip message — minimal token waste. The retro agent was then dispatched despite no meaningful agent interaction to analyze.

Timeline

  1. 12:39 — PR Add shared GCP Vertex AI env template #6 merged (added env/gcp-vertex.env)
  2. 12:46:23 — PR Move gcp-vertex.env to common/env/ #7 opened (move file to common/env/)
  3. 12:46:43 — PR Move gcp-vertex.env to common/env/ #7 merged (20s after creation)
  4. 12:46:46 — fullsend workflow triggered review dispatch
  5. 12:49:26 — Review agent posted "review started"
  6. 12:49:28 — Review agent posted "review skipped — already merged"
  7. 12:50:49 — Retro agent dispatched

Improvement opportunities (all already tracked)

All candidate proposals are covered by existing open issues in fullsend-ai/fullsend:

  • Skip review dispatch for already-merged PRs → #1439, #1870
  • Cancel in-flight review when PR merges → #2388
  • Skip retro dispatch for human PRs with no agent involvement → #2708
  • Pre-review skip should halt workflow to prevent token waste → #2809

No new proposals needed — existing issues adequately cover the identified improvements.

andrewevansrh added a commit to andrewevansrh/agents that referenced this pull request Oct 21, 2026
…ntegration

- Sanitize JIRA_TOKEN before ::add-mask:: to prevent workflow-command
  injection via crafted tokens (finding fullsend-ai#1)
- Remove reporter from required-field exemptions so validation catches
  projects that require Reporter without a default (finding fullsend-ai#4)
- Track whether Labels is required and reject proposals with empty
  labels before create instead of letting Jira reject them (finding fullsend-ai#5)
- Defer duplicate-check failure exit until after summary and Slack
  notification so already-created issues are reported (finding fullsend-ai#6)
- Distinguish absent isLast from explicit false in createmeta pagination
  so a paginated response without total is not treated as single-page
  (finding fullsend-ai#7)
- Document re-registering the agent source to the local Jira harness
  so fullsend resolves it instead of the remote pinned source (finding fullsend-ai#9)
- Pass createmeta pages through temp files instead of --argjson to avoid
  argument-size limits on large projects; strip allowedValues (finding fullsend-ai#10)
- Add _scribe_jira_api_with_status for error-body-preserving API calls
  and use it for label writes (finding fullsend-ai#11)
- Regenerate bundled scripts

Signed-off-by: anevans <anevans@redhat.com>
andrewevansrh added a commit to andrewevansrh/agents that referenced this pull request Oct 26, 2026
…ntegration

- Sanitize JIRA_TOKEN before ::add-mask:: to prevent workflow-command
  injection via crafted tokens (finding fullsend-ai#1)
- Remove reporter from required-field exemptions so validation catches
  projects that require Reporter without a default (finding fullsend-ai#4)
- Track whether Labels is required and reject proposals with empty
  labels before create instead of letting Jira reject them (finding fullsend-ai#5)
- Defer duplicate-check failure exit until after summary and Slack
  notification so already-created issues are reported (finding fullsend-ai#6)
- Distinguish absent isLast from explicit false in createmeta pagination
  so a paginated response without total is not treated as single-page
  (finding fullsend-ai#7)
- Document re-registering the agent source to the local Jira harness
  so fullsend resolves it instead of the remote pinned source (finding fullsend-ai#9)
- Pass createmeta pages through temp files instead of --argjson to avoid
  argument-size limits on large projects; strip allowedValues (finding fullsend-ai#10)
- Add _scribe_jira_api_with_status for error-body-preserving API calls
  and use it for label writes (finding fullsend-ai#11)
- Regenerate bundled scripts

Signed-off-by: anevans <anevans@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant