Skip to content

chore: remove pinned agent digests, rely on CLI fallback - #54

Merged
ggallen merged 3 commits into
mainfrom
remove-agent-digest-pins
Aug 22, 2026
Merged

ggallen merged 3 commits into
mainfrom
remove-agent-digest-pins

Conversation

@ggallen

@ggallen ggallen commented Aug 22, 2026

Copy link
Copy Markdown
Member

Summary

  • Remove the 7 pinned fullsend-ai/agents SHA+hash entries from .fullsend/config.yaml
  • Keep the qualityflow agent entry (external repo, not covered by CLI fallback)
  • The CLI now falls back to resolving agents from heads/main when no agents are configured, making these pins unnecessary
  • The automated digest sync job created commit churn on every push to agents main, and the pins were always stale by the time they landed

Test plan

  • Verify fullsend agents (triage, code, fix, review, retro, prioritize, scribe) still resolve correctly via CLI fallback
  • Verify qualityflow agent still resolves from its pinned external source

🤖 Generated with Claude Code

The CLI now falls back to resolving agents from heads/main when no
agents are configured in config.yaml, making the pinned SHA+hash
entries unnecessary. These pins were kept current by an automated
sync job that created commit churn on every push to agents main,
and were always one commit behind by the time they landed.

The qualityflow agent is retained because it comes from an external
repo (redhat-community-ai-tools/qualityflow-fullsend) and is not
covered by the CLI's agents-repo fallback.

Signed-off-by: Greg Allen <gallen@redhat.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Greg Allen <gallen@redhat.com>
@ggallen
ggallen requested a review from a team August 22, 2026 18:41
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Remove pinned agent digests from config and rely on CLI agent fallback

⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Removes pinned fullsend-ai/agents SHA+digest entries to reduce automated commit churn
• Relies on CLI fallback to resolve default agents from heads/main when config omits them
• Keeps qualityflow agent pinned because it is sourced from an external repository
Diagram

graph TD
  U((User)) --> CLI["Fullsend CLI"] --> CFG[/".fullsend/config.yaml"/] --> DEC{"Agents configured?"}
  DEC -->|"No"| FALL["Fallback: agents@main"] --> GH{{"GitHub raw: fullsend-ai/agents"}}
  DEC -->|"Yes"| QF["Pinned: qualityflow"] --> EXT{{"GitHub raw: qualityflow-fullsend"}}
  subgraph Legend
    direction LR
    _u((User)) ~~~ _p["Process"] ~~~ _c[/"Config"/] ~~~ _d{"Decision"} ~~~ _e{{"External"}}
  end
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Pin to a moving tag/release instead of commits
  • ➕ More reproducible than heads/main while still reducing day-to-day churn
  • ➕ Allows controlled upgrades of agent behavior
  • ➖ Requires a release/tagging process in the agents repo
  • ➖ Still needs periodic updates when consuming newer releases
2. Keep pins but update on a slower cadence (scheduled sync)
  • ➕ Preserves deterministic agent inputs (commit+sha256)
  • ➕ Reduces churn compared to syncing on every agents/main push
  • ➖ Pins will still drift and can still be stale between sync windows
  • ➖ Ongoing maintenance burden for the sync mechanism
3. Add an explicit config knob for fallback branch/ref
  • ➕ Gives users control to pin to a branch, tag, or commit without listing every agent
  • ➕ Keeps config compact while allowing reproducibility when needed
  • ➖ Requires CLI feature surface area and documentation
  • ➖ More combinations to test/support

Recommendation: Given the stated goal (eliminate noisy churn from constantly-updated pins) and the presence of a CLI fallback that already resolves default agents, this PR’s approach is appropriate. The main tradeoff is reduced reproducibility (heads/main can change behavior). If deterministic runs become important, consider a tag/release-based pinning strategy or a single ref-level knob rather than per-agent pinned URLs.

Files changed (1) +0 / -7

Other (1) +0 / -7
config.yamlRemove pinned default agent sources; keep external qualityflow pin +0/-7

Remove pinned default agent sources; keep external qualityflow pin

• Deletes the seven pinned fullsend-ai/agents raw GitHub URLs (commit+sha256) from the configured agents list. Retains the qualityflow agent entry, which still points to a pinned external repository source not covered by the CLI fallback resolution.

.fullsend/config.yaml

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 22, 2026 •

Copy link
Copy Markdown

🤖 Review · ⚠️ Cancelled · Started 6:43 PM UTC · Ended 6:51 PM UTC

Commit: 882478a · View workflow run →

@qodo-code-review

qodo-code-review Bot commented Aug 22, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📜 Skill insights (0)

Grey Divider


Action required

1. Missing core agent registrations 🐞 Bug ≡ Correctness
Description
.fullsend/config.yaml now registers only the qualityflow harness, but the repo config still
declares core roles (triage/coder/review/retro/prioritize) that previously depended on the removed
harness registrations. This can cause fullsend run <agent> for the removed agents to fail with
harness file not found because they are no longer registered in config.
Code

.fullsend/config.yaml[L16-19]

-    - source: https://raw.githubusercontent.com/fullsend-ai/agents/de64c17219ce3cfcf034882e56f56c20d2e462d2/harness/triage.yaml#sha256=44b1cecd335aa0a857e3d11a9224d9a1fb8ca60d2ffbd3abe3b84c6c7653e1c9
-    - source: https://raw.githubusercontent.com/fullsend-ai/agents/de64c17219ce3cfcf034882e56f56c20d2e462d2/harness/code.yaml#sha256=0658cd738a4747a2ebac4726c857dca466cca54f9c92305a3a9fea3587a6866b
-    - source: https://raw.githubusercontent.com/fullsend-ai/agents/de64c17219ce3cfcf034882e56f56c20d2e462d2/harness/fix.yaml#sha256=929c8b44f724cf6f385c9fa2987786a24813c331bd9537ca7b01e90a7ef26e9d
-    - source: https://raw.githubusercontent.com/fullsend-ai/agents/de64c17219ce3cfcf034882e56f56c20d2e462d2/harness/review.yaml#sha256=8e761b0f56f87379635ca559dc33b5aa45304f8c951d75f456a0d2a42456531c
Relevance

●● Moderate

PR explicitly relies on CLI fallback, but no historical review precedent confirms fallback prevents
this failure.

PR-#52

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The repo-level config still declares roles like triage, review, retro, and prioritize, but
the agents: list now contains only the qualityflow harness source. The repository’s own
troubleshooting guide documents that missing agents: registration causes harness file not found,
which is the expected failure mode when those removed harnesses are invoked.

.fullsend/config.yaml[8-20]
0025-subagent-process-isolation/README.md[172-180]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The PR removes the harness registrations for the standard fullsend agents (triage/code/fix/review/retro/prioritize/scribe) from `.fullsend/config.yaml`. The repo config still declares roles that expect those agents to exist; when a harness is not registered, `fullsend` can error with `harness file not found`.

## Issue Context
The current config registers only `qualityflow` under `agents:`.

## Fix
Make sure the standard agents are still registered in a way that matches the new intended behavior:
- If the CLI fallback only applies when **no agents are configured**, then either:
 1) Re-add the standard agents explicitly (but without pinned digests, e.g., using `heads/main` sources), **and** keep qualityflow; or
 2) Remove the `agents:` section entirely to allow fallback, and register qualityflow via whatever supported “extra agents” mechanism exists (only if such a mechanism is supported by the CLI).

## Fix Focus Areas
- .fullsend/config.yaml[8-20]
- 0025-subagent-process-isolation/README.md[172-180]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Context sources
✅ Compliance rules (platform): 19 rules
✅ Skills: writing-how-to

Grey Divider

Tip of the day
💡 Did you know, you can commit Qodo's fix in one click with committable suggestions (GitHub & GitLab)

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment thread .fullsend/config.yaml Outdated
Comment on lines -16 to -19
- source: https://raw.githubusercontent.com/fullsend-ai/agents/de64c17219ce3cfcf034882e56f56c20d2e462d2/harness/triage.yaml#sha256=44b1cecd335aa0a857e3d11a9224d9a1fb8ca60d2ffbd3abe3b84c6c7653e1c9
- source: https://raw.githubusercontent.com/fullsend-ai/agents/de64c17219ce3cfcf034882e56f56c20d2e462d2/harness/code.yaml#sha256=0658cd738a4747a2ebac4726c857dca466cca54f9c92305a3a9fea3587a6866b
- source: https://raw.githubusercontent.com/fullsend-ai/agents/de64c17219ce3cfcf034882e56f56c20d2e462d2/harness/fix.yaml#sha256=929c8b44f724cf6f385c9fa2987786a24813c331bd9537ca7b01e90a7ef26e9d
- source: https://raw.githubusercontent.com/fullsend-ai/agents/de64c17219ce3cfcf034882e56f56c20d2e462d2/harness/review.yaml#sha256=8e761b0f56f87379635ca559dc33b5aa45304f8c951d75f456a0d2a42456531c

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Missing core agent registrations 🐞 Bug ≡ Correctness

.fullsend/config.yaml now registers only the qualityflow harness, but the repo config still
declares core roles (triage/coder/review/retro/prioritize) that previously depended on the removed
harness registrations. This can cause fullsend run <agent> for the removed agents to fail with
harness file not found because they are no longer registered in config.
Agent Prompt
## Issue description
The PR removes the harness registrations for the standard fullsend agents (triage/code/fix/review/retro/prioritize/scribe) from `.fullsend/config.yaml`. The repo config still declares roles that expect those agents to exist; when a harness is not registered, `fullsend` can error with `harness file not found`.

## Issue Context
The current config registers only `qualityflow` under `agents:`.

## Fix
Make sure the standard agents are still registered in a way that matches the new intended behavior:
- If the CLI fallback only applies when **no agents are configured**, then either:
  1) Re-add the standard agents explicitly (but without pinned digests, e.g., using `heads/main` sources), **and** keep qualityflow; or
  2) Remove the `agents:` section entirely to allow fallback, and register qualityflow via whatever supported “extra agents” mechanism exists (only if such a mechanism is supported by the CLI).

## Fix Focus Areas
- .fullsend/config.yaml[8-20]
- 0025-subagent-process-isolation/README.md[172-180]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@ggallen
ggallen added this pull request to the merge queue Aug 22, 2026
Merged via the queue into main with commit 8370148 Aug 22, 2026
10 of 11 checks passed
@ggallen
ggallen deleted the remove-agent-digest-pins branch August 22, 2026 18:52
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 22, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 6:53 PM UTC · Completed 7:04 PM UTC

Commit: 91b156b · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review skipped — this PR is already merged.

The /fs-review command only reviews open PRs/MRs.

Posted by fullsend pre-review check

@fullsend-ai-retro

fullsend-ai-retro Bot commented Aug 22, 2026 •

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 6:54 PM UTC · Completed 7:02 PM UTC

Commit: 91b156b · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #54 — Remove pinned agent digests

PR #54 was a human-authored, single-file config change (9 deletions from .fullsend/config.yaml) that removed 7 pinned fullsend-ai/agents source URLs and 2 allowed_remote_resources entries, relying on the CLI fallback to resolve agents from heads/main. The PR was opened, pushed to once, and merged by the author within ~10 minutes — before the review agent could complete any review.

Workflow timeline

Time (UTC) Event
18:42 PR opened → review agent dispatched (run 32591507621)
18:43 Review agent resolves from fullsend-ai/agents@de64c17, dispatches 3 sub-agents (correctness, security, style)
18:47 qodo-code-review bot posts inline comment flagging potential missing agent registrations
~18:51 Push (synchronize) → new review run cancels the first after ~8 min of active work
18:51 Second review run (32591974169) immediately cancelled (~5s)
18:52 PR merged by author (self-merge, zero human reviews)
18:52 Third review run (32591991370) correctly detects merge and skips
18:52 Retro dispatched (32592017040)

Key observations

  1. Review agent never completed. Three review runs were triggered; none produced feedback. The first was cancelled by the concurrency group after ~8 minutes of work (3 sub-agents dispatched, all wasted). The second was cancelled within seconds. The third correctly detected the merge and skipped.

  2. Qualityflow agent 404. Every run logs skipping agent qualityflow: load failed: ... got 404 — the external agent definition at the pinned commit does not exist. This is a persistent broken reference in the repo config.

  3. No fullsend review feedback on this PR. Only the qodo-code-review bot provided automated review feedback.

Evidence for existing issues (not filing new proposals)

What went well

  • The third review run correctly detected the merged state and skipped without wasting compute.
  • The retro agent dispatched promptly after merge.
  • The qodo-code-review bot provided reasonable feedback about the config change's implications, noting the CLI fallback assumption.

Proposals filed

@fullsend-ai-review

Copy link
Copy Markdown

Review skipped — this PR is already merged.

The /fs-review command only reviews open PRs/MRs.

Posted by fullsend post-review check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant