Skip to content

feat(code-review): flag permission manifest changes as mandatory finding - #1156

Merged
rh-hemartin merged 1 commit into
mainfrom
feat/code-review-permission-manifest
May 21, 2026
Merged

rh-hemartin merged 1 commit into
mainfrom
feat/code-review-permission-manifest

Conversation

@rh-hemartin

Copy link
Copy Markdown
Member

Summary

  • Adds a dedicated Permission manifest changes bullet under the Platform Security dimension in code-review/SKILL.md
  • Any diff touching permission-declaring files (GitHub App manifests, token downscoping maps, OAuth scopes, IAM/RBAC policies, workflow permissions: blocks) must always produce a finding
  • Permission expansions without explicit justification → high severity minimum; reductions → info (intentionality confirmation)
  • Evaluates: scope beyond stated use case, least-privilege alternative, linked issue/ADR authorization

Test plan

  • Submit a test PR that changes a permission scope (e.g. contents: read → contents: write in a workflow) and verify review agent flags it as a Platform Security finding
  • Verify next 3 real PRs touching permission-declaring files receive a review finding

Closes #1060

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented May 19, 2026 •

Copy link
Copy Markdown

Site preview

Preview: https://30f59baf-site.fullsend-ai.workers.dev

Commit: 82f23d5202f956420cf5a68b9413d2663d39f4f1

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

No findings.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label May 19, 2026
@rh-hemartin rh-hemartin self-assigned this May 19, 2026
@rh-hemartin
rh-hemartin force-pushed the feat/code-review-permission-manifest branch 2 times, most recently from 402d525 to 82f23d5 Compare May 21, 2026 14:44
@rh-hemartin
rh-hemartin enabled auto-merge May 21, 2026 14:44
@rh-hemartin
rh-hemartin added this pull request to the merge queue May 21, 2026
Merged via the queue into main with commit 3324427 May 21, 2026
11 of 13 checks passed
@rh-hemartin
rh-hemartin deleted the feat/code-review-permission-manifest branch May 21, 2026 14:48

This branch was successfully deployed

1 active deployment
site-preview — 82f23d52 Deployed May 21, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add permission-manifest change detection to code-review skill

1 participant