Repository navigation
feat: add resource resolver for URL-referenced harness resources - #1623
Conversation
Site previewPreview: https://204eb7fa-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsNo findings. Previous runReviewReason: stale-head The review agent reviewed commit Previous run (2)ReviewFindingsLow
Previous run (3)ReviewFindingsMedium
Low
Previous run (4)ReviewFindingsLow
Info
Previous run (5)ReviewFindingsLow
Info
Previous run (6)ReviewFindingsLow
Previous run (7)ReviewFindingsNo findings. Previous run (8)ReviewFindingsLow
Info
Previous run (9)ReviewFindingsMedium
Low
|
02d981c to
837c49a
Compare
|
All three findings addressed in 837c49a:
|
837c49a to
b0f0a31
Compare
|
All findings from the latest review addressed in b0f0a31:
|
maruiz93
left a comment
There was a problem hiding this comment.
Found three minor issue but I think they are worth to address
a63693f to
2504856
Compare
2504856 to
6782efd
Compare
b6aef4e to
7a548f0
Compare
7a548f0 to
06fa05d
Compare
06fa05d to
799682e
Compare
Introduces internal/resolve package that orchestrates fetch, cache, validation, and audit logging for URL-referenced declarative harness fields (agent, policy, skills). Modifies the harness in place, replacing URLs with local cache paths. Phase 1: single-level only. Moves NewTestPolicy to internal/fetch/fetchtest/ package for safe cross-package test use, and fixes ResolveRelativeTo to skip URL-valued fields. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Greg Allen <gallen@redhat.com>
799682e to
b8fe569
Compare
Summary
internal/resolve/package that orchestrates fetch, cache, validation, and audit logging for URL-referenced declarative harness fields (agent, policy, skills)FetchPolicy.TLSConfigandSkipIPCheckfields for cross-package test useResolveRelativeToto skip URL-valued fields (resolvesTODO(PR 7))Test plan
internal/resolve/resolve_test.go: local pass-through, URL fetch+cache, cache hit, hash mismatch, allowlist rejection, missing hash, offline miss/hit, mixed harness, audit entries, multiple skills, policy URL, empty fieldsTestResolveRelativeTo_URLsUnchangedininternal/harness/harness_test.gogo test ./...passesgo vet ./...clean🤖 Generated with Claude Code