Skip to content

fix(#852): add consumer-completeness check to code-review Correctness dimension - #1807

Merged
ben-alkov merged 1 commit into
mainfrom
agent/852-add-consumer-completeness-check
Jun 2, 2026
Merged

ben-alkov merged 1 commit into
mainfrom
agent/852-add-consumer-completeness-check

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Add a "Consumer completeness" bullet to the Correctness section of the code-review skill. When a PR adds new values to an enum, dispatch table, JSON schema enum, or case/switch structure, the review agent will now check that all downstream consumers handle the new value — including scripts, configs, and files not in the diff. This closes the gap that allowed PR #765 to be approved despite a missing handler for the new reject disposition in post-review.sh.

Note: make lint could not run due to sandbox Go toolchain permission error (unrelated to this change). The change is markdown-only.


Closes #852

Post-script verification

  • Branch is not main/master (agent/852-add-consumer-completeness-check)
  • Secret scan passed (gitleaks — de4ce7110e460377f26ea2ed285d5e8c3f4a560f..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

… dimension

Add a "Consumer completeness" bullet to the Correctness section of the
code-review skill. When a PR adds new values to an enum, dispatch table,
JSON schema enum, or case/switch structure, the review agent will now
check that all downstream consumers handle the new value — including
scripts, configs, and files not in the diff. This closes the gap that
allowed PR #765 to be approved despite a missing handler for the new
`reject` disposition in `post-review.sh`.

Note: `make lint` could not run due to sandbox Go toolchain permission
error (unrelated to this change). The change is markdown-only.

Closes #852

Signed-off-by: fullsend-code <fullsend-code@users.noreply.github.com>
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

Site preview

Preview: https://408dbf94-site.fullsend-ai.workers.dev

Commit: 15dc4bb01417551b4995b33f34714383fe710a6f

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

No findings.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Jun 2, 2026

This branch was successfully deployed

1 active deployment
site-preview — 15dc4bb0 Deployed Jun 2, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review skill: add consumer-completeness check for new enum values/dispatch entries

1 participant