Repository navigation
fix(#852): add consumer-completeness check to code-review Correctness dimension - #1807
Merged
Merged
Conversation
… dimension Add a "Consumer completeness" bullet to the Correctness section of the code-review skill. When a PR adds new values to an enum, dispatch table, JSON schema enum, or case/switch structure, the review agent will now check that all downstream consumers handle the new value — including scripts, configs, and files not in the diff. This closes the gap that allowed PR #765 to be approved despite a missing handler for the new `reject` disposition in `post-review.sh`. Note: `make lint` could not run due to sandbox Go toolchain permission error (unrelated to this change). The change is markdown-only. Closes #852 Signed-off-by: fullsend-code <fullsend-code@users.noreply.github.com>
Site previewPreview: https://408dbf94-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsNo findings. |
ben-alkov
approved these changes
Jun 2, 2026
Merged
7 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a "Consumer completeness" bullet to the Correctness section of the code-review skill. When a PR adds new values to an enum, dispatch table, JSON schema enum, or case/switch structure, the review agent will now check that all downstream consumers handle the new value — including scripts, configs, and files not in the diff. This closes the gap that allowed PR #765 to be approved despite a missing handler for the new
rejectdisposition inpost-review.sh.Note:
make lintcould not run due to sandbox Go toolchain permission error (unrelated to this change). The change is markdown-only.Closes #852
Post-script verification
agent/852-add-consumer-completeness-check)de4ce7110e460377f26ea2ed285d5e8c3f4a560f..HEAD)