Skip to content

chore(ci): bump OpenShell to 0.0.63, extract install scripts, add Renovate - #2315

Merged
rh-hemartin merged 2 commits into
mainfrom
feat/openshell-update-and-others
Jun 17, 2026
Merged

rh-hemartin merged 2 commits into
mainfrom
feat/openshell-update-and-others

Conversation

@rh-hemartin

@rh-hemartin rh-hemartin commented Jun 16, 2026 •

Copy link
Copy Markdown
Member

Summary

Combines changes from #882 (Renovate automation) and the version bump and install script extraction already in progress on this branch.

OpenShell install script extraction

The inline version pin and install logic in action.yml are split into dedicated scripts:

File Purpose
.github/scripts/openshell-version.sh Single source of truth for OPENSHELL_VERSION and OPENSHELL_SHA; exports to GITHUB_ENV; carries Renovate inline comment
.github/scripts/install-openshell.sh Sources version script and runs upstream installer
action.yml Replaces monolithic step with 'Configure OpenShell gateway' + 'Install OpenShell CLI' (delegates to script)

Version bump

Pinned version updated 0.0.54 → 0.0.63 (SHA ec197a43ef349e36c3fff04e9aaea9599fb83b31).

Docs update

docs/guides/user/running-agents-locally.md:

  • Requirements table and install snippet updated to 0.0.63
  • Stale troubleshooting note for the 0.0.54 tcp protocol schema removed

Renovate automation (from #882)

  • renovate.json: regex custom manager targets .github/scripts/openshell-version.sh; matches both OPENSHELL_VERSION and OPENSHELL_SHA in a single regex so Renovate updates them atomically; git-submodules manager replaces Dependabot
  • .github/dependabot.yml removed (consolidated onto Renovate)

Test plan

  • Verify Renovate picks up OPENSHELL_VERSION=0.0.63 and OPENSHELL_SHA from .github/scripts/openshell-version.sh and opens a bump PR (updating both fields) when a newer tag is published
  • Confirm action.yml installs OpenShell successfully in a workflow run
  • Confirm make functional-tests (once environment secrets are configured) installs the correct version via .github/scripts/install-openshell.sh

Refs #882

@github-actions

github-actions Bot commented Jun 16, 2026 •

Copy link
Copy Markdown

Site preview

Preview: https://a175cd17-site.fullsend-ai.workers.dev

Commit: 5c5e14d6c96d8926cb5333ddf016145a7165b6d9

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 16, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:55 AM UTC · Completed 9:07 AM UTC
Commit: bfe8c23 · View workflow run →

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 16, 2026 •

Copy link
Copy Markdown

Review

Findings

Medium

  • [protected-path] .github/dependabot.yml, .github/scripts/install-openshell.sh, .github/scripts/openshell-version.sh — Three files under the protected .github/ path are modified or added. The PR links to issue feat: add Renovate automation for OpenShell version pin #882 and explains the rationale (Renovate automation, script extraction), but human approval is always required for protected-path changes regardless of context.

Low

  • [script-dirname-convention] .github/scripts/install-openshell.sh:11 — SCRIPT_DIR uses $0 instead of ${BASH_SOURCE[0]}. The codebase convention (all 10+ existing scripts) is SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)". While functionally equivalent when executed directly (not sourced), consistency with the established pattern is preferred.

  • [stale-version-reference] docs/plans/agent-execution-environment.md:49 — Planning document contains ARG OPENSHELL_VERSION=0.0.37-dev, a stale version reference. Pre-existing issue, not introduced by this PR. (ADR references to 0.0.37-dev in ADR-0036 and ADR-0046 are in Accepted ADRs and are immutable per AGENTS.md.)

Info

  • [supply-chain] .github/scripts/install-openshell.sh:15 — The install script uses curl-pipe-sh pattern pinned to a full 40-character commit SHA. No change in security posture from the prior inline pattern in action.yml.

  • [workflow-command-injection] .github/scripts/openshell-version.sh:18 — The script writes OPENSHELL_VERSION and OPENSHELL_SHA to GITHUB_ENV. Both values are hardcoded string literals. No injection risk.

  • [supply-chain] renovate.json — Renovate configured with custom regex manager to auto-update the OpenShell version pin including commit SHA digest. Preserves SHA-pinning security control across automated bumps.

  • [scope-alignment] PR combines three distinct changes: (1) Renovate automation from issue feat: add Renovate automation for OpenShell version pin #882, (2) OpenShell version bump 0.0.54→0.0.63, (3) script extraction refactoring. The author acknowledges the combined scope; the concerns are tightly coupled.

  • [version-centralization] .github/scripts/openshell-version.sh — New script establishes single source of truth for OPENSHELL_VERSION and OPENSHELL_SHA. Sound architectural pattern replacing inline version pins in action.yml.

Previous run

Review

Findings

Medium

  • [protected-path] .github/dependabot.yml, .github/scripts/install-openshell.sh, .github/scripts/openshell-version.sh — Three files under the protected .github/ path are modified or added. The PR links to issue feat: add Renovate automation for OpenShell version pin #882 and explains the rationale (Renovate automation, script extraction), but human approval is always required for protected-path changes regardless of context.

Low

  • [script-dirname-convention] .github/scripts/install-openshell.sh:11 — SCRIPT_DIR uses $0 instead of ${BASH_SOURCE[0]}. The codebase convention (seen in 13 existing scripts under hack/, scripts/, internal/scaffold/) is SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)". While $0 and ${BASH_SOURCE[0]} are equivalent when executed directly (not sourced), consistency with the established pattern is preferred.

  • [commit-type-mismatch] PR title uses chore(ci): which is defensible given the CI automation focus, though the script extraction component could also be classified as refactor(ci):. The combined nature is a borderline case; chore(ci) is acceptable per COMMITS.md guidance.

  • [architectural-pattern-introduction] .github/scripts/install-openshell.sh — This PR introduces a new .github/scripts/ directory pattern. The codebase currently has no .github/scripts/ directory, only scripts/ at the repo root and internal/scaffold/fullsend-repo/scripts/. The new pattern is reasonable for CI-specific scripts that are not part of repo scaffolding.

  • [stale-reference] docs/plans/agent-execution-environment.md:49 — Planning document contains ARG OPENSHELL_VERSION=0.0.37-dev, a stale version reference. Pre-existing issue, not introduced by this PR.

Info

  • [supply-chain] .github/scripts/install-openshell.sh:15 — The install script uses curl-pipe-sh pattern pinned to a full 40-character commit SHA. No change in security posture from the prior inline pattern in action.yml.

  • [workflow-command-injection] .github/scripts/openshell-version.sh:18 — The script writes OPENSHELL_VERSION and OPENSHELL_SHA to GITHUB_ENV. Both values are hardcoded string literals. No injection risk.

Previous run (2)

Review

Findings

High

  • [logic-error] .github/scripts/openshell-version.sh:13 — Renovate is configured to auto-bump OPENSHELL_VERSION via the regex custom manager in renovate.json, but OPENSHELL_SHA on the next line is not tracked by Renovate and will not be updated. After an automated version bump, OPENSHELL_SHA will still point to the commit for the old version. The install script fetches install.sh from the commit identified by OPENSHELL_SHA, so a version/SHA mismatch means the installer script from the old release is invoked with the new version tag.
    Remediation: Either (a) add a second matchString in the Renovate customManager to also capture and update OPENSHELL_SHA, (b) change install-openshell.sh to fetch install.sh using the git tag (v${OPENSHELL_VERSION}) instead of the commit SHA so only one value needs updating, or (c) add a CI check that validates the SHA matches the tagged commit.

Medium

Low

  • [scope-creep] This PR combines three concerns: (1) OpenShell version bump, (2) extracting install logic into .github/scripts/, and (3) replacing Dependabot with Renovate. The concerns are tightly coupled (the extracted script is what Renovate manages), so splitting may not be warranted, but the breadth is worth noting.

  • [architectural-coherence] The PR introduces a .github/scripts/ directory pattern. The codebase currently has no .github/scripts/ directory, though it has scripts/ at the repo root. Consider documenting the rationale for this location choice.

  • [script-path-convention] action.yml:276 — Script is invoked via $GITHUB_ACTION_PATH/.github/scripts/install-openshell.sh. The existing composite action uses ${GITHUB_WORKSPACE}/scripts/ instead. Note: $GITHUB_ACTION_PATH is actually the more robust pattern.

  • [stale-reference] docs/plans/agent-execution-environment.md:49 — Planning document contains ARG OPENSHELL_VERSION=0.0.37-dev, a stale version reference. Pre-existing issue, not introduced by this PR.

  • [documentation-consistency] docs/guides/user/running-agents-locally.md — The troubleshooting section about L7 policy validation is removed. If the issue is resolved in 0.0.63, removal is appropriate; consider adding a brief note.

Info

  • [supply-chain] .github/scripts/install-openshell.sh:15 — The install script uses curl-pipe-sh pattern pinned to a full 40-character commit SHA. No change in security posture from the existing action.yml pattern.

  • [workflow-command-injection] .github/scripts/openshell-version.sh:18 — The script writes OPENSHELL_VERSION and OPENSHELL_SHA to GITHUB_ENV. Both values are hardcoded string literals. No injection risk.

  • [dependency-automation-alignment] renovate.json — The switch from Dependabot to Renovate aligns with issue feat: add Renovate automation for OpenShell version pin #882. Architecturally sound choice.

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

Comment thread .github/scripts/openshell-version.sh Resolved
Comment thread action.yml Resolved
@rh-hemartin
rh-hemartin force-pushed the feat/openshell-update-and-others branch from bfe8c23 to 54438b8 Compare June 16, 2026 10:09
@rh-hemartin rh-hemartin changed the title feat: bump OpenShell to 0.0.63, extract install scripts, add Renovate chore(ci): bump OpenShell to 0.0.63, extract install scripts, add Renovate Jun 16, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Jun 16, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:13 AM UTC · Completed 10:23 AM UTC
Commit: 54438b8 · View workflow run →

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Jun 16, 2026
@ralphbean

Copy link
Copy Markdown
Member

Awesome :)

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 17, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 7:27 AM UTC · Completed 7:38 AM UTC
Commit: 7dbcdc2 · View workflow run →

@fullsend-ai-review fullsend-ai-review Bot added requires-manual-review Review requires human judgment and removed requires-manual-review Review requires human judgment labels Jun 17, 2026
…ovate

Signed-off-by: Hector Martinez <hemartin@redhat.com>
TestVendoredDefaultsInfraPathsMatchPredicate and
TestEnumerateVendoredPathsMatchesCollectInCheckout failed because
the new .github/scripts/{install,version}-openshell.sh files are
matched by isVendoredDefaultsInfra but were absent from the
hardcoded vendoredDefaultsInfraPaths slice.

Signed-off-by: Hector Martinez <hemartin@redhat.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Jun 17, 2026 •

Copy link
Copy Markdown

🤖 Review · ❌ Terminated · Started 8:29 AM UTC · Ended 8:54 AM UTC
Commit: 4e21a60 · View workflow run →

@rh-hemartin
rh-hemartin added this pull request to the merge queue Jun 17, 2026
Merged via the queue into main with commit c7ad026 Jun 17, 2026
10 checks passed
@rh-hemartin
rh-hemartin deleted the feat/openshell-update-and-others branch June 17, 2026 08:42
@fullsend-ai-retro

fullsend-ai-retro Bot commented Jun 17, 2026 •

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 8:47 AM UTC · Completed 8:55 AM UTC
Commit: 5c5e14d · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

🤖 Finished Review · ❌ Failure · Started 8:29 AM UTC · Completed 8:54 AM UTC
Commit: 5c5e14d · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #2315 — OpenShell bump, script extraction, Renovate

Workflow quality: Good. The review agent delivered genuine value on this PR by catching a high-severity logic error in the first review: the Renovate config would bump OPENSHELL_VERSION but leave OPENSHELL_SHA stale, causing a version/SHA mismatch after automated bumps. The author fixed this promptly.

Timeline

Time (UTC) Event
Jun 16 08:51 PR opened by rh-hemartin
Jun 16 08:55–09:07 Review #1: CHANGES_REQUESTED — caught SHA/version mismatch (high)
Jun 16 10:09 Force-push: author fixes Renovate config
Jun 16 10:13–10:23 Review #2: re-reviews fix
Jun 16 16:58 Human approval by ralphbean
Jun 17 07:23 Force-push #2
Jun 17 07:27–07:38 Review #3 — after human approval (redundant)
Jun 17 08:26 Force-push #3: fix vendoredDefaultsInfraPaths tests
Jun 17 08:29 Review #4 — after human approval (redundant)
Jun 17 08:42 Merged

Key observations

  1. Review quality was high. The first-iteration high-severity finding was a real, non-obvious logic error that could have caused production issues with Renovate automation. Low/info findings were well-calibrated.
  2. 2 of 4 review runs were unnecessary. Reviews docs: Add codebase context problem document and trim CLAUDE.md #3 and Use AI to help formalise intent after rapid local prototyping #4 ran on force-pushes that occurred after the human had already approved. This is a known inefficiency.
  3. No new proposals filed. The redundant-review-after-approval pattern is extensively covered by existing open issues: Skip review dispatch when HEAD SHA was already reviewed and approved #963 (skip dispatch when already approved), Cancel-and-skip redundant re-reviews on force-pushed PRs with no prior findings #1372 (cancel-and-skip on force-push with no findings), Deduplicate review runs on rapid successive pushes #1418 (deduplicate on rapid pushes), Review-fix race condition causes duplicate review cycles and wasted tokens #1557 (duplicate review cycles and wasted tokens), and others. Filing additional issues would be duplicative.

ralphbean added a commit that referenced this pull request Jun 22, 2026
The functional tests manually downloaded the gateway binary, started it
in the background, and registered it with the CLI — an approach that
worked with 0.0.38 but broke with 0.0.63 (gateway port 8080 never came
up).

Replace the manual setup with the same pattern action.yml uses:
- Write gateway.env config
- Install via the shared install-openshell.sh script
- Let openshell manage its own gateway

This matches the changes made in PR #2315 when openshell was bumped
from 0.0.54 to 0.0.63.

Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ralph Bean <rbean@redhat.com>
ifireball pushed a commit to ifireball/fullsend that referenced this pull request Jun 24, 2026
The functional tests manually downloaded the gateway binary, started it
in the background, and registered it with the CLI — an approach that
worked with 0.0.38 but broke with 0.0.63 (gateway port 8080 never came
up).

Replace the manual setup with the same pattern action.yml uses:
- Write gateway.env config
- Install via the shared install-openshell.sh script
- Let openshell manage its own gateway

This matches the changes made in PR fullsend-ai#2315 when openshell was bumped
from 0.0.54 to 0.0.63.

Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ralph Bean <rbean@redhat.com>

This branch was successfully deployed

1 active deployment
site-preview — 5c5e14d6 Deployed Jun 17, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-manual-review Review requires human judgment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants