Repository navigation
chore(ci): bump OpenShell to 0.0.63, extract install scripts, add Renovate - #2315
Conversation
Site previewPreview: https://a175cd17-site.fullsend-ai.workers.dev Commit: |
|
🤖 Finished Review · ✅ Success · Started 8:55 AM UTC · Completed 9:07 AM UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ReviewFindingsMedium
Low
Info
Previous runReviewFindingsMedium
Low
Info
Previous run (2)ReviewFindingsHigh
Medium
Low
Info
|
bfe8c23 to
54438b8
Compare
|
🤖 Finished Review · ✅ Success · Started 10:13 AM UTC · Completed 10:23 AM UTC |
|
Awesome :) |
54438b8 to
7dbcdc2
Compare
|
🤖 Finished Review · ✅ Success · Started 7:27 AM UTC · Completed 7:38 AM UTC |
…ovate Signed-off-by: Hector Martinez <hemartin@redhat.com>
TestVendoredDefaultsInfraPathsMatchPredicate and
TestEnumerateVendoredPathsMatchesCollectInCheckout failed because
the new .github/scripts/{install,version}-openshell.sh files are
matched by isVendoredDefaultsInfra but were absent from the
hardcoded vendoredDefaultsInfraPaths slice.
Signed-off-by: Hector Martinez <hemartin@redhat.com>
7dbcdc2 to
5c5e14d
Compare
|
🤖 Review · ❌ Terminated · Started 8:29 AM UTC · Ended 8:54 AM UTC |
|
🤖 Finished Retro · ✅ Success · Started 8:47 AM UTC · Completed 8:55 AM UTC |
|
🤖 Finished Review · ❌ Failure · Started 8:29 AM UTC · Completed 8:54 AM UTC |
Retro: PR #2315 — OpenShell bump, script extraction, RenovateWorkflow quality: Good. The review agent delivered genuine value on this PR by catching a high-severity logic error in the first review: the Renovate config would bump Timeline
Key observations
|
The functional tests manually downloaded the gateway binary, started it in the background, and registered it with the CLI — an approach that worked with 0.0.38 but broke with 0.0.63 (gateway port 8080 never came up). Replace the manual setup with the same pattern action.yml uses: - Write gateway.env config - Install via the shared install-openshell.sh script - Let openshell manage its own gateway This matches the changes made in PR #2315 when openshell was bumped from 0.0.54 to 0.0.63. Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>
The functional tests manually downloaded the gateway binary, started it in the background, and registered it with the CLI — an approach that worked with 0.0.38 but broke with 0.0.63 (gateway port 8080 never came up). Replace the manual setup with the same pattern action.yml uses: - Write gateway.env config - Install via the shared install-openshell.sh script - Let openshell manage its own gateway This matches the changes made in PR fullsend-ai#2315 when openshell was bumped from 0.0.54 to 0.0.63. Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>
Summary
Combines changes from #882 (Renovate automation) and the version bump and install script extraction already in progress on this branch.
OpenShell install script extraction
The inline version pin and install logic in
action.ymlare split into dedicated scripts:.github/scripts/openshell-version.shOPENSHELL_VERSIONandOPENSHELL_SHA; exports toGITHUB_ENV; carries Renovate inline comment.github/scripts/install-openshell.shaction.ymlVersion bump
Pinned version updated 0.0.54 → 0.0.63 (SHA
ec197a43ef349e36c3fff04e9aaea9599fb83b31).Docs update
docs/guides/user/running-agents-locally.md:Renovate automation (from #882)
renovate.json: regex custom manager targets.github/scripts/openshell-version.sh; matches bothOPENSHELL_VERSIONandOPENSHELL_SHAin a single regex so Renovate updates them atomically;git-submodulesmanager replaces Dependabot.github/dependabot.ymlremoved (consolidated onto Renovate)Test plan
OPENSHELL_VERSION=0.0.63andOPENSHELL_SHAfrom.github/scripts/openshell-version.shand opens a bump PR (updating both fields) when a newer tag is publishedaction.ymlinstalls OpenShell successfully in a workflow runmake functional-tests(once environment secrets are configured) installs the correct version via.github/scripts/install-openshell.shRefs #882