Repository navigation
ci(release): sync version tags to fullsend-ai/agents - #3079
Conversation
After GoReleaser completes, the release workflow now pushes the same semver tag to fullsend-ai/agents using an org-owned GitHub App token. That tag push triggers agents' own release.yml to create a GitHub Release and move the v0 floating tag. Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Greg Allen <gallen@redhat.com>
PR Summary by QodoSync release semver tags to fullsend-ai/agents after GoReleaser
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
|
🤖 Finished Review · ✅ Success · Started 2:16 PM UTC · Completed 2:27 PM UTC |
Site previewPreview: https://ea6a2900-site.fullsend-ai.workers.dev Commit: |
Code Review by Qodo
1.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ReviewVerdict: comment — clean implementation; protected paths require human approval. This is a well-scoped addition of cross-repo tag synchronization to the release workflow. The only change since the prior approved review (34ff813) is a 5-line comment block in Correctness: The shell script logic is correct. The idempotency check (HTTP status code extraction via Security: No vulnerabilities found. All interpolated variables verified individually:
Intent & scope: Authorized by issue #3083. Scope matches the issue's stated goal (sync version tags to agents repo, update release skill docs). No scope creep. The Documentation: Pre-flight (A2), post-flight (B2), and SKILL.md notes sections are consistent with the workflow behavior and follow existing document structure. No stale documentation found elsewhere in the repo. Findings1. Protected paths require human approval — mediumFile: multiple | Category: This PR modifies files under protected paths that require human reviewer approval:
The PR links to issue #3083 and the description clearly explains the rationale for each change. A human reviewer must approve this PR. Prior finding resolution
Notes
Previous runReviewVerdict: approve — clean implementation with only low-severity observations. Clean, well-scoped addition of cross-repo tag synchronization to the release workflow. Both prior medium and low findings have been addressed: issue #3083 is now linked and the PR title uses the correct Security: No vulnerabilities found. The Findings1. Implicit step ordering dependency — lowFile: Carried from prior review (severity anchored). The "Generate agents repo token" and "Push tag to fullsend-ai/agents" steps have no explicit Remediation: Either add 2. Pre-release tag sync asymmetry — lowFile: The v0 floating tag step is deliberately skipped for pre-release tags via Remediation: Add a comment noting that pre-release tags are intentionally synced to agents (or add a matching Labels: PR modifies CI release workflow and release skill documentation Previous runReviewVerdict: approve — clean implementation with only low-severity observations. Clean, well-scoped addition of cross-repo tag synchronization to the release workflow. Both prior medium and low findings have been addressed: issue #3083 is now linked and the PR title uses the correct Security: No vulnerabilities found. The Findings1. Implicit step ordering dependency — lowFile: Carried from prior review (severity anchored). The "Generate agents repo token" and "Push tag to fullsend-ai/agents" steps have no explicit Remediation: Either add 2. Pre-release tag sync asymmetry — lowFile: The v0 floating tag step is deliberately skipped for pre-release tags via Remediation: Add a comment noting that pre-release tags are intentionally synced to agents (or add a matching Notes
Labels: PR modifies CI release workflow and release skill documentation Previous run (2)ReviewVerdict: comment — medium-severity findings worth noting, none blocking. Clean implementation of cross-repo tag synchronization. The workflow logic is sound: idempotent tag creation, proper Findings1. No linked issue for non-trivial change — mediumFile: N/A | Category: This PR adds 77 lines across 4 files (workflow logic, skill docs, pre-flight, post-flight) with no linked issue. Non-trivial changes benefit from a linked issue for traceability — especially for CI infrastructure changes that introduce new secrets/vars ( Remediation: Create an issue describing the need for agents repo tag synchronization and link it to this PR. 2. PR title prefix — lowFile: N/A | Category: The PR title uses Remediation: Consider changing the PR title to 3. Implicit step ordering dependency — lowFile: The "Generate agents repo token" and "Push tag to fullsend-ai/agents" steps run unconditionally after "Move v0 floating tag." If the v0 step fails (e.g., an unexpected Remediation: If agents tagging should succeed independently of the v0 step, add Notes
|
The tag-existence check was suppressing all gh api errors, making auth and rate-limit failures indistinguishable from a missing tag. Now checks the HTTP status code explicitly: 200 = skip, 404 = create, anything else = fail with an actionable error. Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Greg Allen <gallen@redhat.com>
|
Addressing all three findings: 1. No linked issue — Created #3083 and linked via 2. PR title prefix — Changed from 3. Implicit step ordering dependency — Intentional coupling. If the v0 move fails, the release state is suspect and should be investigated before tagging agents. For prereleases, the v0 step is skipped (not failed), so agents steps still run. The inline review finding on this was also resolved with this explanation. Additionally, the inline finding about silent |
|
🤖 Finished Review · ✅ Success · Started 2:37 PM UTC · Completed 2:47 PM UTC |
Add comments clarifying that agents steps are intentionally coupled to the v0 step and intentionally run for all tags including pre-releases. Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Greg Allen <gallen@redhat.com>
|
🤖 Finished Review · ✅ Success · Started 2:50 PM UTC · Completed 2:59 PM UTC |
|
🤖 Finished Retro · ✅ Success · Started 5:13 PM UTC · Completed 5:20 PM UTC |
Retro: PR #3079 — ci(release): sync version tags to fullsend-ai/agentsThis workflow went well overall. Three review iterations were reasonable for a 3-commit human-authored CI change (4 files, 87 additions). The review agent and Qodo provided complementary coverage: Qodo caught a genuine reliability bug (silent Verdict inconsistency (evidence for #2838)On the second review run (28799582135, commit Autonomy readinessThe review agent fully covered the human reviewer's feedback on this PR — the human added no findings. The security analysis (variable interpolation, workflow command injection, token scoping) was thorough and correct. However, this class of change (CI release workflows with cross-repo token generation) is appropriately behind the protected-path constraint. The agent's value is in surfacing detailed findings for the human to approve, not in autonomous approval. No additional proposals neededBeyond the evidence issue for #2838, no novel improvement opportunities were identified. The workflow executed efficiently with reasonable iteration count, token cost, and time to resolution (~3 hours including human approval wait time). Proposals filed
|
Summary
Closes #3083
fullsend-ai/agentsusing an org-owned GitHub App token (RELEASE_APP_ID/RELEASE_APP_PRIVATE_KEY)release.yml(see feat: add release workflow for version tag sync agents#25) to create a GitHub Release and move thev0floating tagPrerequisites
The
fullsend-releaseGitHub App must be:fullsend-aiorg with Contents → Read and write permissionfullsend-ai/agentsRELEASE_APP_IDvariable on this repoRELEASE_APP_PRIVATE_KEYsecret on this repoTest plan
RELEASE_APP_IDvariable andRELEASE_APP_PRIVATE_KEYsecret are setfullsend-ai/agentsfullsend-ai/agents(addsrelease.yml)🤖 Generated with Claude Code