Repository navigation
feat(#5844): make repos install/uninstall the single path for GitLab - #5845
Conversation
|
🤖 Finished Review · ✅ Success · Started 2:37 AM UTC · Completed 2:53 AM UTC |
ReviewFindingsLow
Previous runReviewFindingsLow
Previous run (2)ReviewFindingsLow
Previous run (3)ReviewFindingsMedium
Low
Previous run (4)ReviewFindingsLow
Previous run (5)ReviewFindingsLow
Previous run (6)ReviewFindingsLow
Previous run (7)ReviewFindingsHigh
Medium
Low
Next steps:
Previous run (8)ReviewFindingsHigh
Medium
Low
Next steps:
Previous run (9)ReviewFindingsMedium
Low
Labels: PR adds GitLab support to repos install/uninstall path — a feature addition with documentation and CI template changes Next steps:
Previous run (10)ReviewFindingsMedium
Low
Next steps:
Previous run (11)ReviewFindingsCritical
High
Medium
Low
Labels: PR adds GitLab support to the repos install/uninstall CLI path with Go code changes. Next steps:
|
cbd2cea to
a56d4bd
Compare
|
🤖 Review · |
a56d4bd to
5249c59
Compare
|
🤖 Finished Review · ✅ Success · Started 3:27 AM UTC · Completed 3:44 AM UTC |
5249c59 to
a5c569e
Compare
|
🤖 Finished Review · ✅ Success · Started 3:54 AM UTC · Completed 4:14 AM UTC |
a5c569e to
54dd351
Compare
|
🤖 Review · ❌ Terminated · Started 4:27 AM UTC · Ended 4:46 AM UTC |
Site previewPreview: https://b0105307-site.fullsend-ai.workers.dev Commit: |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
🤖 Finished Review · ✅ Success · Started 4:27 AM UTC · Completed 4:46 AM UTC |
54dd351 to
bf734f7
Compare
|
🤖 Finished Review · ✅ Success · Started 8:43 AM UTC · Completed 9:02 AM UTC |
|
🤖 Review · |
b4f053a to
c3f6f33
Compare
|
🤖 Finished Review · ✅ Success · Started 12:39 PM UTC · Completed 12:55 PM UTC |
c3f6f33 to
c50e9a2
Compare
|
🤖 Finished Review · ✅ Success · Started 1:01 PM UTC · Completed 1:15 PM UTC |
Signed-off-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Greg Allen <gallen@redhat.com>
c50e9a2 to
b2b00d6
Compare
|
🤖 Finished Review · ✅ Success · Started 1:22 PM UTC · Completed 1:40 PM UTC |
|
🤖 Finished Retro · ✅ Success · Started 2:55 PM UTC · Completed 3:17 PM UTC |
Retro: PR #5845 — GitLab repos install/uninstallWorkflow: Issue #5844 → triage → code → PR #5845 → 11 review iterations → human fixes → merge (12h total) Review quality: StrongThe review agent found genuinely important bugs across 11 iterations:
All findings were confirmed correct by the human reviewer (ggallen). The human added no correctness findings beyond what the bot found. Fix agent: Completely blockedAll 5 fix dispatches failed with "Human-authored PR without fullsend-fix label" because the guard-rail regex checks for Repeated findingsFour low-severity finding categories were re-raised across multiple iterations after human acknowledgment: fail-open (orphaned tokens), excessive-token-scope, token-lifetime, yaml-injection. New evidence for #1013 / #2816: 20+ duplicate inline comments. New evidence for #5265: human acknowledgments not incorporated. Piecemeal discoveryThe HIGH-severity missing-continue bug was found on the 4th review iteration, not the 1st, despite the code being present from the initial PR. A MEDIUM-severity error-handling issue was found on the 8th+ iteration, after the bot had already approved. New evidence for #4970. Cost89 total workflow runs: 1 triage + 1 code + 10 review + 5 fix (all failed) + 72 source repo CI. The 5 fix failures contributed no value. New evidence for #5811 (skip fix dispatch at routing level). Autonomy readinessThe review agent's approval aligned with the human reviewer's assessment — the human approved 12 minutes after the bot's final approval and added no additional findings. If the fix agent had been operational, the pipeline could have resolved this PR with minimal human intervention for this class of change (well-tested Go code). Proposals filed
|
Summary
Phase 4 of GitLab integration — make
repos installandrepos uninstallthe single installation path for GitLab repos, eliminating separateadmin gitlabcommands.Key changes:
repos installinternal/cli/repos_gitlab.gowith helper functions for bot token setup, pipeline schedule creation, and cleanup--gitlab-bot-tokenflag for free-tier GitLab instances without project access token support\bword-boundary in GL ref patterns to prevent false positives onhead_ref:/base_ref:CreateProjectAccessToken,ListProjectAccessTokens,RevokeProjectAccessToken, andIsEnterprisemethods to the GitLab clientTesting
checkInstallComponentstests to includeforgeNameparametercheckInstallComponentstests for GitLab (fully installed, no secrets needed, missing variable)cleanupGitLabPipelineSchedulesandcleanupGitLabBotTokentestsinternal/repos/...,internal/scaffold/...,internal/forge/...tests passTestStartFetchService_*,TestPostScriptEnv_*) are unrelated to this changeCloses #5844
Post-script verification
agent/5844-gitlab-repos-install-uninstall)c1a87a55225209ebfd7e561316618cca4bb344c7..HEAD)