Repository navigation
chore(docs): pull agent documentation from fullsend-ai/agents - #6953
rh-hemartin wants to merge 1 commit into
Conversation
|
🤖 Review · Commit: |
PR Summary by QodoSource agent docs from the fullsend-ai/agents submodule
AI Description
Diagram
High-Level Assessment
Files changed (7)
|
Code Review by Qodo
1.
|
Site previewPreview: https://9a7dd251-site.fullsend-ai.workers.dev Commit: |
f7c716f to
229fa6f
Compare
|
🤖 Finished Review · ✅ Success · Started 10:41 AM UTC · Completed 11:02 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $7.18 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Risk Assessment: moderate (2/5) DetailsRe-review anchoring preserves the prior score of 2: Tier 1 signals are structurally unchanged (43 files/1311 lines, large blast radius, 4 protected-path hits, CI workflow touched, no dependency changes, neutral docs-only test ratio, non-bot non-first-time author), Tier 2 churn/fix-commit signals reflect ordinary long-running file history rather than any PR-specific regression signal, and Tier 3 confirms the PR still fully satisfies all three acceptance criteria of linked issue #5710 with no risk labels or unresolved discussion. Previous runRisk Assessment: moderate (2/5) DetailsRe-review anchoring confirms the prior score of 2: Tier 1 signals are structurally unchanged (43 files/1315 lines, large blast radius, 4 protected-path hits, CI workflow touched, no dependency changes, neutral docs-only test ratio), and no Tier 2 or Tier 3 evidence surfaced a specific reason to deviate - churn/authorship remains typical docs-restructuring activity with zero reverts or hack sentiment, and the PR still fully satisfies issue #5710's three-step acceptance criteria with only a single advisory label and no unresolved discussion. Previous run (2)Risk Assessment: moderate (2/5) DetailsRe-review anchoring confirms the prior score of 2: Tier 1 composite is driven by large blast radius, 4 protected-path hits, and CI workflow touch, offset by no dependency changes, no security-sensitive paths, and a neutral (docs-only) test ratio; Tier 2 shows expected high-churn/multi-author docs and config-site history with zero reverts and zero hack/workaround sentiment; Tier 3 confirms the PR fully satisfies issue #5710's acceptance criteria with only a single advisory label and no unresolved discussion. Previous run (3)Risk Assessment: moderate (2/5) DetailsRe-review anchoring preserves the prior score of 2: Tier 1 signals remain structurally the same (large blast radius, 4 protected-path hits, CI workflow touched, no dependency changes, docs-only so zero test ratio treated as neutral, non-bot/non-first-time author), Tier 2 shows expected high-churn/multi-author docs and config-site file history but zero reverts or hack/workaround commit sentiment, and Tier 3 confirms the PR substantially satisfies issue #5710's acceptance steps with only an implementation-detail deviation and a single advisory risk/moderate label, no unresolved discussion. Previous run (4)Risk Assessment: moderate (2/5) DetailsRe-review anchoring preserves the prior score of 2: Tier 1 metadata is unchanged (large blast radius, protected-path count still elevated after re-verifying the agents/ -> _agents/ rename, CI workflow touched, no test files — all structurally inflated by the docs-only submodule swap rather than genuine production risk), Tier 2 shows typical multi-author docs/config churn with no reverts or hack/workaround signals tied to this change, and Tier 3 confirms the PR fully satisfies issue #5710's acceptance criteria with no risk labels. Previous run (5)Risk Assessment: moderate (2/5) DetailsRe-review anchoring preserved the prior score of 2: Tier 1 signals are unchanged (large blast radius, 4 protected paths, CI workflow touched, no test files), Tier 2 shows typical multi-author doc/config churn with no reversions, and Tier 3 confirms all acceptance criteria are satisfied with no risk labels — the elevated metadata signal scores are structurally inflated by submodule and docs-only changes rather than representing genuine production risk. Previous run (6)Risk Assessment: moderate (2/5) DetailsModerate risk — Tier 1 signals are unchanged from prior assessment (large blast radius, protected CI paths, no test files), but this remains fundamentally a documentation/submodule integration PR with no production code changes, no security-sensitive files, clear acceptance criteria fully satisfied, and straightforward rollback. Previous run (7)Risk Assessment: moderate (2/5) DetailsModerate risk — large file count (41) and protected path changes (CI workflows) elevate Tier 1 signals, but this is fundamentally a documentation/submodule integration PR with no production code changes, clear acceptance criteria fully addressed, no security-sensitive files touched, and straightforward rollback. |
ReviewFindingsMedium
Low
Next steps:
Previous runReviewFindingsMedium
Low
Next steps:
Previous run (2)ReviewFindingsMedium
Low
Next steps:
Previous run (3)ReviewFindingsMedium
Low
Next steps:
Previous run (4)ReviewFindingsMedium
Low
Info
Next steps:
Previous run (5)ReviewFindingsMedium
Low
Labels: PR restructures documentation delivery (new agents submodule, docs/agents symlink, sidebar auto-discovery) and modifies CI workflow files (lint.yml, site-build.yml); neither the docs nor CI component labels are currently applied. Next steps:
Previous run (6)ReviewFindingsMedium
Low
Next steps:
Previous run (7)ReviewFindingsHigh
Medium
Low
Next steps:
Previous run (8)ReviewFindingsMedium
Low
Next steps:
|
waynesun09
left a comment
There was a problem hiding this comment.
Additional review finding (posted programmatically, deduplicated against existing comments):
229fa6f to
9b83535
Compare
|
🤖 Finished Review · ✅ Success · Started 8:49 AM UTC · Completed 9:12 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $7.43 |
9b83535 to
a503979
Compare
|
🤖 Finished Review · ✅ Success · Started 9:39 AM UTC · Completed 9:58 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $6.21 |
This comment was marked as off-topic.
This comment was marked as off-topic.
waynesun09
left a comment
There was a problem hiding this comment.
Review-only pass (no approval, no change request). Findings verified against head 516b44d9 and deduplicated against the existing comments on this PR. One finding is inline; the one below is commit-level and has no line in the diff to anchor to.
[MEDIUM] Branch commit is typed feat(docs) but COMMITS.md reserves feat for user-facing functionality; it will land under Features in the release notes
The single branch commit 516b44d and the PR title are feat(docs): pull agent documentation from fullsend-ai/agents. COMMITS.md (which says reviewers "must consult this file") defines feat as "New user-facing functionality" (line 19) and docs as "Documentation only" (line 22), gives docs: add mint URL stability note to installation guide as a worked example (line 109), and states "When in doubt, prefer refactor or chore over feat or fix ... A change miscategorized as feat erodes the signal of the Features list" (line 47).
.goreleaser.yml:45-48 groups ^.*?feat(...)?: under Features and excludes ^docs/^chore/^ci/^build entirely, and the main ruleset's merge queue uses merge_method: MERGE, so GoReleaser will read the branch commit's title (not a squash title) — retitling the PR alone does not fix it.
The diff adds no capability an end user invokes: it adds the _agents submodule + docs/agents symlink, sidebar auto-discovery, Makefile/lint.yml/site-build.yml/CODEOWNERS/CONTRIBUTING wiring, and moves two guides. gitlint (.gitlint contrib CT1) only checks that the type is in the allowed list, so nothing in CI catches the misclassification. The PR body's "[x] PR title follows Conventional Commits (correct type)" box is ticked.
Suggested fix: amend the branch commit (and PR title) to chore(docs): pull agent documentation from fullsend-ai/agents — chore fits best since the change spans CI, Makefile, CODEOWNERS and submodule wiring, not documentation text alone; plain docs: per the COMMITS.md:109 example is also acceptable. Either keeps it out of the Features section per .goreleaser.yml.
516b44d to
6aa7b15
Compare
|
🤖 Review · Commit: |
6aa7b15 to
f194582
Compare
|
🤖 Finished Review · ✅ Success · Started 9:38 AM UTC · Completed 9:59 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $5.28 |
f194582 to
c0302cc
Compare
Add fullsend-ai/agents as a submodule and link its docs/ folder into docs/agents, so the contents are fresh from that repository. Rebuild the docs site when the agents submodule changes, matching the experiments/ path filters. There will be a drift as the submodule gets updated, but we can deal with that later. Assisted-By: Grok 4.6 (Pi runtime) Signed-off-by: Hector Martinez <hemartin@redhat.com>
c0302cc to
4b59000
Compare
|
🤖 Finished Review · ✅ Success · Started 6:05 AM UTC · Completed 6:29 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $5.81 |
There was a problem hiding this comment.
Note: The following review comments could not be posted on the diff (GitHub returned 422) and are included here instead:
docs/guides/user/escalation-ladder.md(file-level): Line 78 · [low] documentation-staleness
In 'Level 2: Contribute to the default agent,' the how-to-contribute paragraph still says: if the change is in fullsend-ai/fullsend (harness, scripts, skills, agent definitions), contribute there; if the agent definition or harness lives in fullsend-ai/agents, contribute there instead. That first branch's examples (harness, scripts, agent definitions living in fullsend-ai/fullsend) are stale relative to the repository split this same PR establishes in CONTRIBUTING.md, where those live in fullsend-ai/agents (the _agents/ submodule).
Suggested fix: Update the Level 2 contribute paragraph so default-agent definitions, harnesses, scripts, and built-in skills are described as belonging in fullsend-ai/agents, consistent with the new CONTRIBUTING.md table.
docs/guides/user/escalation-ladder.md(file-level): Line 109 · [low] documentation-staleness
The Level 3 example still uses a base: URL pointing into fullsend-ai/fullsend's internal/scaffold/fullsend-repo/harness/code.yaml path. Current examples elsewhere in the repo (docs/guides/user/customizing-agents.md, docs/guides/user/customizing-overview.md) point the same base: example at fullsend-ai/agents's harness/code.yaml instead, and internal/scaffold/fullsend-repo/ no longer has a harness/ subdirectory (only providers/, templates/, scripts/, profiles/, .github/ remain). This stale reference predates this PR, but the PR moves/edits this exact file without correcting it, and the PR's own subject (the agents/fullsend repo split) makes this a directly on-topic omission.
Suggested fix: Update the Level 3 example's base: URL to point at the fullsend-ai/agents repo's harness/code.yaml, matching docs/guides/user/customizing-agents.md and docs/guides/user/customizing-overview.md.
|
This is taking too much to merge, will look for an alternative |
|
🤖 Finished Retro · ✅ Success · Started 7:35 AM UTC · Completed 7:44 AM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $1.37 |
|
PR #6953 (vendor fullsend-ai/agents docs via submodule, closing #5710) was never merged — the human author closed it after 18 days, 12 force-pushes, and 10 successful review passes plus 3 cancelled ones, citing it was "taking too much to merge." The review agent (resolved from fullsend-ai/agents@v0.40.0) correctly required human approval on every pass because the PR touched protected paths (CI workflow filters, CODEOWNERS); that gate was legitimate, but the pipeline never adapted to the resulting churn. Three review runs (Sep 3, 10, 18) were cancelled mid-flight by GitHub Actions concurrency preemption when the author pushed a new commit while a ~15-20 min review was still running — this is already extensively tracked as open issues #1014 and #7314 (debounce review dispatch on rapid pushes); this run adds a third confirming data point (3/13 dispatches cancelled this way). A human reviewer (waynesun09) also independently caught a conventional-commit-type miscategorization ( Proposals filed |
Summary
Add
fullsend-ai/agentsas a git submodule and serve itsdocs/folder fromdocs/agentson the documentation site, so agent pages stay in sync with the agents repo instead of being copied by hand.Related Issue
Closes #5710
Changes
agentssubmodule at the repo root and replacedocs/agentswith a symlink toagents/docsgetMarkdownFilesdocs/guides/user/agents/changes, matching the existingexperiments/path filtersTesting
make lintpasses (stage changes first, then run)Checklist
!for breaking changes)