Repository navigation
feat(#6958): add --inference-wif-provider to repos install, drop --inference-project-number - #6960
Conversation
…ference-project-number Add --inference-wif-provider flag to `repos install` so callers can pass a full WIF provider resource name that is used verbatim for all repos, bypassing per-repo provider derivation via BuildRepoProviderID. This brings `repos install` to parity with `github setup`, which already supports the flag. Remove --inference-project-number as a CLI flag — it was always auto-derived from --inference-project and is now also unnecessary when --inference-wif-provider is set (the project number is embedded in the provider path). The internal field remains for the auto-derivation codepath. Changes: - repos.go: replace --inference-project-number flag with --inference-wif-provider, reuse validateWIFProvider from admin.go, skip project number derivation when WIF provider is set - converge.go: add WIFProvider field to ConvergeConfig, use it directly in the WIF computation switch (skipping collision check), relax inference flag validation when WIFProvider is set - converge_test.go: add tests for explicit WIF provider path, collision check bypass, and per-repo fallback - repos_test.go: update tests for new flag, add flag presence and absence assertions - docs/cli/repos.md, docs/guides/dev/cli-internals.md: replace --inference-project-number with --inference-wif-provider Closes #6958
|
🤖 Finished Review · ✅ Success · Started 1:22 PM UTC · Completed 1:43 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $7.63 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Site previewPreview: https://d32282fe-site.fullsend-ai.workers.dev Commit: |
|
Risk Assessment: moderate (2/5) DetailsWell-scoped bot-authored feature change to an unreleased CLI command with good test coverage and all acceptance criteria met; elevated git history signals reflect active monorepo development rather than instability, and the issue explicitly confirms no breaking-change risk. Previous runRisk Assessment: moderate (2/5) DetailsWell-scoped bot-authored feature change to an unreleased CLI command with good test coverage and all acceptance criteria met; elevated git history signals reflect active monorepo development rather than instability, and the issue explicitly confirms no breaking-change risk. |
ReviewFindingsLow
Previous runReviewFindingsMedium
Low
Next steps:
|
|
🤖 Finished Fix · ✅ Success · Started 1:44 PM UTC · Completed 1:54 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.39 |
… is set Address review finding: WIFProvider-without-InferenceProject silently skipped secret writes. Add explicit validation error and make InferenceRegion validation unconditional in the WIFProvider branch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🔧 Fix agent — iteration 1 (bot-triggered)Fixed two review findings in internal/repos/converge.go: (1) Added validation requiring --inference-project when --inference-wif-provider is set, preventing silent secret-write skips. (2) Made InferenceRegion validation unconditional in the WIFProvider branch for consistency. Added a new test covering the WIFProvider-without-InferenceProject error path. The third finding (privilege scope change) was acknowledged as intentional behavior requiring no code change. Fixed (2):
Disagreed (1):
Tests: passed Decision points
Next steps:
|
|
🤖 Finished Review · ✅ Success · Started 1:55 PM UTC · Completed 2:12 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $6.58 |
Superseded by updated review
|
🤖 Finished Retro · ✅ Success · Started 2:54 PM UTC · Completed 3:03 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.54 |
Retro: PR #6960 —
|
Summary
Add
--inference-wif-providerflag torepos installfor parity withgithub setup, allowing callers to pass a full WIF provider resource name used verbatim for all repos instead of deriving per-repo providers. Remove the redundant--inference-project-numberflag — the project number is either auto-derived from--inference-projector embedded in the WIF provider path.Changes
internal/cli/repos.go: Replace--inference-project-numberCLI flag with--inference-wif-provider, reusevalidateWIFProviderfromadmin.go, skip project number derivation when WIF provider is setinternal/repos/converge.go: AddWIFProviderfield toConvergeConfig, use it directly in the WIF computation (skipping per-repo derivation and collision check), relax inference flag validation whenWIFProvideris setinternal/repos/converge_test.go: Add 4 tests covering explicit WIF provider usage, collision check bypass, no-project-number-required path, and per-repo fallbackinternal/cli/repos_test.go: Update tests for new flag validation, add flag presence/absence assertionsdocs/cli/repos.md,docs/guides/dev/cli-internals.md: Replace--inference-project-numberwith--inference-wif-providerin flag tablesTesting
go vetandgofmtpassCloses #6958
Post-script verification
agent/6958-wif-provider-repos-install)2a103497560b9bcca901372c70a6e073b1a73cde..HEAD)