Skip to content

fix(#7058): canonicalize symlinks in harness base-path containment check - #7061

Merged
waynesun09 merged 12 commits into
fullsend-ai:mainfrom
shairevivo:srevivo/7058-macos-tempdir
Sep 17, 2026
Merged

waynesun09 merged 12 commits into
fullsend-ai:mainfrom
shairevivo:srevivo/7058-macos-tempdir

Conversation

@shairevivo

@shairevivo shairevivo commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Canonicalize local harness base paths and the workspace containment root before
comparing them, so macOS /var to /private/var aliases do not falsely reject
valid composition and symlink escapes remain blocked. Load the same resolved
path that passed containment validation, closing an absolute-path
symlink-plus-.. check/open divergence.

Extend the existing Darwin job to exercise the harness and harness-dispatch
packages that cover this behavior.

Related Issue

Fixes #7058

Changes

  • resolve workspace roots and base paths through symlinks for containment checks
  • preserve lexical traversal diagnostics and relative chained-base resolution
  • open the validated resolved base path instead of the original absolute string
  • cover workspace aliases, missing paths, symlink escapes, and absolute
    symlink-plus-.. traversal with regression tests
  • run internal/harness and internal/harnessdispatch tests in the existing
    Darwin CI job

Testing

  • make lint
  • make go-test
  • make go-vet
  • targeted absolute symlink traversal regression verified RED then GREEN
  • loadBaseChain function coverage: 94.9%

Checklist

  • PR title follows Conventional Commits
  • Commits are signed off (DCO)
  • I wrote this contribution myself and can explain all changes in it

Approval required

  • Human approval for the protected .github/workflows/lint.yml change

@shairevivo
shairevivo requested a review from a team September 6, 2026 13:56
@github-actions

github-actions Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

E2E tests did not run

E2E tests run automatically for org/repo members and collaborators on pull requests.

For other contributors, a maintainer must add the ok-to-test label after the latest push.

See E2E testing guide for details.

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Cover harness dispatch tests on macOS

🧪 Tests ⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

AI Description

• Canonicalizes temporary composition workspaces to handle macOS /var symlink aliases.
• Runs harness-dispatch race tests in the existing Darwin CI job.
Diagram

graph TD
  CI["Darwin CI"] --> Race["Race Test Runner"] --> Sandbox["Sandbox Tests"]
  Race --> Harness["Harness Tests"] --> Base["Base Composition"] --> Canon["Canonical Workspace"]
Loading
High-Level Assessment

The current approach is appropriate: resolving the temporary directory with filepath.EvalSymlinks models the canonical paths used by containment checks and remains cross-platform. macOS-specific string rewriting or skipping the test on Darwin would be more brittle and reduce coverage.

Files changed (2) +3 / -1

Tests (1) +2 / -0
enumerate_test.goCanonicalize the composition test workspace +2/-0

Canonicalize the composition test workspace

• Resolves the temporary test directory through symlinks before constructing harness paths. This prevents macOS '/var' and '/private/var' aliases from falsely failing production containment validation.

internal/harnessdispatch/enumerate_test.go

Other (1) +1 / -1
lint.ymlRun harness-dispatch tests in Darwin CI +1/-1

Run harness-dispatch tests in Darwin CI

• Extends the existing macOS race-test command to include all 'internal/harnessdispatch' packages alongside the sandbox suite.

.github/workflows/lint.yml

@codecov

codecov Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/harness/compose.go 92.59% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@ralphbean

Copy link
Copy Markdown
Member

/fs-review

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:37 PM UTC · Completed 8:56 PM UTC

Commit: 6526187 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $5.66

@ralphbean ralphbean added the ok-to-test Allow e2e CI to run after maintainer review (must be re-applied after each push) label Sep 8, 2026
@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Sep 8, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Risk Assessment: moderate (2/5)

Details

Composite holds at 2 (moderate): Tier1 metadata is unchanged from the prior review (4 files, 1 protected CI-workflow path, no dependency changes, non-first-time author), and although this increment is larger than the prior one (+41/-7 vs +5/-3, plus 173 new test lines), it remains an in-place tightening of the same containment/symlink-canonicalization logic already reviewed rather than a new risk surface. High historical fix/revert churn and multi-author contention on compose.go keep Tier2 near its prior level, and Tier3 stays low given tight issue-scope alignment and no new risk labels, offset only by the lack of a feature flag for this production security-adjacent check; weighted composite rounds to the same score of 2.

Previous run

Risk Assessment: moderate (2/5)

Details

Re-review anchoring holds at 2: Tier 1 signals (file count 4, protected-path count 1, no dependency changes, non-first-time author) are unchanged from the prior assessment, and the incremental compose.go/compose_test.go hardening (+5/-3, +15/-0) is a further tightening of the same containment logic rather than a scope expansion; weighted composite (Tier1 2.0x0.5 + Tier2 3.0x0.3 + Tier3 2x0.2 = 2.3) rounds to the same score of 2 (moderate), driven by the CI workflow touch and high historical churn/coupling on the harness compose files, offset by strong issue-scope alignment and no feature-flag/rollback path for the production check change.

Previous run (2)

Risk Assessment: moderate (2/5)

Details

Score holds at 2 (moderate) on re-review: Tier 1 rises modestly versus the prior test-only characterization because compose.go now carries a non-trivial (+34/-5) rewrite of security-relevant containment logic alongside the CI workflow tweak, offset by small blast radius, a 0.50 test ratio, and no dependency changes; Tier 2 shows high historical churn typical of this hot file; Tier 3 shows strong issue-to-PR alignment despite lacking a rollback flag, so the weighted composite still rounds to moderate.

Previous run (3)

Risk Assessment: moderate (2/5)

Details

Small, test-focused fix with a minor CI workflow tweak in a heavily active codebase area; moderate score reflects the CI file touch and high historical churn on these files, offset by minimal blast radius and clear issue alignment.

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Review

Findings

Medium

  • [protected-path] .github/workflows/lint.yml — This PR modifies a file under the protected path .github/. The change extends the Darwin CI job's go test invocation to also cover ./internal/harness/... and ./internal/harnessdispatch/..., and updates an adjacent comment (unchanged since the prior review). The PR links issue harnessdispatch: base-composition test repeats macOS TempDir alias failure from #2962 #7058, and both the PR description and the issue explain the rationale (the hosted macOS job did not previously exercise internal/harnessdispatch, which is why this bug went undetected). Human approval is always required for protected-path changes, regardless of context.

Low

  • [scope-authorization] internal/harness/compose.go:454 — Issue harnessdispatch: base-composition test repeats macOS TempDir alias failure from #2962 #7058 is scoped narrowly to a macOS test-flakiness bug (workspace-root vs. resolved-child-path /var//private/var alias causing a false-positive containment rejection). This PR's production fix goes further than alias tolerance: it also changes which path is opened after containment passes — loading resolvedBasePath instead of the original absBasePath — closing a check/open divergence for absolute-path symlink-plus-.. traversal (covered by the new TestLoadWithBase_LocalBase_AbsoluteSymlinkTraversalRejected), and introduces a new distinguished error, escapes workspace root via symlink. This is a reasonable and arguably necessary consequence of canonicalizing the containment check — resolving aliases while still opening the original string would reopen the exact class of symlink-escape bug the containment check exists to prevent — so it is not disqualifying scope creep. The current PR body now discloses this production, security-adjacent scope (an improvement over an earlier revision that read as test-only), so no code or description change is required; noted for reviewer awareness that this "fix" PR both resolves the flaky test and hardens check/open consistency for absolute symlink traversal.
    Remediation: No code change required. Confirm reviewers are aware of the dual scope (flaky-test fix + containment-hardening) before merge.

  • [sub-agent-failure] N/A — The challenger sub-agent returned an empty adjudicated_findings array for a non-empty input set (2 findings from the intent-coherence dimension), which the orchestrator treats as a challenger failure per policy (an empty result more likely indicates a parsing/context issue than a legitimate full removal). The pre-challenger finding set was used instead. Note: the challenger's own reasoning (in removed_findings) correctly identified that the intent-coherence sub-agent's original line citation (compose.go:380) was wrong (that line is in the unrelated URL-base branch); the citation has been corrected to compose.go:454 in the finding above.

Correctness / Security note

Both the correctness and security sub-agents independently confirmed that the prior medium-severity [path-traversal] finding (absolute base: check/open divergence at internal/harness/compose.go:454) is resolved in this revision: LoadRaw now opens the same resolvedBasePath that passed the containment check (including the reconstructed path in the missing-file dirErr branch), and the new TestLoadWithBase_LocalBase_AbsoluteSymlinkTraversalRejected test would fail against the pre-fix code and passes against the fix. No remaining correctness or security findings.

Previous run

Review

Findings

Medium

  • [path-traversal] internal/harness/compose.go:454 — The prior mixed-alias dirErr gap is fixed, but the symlink-aware rewrite in loadBaseChain leaves a real check/open divergence for absolute base: values. For a relative base:, filepath.Join(childDir, baseRef) lexically Cleans the string before both the containment check and the eventual LoadRaw(basePath) open, so base: ../../../etc/passwd and base: linked/base.yaml (a symlink to an outside directory) are still correctly rejected. For an absolute base: value, basePath is never reassigned/cleaned — it stays the literal string the harness author wrote. filepath.Abs+Clean (used to build absBasePath for the containment check) then lexically collapses any <symlink-dir>/.. segment without knowing <symlink-dir> is a symlink (e.g. Clean("/ws/harness/x/../secret.yaml") → "/ws/harness/secret.yaml"). EvalSymlinks is only ever called on this already-cleaned absBasePath, so the Rel containment check evaluates a fictitious in-workspace path. LoadRaw(basePath) at line 454 then opens the original, uncleaned absolute string, and the kernel walks the real symlink followed by the real .. — which can land outside the workspace even though the check reported the (different, cleaned) path as contained. This divergence pre-dates this PR (the old code already checked a Cleand absBasePath while opening basePath), but this PR is the one that adds symlink-following to the containment logic without also making the open consistent with what was actually resolved and checked, so it directly bears on the fix's stated goal of continuing "to verify that genuine path traversal and symlink escapes are rejected" (issue harnessdispatch: base-composition test repeats macOS TempDir alias failure from #2962 #7058). The new tests (TestLoadWithBase_LocalBase_SymlinkEscapeRejected and friends) only cover a symlink path prefix without a following .., so this gap is untested.
    Remediation: Open the same path that passed the containment check — LoadRaw(resolvedBasePath) (or LoadRaw(absBasePath) after Clean) — never the original, uncleaned absolute baseRef. Add a regression test that plants an in-workspace directory symlink to an outside directory and uses an absolute base: of the form <workspace>/<symlink>/../outside.yaml, asserting the load is rejected (or that only the lexically-cleaned in-workspace path is ever opened). Rejecting absolute local base: values entirely would also close this class of bypass.

  • [protected-path] .github/workflows/lint.yml — This PR modifies a file under the protected path .github/. The change extends the Darwin CI job's go test invocation to also cover ./internal/harness/... and ./internal/harnessdispatch/..., and updates an adjacent comment. The PR links issue harnessdispatch: base-composition test repeats macOS TempDir alias failure from #2962 #7058, and both the PR description and the issue explain the rationale (the hosted macOS job did not previously exercise internal/harnessdispatch, which is why this bug went undetected). Human approval is always required for protected-path changes, regardless of context.

Low

  • [description-scope-mismatch] PR description — The PR title (fix(#7058): canonicalize symlinks in harness base-path containment check) correctly signals a production change, but the body's Summary ("Canonicalize the base-composition test workspace on macOS so the /var to /private/var alias does not falsely trigger the production containment check") and Changes list ("resolve the temporary test directory through symlinks before composing paths") read as if only the test harness was touched. In fact loadBaseChain in internal/harness/compose.go was substantially rewritten to resolve the workspace root and base path through symlinks and to distinguish lexical traversal from symlink-based escapes. This is a narrative gap, not a code defect — the diff and new tests already make the actual scope discoverable.
    Remediation: If updating the PR body, state explicitly that loadBaseChain's production containment check now resolves symlinks and returns two distinct escape errors (lexical vs. symlink). Not a repository code change.

Correctness note

The correctness sub-agent confirmed the prior low-severity finding (mixed-alias dirErr misclassification on the ListTriggeredHarnesses dispatch path) is resolved: the new code requires both the unresolved-workspace and resolved-workspace Rel comparisons to indicate an escape before reporting "escapes workspace root," and TestLoadWithBase_LocalBase_MissingSiblingWithMixedWorkspaceAlias exercises exactly that mixed-alias scenario (resolved child path, unresolved WorkspaceRoot). No remaining correctness findings.


Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (2)

Review

Findings

Medium

  • [protected-path] .github/workflows/lint.yml — This PR modifies a file under the protected path .github/. The change extends the Darwin CI job's go test invocation to also cover ./internal/harness/... and ./internal/harnessdispatch/..., and updates an adjacent comment. The PR links issue harnessdispatch: base-composition test repeats macOS TempDir alias failure from #2962 #7058, and both the PR description and the issue explain the rationale (the hosted macOS job did not previously exercise internal/harnessdispatch, which is why this bug went undetected). Human approval is always required for protected-path changes, regardless of context.

Low

  • [logic-error] internal/harness/compose.go:432 — The dirErr branch still decides missing-directory vs. escape using only Rel(unresolvedWorkspace, absBasePath). On the production dispatch path this comparison is mixed-alias: ListTriggeredHarnesses sets WorkspaceRoot to filepath.Dir(configDir) (unresolved, e.g. /var/...), while LoadWithBase receives the child path from ResolveRegisteredPath/containedRegisteredPath, which is already EvalSymlinks-resolved (e.g. /private/var/...). absBasePath is Abs+Clean of Join(childDir, baseRef), so it inherits the resolved prefix. filepath.Rel is purely lexical, so Rel("/var/...", "/private/var/.../sibling-dir/missing.yaml") gets a .. prefix, and a nonexistent-but-in-workspace sibling directory is still misreported as "escapes workspace root" instead of wrapping dirErr. This does not reintroduce the original harnessdispatch: base-composition test repeats macOS TempDir alias failure from #2962 #7058 false-escape for existing files (both sides are canonicalized once the parent exists), and the load still correctly fails either way — the defect is error-class mislabeling on this dispatch path, not a containment bypass. The new Darwin dispatch test (TestListTriggeredHarnesses_BaseComposition) cannot catch this because it EvalSymlinks's the temp dir up front, so both sides already match by construction.
    Remediation: In the dirErr branch, treat the path as inside the workspace if either Rel(unresolvedWorkspace, absBasePath) or Rel(absWorkspace, absBasePath) is contained (no error, no .. prefix); return "escapes workspace root" only when both comparisons show an escape, otherwise wrap dirErr. Using only the resolved absWorkspace would break TestLoadWithBase_LocalBase_MissingSiblingWithinWorkspace on Darwin (unresolved absBasePath vs. resolved workspace); using only unresolvedWorkspace leaves this dispatch-path mixed-alias hole. Add a regression test that EvalSymlinks's the child path (or places it under a resolved alias) while WorkspaceRoot stays in unresolved form, with base: ../sibling-dir/missing.yaml, asserting the error is "resolving base path symlinks" rather than "escapes workspace root".

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (3)

Review

Findings

Medium

  • [protected-path] .github/workflows/lint.yml — This PR modifies a file under the protected path .github/. The change extends the Darwin CI job's go test invocation to also cover ./internal/harness/... and ./internal/harnessdispatch/..., and updates an adjacent comment. The PR links issue harnessdispatch: base-composition test repeats macOS TempDir alias failure from #2962 #7058, and both the PR description and the issue explain the rationale (the hosted macOS job did not previously exercise internal/harnessdispatch, which is why this bug went undetected). Human approval is always required for protected-path changes, regardless of context.

Low

  • [logic-error] internal/harness/compose.go:432 — When both the base file and its parent directory fail EvalSymlinks in loadBaseChain's local-path-base branch, the code classifies the path as a workspace escape using lexicallyEscapes, computed as filepath.Rel(childDir, absBasePath) having a .. prefix. childDir is the wrong reference point for a workspace-containment decision: production WorkspaceRoot is the repo root while childDir is the harness file's own directory, so a legitimate in-workspace reference such as base: ../sibling-dir/missing.yaml from a nested harness is lexicallyEscapes=true even though absBasePath never leaves WorkspaceRoot. If sibling-dir doesn't exist yet, this branch reports "escapes workspace root" instead of a missing-directory error. Successful loads (where the parent directory exists) are unaffected — this is a misleading-error-message regression on an already-failing path, not a new containment bypass. Before this PR, the equivalent case (Rel(absWorkspace, absBasePath) on unresolved, cleaned paths) accepted the same in-workspace missing-nested-path reference and let LoadRaw surface a plain file-not-found error.
    Remediation: Keep a copy of the Abs+Clean (unresolved) workspace path from before the EvalSymlinks(absWorkspace) call. In the dirErr branch, decide containment with Rel(unresolvedWorkspace, absBasePath) rather than Rel(childDir, absBasePath) — do not compare against the already-resolved absWorkspace, which would reintroduce the macOS /var vs /private/var alias false-escape this PR is fixing. Return "escapes workspace root" only when that unresolved comparison shows the base path leaving WorkspaceRoot; otherwise wrap dirErr. Add a regression test: WorkspaceRoot an ancestor of childDir, base: ../sibling-dir/missing.yaml referencing a nonexistent but in-workspace sibling directory, asserting the error is a missing-path error, not a containment escape.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (4)

Review

Findings

High

  • [commit-type-mismatch] internal/harness/compose.go:403 — The PR title uses the test prefix (test(#7058): cover harness dispatch on macOS), but the change includes a production-code fix: filepath.EvalSymlinks is added to the workspace containment check in loadBaseChain. Per COMMITS.md, test is reserved for adding or updating tests only and does not appear in release notes. This production fix corrects a user-visible defect (harness base composition silently misclassifying containment on macOS due to the /var → /private/var alias) and belongs under fix. GoReleaser uses PR titles to build release notes, so a test-typed title makes this bug fix invisible in the changelog.
    Remediation: Retitle the PR to fix(#7058): canonicalize symlinks in harness base-path containment check (or similar).

Medium

  • [protected-path] .github/workflows/lint.yml — This PR modifies a file under the .github/ protected path. The change adds ./internal/harnessdispatch/... to the Darwin CI test step. The PR links to issue harnessdispatch: base-composition test repeats macOS TempDir alias failure from #2962 #7058 and explains the rationale (extending the Darwin job to cover harness dispatch tests). Human approval is always required for protected-path changes, regardless of context.

Low

  • [error-handling] internal/harness/compose.go:413 — When EvalSymlinks(absBasePath) fails (e.g., nonexistent base file), the fallback filepath.Rel comparison uses the EvalSymlinks-resolved absWorkspace but the unresolved absBasePath. On macOS these path forms are inconsistent, causing a less precise error message ("escapes workspace root" instead of "resolving base path symlinks"). Mitigated in practice because production callers feed already-resolved paths.
    Remediation: Attempt EvalSymlinks on filepath.Dir(absBasePath) in the fallback block to give a consistent comparison.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

fullsend-ai-review[bot]

This comment was marked as outdated.

@shairevivo shairevivo changed the title test(#7058): cover harness dispatch on macOS fix(#7058): canonicalize symlinks in harness base-path containment check Sep 9, 2026
@github-actions github-actions Bot removed the ok-to-test Allow e2e CI to run after maintainer review (must be re-applied after each push) label Sep 9, 2026
@shairevivo

shairevivo commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor Author

Implemented and pushed in aece2be.

  • Retitled the PR as fix(harnessdispatch: base-composition test repeats macOS TempDir alias failure from #2962 #7058): canonicalize symlinks in harness base-path containment check.
  • Updated loadBaseChain to canonicalize the existing parent directory when the base file itself cannot be resolved, keeping /var and /private/var comparisons consistent.
  • Added a regression test covering a missing base under a workspace symlink alias.
  • Verified targeted tests, go test -race ./internal/harness/..., coverage, and staged make lint.
  • The protected-path item only requires the usual human approval for the .github/ workflow change.

@ralphbean ralphbean added the ok-to-test Allow e2e CI to run after maintainer review (must be re-applied after each push) label Sep 9, 2026
@github-actions github-actions Bot removed the ok-to-test Allow e2e CI to run after maintainer review (must be re-applied after each push) label Sep 9, 2026

@waynesun09 waynesun09 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review-only pass on the updated head (7843c49c8) — three findings, all verified by running fixtures against this head and against the pre-fix parent. No approval or change request implied.

Comment thread internal/harness/compose.go Resolved
Comment thread internal/harness/compose.go Resolved
Comment thread .github/workflows/lint.yml Resolved
shairevivo and others added 4 commits September 10, 2026 23:14
Canonicalize the temporary workspace used by the composition test.
This prevents macOS /var aliases from tripping containment checks.

Run harnessdispatch tests in the existing Darwin CI job.

Co-authored-by: Codex <noreply@openai.com>
Signed-off-by: Shai Revivo <srevivo@redhat.com>
Canonicalize workspace and base paths before containment checks.

Signed-off-by: Shai Revivo <srevivo@redhat.com>
Co-authored-by: Codex <noreply@openai.com>
Canonicalize the existing parent directory when a local base file
 does not yet exist.

This keeps workspace aliases consistent before reporting the underlying
load error.

Co-authored-by: Codex <noreply@openai.com>
Signed-off-by: Shai Revivo <srevivo@redhat.com>
Keep lexical base paths for loading and ancestor resolution while using
canonical paths for containment and cycle detection. Distinguish traversal
from symlink escapes and run containment tests on Darwin.

Co-authored-by: Codex <noreply@openai.com>
Signed-off-by: Shai Revivo <srevivo@redhat.com>
@shairevivo
shairevivo force-pushed the srevivo/7058-macos-tempdir branch from 511f50d to 56a8a8d Compare September 10, 2026 20:14
@ifireball ifireball added the ok-to-test Allow e2e CI to run after maintainer review (must be re-applied after each push) label Sep 15, 2026
@github-actions github-actions Bot removed ok-to-test Allow e2e CI to run after maintainer review (must be re-applied after each push) labels Sep 15, 2026
@shairevivo shairevivo mentioned this pull request Sep 15, 2026
9 of 13 tasks
@fullsend-ai-review

fullsend-ai-review Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:24 AM UTC · Completed 3:44 AM UTC

Commit: 028d7ca · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $4.05

fullsend-ai-review[bot]

This comment was marked as outdated.

Check unresolved and canonical workspace paths when base resolution fails.

This keeps mixed aliases from misclassifying missing paths as escapes.

Co-authored-by: Codex <noreply@openai.com>
Signed-off-by: Shai Revivo <srevivo@redhat.com>
@shairevivo

Copy link
Copy Markdown
Contributor Author

Fixed the remaining low [logic-error] finding in commit 19a01d5.

The missing-parent fallback now reports a workspace escape only when both the unresolved and canonical workspace forms reject the base path. Added TestLoadWithBase_LocalBase_MissingSiblingWithMixedWorkspaceAlias, which reproduces the dispatch path with an unresolved workspace alias and an EvalSymlinks-resolved child path.

Verification:

  • regression test failed with the old escapes workspace root classification before the fix, then passed after it
  • go test -race -count=1 ./internal/harness/...
  • make go-test
  • make go-vet
  • staged make lint
  • loadBaseChain coverage: 94.9%

The separate protected-path finding still requires human approval for .github/workflows/lint.yml.

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:15 AM UTC · Completed 8:33 AM UTC

Commit: 19a01d5 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $4.70

@fullsend-ai-review fullsend-ai-review Bot removed the risk/moderate PR risk: moderate label Sep 16, 2026
fullsend-ai-review[bot]

This comment was marked as outdated.

Co-authored-by: Codex <noreply@openai.com>
Signed-off-by: Shai Revivo <srevivo@redhat.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

🤖 Review · ⚠️ Cancelled · Started 9:17 PM UTC · Ended 9:22 PM UTC

Commit: 1ca8d36 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 9:24 PM UTC · Completed 9:41 PM UTC

Commit: 8199f07 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $3.71

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Sep 16, 2026
@fullsend-ai-review
fullsend-ai-review Bot dismissed stale reviews from themself September 16, 2026 21:41

Superseded by updated review

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

Comment thread internal/harness/compose.go Resolved
@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Sep 16, 2026
@waynesun09
waynesun09 added this pull request to the merge queue Sep 17, 2026
Merged via the queue into fullsend-ai:main with commit 662d2cc Sep 17, 2026
75 checks passed
@qodo-code-review qodo-code-review Bot mentioned this pull request Oct 8, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-manual-review Review requires human judgment risk/moderate PR risk: moderate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

harnessdispatch: base-composition test repeats macOS TempDir alias failure from #2962

4 participants