Repository navigation
fix(#7140): map hyphens to underscores in role identifiers - #7215
Conversation
PR Summary by QodoNormalize hyphenated role identifiers across integration surfaces
AI Description
Diagram
High-Level Assessment
Files changed (23)
|
Custom harness roles such as ci-check produced invalid bash identifiers in Setup agent environment. Role-prefixed env vars, GitHub Actions secrets/variables, and FOREIGN allow-list names now share mintcore.RoleIdentifier: uppercase the role and replace hyphens with underscores. github status prints FOREIGN variable names without a reconstructed role; CI_CHECK is not uniquely ci-check or ci_check. Assisted-By: grok-4.6(pi) Signed-off-by: Hector Martinez <hemartin@redhat.com>
02cb454 to
d7fb5a7
Compare
|
🤖 Review · Commit: |
Code Review by Qodo
1. Workflow changes bypass guide review
|
|
🤖 Finished Review · ✅ Success · Started 3:18 PM UTC · Completed 3:37 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $7.88 |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
ReviewFindingsMedium
Next steps:
|
waynesun09
left a comment
There was a problem hiding this comment.
Approving at d7fb5a7. The role-identifier normalization and the regression tests that cover it look correct, and the mint-side note documents the new prefix mapping.
The one MEDIUM comment I left stands as non-blocking. docs/runtimes.md is the page the dispatch workflow comment points operators to for <ROLE>_FULLSEND_MODEL, and it still describes the prefix as the plain agent name, so a hyphenated custom role reads there as CI-CHECK_FULLSEND_MODEL rather than CI_CHECK_FULLSEND_MODEL. A follow-up sentence on that page, or retargeting the pointer, would close it.
|
🤖 Finished Retro · ✅ Success · Started 10:42 AM UTC · Completed 10:51 AM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $1.47 |
|
PR #7215 (fullsend-ai/fullsend) was a human-authored fix (rh-hemartin, AI-assisted by an external tool, not a fullsend code-agent dispatch) for issue #7140: hyphenated custom harness roles (e.g. The fullsend review agent performed strongly here: after a cancelled first pass (superseded by a push), its full review on the final commit correctly flagged (a) a protected-path policy match on Two new, unduplicated issues are proposed below (the RoleIdentifier collision bug, and the docs/runtimes.md staleness the author asked for). A third pattern — human merge overriding an unresolved agent CHANGES_REQUESTED with no acknowledgment requirement — is already tracked by open issues #1201 (merge-policy gate) and #2099 (nudge on unresolved Medium+ findings); this PR is a fresh, concrete data point for both (a real security-relevant regression, correctly caught by the review agent, silently unaddressed through merge) but does not warrant a new duplicate issue. Proposals filed |
Summary
Custom harness roles with hyphens (
ci-check) failed in Setup agent environment because the dispatch job uppercasedmatrix.roleand exported names likeCI-CHECK_TARGET_REPO_DIR, which bash rejects. Role-prefixed identifiers now sharemintcore.RoleIdentifier: uppercase the role and replace hyphens with underscores (ci-check→CI_CHECK).Related Issue
Fixes #7140
Changes
reusable-dispatch.yml) soci-checkbecomesCI_CHECK_TARGET_REPO_DIR/CI_CHECK_.FULLSEND_<ROLE>_APP_PRIVATE_KEY,FULLSEND_<ROLE>_CLIENT_ID), FOREIGN allow-lists (FULLSEND_FOREIGN_<ROLE>_REPOS), and CF PEM names.fullsend github statusprints FOREIGN variable names without a reconstructed role in parentheses (CI_CHECKis not uniquelyci-checkorci_check).Testing
make lintpasses (stage changes first, then run)RoleIdentifier, hyphenated foreign allow,github statusoutput, dispatch hyphen mapping pin)Checklist
!for breaking changes)