Repository navigation
docs(adr): ADR 0107 — capture tool-call results in the run trace - #7419
AshwinUgale wants to merge 1 commit into
Conversation
Proposes capturing each tool call's result on the trace (bounded, redacted, gated), the prerequisite for deterministic run-health analysis raised as an open question in operational-observability.md (fullsend-ai#7386). Scoped to the capture-contract change only; a run-health scorer is a separate follow-up. Includes the required architecture.md and problem-doc updates. Refs: fullsend-ai#7246, fullsend-ai#7386. Signed-off-by: Ashwin Govind Ugale <ugaleashwin@gmail.com>
E2E tests did not runE2E tests run automatically for org/repo members and collaborators on pull requests. For other contributors, a maintainer must add the See E2E testing guide for details. |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can enable the Remediation agent and Qodo fixes findings in a dedicated fix PR |
PR Summary by QodoAdopt bounded tool-result capture for run traces
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Site previewPreview: https://89efde52-site.fullsend-ai.workers.dev Commit: |
|
Closing , I hadn't seen #6603, which already lands this capture decision (ADR 0108, plus the execute_tool spans and tool-result content). No sense in a second ADR on the same thing. Thanks @dhshah13; I'll build the run-health scorer (fullsend-ai/fullsend#7246) on top once it merges. |
|
🤖 Finished Retro · ✅ Success · Started 9:56 PM UTC · Completed 10:07 PM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $2.07 |
|
PR #7419 was a human-authored, docs-only ADR proposal ("ADR 0107 — capture tool-call results in the run trace") that its own author closed ~3 hours after opening because it duplicated the decision already made in the still-open PR #6603 (ADR 0108), which has covered the same capture prerequisite since 2026-08-25. No fullsend review agent ever looked at PR #7419's content: the author holds only Proposals filed
|
Follows the merged problem-doc addition in #7386, which recorded the open question in
operational-observability.mdof whether trace scoring should cover run health, not just trace fitness (ADR 0087), and the earlier discussion in #7246.This ADR takes the one prerequisite that gates all of it: capturing tool-call results on the trace. Today Level 3 content capture records tool-call names and counts but explicitly defers results (
internal/cli/content_collector.go: "not captured yet"), so the structurally-decidable failure classes — a tool error the run ignored, an errored result reused by a later side-effecting call — aren't visible to any deterministic post-run analysis.I'm suggesting this and asking for your approval on the direction — not asserting it's already settled. There's no "Proposed" ADR status in this repo, so per convention it's written as
Accepted, but the intent is maintainer sign-off at review; if the direction isn't wanted, that's useful to know too. The decision is scoped to the capture-contract change only — a run-health scorer (EM-002) would be a separate follow-up if you want it.Notes:
0107may collide with in-flight ADRs — happy to renumber at merge.architecture.mdObservability "Decided" bullet, and an annotation on theoperational-observability.mdopen question (capture prerequisite marked decided; the scorer question left open).Refs: #7246, #7386.