Skip to content

docs(#7513): add fallback terminology checklist item - #7515

Merged
ggallen merged 1 commit into
mainfrom
agent/7513-fallback-terminology-checklist
Sep 21, 2026
Merged

ggallen merged 1 commit into
mainfrom
agent/7513-fallback-terminology-checklist

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

Add a fifth item to the GitLab credential-routing security checklist so later routing/rotation/cutover work keeps the two fallback mechanisms named consistently across the four docs that describe them.

Related Issue

#7513 (follow-up to the checklist added in #7511 / PR #7512). Aimed at remaining rollout stages #7500 and #7501, which already treat this checklist as required reading.

Changes

  • Add Keep fallback terminology consistent across docs after Preserve non-role-aware token fallbacks in docs/contributing/gitlab-role-credentials.md.
  • Name the two mechanisms with fixed terms:
    • shared-token fallback — selecting FULLSEND_FORGE_TOKEN (always-on in disabled/rollback; explicit fallback in migrating when that role is unconfigured; never in enforced).
    • local direct-GITLAB_TOKEN fallback — the documented local-dev workflow where GITLAB_TOKEN is set with no FULLSEND_FORGE_TOKEN, handled as a no-op on gitlabroles.ErrSharedUnconfigured in disabled/rollback only.
  • List the four docs that describe them independently (gitlab-role-credentials.md, docs/cli/run.md, docs/guides/user/running-agents-locally.md, docs/problems/security-threat-model.md).
  • Add a checkbox requiring any fallback or migration-gate change to re-read and update all four with the same terms.
  • Update the checklist intro so it covers the four code invariants plus this documentation-terminology rule.

Testing

  • lychee --offline --include-fragments (make lint-md-links) — 0 errors
  • ./hack/lint-docs-links on the contract doc
  • gitleaks / scan-secrets on changed and staged files
  • make lint — pre-commit could not fetch remote hook repos (HTTP 403); local equivalents of the applicable hooks were run instead
  • N/A Tests added/updated — documentation only; no production code change

Checklist

  • PR title follows Conventional Commits (correct type, ! for breaking changes)
  • Commits are signed off (DCO) — human and human-directed agent sessions only (autonomous agent commits are exempt)
  • I wrote this contribution myself and can explain all changes in it

Closes #7513

Post-script verification

  • Branch is not main/master (agent/7513-fallback-terminology-checklist)
  • Secret scan passed (gitleaks — 2e7f522bea11c7bcbd7e49e3b4eae5214663cac8..HEAD)
  • PR body secret scan passed (gitleaks — no-git)

@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team September 21, 2026 02:05
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Triggers review agent dispatch label Sep 21, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:06 AM UTC · Completed 2:19 AM UTC

Commit: 99cbc62 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $2.33

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Site preview

Preview: https://89a235a6-site.fullsend-ai.workers.dev

Commit: f0f52bbe3028310077abc8d75601b1844b096490

@codecov

codecov Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review fullsend-ai-review Bot added the risk/low PR risk: low label Sep 21, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Risk Assessment: low (1/5)

Details

Docs-only, bot-authored, 36-line single-file change with no protected/security/CI/dependency touches (Tier 1 ~1.0); elevated change-coupling with the broader gitlabroles implementation but low churn/age and no reverts (Tier 2 ~2.3); tight same-day issue-scope alignment with all criteria met (Tier 3 ~1.3). Weighted composite ~1.45 rounds to 1/low, consistent with and anchored to the prior round-2 assessment (also 1/low).

Previous run

Risk Assessment: low (1/5)

Details

Re-review round 2: cumulative diff grew from 32 to 46 lines but remains a single docs file with no protected/security/CI/dependency touches and a bot author (Tier 1 composite ~1.0); Tier 2 shows elevated change-coupling with the broader GitLab-role-credentials implementation but low author diversity and no regressions/reverts (composite ~2.0); Tier 3 shows tight same-day issue-scope alignment with all criteria met (composite ~1.3). Weighted composite rounds to 1/low, unchanged from the prior assessment.

Previous run (2)

Risk Assessment: low (1/5)

Details

Single-file, 32-line docs-only checklist addition by a bot author against a well-specified, same-day issue with no risk labels or open discussion; git history shows the file changes frequently alongside a broader implementation effort (elevated change-coupling), but low file/line count, single recent author, no protected/security/CI/dependency touches, and tight issue-scope alignment keep the composite score at the low end.

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Looks good to me

Previous run

Looks good to me

Previous run (2)

Review

Findings

Low


Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-coder

fullsend-ai-coder Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Finished Fix · ✅ Success · Started 2:21 AM UTC · Completed 2:27 AM UTC

Commit: 99cbc62 · View workflow run →

Runtime: claude · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $0.84

fullsend-ai-coder Bot added a commit that referenced this pull request Sep 21, 2026
The checklist intro said the terminology rule (added in #7513) was
part of "the review findings from PR #7510" and could be "reintroduced"
by a routing-code change, which only makes sense for the four code
invariants. Scope "They"/"any of them" to those four and attribute the
terminology rule to #7513 separately.

Addresses #7515
@fullsend-ai-coder

Copy link
Copy Markdown
Contributor Author

🔧 Fix agent — iteration 1 (bot-triggered)

Fixed the one low-severity finding: scoped the checklist's PR #7510 provenance and "can reintroduce any of them" language to the four code invariants only, and gave the new terminology rule its own #7513 attribution so it no longer reads as a reintroducible routing-code finding.

Fixed (1):

  1. incorrect-claim: checklist intro implies the new documentation-terminology rule is one of the PR feat(#7499): route GitLab jobs by registered role identity #7510 routing findings that a routing-code change can "reintroduce" (docs/contributing/gitlab-role-credentials.md): Reworded the checklist intro (lines ~387-394) so "They"/"any of them" refers only to the four code invariants attributed to PR feat(#7499): route GitLab jobs by registered role identity #7510, and added a separate sentence attributing the new documentation-terminology rule to Add a cross-doc terminology-consistency item to the GitLab credential-routing security checklist #7513 as a docs-consistency practice rather than a routing bug that code can reintroduce.

Tests: passed

Next steps:

  • /fs-review — request a re-review of the changes
  • /fs-fix <your instruction> — run another fix pass with specific guidance
  • Push commits directly — review re-runs automatically on push
    Updated by fullsend fix agent

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:29 AM UTC · Completed 2:41 AM UTC

Commit: f0c4061 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $2.26

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Sep 21, 2026
@ggallen
ggallen force-pushed the agent/7513-fallback-terminology-checklist branch from f0c4061 to a5afcfd Compare September 21, 2026 13:45
@fullsend-ai-review

fullsend-ai-review Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

🤖 Review · ⚠️ Cancelled · Started 1:48 PM UTC · Ended 1:50 PM UTC

Commit: a5afcfd · View workflow run →

Document the shared-token and local direct-GITLAB_TOKEN fallbacks with fixed terminology, list the four related documents, and require synchronized updates across them. Scope the checklist provenance to the four PR #7510 code invariants and attribute the terminology rule to #7513.

Signed-off-by: Greg Allen <gallen@redhat.com>
Signed-off-by: Codex <noreply@openai.com>
@ggallen
ggallen force-pushed the agent/7513-fallback-terminology-checklist branch from a5afcfd to f0f52bb Compare September 21, 2026 13:48
@fullsend-ai-review

fullsend-ai-review Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 1:52 PM UTC · Completed 2:02 PM UTC

Commit: f0f52bb · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $2.17

@fullsend-ai-review
fullsend-ai-review Bot dismissed their stale review September 21, 2026 14:02

Superseded by updated review

@ggallen
ggallen enabled auto-merge September 21, 2026 14:03
@ggallen
ggallen added this pull request to the merge queue Sep 21, 2026
Merged via the queue into main with commit eb8149a Sep 21, 2026
42 checks passed
@ggallen
ggallen deleted the agent/7513-fallback-terminology-checklist branch September 21, 2026 14:06
@fullsend-ai-retro

fullsend-ai-retro Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 2:08 PM UTC · Completed 2:17 PM UTC

Commit: f0f52bb · View workflow run →

Runtime: claude · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $1.28

@fullsend-ai-retro

Copy link
Copy Markdown

PR #7515 (docs(#7513): add fallback terminology checklist item) is a clean, fully-traced example of the autonomous pipeline working as intended: a prior retro (on PR #7512) identified a terminology-consistency gap and filed issue #7513, triage independently re-verified the proposal and marked it ready-to-code, the code agent implemented the fix, review round 1 caught one real low-severity issue (an over-broad provenance claim in the checklist intro), the fix agent resolved it in one cycle, and review round 2 approved. A human (ggallen) later rebased the branch onto a concurrently-merged main (an unrelated PR touching the same doc file) and approved after review round 4 re-confirmed no new findings; round 3 was a harmless GitHub Actions cancellation caused by two rapid pushes 3 minutes apart. CI was green throughout with no flakiness signal. The human's only contribution beyond approval was the rebase and an inline comment confirming the round-1 fix — no findings were caught by human review that the agent missed, and no findings were false positives. The apparent 'model inconsistency' (code stage using xai/grok-4.6 while triage/review/fix/retro used Sonnet) was verified as intentional cross-vendor dogfooding configured in fullsend-ai/fullsend's own .fullsend/config.yaml per ADR 0104, not a defect. One process friction was found: tracing this PR required discovering that fullsend-ai/fullsend dogfoods its own dispatch pipeline (all stages run as jobs within its own workflow runs, not via a separate fullsend-ai/.fullsend dispatch repo as the finding-agent-runs/github skills assume), which cost extra investigation tool calls. This is an exact duplicate of already-open fullsend-ai/agents#1283 ('finding-agent-runs / github recipe skills point at deprecated .fullsend per-stage workflows'), filed 2026-09-14 from a different PR (#7285) and still unaddressed; this run's evidence corroborates it but no new issue is filed. No other improvement opportunities were identified — this workflow is a positive example for autonomy readiness (review agent matched human review quality on this class of low-risk doc change).

This branch was successfully deployed

1 active and 1 inactive deployments
site-preview — f0f52bbe Deployed Sep 21, 2026 by github-actions[bot]
dev — f0f52bbe Deployed Sep 21, 2026 by ggallen via behaviour #13413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge ready-for-review Triggers review agent dispatch risk/low PR risk: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a cross-doc terminology-consistency item to the GitLab credential-routing security checklist

1 participant