Repository navigation
docs(#7734): warn Jira poller credentials must be a service account - #7735
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
|
🤖 Review · Commit: |
|
🤖 Finished Review · ✅ Success · Started 9:24 PM UTC · Completed 9:36 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $1.85 |
Site previewPreview: https://9f17ea43-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ReviewFindingsLow
Previous runLooks good to me |
|
Consider whether the documentation can distinguish the poller's technical credential contract from the recommended operating identity. |
|
One wording point before this merges. The PR title, #7734 and the new text all say "dedicated Jira service account" when they mean "an account that is not a real person's". In Atlassian terms those are two different kinds of dedicated non-human account, and only one of them works with fullsend today:
So #7734 treats "service account" and "dedicated non-human account" as interchangeable, and they are not. Read literally, the warning tells operators to use the one account type that does not work. There seems to be demand for each. My personal opinion is that we should support both. I opened #9007 for adding service-account support alongside the bot-account path, which must keep working. For this PR, I would say "dedicated non-human account" (or "bot account") instead of "service account", so the warning stays correct once #9007 lands and #8678's authentication-model section, which draws the same distinction, does not contradict it. Posted by Bill Murdock with assistance from Claude Code. |
|
/fs-fix |
|
🤖 Finished Fix · ✅ Success · Started 7:07 AM UTC · Completed 7:10 AM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.33 |
🔧 Fix agent — iteration 1 (human-triggered)No commit was made. The PR conflicts with main in docs/guides/user/jira-integration.md. I resolved it locally by keeping both sides, but the mandatory secret scan flagged a dummy OpenAI-style test key in a Go test file brought in from main (not authored by this PR). The scan is a hard stop, so I aborted the merge and left the branch unchanged. A human needs to resolve the conflict manually or confirm the finding is a false positive (for example by allowlisting it). The empty /fs-fix instruction and the approving review gave no other findings; the jwm4 and jasonawant comments were not applied. Fixed (1):
Disagreed (1):
Tests: failed CI inspections (4):
Conflict update: failed; strategy Decision points
Next steps:
|
|
/fs-fix rebase and resolve confclits and then One wording point before this merges. The PR title, #7734 and the new text all say "dedicated Jira service account" when they mean "an account that is not a real person's". In Atlassian terms those are two different kinds of dedicated non-human account, and only one of them works with fullsend today:
So #7734 treats "service account" and "dedicated non-human account" as interchangeable, and they are not. Read literally, the warning tells operators to use the one account type that does not work. There seems to be demand for each. My personal opinion is that we should support both. I opened #9007 for adding service-account support alongside the bot-account path, which must keep working. For this PR, I would say "dedicated non-human account" (or "bot account") instead of "service account", so the warning stays correct once #9007 lands and #8678's authentication-model section, which draws the same distinction, does not contradict it. Posted by Bill Murdock with assistance from Claude Code. |
|
🤖 Finished Fix · ✅ Success · Started 7:18 AM UTC · Completed 7:21 AM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.31 |
The poller classifies its own /myself account as actor.kind: bot so self-authored comments and changelog entries do not re-trigger dispatch. Using a real person's JIRA_USER_EMAIL/JIRA_TOKEN therefore silently drops that person's genuine comments and label changes. Warn operators in the credential prerequisites and add a matching troubleshooting row. Note: pre-commit could not fetch remote hook repositories (HTTP 403). Equivalent local checks were run instead: trailing-whitespace, end-of-file-fixer, check-merge-conflict, detect-private-key, gitleaks, lint-broken-symlinks, lint-docs-links, and lychee --offline. make lint failed for the same fetch error. Closes #7734
🔧 Fix agent — iteration 1 (human-triggered)Rebased onto main (resolved 3 conflicts in jira-integration.md) and reworded this PR's added text from 'dedicated service account' to 'dedicated non-human (bot) account'. PR title and commit message still say 'service account' and need a manual update. Fixed (2):
Tests: passed CI inspections (1):
Decision points
Next steps:
|
3038be3 to
f9414d7
Compare
|
🤖 Finished Review · ✅ Success · Started 7:23 AM UTC · Completed 7:29 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.93 |
|
<!-- fullsend:risk-assessment --> DetailsSmall documentation-only update with minimal metadata risk, but elevated to moderate due to high recent commit churn and active multi-author contention on the Jira integration guide. |
Superseded by updated review
Summary
Warn operators that
JIRA_USER_EMAIL/JIRA_TOKENmust belong to a dedicated Jira service account. The poller classifies its own/myselfaccount asactor.kind: botto prevent self-triggered dispatch loops, so a teammate's genuine comments and label changes would otherwise be silently dropped.Related Issue
#7734. Sibling #6847 (open PR #7691) documents service-account creation for permission/role scoping; this warning covers the silent-drop risk from the self-loop filter shipped in #7688.
Changes
Testing
scan-secrets) and gitleaks on the edited file.hack/lint-docs-linksandlychee --offline --include-fragments(0 errors).make lint—pre-commit runcould not fetch remote hook repos (HTTP 403). Equivalent local markdown hooks were run instead.Checklist
Closes #7734
Post-script verification
agent/7734-jira-service-account-warning)7ef8630bceb6793de6a65a00a493e79aaa76056f..HEAD)