Repository navigation
docs(adr): fullsend-owned mechanism for Codex sub-agents - #7827
Conversation
Record the decision fullsend-ai#6970 needs before any implementation: Codex review and retro children run under roles and models the runner provisions, a mandatory dispatch hook that admits only fresh-context V1 spawns of registered roles, and a spawn-time digest check on the hook and role files. Write protection of those files is an option, not chosen. Cross-reference the new ADR from the Accepted ADR 0104, whose persona frontmatter the Codex policy does not apply. Signed-off-by: Dharit Shah <dhshah@redhat.com>
E2E tests did not runE2E tests run automatically for org/repo members and collaborators on pull requests. For other contributors, a maintainer with write access must add the See E2E testing guide for details. |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR |
PR Summary by QodoDocument runner-owned policy for native Codex child agents
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
|
🤖 Finished Review · ✅ Success · Started 1:01 PM UTC · Completed 1:20 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $4.97 |
Site previewPreview: https://75bb427b-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ReviewFindingsMedium
Next steps:
Previous runReviewFindingsLow
Previous run (2)ReviewFindingsMedium
Low
Other dimensions dispatched clean against the current diff: Next steps:
Previous run (3)ReviewFindingsMedium
Next steps:
Previous run (4)ReviewFindingsMedium
Low
Next steps:
Previous run (5)ReviewFindingsLow
Next steps:
Previous run (6)ReviewFindingsHigh
Other dimensions dispatched clean against the current revision:
A challenger pass adjudicated the sub-agent-failure finding above: it proposed downgrading the severity to medium on the grounds that the underlying change is documentation-only and not-yet-implemented. The orchestrator preserves the high severity here per this review process's fixed rule for Opus-tier sub-agent dispatch failures — a correctness review that cannot complete on a security-relevant ADR (hook admission policy, fail-open/fail-closed behavior, model-resolution precedence) is a gap serious enough to warrant a human rather than being silently treated as a pass. This is the third consecutive run in which the correctness sub-agent has failed to complete on this specific PR, which may indicate the ADR's length/density or its external-verification-shaped claims are triggering excessive tool use for the Opus-tier reviewer; manual correctness review of Next steps:
Previous run (7)ReviewFindingsHigh
Medium
Low
Other dimensions dispatched clean: Next steps:
Previous run (8)Looks good to me Previous run (9)Looks good to me Previous run (10)Looks good to me Previous run (11)Looks good to me Previous run (12)ReviewFindingsMedium
The prior medium finding on this ADR (the admission hook's failure mode being unstated) is not observed in the current diff: the Decision now states the hook fails closed for policy violation, digest mismatch, missing/unreadable input, or any in-hook error (mapped to exit 2), and Bootstrap fails if the hook cannot be installed. The Consequences separately disclose that a handler Codex cannot complete (timeout, interpreter failure) is recorded "Failed" and does not block — the same platform residual ADR 0100 already accepts for all Codex hooks, now explicitly named rather than left silent. Next steps:
Previous run (13)ReviewFindingsMedium
Other candidate findings raised by dimension sub-agents (an internal-inconsistency claim about Next steps:
|
A policy violation, digest mismatch, missing file, unreadable input or hook error denies the spawn with exit 2, the only exit Codex treats as a block. Name the timeout residual ADR 0100 already records. Signed-off-by: Dharit Shah <dhshah@redhat.com>
|
🤖 Review · Commit: |
Signed-off-by: Dharit Shah <dhshah@redhat.com>
|
🤖 Review · Commit: |
…hook residual Signed-off-by: Dharit Shah <dhshah@redhat.com>
|
Addressed the fail-open finding in 66a8f94 and 5a6f3d7:
🤖 Addressed by Claude Code |
|
🤖 Finished Review · ✅ Success · Started 1:34 PM UTC · Completed 1:49 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $3.64 |
|
Risk Assessment: moderate (2/5) DetailsDocumentation-only ADR addition with no code modifications or protected paths, elevated to moderate risk by high commit churn (74 commits in 30 days) and multi-author contention (15 authors in 90 days) on docs/architecture.md; consistent with prior runs on this PR. Previous runRisk Assessment: moderate (2/5) DetailsDocumentation-only ADR addition with no code modifications or protected paths, elevated to moderate risk by high commit churn (74 commits in 30 days) and multi-author contention (15 authors in 90 days) on docs/architecture.md; consistent with 10+ prior runs on this PR. Previous run (2)Risk Assessment: moderate (2/5) DetailsDocumentation-only ADR addition with no code modifications or protected paths, elevated to moderate risk by high commit churn and multi-author contention on docs/architecture.md. Consistent with prior runs on this PR. Previous run (3)Risk Assessment: moderate (2/5) DetailsDocumentation-only ADR change with no protected paths or code modifications, moderate file churn driven by the architecture index, and clean rollback safety. Previous run (4)Risk Assessment: moderate (2/5) DetailsDocumentation-only change (new ADR plus cross-reference edits) with no protected paths, no security-sensitive files, and no dependency changes, but high historical churn and author contention on the modified ADR/architecture documentation elevate the composite risk from low to moderate. Previous run (5)Risk Assessment: moderate (2/5) DetailsDocumentation-only ADR change with no protected paths or dependency modifications, anchored to moderate risk (consistent with 5+ prior runs on this PR) due to high churn, multi-author contention, and regression history on docs/architecture.md. Previous run (6)Risk Assessment: moderate (2/5) DetailsDocumentation-only ADR change with no protected paths or dependency modifications, anchored to moderate risk (consistent with 5+ prior runs on this PR) due to high churn, multi-author contention, and regression history on docs/architecture.md. Previous run (7)Risk Assessment: moderate (2/5) DetailsDocumentation-only ADR change with no protected paths or dependency modifications, anchored to moderate risk due to high churn, multi-author contention, and regression history on docs/architecture.md. Previous run (8)Risk Assessment: moderate (2/5) DetailsDocumentation-only ADR change with no protected paths or dependency modifications, anchored to moderate risk due to high churn, multi-author contention, and regression history on docs/architecture.md. Previous run (9)Risk Assessment: moderate (2/5) DetailsDocumentation-only ADR change with no protected paths or dependency modifications, anchored to moderate risk due to high churn, multi-author contention, and regression history on docs/architecture.md. Previous run (10)Risk Assessment: moderate (2/5) DetailsDocumentation-only ADR change with no protected paths or dependency modifications, anchored to moderate risk due to high churn, multi-author contention, and regression history on docs/architecture.md. Previous run (11)Risk Assessment: moderate (2/5) DetailsSmall documentation-only ADR change with no protected paths, but assigned moderate risk due to high churn, multi-author contention, and regression history on docs/architecture.md. |
Signed-off-by: Dharit Shah <dhshah@redhat.com>
Signed-off-by: Dharit Shah <dhshah@redhat.com>
Signed-off-by: Dharit Shah <dhshah@redhat.com>
Superseded by updated review
Answers the review bot's low finding on 6c0ad3a, which asked for a decision on the fail-open path before implementation. Codex's exec stream drops hook outcomes and its rollout does not persist them (exec/src/event_processor_with_jsonl_output.rs, rollout/src/policy.rs), so the runner cannot see a failed guard directly; instead the guard records each admission with the spawn's tool_use_id in the findings log and the runner, which already reads every child's rollout, fails the run when a child has no admission, as it fails a run whose audit log does not verify. A resume on that path is the residual that remains. The switch ships after the cross-check. Signed-off-by: Dharit Shah <dhshah@redhat.com>
waynesun09, 2026-10-01: an implementation-time choice, not an ADR defect; fullsend-ai#7829 keeps the multi-agent tools off until the hook ships, and whether a Failed/timeout dispatch outcome aborts the run is for the implementation PRs under fullsend-ai#6970. The ADR keeps the two verified facts an implementation needs (exec --json drops hook outcomes; the rollout does not persist them) and no longer decides the cross-check itself. Signed-off-by: Dharit Shah <dhshah@redhat.com>
|
🤖 Finished Review · ✅ Success · Started 8:13 PM UTC · Completed 8:31 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $6.97 |
Superseded by updated review
Answers the review bot's medium finding on 095c62e: the findings log and the children's rollouts are agent-writable, so they cannot establish that an unadmitted spawn fails the run. The claim itself is already gone (the abort choice is left to the implementation PRs); this commit replaces the pointer to those two stores with the exec stream's collab_tool_call items (a spawn's sender and receiver thread ids and status), which the host captures outside the sandbox, and notes that the stream carries no item for a resume. Signed-off-by: Dharit Shah <dhshah@redhat.com>
|
🤖 Finished Review · ✅ Success · Started 8:36 PM UTC · Completed 8:47 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $2.27 |
|
Review skipped — this PR is already merged. The Posted by fullsend post-review check |
Summary
ADR 0126 decides whether Codex review and retro get native child agents, and under what policy. Docs only. #7809 and fullsend-ai/agents#1542 are closed; the implementation follows as small PRs after this is decided.
Related Issue
Part of #6970. It decides the approach but does not close the issue.
Related: ADR 0112 in #7808 rejects routed
subagentskeys on codex because it has no persona roster.Changes
docs/ADRs/0126-fullsend-owned-codex-subagents.md: new ADR.docs/architecture.md: one Decided line under the runtime section, marked not yet implemented.docs/ADRs/0104-per-persona-model-resolution.mdanddocs/ADRs/0100-codex-sandbox-hooks.md(Accepted): each adds a two-line cross-reference to 0126 under Status. Their Context, Decision and Consequences sections are unchanged.Questions for review:
model:andtools:are not applied, the child model chain is the one decided on codex runtime: run the review/retro sub-agent rosters through codex's native spawn_agent roles #6970, and unregistered roles are always rejected. If it's rejected, review and retro stay single-context on Codex, as they are today.hooks.jsonedit that leaves the adapter untouched. Option 4, write protection through Landlock, a read-only OpenShell path or image-baked roles, closes the residual and would be a separate ADR.Agenttool, which includescodeandfix, when harness security is enabled. The alternative is opt-in throughsubagents.collaborationspawn_agentwith no policy on it, which fix(codex): turn off codex's native multi-agent tools #7829 turns off); an entry without a version takes V1 from Codex'smulti_agentfeature, on by default. Onrust-v0.159.3(the sandbox pin since chore(deps): update dependency @openai/codex to v0.159.3 #7747) that leavesgpt-5.6-lunaandgpt-5.5as delegating parents; everygpt-6model and the othergpt-5.6tiers run in one context, the main outcome at the pin.Testing
make lintpassesChecklist
!for breaking changes)🤖 Generated with Claude Code