Repository navigation
refactor(workflow)!: remove enabled/disabled agent gate from workflow - #7864
rh-hemartin wants to merge 1 commit into
Conversation
PR Summary by QodoRemove redundant agent gating from reusable dispatch workflow
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
|
🤖 Finished Review · ✅ Success · Started 11:54 AM UTC · Completed 12:24 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $9.57 |
Code Review by Qodo
1.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ReviewFindingsMedium
Low
Earlier findings
8 finding(s) below the Previous run<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImFwaS1jb250cmFjdCIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmXzNmMmY3MjZmMjhiMDE3MWUiLCJsaW5lIjo3Mjk4LCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJpbmNvcnJlY3QtZG9jIiwiZmlsZSI6ImRvY3Mvbm9ybWF0aXZlL3ByZXNjcmlwdC1vdXRwdXQvdjEvUkVBRE1FLm1kIiwiaWQiOiJmXzUxMGUxMDc2MDNjOTIwY2EiLCJsaW5lIjoyMDEsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29ycmVjdC1kb2MiLCJmaWxlIjoiZG9jcy9ndWlkZXMvdXNlci9jdXN0b21pemluZy1hZ2VudHMubWQiLCJpZCI6ImZfODM4MzJjMGY3MDU4ZWJmMyIsImxpbmUiOjUxNywiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoibG9naWMtZXJyb3IiLCJmaWxlIjoiLmdpdGh1Yi93b3JrZmxvd3MvcmV1c2FibGUtZGlzcGF0Y2gueW1sIiwiaWQiOiJmXzBiNzQyYjk3MTNmNGI1ZDIiLCJsaW5lIjo5MzksImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJwYXR0ZXJuLWluY29uc2lzdGVuY3kiLCJmaWxlIjoiaW50ZXJuYWwvcHJlc2NyaXB0L3ByZXNjcmlwdC5nbyIsImlkIjoiZl9hMDViZDU0Y2FmODViZmM1IiwibGluZSI6MTE4LCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJtaXNwbGFjZWQtYWJzdHJhY3Rpb24iLCJmaWxlIjoiaW50ZXJuYWwvcHJlc2NyaXB0L3ByZXNjcmlwdC5nbyIsImlkIjoiZl8wZDRjMDE5MjczYzYwMWRmIiwibGluZSI6NzQsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJpbmNvbXBsZXRlLWRvYyIsImZpbGUiOiJkb2NzL25vcm1hdGl2ZS9wcmVzY3JpcHQtb3V0cHV0L3YxL1JFQURNRS5tZCIsImlkIjoiZl9mYzdkZDhjMjI1OGE5NDRjIiwibGluZSI6MTY4LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYmFja3dhcmQtaW5jb21wYXRpYmxlIiwiZmlsZSI6ImludGVybmFsL3ByZXNjcmlwdC9wcmVzY3JpcHQuZ28iLCJpZCI6ImZfNzIwMzQ0ZWU0ZGYyMzQ0MyIsImxpbmUiOjIwNCwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImJhY2t3YXJkLWluY29tcGF0aWJsZSIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmXzBiMGUwMzRkNjhlMzc5OTciLCJsaW5lIjo2NjksImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoicGVybWlzc2lvbi1leHBhbnNpb24iLCJmaWxlIjoiLmdpdGh1Yi93b3JrZmxvd3MvcmV1c2FibGUtZGlzcGF0Y2gueW1sIiwiaWQiOiJmX2JlMzYyNWQ1YWQ1NjBmNmYiLCJsaW5lIjoxMjYsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiZmFpbC1vcGVuIiwiZmlsZSI6Ii5naXRodWIvd29ya2Zsb3dzL3JldXNhYmxlLWRpc3BhdGNoLnltbCIsImlkIjoiZl85ZmY5ODc3MjU3MjQ4NWNmIiwibGluZSI6OTI3LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImRlc2lnbi1zbWVsbCIsImZpbGUiOiJhY3Rpb24ueW1sIiwiaWQiOiJmX2ExODMyZmQ5OWVmYzQzNTQiLCJsaW5lIjo1ODksImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5Ijoic2NvcGUtY3JlZXAiLCJmaWxlIjoicGtnL2JlaGF2aW91cnRlc3Qvc3RlcHMvc3RhdHVzY29tbWVudC5nbyIsImlkIjoiZl9hZDIxZjhiNDFiMjgzZWRiIiwibGluZSI6MTQsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYXBpLXNoYXBlIiwiZmlsZSI6ImludGVybmFsL3ByZXNjcmlwdC9wcmVzY3JpcHQuZ28iLCJpZCI6ImZfZjQ2ZmIyNDk3ODZjMzM1YSIsImxpbmUiOjc1LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJpbnRlcm5hbC9wcmVzY3JpcHQvcHJlc2NyaXB0LmdvIiwiaWQiOiJmX2ZkODhjOWVhNGJlZmEzNWQiLCJsaW5lIjo5MSwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJlcnJvci1oYW5kbGluZy1pZGlvbSIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmXzE2NjVkMDI4ZGU0NjYwOWQiLCJsaW5lIjo3Mjk4LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiYmFja3dhcmQtaW5jb21wYXRpYmxlIiwiZmlsZSI6ImludGVybmFsL3ByZXNjcmlwdC9wcmVzY3JpcHQuZ28iLCJpZCI6ImZfMzA1ZmEyODdkZTUxYTljZSIsImxpbmUiOjk0LCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoibWlzbGVhZGluZy1sYWJlbCIsImZpbGUiOiIuZ2l0aHViL3dvcmtmbG93cy9yZXVzYWJsZS1kaXNwYXRjaC55bWwiLCJpZCI6ImZfOGI3ZDY0ZjcyZWE3OWU1MSIsImxpbmUiOjEyMiwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImluY29tcGxldGUtZG9jIiwiZmlsZSI6ImRvY3MvZ3VpZGVzL2Rldi9iZWhhdmlvdXItdGVzdGluZy5tZCIsImlkIjoiZl81N2Y4NmMxZDdjNDUxNjM5IiwibGluZSI6NDQ0LCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJwa2cvYmVoYXZpb3VydGVzdC9zdGVwcy9kaXNwYXRjaC5nbyIsImlkIjoiZl84OTQ0NDNkOWM3Nzg1OTk1IiwibGluZSI6Mjc1LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoidGVzdC1pbmFkZXF1YXRlIiwiZmlsZSI6ImUyZS9iZWhhdmlvdXIvZmVhdHVyZXMvdHJpYWdlL3RyaWFnZS5mZWF0dXJlIiwiaWQiOiJmXzk0OGU3MzMxMDExODI1ZDciLCJsaW5lIjozMCwiYWN0aW9uYWJsZSI6dHJ1ZX1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl8zZjJmNzI2ZjI4YjAxNzFlIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzBiNzQyYjk3MTNmNGI1ZDIiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfYTA1YmQ1NGNhZjg1YmZjNSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl8wZDRjMDE5MjczYzYwMWRmIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzcyMDM0NGVlNGRmMjM0NDMiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMGIwZTAzNGQ2OGUzNzk5NyIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9mNDZmYjI0OTc4NmMzMzVhIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfYTE4MzJmZDk5ZWZjNDM1NCIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9LHsiaWQiOiJmX2FkMjFmOGI0MWIyODNlZGIiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifSx7ImlkIjoiZl9iZTM2MjVkNWFkNTYwZjZmIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfOWZmOTg3NzI1NzI0ODVjZiIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9LHsiaWQiOiJmX2ZkODhjOWVhNGJlZmEzNWQiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifSx7ImlkIjoiZl8xNjY1ZDAyOGRlNDY2MDlkIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfMzA1ZmEyODdkZTUxYTljZSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzhiN2Q2NGY3MmVhNzllNTEiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl81N2Y4NmMxZDdjNDUxNjM5Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfODk0NDQzZDljNzc4NTk5NSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzk0OGU3MzMxMDExODI1ZDciLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 --> ReviewFindingsMedium
Low
Earlier findings
Next steps:
7 finding(s) below the Previous run (2)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImFwaS1jb250cmFjdCIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmXzNmMmY3MjZmMjhiMDE3MWUiLCJsaW5lIjo3MzAzLCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiIuZ2l0aHViL3dvcmtmbG93cy9yZXVzYWJsZS1kaXNwYXRjaC55bWwiLCJpZCI6ImZfMGI3NDJiOTcxM2Y0YjVkMiIsImxpbmUiOjkzOSwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6InBhdHRlcm4taW5jb25zaXN0ZW5jeSIsImZpbGUiOiJpbnRlcm5hbC9wcmVzY3JpcHQvcHJlc2NyaXB0LmdvIiwiaWQiOiJmX2EwNWJkNTRjYWY4NWJmYzUiLCJsaW5lIjoxMTgsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6Im1pc3BsYWNlZC1hYnN0cmFjdGlvbiIsImZpbGUiOiJpbnRlcm5hbC9wcmVzY3JpcHQvcHJlc2NyaXB0LmdvIiwiaWQiOiJmXzBkNGMwMTkyNzNjNjAxZGYiLCJsaW5lIjo3NCwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImJhY2t3YXJkLWluY29tcGF0aWJsZSIsImZpbGUiOiJpbnRlcm5hbC9wcmVzY3JpcHQvcHJlc2NyaXB0LmdvIiwiaWQiOiJmXzcyMDM0NGVlNGRmMjM0NDMiLCJsaW5lIjoyMDQsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJiYWNrd2FyZC1pbmNvbXBhdGlibGUiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl8wYjBlMDM0ZDY4ZTM3OTk3IiwibGluZSI6NjY5LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImFwaS1zaGFwZSIsImZpbGUiOiJpbnRlcm5hbC9wcmVzY3JpcHQvcHJlc2NyaXB0LmdvIiwiaWQiOiJmX2Y0NmZiMjQ5Nzg2YzMzNWEiLCJsaW5lIjo3NSwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJkZXNpZ24tc21lbGwiLCJmaWxlIjoiYWN0aW9uLnltbCIsImlkIjoiZl9hMTgzMmZkOTllZmM0MzU0IiwibGluZSI6NTg5LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6InNjb3BlLWNyZWVwIiwiZmlsZSI6InBrZy9iZWhhdmlvdXJ0ZXN0L3N0ZXBzL3N0YXR1c2NvbW1lbnQuZ28iLCJpZCI6ImZfYWQyMWY4YjQxYjI4M2VkYiIsImxpbmUiOjE0LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6InBlcm1pc3Npb24tZXhwYW5zaW9uIiwiZmlsZSI6Ii5naXRodWIvd29ya2Zsb3dzL3JldXNhYmxlLWRpc3BhdGNoLnltbCIsImlkIjoiZl9iZTM2MjVkNWFkNTYwZjZmIiwibGluZSI6MTI2LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImZhaWwtb3BlbiIsImZpbGUiOiIuZ2l0aHViL3dvcmtmbG93cy9yZXVzYWJsZS1kaXNwYXRjaC55bWwiLCJpZCI6ImZfOWZmOTg3NzI1NzI0ODVjZiIsImxpbmUiOjkyNywiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiaW50ZXJuYWwvcHJlc2NyaXB0L3ByZXNjcmlwdC5nbyIsImlkIjoiZl9mZDg4YzllYTRiZWZhMzVkIiwibGluZSI6OTEsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiZXJyb3ItaGFuZGxpbmctaWRpb20iLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl8xNjY1ZDAyOGRlNDY2MDlkIiwibGluZSI6NzI5OCwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImJhY2t3YXJkLWluY29tcGF0aWJsZSIsImZpbGUiOiJpbnRlcm5hbC9wcmVzY3JpcHQvcHJlc2NyaXB0LmdvIiwiaWQiOiJmXzMwNWZhMjg3ZGU1MWE5Y2UiLCJsaW5lIjo5NCwiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6Im1pc2xlYWRpbmctbGFiZWwiLCJmaWxlIjoiLmdpdGh1Yi93b3JrZmxvd3MvcmV1c2FibGUtZGlzcGF0Y2gueW1sIiwiaWQiOiJmXzhiN2Q2NGY3MmVhNzllNTEiLCJsaW5lIjoxMjIsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJpbmNvbXBsZXRlLWRvYyIsImZpbGUiOiJkb2NzL2d1aWRlcy9kZXYvYmVoYXZpb3VyLXRlc3RpbmcubWQiLCJpZCI6ImZfNTdmODZjMWQ3YzQ1MTYzOSIsImxpbmUiOjQ0NCwiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoibG9naWMtZXJyb3IiLCJmaWxlIjoicGtnL2JlaGF2aW91cnRlc3Qvc3RlcHMvZGlzcGF0Y2guZ28iLCJpZCI6ImZfODk0NDQzZDljNzc4NTk5NSIsImxpbmUiOjI3NSwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6InRlc3QtaW5hZGVxdWF0ZSIsImZpbGUiOiJlMmUvYmVoYXZpb3VyL2ZlYXR1cmVzL3RyaWFnZS90cmlhZ2UuZmVhdHVyZSIsImlkIjoiZl85NDhlNzMzMTAxMTgyNWQ3IiwibGluZSI6MzAsImFjdGlvbmFibGUiOnRydWV9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfOTQ4ZTczMzEwMTE4MjVkNyIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzBiNzQyYjk3MTNmNGI1ZDIiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMGQ0YzAxOTI3M2M2MDFkZiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9hMTgzMmZkOTllZmM0MzU0Iiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfYWQyMWY4YjQxYjI4M2VkYiIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9LHsiaWQiOiJmX2Y0NmZiMjQ5Nzg2YzMzNWEiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifSx7ImlkIjoiZl83MjAzNDRlZTRkZjIzNDQzIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzBiMGUwMzRkNjhlMzc5OTciLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfYmUzNjI1ZDVhZDU2MGY2ZiIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9LHsiaWQiOiJmXzlmZjk4NzcyNTcyNDg1Y2YiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifSx7ImlkIjoiZl9mZDg4YzllYTRiZWZhMzVkIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfMTY2NWQwMjhkZTQ2NjA5ZCIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9LHsiaWQiOiJmXzMwNWZhMjg3ZGU1MWE5Y2UiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl84YjdkNjRmNzJlYTc5ZTUxIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfNTdmODZjMWQ3YzQ1MTYzOSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzg5NDQ0M2Q5Yzc3ODU5OTUiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 --> ReviewFindingsMedium
Low
Earlier findings
Next steps:
7 finding(s) below the Previous run (3)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6InRlc3QtaW5hZGVxdWF0ZSIsImZpbGUiOiJlMmUvYmVoYXZpb3VyL2ZlYXR1cmVzL3RyaWFnZS90cmlhZ2UuZmVhdHVyZSIsImlkIjoiZl85NDhlNzMzMTAxMTgyNWQ3IiwibGluZSI6MzAsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6Ii5naXRodWIvd29ya2Zsb3dzL3JldXNhYmxlLWRpc3BhdGNoLnltbCIsImlkIjoiZl8wYjc0MmI5NzEzZjRiNWQyIiwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6Im1pc3BsYWNlZC1hYnN0cmFjdGlvbiIsImZpbGUiOiJpbnRlcm5hbC9wcmVzY3JpcHQvcHJlc2NyaXB0LmdvIiwiaWQiOiJmXzBkNGMwMTkyNzNjNjAxZGYiLCJsaW5lIjo3NCwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRlc2lnbi1zbWVsbCIsImZpbGUiOiJhY3Rpb24ueW1sIiwiaWQiOiJmX2ExODMyZmQ5OWVmYzQzNTQiLCJsaW5lIjo1ODEsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJzY29wZS1jcmVlcCIsImZpbGUiOiJwa2cvYmVoYXZpb3VydGVzdC9zdGVwcy9zdGF0dXNjb21tZW50LmdvIiwiaWQiOiJmX2FkMjFmOGI0MWIyODNlZGIiLCJsaW5lIjoxNiwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImFwaS1zaGFwZSIsImZpbGUiOiJpbnRlcm5hbC9wcmVzY3JpcHQvcHJlc2NyaXB0LmdvIiwiaWQiOiJmX2Y0NmZiMjQ5Nzg2YzMzNWEiLCJsaW5lIjo3NSwiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYmFja3dhcmQtaW5jb21wYXRpYmxlIiwiZmlsZSI6ImludGVybmFsL3ByZXNjcmlwdC9wcmVzY3JpcHQuZ28iLCJpZCI6ImZfNzIwMzQ0ZWU0ZGYyMzQ0MyIsImxpbmUiOjIwNCwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImJhY2t3YXJkLWluY29tcGF0aWJsZSIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmXzBiMGUwMzRkNjhlMzc5OTciLCJsaW5lIjo2NDEsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoicGVybWlzc2lvbi1leHBhbnNpb24iLCJmaWxlIjoiLmdpdGh1Yi93b3JrZmxvd3MvcmV1c2FibGUtZGlzcGF0Y2gueW1sIiwiaWQiOiJmX2JlMzYyNWQ1YWQ1NjBmNmYiLCJsaW5lIjoxMjIsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiZmFpbC1vcGVuIiwiZmlsZSI6Ii5naXRodWIvd29ya2Zsb3dzL3JldXNhYmxlLWRpc3BhdGNoLnltbCIsImlkIjoiZl85ZmY5ODc3MjU3MjQ4NWNmIiwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiaW50ZXJuYWwvcHJlc2NyaXB0L3ByZXNjcmlwdC5nbyIsImlkIjoiZl9mZDg4YzllYTRiZWZhMzVkIiwibGluZSI6OTEsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiZXJyb3ItaGFuZGxpbmctaWRpb20iLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl8xNjY1ZDAyOGRlNDY2MDlkIiwibGluZSI6NzAzNSwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImJhY2t3YXJkLWluY29tcGF0aWJsZSIsImZpbGUiOiJpbnRlcm5hbC9wcmVzY3JpcHQvcHJlc2NyaXB0LmdvIiwiaWQiOiJmXzMwNWZhMjg3ZGU1MWE5Y2UiLCJsaW5lIjo5NCwiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6Im1pc2xlYWRpbmctbGFiZWwiLCJmaWxlIjoiLmdpdGh1Yi93b3JrZmxvd3MvcmV1c2FibGUtZGlzcGF0Y2gueW1sIiwiaWQiOiJmXzhiN2Q2NGY3MmVhNzllNTEiLCJsaW5lIjoxMjIsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJpbmNvbXBsZXRlLWRvYyIsImZpbGUiOiJkb2NzL2d1aWRlcy9kZXYvYmVoYXZpb3VyLXRlc3RpbmcubWQiLCJpZCI6ImZfNTdmODZjMWQ3YzQ1MTYzOSIsImxpbmUiOjQ0NCwiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoibG9naWMtZXJyb3IiLCJmaWxlIjoicGtnL2JlaGF2aW91cnRlc3Qvc3RlcHMvZGlzcGF0Y2guZ28iLCJpZCI6ImZfODk0NDQzZDljNzc4NTk5NSIsImxpbmUiOjI3NSwiYWN0aW9uYWJsZSI6ZmFsc2V9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfOTQ4ZTczMzEwMTE4MjVkNyIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl81N2Y4NmMxZDdjNDUxNjM5Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMGI3NDJiOTcxM2Y0YjVkMiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl84OTQ0NDNkOWM3Nzg1OTk1Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMGQ0YzAxOTI3M2M2MDFkZiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9hMTgzMmZkOTllZmM0MzU0Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2FkMjFmOGI0MWIyODNlZGIiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfZjQ2ZmIyNDk3ODZjMzM1YSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl83MjAzNDRlZTRkZjIzNDQzIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzBiMGUwMzRkNjhlMzc5OTciLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfZmQ4OGM5ZWE0YmVmYTM1ZCIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9LHsiaWQiOiJmXzE2NjVkMDI4ZGU0NjYwOWQiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifSx7ImlkIjoiZl9iZTM2MjVkNWFkNTYwZjZmIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfOWZmOTg3NzI1NzI0ODVjZiIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9LHsiaWQiOiJmXzMwNWZhMjg3ZGU1MWE5Y2UiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl84YjdkNjRmNzJlYTc5ZTUxIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn1dfQ== --> ReviewFindingsMedium
Low
Earlier findings
Next steps:
Previous run (4)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6InRlc3QtaW5hZGVxdWF0ZSIsImZpbGUiOiJlMmUvYmVoYXZpb3VyL2ZlYXR1cmVzL3RyaWFnZS90cmlhZ2UuZmVhdHVyZSIsImlkIjoiZl85NDhlNzMzMTAxMTgyNWQ3IiwibGluZSI6MzAsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImluY29tcGxldGUtZG9jIiwiZmlsZSI6ImRvY3MvZ3VpZGVzL2Rldi9iZWhhdmlvdXItdGVzdGluZy5tZCIsImlkIjoiZl81N2Y4NmMxZDdjNDUxNjM5IiwibGluZSI6NDQ0LCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiIuZ2l0aHViL3dvcmtmbG93cy9yZXVzYWJsZS1kaXNwYXRjaC55bWwiLCJpZCI6ImZfMGI3NDJiOTcxM2Y0YjVkMiIsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJwa2cvYmVoYXZpb3VydGVzdC9zdGVwcy9kaXNwYXRjaC5nbyIsImlkIjoiZl84OTQ0NDNkOWM3Nzg1OTk1IiwibGluZSI6Mjc1LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoibWlzcGxhY2VkLWFic3RyYWN0aW9uIiwiZmlsZSI6ImludGVybmFsL3ByZXNjcmlwdC9wcmVzY3JpcHQuZ28iLCJpZCI6ImZfMGQ0YzAxOTI3M2M2MDFkZiIsImxpbmUiOjc0LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZGVzaWduLXNtZWxsIiwiZmlsZSI6ImFjdGlvbi55bWwiLCJpZCI6ImZfYTE4MzJmZDk5ZWZjNDM1NCIsImxpbmUiOjU4MSwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6InNjb3BlLWNyZWVwIiwiZmlsZSI6InBrZy9iZWhhdmlvdXJ0ZXN0L3N0ZXBzL3N0YXR1c2NvbW1lbnQuZ28iLCJpZCI6ImZfYWQyMWY4YjQxYjI4M2VkYiIsImxpbmUiOjE2LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYXBpLXNoYXBlIiwiZmlsZSI6ImludGVybmFsL3ByZXNjcmlwdC9wcmVzY3JpcHQuZ28iLCJpZCI6ImZfZjQ2ZmIyNDk3ODZjMzM1YSIsImxpbmUiOjc1LCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJiYWNrd2FyZC1pbmNvbXBhdGlibGUiLCJmaWxlIjoiaW50ZXJuYWwvcHJlc2NyaXB0L3ByZXNjcmlwdC5nbyIsImlkIjoiZl83MjAzNDRlZTRkZjIzNDQzIiwibGluZSI6OTUsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJiYWNrd2FyZC1pbmNvbXBhdGlibGUiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl8wYjBlMDM0ZDY4ZTM3OTk3IiwibGluZSI6NjQxLCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJpbnRlcm5hbC9wcmVzY3JpcHQvcHJlc2NyaXB0LmdvIiwiaWQiOiJmX2ZkODhjOWVhNGJlZmEzNWQiLCJsaW5lIjo5MSwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJlcnJvci1oYW5kbGluZy1pZGlvbSIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmXzE2NjVkMDI4ZGU0NjYwOWQiLCJsaW5lIjo3MDM1LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6InBlcm1pc3Npb24tZXhwYW5zaW9uIiwiZmlsZSI6Ii5naXRodWIvd29ya2Zsb3dzL3JldXNhYmxlLWRpc3BhdGNoLnltbCIsImlkIjoiZl9iZTM2MjVkNWFkNTYwZjZmIiwibGluZSI6MTIyLCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImZhaWwtb3BlbiIsImZpbGUiOiIuZ2l0aHViL3dvcmtmbG93cy9yZXVzYWJsZS1kaXNwYXRjaC55bWwiLCJpZCI6ImZfOWZmOTg3NzI1NzI0ODVjZiIsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJiYWNrd2FyZC1pbmNvbXBhdGlibGUiLCJmaWxlIjoiaW50ZXJuYWwvcHJlc2NyaXB0L3ByZXNjcmlwdC5nbyIsImlkIjoiZl8zMDVmYTI4N2RlNTFhOWNlIiwibGluZSI6OTQsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJtaXNsZWFkaW5nLWxhYmVsIiwiZmlsZSI6Ii5naXRodWIvd29ya2Zsb3dzL3JldXNhYmxlLWRpc3BhdGNoLnltbCIsImlkIjoiZl84YjdkNjRmNzJlYTc5ZTUxIiwibGluZSI6MTIyLCJhY3Rpb25hYmxlIjpmYWxzZX1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl85NDhlNzMzMTAxMTgyNWQ3Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzU3Zjg2YzFkN2M0NTE2MzkiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMGI3NDJiOTcxM2Y0YjVkMiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl84OTQ0NDNkOWM3Nzg1OTk1Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzBkNGMwMTkyNzNjNjAxZGYiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfYTE4MzJmZDk5ZWZjNDM1NCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9mNDZmYjI0OTc4NmMzMzVhIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2ZkODhjOWVhNGJlZmEzNWQiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifSx7ImlkIjoiZl9hZDIxZjhiNDFiMjgzZWRiIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzE2NjVkMDI4ZGU0NjYwOWQiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifSx7ImlkIjoiZl8wYjBlMDM0ZDY4ZTM3OTk3Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzcyMDM0NGVlNGRmMjM0NDMiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfYmUzNjI1ZDVhZDU2MGY2ZiIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9LHsiaWQiOiJmXzlmZjk4NzcyNTcyNDg1Y2YiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifSx7ImlkIjoiZl8zMDVmYTI4N2RlNTFhOWNlIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfOGI3ZDY0ZjcyZWE3OWU1MSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= --> ReviewFindingsMedium
Low
Earlier findings
Next steps:
Previous run (5)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6InRlc3QtaW5hZGVxdWF0ZSIsImZpbGUiOiJlMmUvYmVoYXZpb3VyL2ZlYXR1cmVzL3RyaWFnZS90cmlhZ2UuZmVhdHVyZSIsImlkIjoiZl85NDhlNzMzMTAxMTgyNWQ3IiwibGluZSI6MzAsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImluY29tcGxldGUtZG9jIiwiZmlsZSI6ImRvY3MvZ3VpZGVzL2Rldi9iZWhhdmlvdXItdGVzdGluZy5tZCIsImlkIjoiZl81N2Y4NmMxZDdjNDUxNjM5IiwibGluZSI6NDQyLCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiIuZ2l0aHViL3dvcmtmbG93cy9yZXVzYWJsZS1kaXNwYXRjaC55bWwiLCJpZCI6ImZfMGI3NDJiOTcxM2Y0YjVkMiIsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJwa2cvYmVoYXZpb3VydGVzdC9zdGVwcy9kaXNwYXRjaC5nbyIsImlkIjoiZl84OTQ0NDNkOWM3Nzg1OTk1IiwibGluZSI6Mjc1LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoibWlzcGxhY2VkLWFic3RyYWN0aW9uIiwiZmlsZSI6ImludGVybmFsL3ByZXNjcmlwdC9wcmVzY3JpcHQuZ28iLCJpZCI6ImZfMGQ0YzAxOTI3M2M2MDFkZiIsImxpbmUiOjc1LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZGVzaWduLXNtZWxsIiwiZmlsZSI6ImFjdGlvbi55bWwiLCJpZCI6ImZfYTE4MzJmZDk5ZWZjNDM1NCIsImxpbmUiOjU4MSwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImFwaS1zaGFwZSIsImZpbGUiOiJpbnRlcm5hbC9wcmVzY3JpcHQvcHJlc2NyaXB0LmdvIiwiaWQiOiJmX2Y0NmZiMjQ5Nzg2YzMzNWEiLCJsaW5lIjo3NSwiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImludGVybmFsL3ByZXNjcmlwdC9wcmVzY3JpcHQuZ28iLCJpZCI6ImZfZmQ4OGM5ZWE0YmVmYTM1ZCIsImxpbmUiOjkxLCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJzY29wZS1jcmVlcCIsImZpbGUiOiJwa2cvYmVoYXZpb3VydGVzdC9zdGVwcy9zdGF0dXNjb21tZW50LmdvIiwiaWQiOiJmX2FkMjFmOGI0MWIyODNlZGIiLCJsaW5lIjoxNiwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImVycm9yLWhhbmRsaW5nLWlkaW9tIiwiZmlsZSI6ImludGVybmFsL2NsaS9ydW4uZ28iLCJpZCI6ImZfMTY2NWQwMjhkZTQ2NjA5ZCIsImxpbmUiOjcwMzUsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJiYWNrd2FyZC1pbmNvbXBhdGlibGUiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl8wYjBlMDM0ZDY4ZTM3OTk3IiwibGluZSI6NjQxLCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYmFja3dhcmQtaW5jb21wYXRpYmxlIiwiZmlsZSI6ImludGVybmFsL3ByZXNjcmlwdC9wcmVzY3JpcHQuZ28iLCJpZCI6ImZfNzIwMzQ0ZWU0ZGYyMzQ0MyIsImxpbmUiOjk1LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6InBlcm1pc3Npb24tZXhwYW5zaW9uIiwiZmlsZSI6Ii5naXRodWIvd29ya2Zsb3dzL3JldXNhYmxlLWRpc3BhdGNoLnltbCIsImlkIjoiZl9iZTM2MjVkNWFkNTYwZjZmIiwibGluZSI6MTIyLCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImZhaWwtb3BlbiIsImZpbGUiOiIuZ2l0aHViL3dvcmtmbG93cy9yZXVzYWJsZS1kaXNwYXRjaC55bWwiLCJpZCI6ImZfOWZmOTg3NzI1NzI0ODVjZiIsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJiYWNrd2FyZC1pbmNvbXBhdGlibGUiLCJmaWxlIjoiaW50ZXJuYWwvcHJlc2NyaXB0L3ByZXNjcmlwdC5nbyIsImlkIjoiZl8zMDVmYTI4N2RlNTFhOWNlIiwibGluZSI6OTQsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJtaXNsZWFkaW5nLWxhYmVsIiwiZmlsZSI6Ii5naXRodWIvd29ya2Zsb3dzL3JldXNhYmxlLWRpc3BhdGNoLnltbCIsImlkIjoiZl84YjdkNjRmNzJlYTc5ZTUxIiwibGluZSI6MTIyLCJhY3Rpb25hYmxlIjpmYWxzZX1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl85NDhlNzMzMTAxMTgyNWQ3Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzU3Zjg2YzFkN2M0NTE2MzkiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifSx7ImlkIjoiZl83MjAzNDRlZTRkZjIzNDQzIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzBiMGUwMzRkNjhlMzc5OTciLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMGQ0YzAxOTI3M2M2MDFkZiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9hMTgzMmZkOTllZmM0MzU0Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2Y0NmZiMjQ5Nzg2YzMzNWEiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfZmQ4OGM5ZWE0YmVmYTM1ZCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl85ZmY5ODc3MjU3MjQ4NWNmIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfYmUzNjI1ZDVhZDU2MGY2ZiIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9LHsiaWQiOiJmXzhiN2Q2NGY3MmVhNzllNTEiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8zMDVmYTI4N2RlNTFhOWNlIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn1dfQ== --> ReviewFindingsMedium
Low
Earlier findings
Next steps:
Previous run (6)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6InRlc3QtaW5hZGVxdWF0ZSIsImZpbGUiOiJlMmUvYmVoYXZpb3VyL2ZlYXR1cmVzL3RyaWFnZS90cmlhZ2UuZmVhdHVyZSIsImlkIjoiZl85NDhlNzMzMTAxMTgyNWQ3IiwibGluZSI6MzAsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29tcGxldGUtZG9jIiwiZmlsZSI6ImRvY3MvZ3VpZGVzL2Rldi9iZWhhdmlvdXItdGVzdGluZy5tZCIsImlkIjoiZl81N2Y4NmMxZDdjNDUxNjM5IiwibGluZSI6NDQyLCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJiYWNrd2FyZC1pbmNvbXBhdGlibGUiLCJmaWxlIjoiaW50ZXJuYWwvcHJlc2NyaXB0L3ByZXNjcmlwdC5nbyIsImlkIjoiZl83MjAzNDRlZTRkZjIzNDQzIiwibGluZSI6MTg5LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYmFja3dhcmQtaW5jb21wYXRpYmxlIiwiZmlsZSI6ImludGVybmFsL2NsaS9ydW4uZ28iLCJpZCI6ImZfMGIwZTAzNGQ2OGUzNzk5NyIsImxpbmUiOjY0MSwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6Im1pc3BsYWNlZC1hYnN0cmFjdGlvbiIsImZpbGUiOiJpbnRlcm5hbC9wcmVzY3JpcHQvcHJlc2NyaXB0LmdvIiwiaWQiOiJmXzBkNGMwMTkyNzNjNjAxZGYiLCJsaW5lIjo3NSwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRlc2lnbi1zbWVsbCIsImZpbGUiOiJhY3Rpb24ueW1sIiwiaWQiOiJmX2ExODMyZmQ5OWVmYzQzNTQiLCJsaW5lIjo1ODEsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJhcGktc2hhcGUiLCJmaWxlIjoiaW50ZXJuYWwvcHJlc2NyaXB0L3ByZXNjcmlwdC5nbyIsImlkIjoiZl9mNDZmYjI0OTc4NmMzMzVhIiwibGluZSI6NzUsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJpbnRlcm5hbC9wcmVzY3JpcHQvcHJlc2NyaXB0LmdvIiwiaWQiOiJmX2ZkODhjOWVhNGJlZmEzNWQiLCJsaW5lIjo5MSwiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZmFpbC1vcGVuIiwiZmlsZSI6Ii5naXRodWIvd29ya2Zsb3dzL3JldXNhYmxlLWRpc3BhdGNoLnltbCIsImlkIjoiZl85ZmY5ODc3MjU3MjQ4NWNmIiwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6InBlcm1pc3Npb24tZXhwYW5zaW9uIiwiZmlsZSI6Ii5naXRodWIvd29ya2Zsb3dzL3JldXNhYmxlLWRpc3BhdGNoLnltbCIsImlkIjoiZl9iZTM2MjVkNWFkNTYwZjZmIiwibGluZSI6MTIyLCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6Im1pc2xlYWRpbmctbGFiZWwiLCJmaWxlIjoiLmdpdGh1Yi93b3JrZmxvd3MvcmV1c2FibGUtZGlzcGF0Y2gueW1sIiwiaWQiOiJmXzhiN2Q2NGY3MmVhNzllNTEiLCJsaW5lIjoxMjIsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJiYWNrd2FyZC1pbmNvbXBhdGlibGUiLCJmaWxlIjoiaW50ZXJuYWwvcHJlc2NyaXB0L3ByZXNjcmlwdC5nbyIsImlkIjoiZl8zMDVmYTI4N2RlNTFhOWNlIiwibGluZSI6OTQsImFjdGlvbmFibGUiOnRydWV9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfOTQ4ZTczMzEwMTE4MjVkNyIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl81N2Y4NmMxZDdjNDUxNjM5Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzMwNWZhMjg3ZGU1MWE5Y2UiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl85ZmY5ODc3MjU3MjQ4NWNmIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2JlMzYyNWQ1YWQ1NjBmNmYiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMGQ0YzAxOTI3M2M2MDFkZiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl84YjdkNjRmNzJlYTc5ZTUxIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfYTE4MzJmZDk5ZWZjNDM1NCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9mZDg4YzllYTRiZWZhMzVkIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2Y0NmZiMjQ5Nzg2YzMzNWEiLCJzdGF0dXMiOiJvcGVuIn1dfQ== --> ReviewFindingsMedium
Low
Earlier findings
Next steps:
|
jflowers
left a comment
There was a problem hiding this comment.
Council Verdict: REQUEST CHANGES
Reviewers: adversary, architect, fullsend, guard, testing, sre, curator, envoy, herald, scribe · Iterations: 1
1. [HIGH] fix(workflow) type + "not a breaking change" claim rest on an unstated intent, and are unactionable as written. (envoy, herald, sre, guard) — the body asserts "not a breaking change" because disabled agents remain blocked, but the CLI blocks by failing the job (red CI) after the workflow gate previously skipped it (green, zero-cost). Resolve by intent: (a) if skip→fail is unintended, restore skip semantics (the line-113 regression, already covered by bot review); (b) if fail-on-disabled is the intended policy, the change is breaking for consumers pinning reusable-dispatch.yml@<ref> and must carry ! + BREAKING CHANGE: trailer — or be retyped ci(workflow) (it is a CI change, not a user-visible fix). Either way the current "behavior retained, therefore not breaking" framing conflates skip with fail.
2. [MEDIUM] Dispatch-sync contract violated. (architect, testing, sre, fullsend, curator, scribe, herald) — docs/contributing/workflow-contracts.md:3 asserts scaffold dispatch.yml and reusable-dispatch.yml share identical routing logic, but internal/scaffold/fullsend-repo/.github/workflows/dispatch.yml:435,494-521,557 still retains the removed gate/validation. Mirror the removal, or record the intentional divergence (per-org deprecated per ADR 44).
3. [MEDIUM] Stale user doc — docs/guides/user/customizing-agents.md:533 still states enabled: false "prevents the agent from dispatching." (curator, scribe, architect, sre)
4. [MEDIUM] Stale test rationale — internal/config/repo_overlay_test.go:30-43 comment + assertion message name the removed agent-check mechanism. (testing, architect, sre, fullsend, herald)
5. [LOW] ADR 0091 references the removed reusable-workflow guard. (curator, sre)
This review was generated by /uf.review-council (AI-assisted).
68a4973 to
9867bb8
Compare
|
@jflowers let me know what you think of the new approach. |
|
🤖 Finished Review · ❌ Failure (resolving persona models: persona "correctness": a Bash(...) allowlist in persona frontmatter is not supported yet and would not restrict the child; declare plain Commit: Runtime: pi · Model: sonnet · Effort: high |
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 11:52 AM UTC · Completed 12:33 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $2.97 |
|
<!-- fullsend:risk-assessment --> DetailsScore remains 3 (elevated) anchored to prior review: breaking CI dispatch workflow modifications across 26 files and high git churn are balanced by strong test coverage from an established contributor. Previous run<!-- fullsend:risk-assessment --> DetailsScore remains 3 (elevated) anchored to prior review: breaking CI dispatch workflow modifications across 24 files and high git churn are balanced by strong test coverage from an established contributor. Previous run (2)<!-- fullsend:risk-assessment --> DetailsScore remains 3 (elevated) anchored to the prior review: breaking CI dispatch workflow modifications across 23 files and high git churn are balanced by strong test coverage from an established contributor. Previous run (3)<!-- fullsend:risk-assessment --> DetailsScore remains 3 (elevated) anchored to the prior review: the Tier 1 signal bins are unchanged across 22 files and 849 lines, with breaking CI dispatch workflow modifications and high-churn hotspot files balanced by strong test coverage from an experienced contributor. Previous run (4)<!-- fullsend:risk-assessment --> DetailsScore remains 3 (elevated) as the PR maintains its risk profile across 24 files and 1,022 lines with CI workflow modifications, breaking dispatch changes, and high-churn hotspot files, balanced by solid test coverage and an experienced contributor. Previous run (5)<!-- fullsend:risk-assessment --> DetailsScore remains 3 (elevated) as the rebased PR keeps the same risk profile across 24 files and about 1,026 lines with CI workflow modifications and breaking dispatch changes across high-churn files, balanced by strong test coverage and familiar authorship. Previous run (6)<!-- fullsend:risk-assessment --> DetailsScore remains 3 (elevated) as the diff expanded to 23 files and 996 lines with CI workflow modifications and breaking dispatch changes across high-churn files, balanced by strong test coverage and familiar authorship. Previous run (7)<!-- fullsend:risk-assessment --> DetailsElevated risk reflects CI workflow and protected path modifications with breaking dispatch behavior changes and high churn on touched files, with the score increasing from prior moderate (2) because the diff expanded from 8 to 16 files (542 lines, large blast radius). Previous run (8)<!-- fullsend:risk-assessment --> DetailsModerate risk reflects CI workflow modifications, a protected path change, and high churn on dispatch and runner files, balanced by modest diff size, an established contributor, strong test coverage, and close alignment with the linked issue scope. Previous run (9)<!-- fullsend:risk-assessment --> DetailsModerate risk reflects CI workflow modifications, a protected path change, and high churn on dispatch and runner files, balanced by modest diff size, an established contributor, strong test coverage, and close alignment with the linked issue scope. Previous run (10)<!-- fullsend:risk-assessment --> DetailsModerate risk preserved at 2 as CI workflow modification, lack of rollback flag, and high churn on dispatch and CLI files are balanced by modest change size (7 files, 186 lines), established contributor, and close alignment with linked issue scope. Previous run (11)Risk Assessment: moderate (2/5) DetailsModerate risk preserved at 2 as CI workflow modification, lack of rollback flag, and high churn on dispatch and CLI files are balanced by modest change size (8 files, 190 lines), established contributor, and close alignment with linked issue scope. Previous run (12)Risk Assessment: moderate (2/5) DetailsModerate risk preserved at 2 as CI workflow modification, lack of rollback flag, and high churn on dispatch and CLI files are balanced by modest change size (8 files, 191 lines), established contributor, and close alignment with linked issue scope. Previous run (13)Risk Assessment: moderate (2/5) DetailsModerate risk preserved at 2 as CI workflow modification, lack of rollback flag, and high churn on dispatch and CLI files are balanced by modest change size (8 files, 281 lines), established contributor, and close alignment with linked issue scope. Previous run (14)Risk Assessment: moderate (2/5) DetailsModerate risk preserved at 2 as CI workflow changes, lack of rollback flag, and high churn on dispatch and CLI files are balanced by small file count (8 files), established contributor, and close alignment with linked issue scope. Previous run (15)Risk Assessment: moderate (2/5) DetailsModerate risk preserved at 2 as CI workflow changes, lack of rollback flag, and high churn on dispatch and CLI files are balanced by small file count (7 files), established contributor, and close alignment with linked issue scope following addition of CLI skip handling. Previous run (16)Risk Assessment: moderate (2/5) DetailsModerate risk due to CI workflow modifications and active multi-author contention on dispatch files, balanced by small file count, an established contributor, and close alignment with linked issue scope. Previous run (17)Risk Assessment: moderate (2/5) DetailsModerate risk due to CI workflow modifications and active multi-author contention on dispatch files, balanced by small file count, an established contributor, and close alignment with linked issue scope. Previous run (18)Risk Assessment: elevated (3/5) DetailsElevated risk due to modification of core CI dispatch workflow without rollback toggles, introducing a breaking change with unaddressed trade-off discussion in the linked issue, combined with high churn and author contention across touched files. |
|
@rh-hemartin thanks for the ping. The new approach reads clean1 The
Nothing new or blocking here, just confirming the remaining doc/scope gaps are closed or consciously deferred. |
Yes, this is accepted for now. Also soon
Changed
Added.
Well, there shouldn't be barely any sync at all, per-org mode will go away soon.
Fixed. |
9867bb8 to
7f5327c
Compare
|
🤖 Review · Commit: |
7f5327c to
4f9cc9a
Compare
waynesun09
left a comment
There was a problem hiding this comment.
Review sweep: one finding, inline below.
8e5e937 to
c8381ee
Compare
|
🤖 Finished Review · ✅ Success · Started 6:07 AM UTC · Completed 6:24 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $4.47 |
|
🤖 Finished Review · ✅ Success · Started 7:01 AM UTC · Completed 7:15 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.46 |
|
🤖 Finished Review · ✅ Success · Started 8:01 AM UTC · Completed 8:23 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $4.78 |
|
🤖 Finished Review · ✅ Success · Started 8:55 AM UTC · Completed 9:14 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $4.17 |
waynesun09
left a comment
There was a problem hiding this comment.
Review findings at ab04859 (inline below).
|
🤖 Finished Review · ✅ Success · Started 8:59 AM UTC · Completed 9:22 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $4.07 |
|
🤖 Finished Review · ✅ Success · Started 10:46 AM UTC · Completed 11:04 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $4.27 |
|
🤖 Finished Review · ✅ Success · Started 11:44 AM UTC · Completed 11:58 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.62 |
The dispatch workflow no longer checks whether an agent is enabled before running its setup steps. Instead, `fullsend run` performs the skip: for an agent with `enabled: false` it exits 0 and relays `skipped=true`, `disabled=true`, and the skip reason as step outputs. - Return the typed agentDisabledError from resolveHarnessForLock so the disabled-agent error contract matches run.go - Keep the disabled-agent skip signal in the CLI (disabledSkipResult) rather than the pre-script protocol package - Keep a fix-only enabled check in the Route job so a disabled fix agent does not hard-fail fork-PR and PR-fetch checks, and gate Resolve PR head on it - Document the fix-agent exception, the roles workaround limits, the reserved `disabled` key in the error semantics table, its migration note, and the skipped=true consumer state for disabled agents - Add behaviour-test steps for disabled agents and status-comment assertions BREAKING CHANGE: `fullsend run` for a disabled agent now exits 0 and relays skip outputs instead of the workflow blocking the run earlier; `disabled` is now a reserved pre-script output key. Assisted-By: rits/zai-org/glm-5-3(pi) Signed-off-by: Hector Martinez <hemartin@redhat.com>
|
🤖 Finished Review · ✅ Success · Started 1:55 PM UTC · Completed 2:14 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.14 |
| .enabled | ||
| " .fullsend/config.yaml 2>"$YQ_ERR" | tail -1) || { | ||
| FIX_ENABLED=$(yq '.agents[] | select((.name | downcase) == "fix") | .enabled' .fullsend/config.yaml 2>/dev/null | tail -1) || { | ||
| echo "::warning::yq failed checking agents[].enabled — see logs" |
There was a problem hiding this comment.
[low] logic-error
In the new fix-check step, yq stderr is redirected to /dev/null, yet the failure handler warns "yq failed checking agents[].enabled — see logs". Nothing diagnostic reaches the logs, and the handler exits 0 so the disabled-fix guard is skipped. The base version captured stderr and printed it in this handler. fullsend run still skips a disabled agent later, so impact is limited to lost diagnostics.
Suggested fix: Capture yq stderr (as the base step did) and print it in the failure handler instead of discarding it.
|
|
||
| `fullsend run` terminates early and exits 0 before sandbox creation in these cases: | ||
|
|
||
| - **Pre-script skip:** When the harness `pre_script` writes `skipped=true` to `$FULLSEND_PRESCRIPT_OUTPUT`, `fullsend run` logs the skip, emits `skipped=true` (and `reason=<reason>` if provided) to `$GITHUB_OUTPUT` under GitHub Actions, and exits 0. |
There was a problem hiding this comment.
[low] doc-style
The new ## Early termination and skips section's intro line and both bullets (lines 348-351) are single lines of roughly 80-340 characters. docs/contributing/documentation.md ("Line wrapping") says new Markdown prose is written wrapped at about 80 columns with list continuation lines indented.
Suggested fix: Wrap the intro line and the two list items at about 80 columns, indenting continuation lines to align with the item text.
| return res, fmt.Errorf("pre-script output line %d: value for %q contains a control character (%#U) "+ | ||
| "at offset %d — values must be plain single-line text", lineNum, key, rune(value[i]), i) | ||
| } | ||
| if key == disabledKey { |
There was a problem hiding this comment.
[low] backward-incompatible
disabled is now a reserved pre-script output key: any existing pre-script that emits disabled=... now fails the run with a hard error (prescript.go:191-193), a tightening of the v1 protocol without a version bump. The PR documents it in the error-semantics table and a migration note, and the title carries !. Impact is limited to scripts that already used that key.
Suggested fix: Keep the migration note; optionally call out the reserved key in release notes.
| fallbackForgeClient := gh.New(composeGitToken) | ||
| harnessPath, fetchDeps, err := resolveAgentSource(ctx, absFullsendDir, agentName, fallbackForgeClient, orgCfg, composeOpts, printer) | ||
| if err != nil { | ||
| var disabledErr *agentDisabledError |
There was a problem hiding this comment.
[low] backward-incompatible
fullsend run for an agent with enabled: false used to exit non-zero; it now exits 0 and relays skipped=true, disabled=true, and reason (run.go:669-683). Callers keyed on the exit code now see success, and disabled non-fix agents now start a workflow run before the CLI skips. Documented and marked with !; consumers must key off skipped.
Suggested fix: Ensure downstream steps and consumers check skipped, not only the exit code. The PR already documents this.
|
/fs-fix address all feedback, rebase and resolve conflicts |
|
🤖 Finished Fix · ❌ Failure (post-script /home/runner/work/fullsend/fullsend/.fullsend/.fullsend-cache/resources/sha256/3b4860c748ffd59d27bac1cb5f7f8ca71c8d3b3daba0bbfb012969f8c5127f50/scripts/post-fix.sh failed: exit status 1) · Started 7:18 AM UTC · Completed 7:34 AM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.58 |
|
The fix agent completed, but the post-fix script failed before finishing. Workflow run: https://github.com/fullsend-ai/fullsend/actions/runs/43173972456 Details: |
|
@rh-hemartin Thanks for reworking this; moving the enabled decision into the CLI looks like the right direction to me. The route job’s yq check reads only .fullsend/config.yaml, while IsAgentExplicitlyDisabled sees the layered config, so the two can drift today. My earlier findings look addressed, or they no longer apply on main. The scaffold dispatch.yml, repo_overlay_test.go, and the ADR references are all gone there. On your Oct 5 question, I’d still read this as breaking, so the ! and trailer look right to me. From what I can tell, the CLI skip itself works. The rebase and the cost of starting the stage job may be worth settling before it lands. Rebase onto main Wondering if a rebase could come first, since the branch is about 700 commits behind and has conflicts. Since this branched, #8726 added the CEL route step, and its disabled-agent branch in dispatch_route.go returns routeBash. Its comment says the route job’s own agent-enabled checks report these cases. Does that still hold once agent-check is gone? Gating in the route job through the CLI Could the route job ask the CLI whether the agent is enabled, for every stage, instead of skipping inside the stage job? The route job can already install the CLI, cached per workflow_sha, so a few things might fall out of that: one source of truth: layered config, last entry wins, and the same matching as run With retro disabled here, would every PR close in this repo start a runner and mint a token with write scope for nothing? The catch is that the CLI install is currently gated on cel-config and marked continue-on-error, so it would have to run every time. If landing the stage job skip first is easier, I’m fine with that, as long as a separate issue tracks the cost. fix-check Is the yq read in fix-check intentional, given it still only sees config.yaml and misses config.base.yaml? It also seems to give enabled: false two different behaviours. fix would skip in the route job with no skipped or disabled outputs, while every other stage skips inside its stage job. Is that split something you want to keep? The roles paragraph The roles paragraph in customizing-agents.md says roles no longer gates dispatch, then describes the fullsend and coder role rules. I couldn’t find a role check in reusable-dispatch.yml on main or on this branch, so is the second half still accurate? Would it read cleaner as: roles decides which Apps get installed, and enabled: false turns an agent off? Version mismatch What happens when a caller pins fullsend_version to an older CLI but picks up this workflow? From what I can tell, the old CLI fails the job, no disabled output appears, and cleanup posts “Agent run interrupted”. Worth adding a line to the breaking change note saying the workflow and CLI upgrade together? Coverage for the fix path The new scenario covers a disabled triage. Is there a reason the disabled fix on a fork PR path has no scenario? |
Summary
This PR removes the workflow-level gate that used config's agent
enabledkey to block execution. The same check already exists in the CLI, so the workflow gate was duplication.fullsend runnow performs the skip itself: for an agent withenabled: falseit exits 0 and relaysskipped=true,disabled=true, and the skip reason as step outputs.It is considered a breaking change because disabled agents now start a workflow and skip at the CLI instead of being blocked up front, and
disabledis now a reserved pre-script output key.Related Issue
Closes #7857, Related to #7608
Changes
reusable-dispatch.yml(all stages exceptfix)fixagent does not hard-fail the fork-PR and PR-head checks; gateResolve PR headon itagentDisabledErrorfromresolveHarnessForLockso the disabled-agent error contract matchesrun.godisabledSkipResult) rather than the pre-script protocol packagedisabledpre-script output key (hard error if a pre-script emits it)rolesworkaround limits, error-semantics table row and migration note for the reserveddisabledkey, and theskipped=trueconsumer state for disabled agentsTesting
make lintpasses (stage changes first, then run)Checklist
!for breaking changes)