Repository navigation
refactor(#8065)!: remove org-specific config models and loading - #8088
Conversation
|
🤖 Finished Review · ✅ Success · Started 7:31 PM UTC · Completed 7:54 PM UTC Commit: Runtime: pi · Model: openai/gpt-6.1-sol → gpt-6.1-sol · Effort: high · Cost: $4.31 |
Site previewPreview: https://49c642c3-site.fullsend-ai.workers.dev Commit: |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Risk Assessment: moderate (2/5) DetailsExtensive removal of deprecated org configuration across 42 files with strong test coverage and zero protected path edits balances elevated git history churn and coupling in core CLI and config modules, maintaining moderate risk. Previous runRisk Assessment: moderate (2/5) DetailsExtensive removal of deprecated org configuration across 42 files with strong test coverage and zero protected path edits balances elevated git history churn and coupling in core CLI and config modules, maintaining moderate risk. Previous run (2)Risk Assessment: moderate (2/5) DetailsExtensive removal of deprecated org configuration across 42 files with strong test coverage and zero protected path edits balances elevated git history churn and coupling in core CLI and config modules, maintaining moderate risk. Previous run (3)Risk Assessment: moderate (2/5) DetailsExtensive removal of deprecated org configuration across 39 files with strong test coverage and zero protected path edits balances elevated git history churn and coupling in core CLI and config modules, maintaining moderate risk. Previous run (4)Risk Assessment: moderate (2/5) DetailsExtensive removal of deprecated org configuration across 37 files with strong test coverage and zero protected path edits balances elevated git history churn and coupling in core CLI and config modules, maintaining moderate risk. Previous run (5)Risk Assessment: moderate (2/5) DetailsThe large diff primarily removes deprecated org configuration and includes extensive test changes with no protected-path edits; elevated churn and regression history in core modules balance the clearly authorized scope, yielding moderate risk. |
|
Looks good to me Previous runReviewFindingsHigh
Next steps:
Previous run (2)ReviewFindingsHigh
Next steps:
Previous run (3)ReviewFindingsMedium
Next steps:
Previous run (4)ReviewFindingsMedium
Low
Next steps:
Previous run (5)ReviewFindingsMedium
Low
Labels: This removes deprecated installation configuration and its consumers, matching the repository’s maintenance/install labeling conventions. Next steps:
|
|
/fs-fix Rebase. Squash commits. Fix all review issues. Reply to and resolve all threads. |
1 similar comment
|
/fs-fix Rebase. Squash commits. Fix all review issues. Reply to and resolve all threads. |
|
🤖 Finished Fix · ✅ Success · Started 8:52 PM UTC · Completed 9:02 PM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.96 |
Per-org installation mode is deprecated (ADR 0044). Remove the org config model and every reader of it: - config: drop orgConfig, NewOrgConfig, ParseOrgConfig, the DispatchConfig/RepoDefaults/RepoConfig/InferenceConfig types, NewPerRepoConfigFromOrg, IsOrgMode and the OrgConfigReader/Writer interfaces. LoadConfig and LoadConfigWriter now reject a config.yaml with top-level dispatch, repos or defaults keys instead of loading it. - runtime: drop ResolveFromConfig. - cli: drop the org branch of `fullsend run` runtime and agent-settings resolution (resolveBackendFromConfigData, isOrgConfigData). - repos: delete the org-to-per-repo Migrate helper (no callers since #8064) and the org-only discovery code; move MarshalWithHeader into manifest.go and the readWorkflowRef tests into status_test.go, and remove the now-misnamed discover.go/discover_test.go. Validators shared with per-repo config (agent entries, status notifications, create_issues incl. AllowTargets.Orgs) keep their tests, now exercised through per-repo config. Changes from review feedback on PR #8088: - eval-measure fails closed (denies the agents-repo fetch) when an existing config.yaml cannot be loaded, so a rejected org-shaped config with allowed_remote_resources: [] no longer reverts to the default allowlist; regression test added. - TestResolveAgentSource fixtures renamed from orgCfg to cfg. - Docs: drop the per-org roles snippet from the private-repositories guide and update stale per-org wording in customizing-agents, cli-internals and config-reference. BREAKING CHANGE: a .fullsend config.yaml in the per-org format (top-level dispatch, repos or defaults) is now rejected with an error instead of being loaded. Use a per-repo .fullsend/config.yaml. Note: pre-commit could not fetch hook repositories (sandbox TLS failure); gofmt, go vet ./... and whitespace checks were run directly. Unrelated TestStartFetchService_* and TestPostScriptEnv_NoSchema* tests fail in the sandbox with and without this change. Closes #8065 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🔧 Fix agent — iteration 1 (human-triggered)Addressed all 7 review findings (1 medium fail-open fix with regression test, 1 medium doc fix, 5 low items). The branch was already up to date with main, so the rebase was a no-op, and the PR is squashed to a single commit. Thread replies and resolution are left to the post-script. Pre-commit could not fetch hook repos in the sandbox, so gofmt, go vet and whitespace checks were run directly. Some internal/cli tests (TestStartFetchService_, TestPostScriptEnv_NoSchema) fail in the sandbox both with and without this change. Fixed (9):
Disagreed (1):
Tests: passed CI inspections (8):
Decision points
Next steps:
|
1d2ab0b to
a6704c9
Compare
|
🤖 Finished Review · ✅ Success · Started 9:15 PM UTC · Completed 9:33 PM UTC Commit: Runtime: pi · Model: openai/gpt-6.1-sol → gpt-6.1-sol · Effort: high · Cost: $3.44 |
|
🤖 Finished Fix · ✅ Success · Started 9:41 PM UTC · Completed 9:51 PM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.62 |
Address review feedback on PR #8088: - runAgent no longer treats an existing but unloadable config.yaml as absent; the load error is returned before agent-source resolution so an explicit allowed_remote_resources deny-all cannot be replaced by the default allowlist. Adds a regression test and updates three tests that asserted the old fallback error. - Remove the reference to the deleted defaults.max_implementation_retries setting from the bugfix workflow guide. Note: pre-commit could not fetch hook repos (TLS); gofmt, go vet and git diff --check were run directly. Unrelated pre-existing failures in TestStartFetchService_* and TestPostScriptEnv_NoSchema* also fail on the base. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🔧 Fix agent — iteration 2 (bot-triggered)Addressed both findings: runAgent now fails closed on an existing-but-rejected config.yaml before any remote resolution (with regression test), and the stale max_implementation_retries doc reference was removed. The new test passes. Other cli test failures (fetch service and post-script env tests) also fail on the base commit and are unrelated sandbox issues. Pre-commit could not fetch hook repos, so gofmt, go vet and diff checks were run directly. Fixed (2):
Tests: passed CI inspections (3):
Conflict update: skipped; strategy Decision points
Next steps:
|
|
🤖 Finished Review · ✅ Success · Started 10:46 PM UTC · Completed 10:55 PM UTC Commit: Runtime: pi · Model: openai/gpt-6.1-sol → gpt-6.1-sol · Effort: high · Cost: $1.76 |
|
🤖 Finished Fix · ✅ Success · Started 10:57 PM UTC · Completed 11:07 PM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.75 |
runAgent and evalMeasureFetchContext checked only config.yaml when deciding whether config was absent, so a base-only allowed_remote_resources: [] fell back to the default allowlist and a malformed config.base.yaml was ignored before fetching. Both now load the layered config strictly via loadLockConfig (absent only when neither layer exists) and deny remote fetching on any load failure. Pre-commit could not fetch hook repos (TLS failure); ran gofmt, go vet and git diff --check directly. Unrelated pre-existing failures in TestStartFetchService_* and TestPostScriptEnv_NoSchema* also fail on the base branch in this sandbox. Addresses #8088 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🔧 Fix agent — iteration 5 (bot-triggered)Both findings shared one root cause (config absence decided from config.yaml alone). Run and eval-measure now reuse the layered strict loader already used for locking. Tests in internal/cli pass except six pre-existing sandbox-environment failures (TestStartFetchService_, TestPostScriptEnv_NoSchema) that also fail on the unmodified branch. pre-commit could not fetch hook repos; gofmt, go vet and diff checks were run directly. Fixed (2):
Tests: passed CI inspections (1):
Conflict update: skipped; strategy
|
|
🤖 Finished Review · ✅ Success · Started 11:09 PM UTC · Completed 11:18 PM UTC Commit: Runtime: pi · Model: openai/gpt-6.1-sol → gpt-6.1-sol · Effort: high · Cost: $1.47 |
Superseded by updated review
Summary
This removes the per-org configuration model and everything that read it: the config structs, parsers, interfaces and mode detection, plus their consumers in runtime, run, lock/eval, harness and repos code. Per-org installation is deprecated (ADR 0044). A
config.yamlin the old per-org format now fails with a clear error. Before this change, its org-only keys would have been silently dropped.Related Issue
Closes #8065 (part of #8063)
Changes
internal/configorgConfig,NewOrgConfig,ParseOrgConfig,DispatchConfig,RepoDefaults,RepoConfig,InferenceConfig,NewPerRepoConfigFromOrg,IsOrgModeandOrgConfigReader/OrgConfigWriter.LoadConfig/LoadConfigWriternow reject aconfig.yamlwith top-leveldispatch,reposordefaultskeys (errPerOrgConfig). YAML that isn't a mapping still reports aparsing config.yamlerror.create_issues.allow_targets.orgs, are kept.internal/runtime: removedResolveFromConfig.internal/clifullsend runno longer has an org path for runtime or per-agent settings (resolveBackendFromConfigData,isOrgConfigDataandrunConfig.orgDataare gone).orgconfig.goandreconcilestatus.go.internal/reposmigrate.go, the org→per-repo migration helper. It has had no callers since Remove per-org CLI commands and installation branching #8064.discover.gotoMarshalWithHeader.create_issues) now run through per-repo config instead of being dropped.OrgConfigandResolveFromConfigreferences fromdocs/architecture.mdanddocs/contributing/runtime-implementation.md.Some code is now unreachable but left in place, for example
!okbranches after aPerRepoConfigReaderassertion and thetryLoadOrgConfig/requireOrgConfigaliases. Per the issue's sequencing, the final sweep belongs to #8070.Breaking change: a per-org
.fullsend/config.yamlis now rejected with an error instead of being loaded.Testing
make lintpasses (stage changes first, then run). Thepre-commithook-repo fetch failed in the sandbox because of TLS, so the hooks were run directly: gofmt,go vet ./..., trailing-whitespace/EOF,lint-docs-links,lint-broken-symlinks, lychee offline and gitlint all passed.LoadConfig/LoadConfigWriter(each key, and alongside a base layer),backendFromConfigFile,tryLoadFullsendConfig/requireFullsendConfig,loadAgentConfig,runAgentSetandKillSwitchActive.go build ./...andgo testpass forinternal/config,internal/cli,internal/runtime,internal/repos,internal/harnessandinternal/harnessdispatch. The exception isTestStartFetchService_*ininternal/cli, which fails in the sandbox because local dials are denied.fetch,sandbox,securityandtelemetryalso fail in the sandbox for network reasons, and none of them are touched here.Checklist
!for breaking changes)🤖 Generated with Claude Code
Closes #8065
Post-script verification
agent/8065-remove-org-config)6cbd29593d396828305081b72bc2bdc76c4a79eb..HEAD)