Repository navigation
feat: start runtime workflows from the runner - #8228
waynesun09 wants to merge 16 commits into
Conversation
PR Summary by QodoStart harness workflows directly from the runner
AI Description
Diagram
High-Level Assessment
Files changed (60)
|
|
🤖 Review · Commit: |
Code Review by Qodo
1.
|
Site previewPreview: https://6c27abd3-site.fullsend-ai.workers.dev Commit: |
3a6129f to
2adad7d
Compare
38a221b to
7d9635c
Compare
|
🤖 Finished Review · ✅ Success · Started 3:26 AM UTC · Completed 3:42 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $5.48 |
|
/fs-fix-stop |
|
Fix agent disabled for this PR. Remove the |
|
Risk Assessment: moderate (2/5) DetailsLarge additive feature with high file count and churn in core runner files, mitigated by strictly opt-in workflow configuration, zero protected or security-sensitive changes, clean dependency footprint, and close alignment with accepted ADR 0130. Previous runRisk Assessment: moderate (2/5) DetailsLarge additive feature with high file count and churn in core runner files, mitigated by strictly opt-in workflow configuration, zero protected or security-sensitive changes, clean dependency footprint, and close alignment with accepted ADR 0130. Previous run (2)Risk Assessment: moderate (2/5) DetailsLarge additive feature with high file count and churn in core runner files, mitigated by strictly opt-in workflow configuration, zero protected or security-sensitive changes, clean dependency footprint, and close alignment with accepted ADR 0130. Previous run (3)Risk Assessment: moderate (2/5) DetailsLarge additive feature with high file count and churn in core runner files, mitigated by strictly opt-in workflow configuration, zero protected or security-sensitive changes, clean dependency footprint, and close alignment with accepted ADR 0130. Previous run (4)Risk Assessment: moderate (2/5) DetailsLarge additive feature with high file count and churn in core runner files, mitigated by strictly opt-in workflow configuration, zero protected or security-sensitive changes, clean dependency footprint, and close alignment with accepted ADR 0130. Previous run (5)Risk Assessment: moderate (2/5) DetailsLarge additive feature with high file count and churn in core runner files, mitigated by strictly opt-in workflow configuration, zero protected or security-sensitive changes, clean dependency footprint, and close alignment with accepted ADR 0130. |
ReviewFindingsLow
Earlier findings
Labels: Feature PR adding runtime-workflow start logic with behaviour-test (e2e) coverage. 6 finding(s) below the Previous run<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9jbGkvd29ya2Zsb3cuZ28iLCJpZCI6ImZfYTU3MTliNjQ3NmZhNzdmZCIsImxpbmUiOjM2MiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYXBpLWNvbnRyYWN0IiwiZmlsZSI6ImRvY3MvZ3VpZGVzL3VzZXIvcnVudGltZS13b3JrZmxvd3MubWQiLCJpZCI6ImZfZGU0YWJhMjNlNTNiYmU0YyIsImxpbmUiOjM4OSwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZXJyb3ItaGFuZGxpbmctaWRpb20iLCJmaWxlIjoiaW50ZXJuYWwvYWdlbnRuZXcvb3B0aW9ucy5nbyIsImlkIjoiZl8zZTRiNDBiYTM3Mzk1YjgyIiwibGluZSI6NjIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImVycm9yLWhhbmRsaW5nLWlkaW9tIiwiZmlsZSI6ImludGVybmFsL3J1bnRpbWUvcGlfYWdlbnQuZ28iLCJpZCI6ImZfZjNiOWVhODcxNjE0Yzk4YSIsImxpbmUiOjEwNCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImVycm9yLWhhbmRsaW5nLWlkaW9tIiwiZmlsZSI6InBrZy9iZWhhdmlvdXJ0ZXN0L3N0ZXBzL3dvcmtmbG93LmdvIiwiaWQiOiJmX2IzOWQwY2RkZGQ1MWU1MzYiLCJsaW5lIjo5MywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImFwaS1zaGFwZSIsImZpbGUiOiJwa2cvYmVoYXZpb3VydGVzdC9zdGVwcy93b3JrZmxvdy5nbyIsImlkIjoiZl82ZTFlOWI4MzQ5YzNjZmU3IiwibGluZSI6MTI0LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJiYWNrd2FyZC1pbmNvbXBhdGlibGUiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy93b3JrZmxvdy5nbyIsImlkIjoiZl81YWNkOGRkOTIxNjM5ZDJhIiwibGluZSI6MTA0LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJpbmNvbXBsZXRlLWRvYyIsImZpbGUiOiJkb2NzL3JlZmVyZW5jZS9jb25maWctcmVmZXJlbmNlLm1kIiwiaWQiOiJmXzZhYzZmYzBkNzcyZWY0NjEiLCJsaW5lIjo1NSwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImRvY3MtY3VycmVuY3kifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJpbmNvbXBsZXRlLWRvYyIsImZpbGUiOiJkb2NzL2d1aWRlcy9pbmZyYXN0cnVjdHVyZS9sYXllcmVkLWNvbmZpZy1yZWZlcmVuY2UubWQiLCJpZCI6ImZfNTgwMzI5MWNjZWFkMTM3NSIsImxpbmUiOjQyNiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImRvY3MtY3VycmVuY3kifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJpbmNvbXBsZXRlLWRvYyIsImZpbGUiOiJkb2NzL3J1bnRpbWVzL3BpLm1kIiwiaWQiOiJmXzdmMGQ5YTgyMjY0MGIxNzAiLCJsaW5lIjoxODMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJkb2NzLWN1cnJlbmN5In0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYXBpLWNvbnRyYWN0IiwiZmlsZSI6ImRvY3MvZ3VpZGVzL3VzZXIvcnVudGltZS13b3JrZmxvd3MubWQiLCJpZCI6ImZfMzYwNWRjMDc5YzlmZjczOCIsImxpbmUiOjQwMCwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJlcnJvci1oYW5kbGluZy1pZGlvbSIsImZpbGUiOiJwa2cvYmVoYXZpb3VydGVzdC9zdGVwcy93b3JrZmxvdy5nbyIsImlkIjoiZl82YzAxNzAyNmMwNDNiYTM0IiwibGluZSI6OTMsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYXBpLXNoYXBlIiwiZmlsZSI6InBrZy9iZWhhdmlvdXJ0ZXN0L3N0ZXBzL3dvcmtmbG93LmdvIiwiaWQiOiJmXzU0ODJiZTkwZTRkYzJmNDMiLCJsaW5lIjoxMjQsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJzZWNyZXQtZXhwb3N1cmUiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy93b3JrZmxvdy5nbyIsImlkIjoiZl85NWM2NWQ0N2M0MTRlNTY3IiwibGluZSI6MjQ1fSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJwcm9tcHQtaW5qZWN0aW9uIiwiZmlsZSI6ImUyZS9iZWhhdmlvdXIvZml4dHVyZXMvd29ya2Zsb3cvc2FtcGxlLXBpcGVsaW5lL3dvcmtmbG93cy90cmlhZ2UtZmFub3V0LmpzIiwiaWQiOiJmXzJiOGZiZWU4OTlhM2Y4NzciLCJsaW5lIjozMn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoibWlzc2luZy1hdXRob3JpemF0aW9uIiwiZmlsZSI6ImRvY3MvYXJjaGl0ZWN0dXJlLm1kIiwiaWQiOiJmX2I0OTVjYjRiNTRhYTM4MjEiLCJsaW5lIjoyNzAsImFjdGlvbmFibGUiOmZhbHNlfV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmX2E1NzE5YjY0NzZmYTc3ZmQiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMzYwNWRjMDc5YzlmZjczOCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl8zZTRiNDBiYTM3Mzk1YjgyIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzZjMDE3MDI2YzA0M2JhMzQiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfNTQ4MmJlOTBlNGRjMmY0MyIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9mM2I5ZWE4NzE2MTRjOThhIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzk1YzY1ZDQ3YzQxNGU1NjciLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8yYjhmYmVlODk5YTNmODc3Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYjQ5NWNiNGI1NGFhMzgyMSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= --> ReviewFindingsLow
Labels: PR adds runner-side start of runtime workflows, a harness field behaviour, CLI flags and user guides 2 finding(s) below the Previous run (2)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9jbGkvd29ya2Zsb3cuZ28iLCJpZCI6ImZfYTU3MTliNjQ3NmZhNzdmZCIsImxpbmUiOjM1OSwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImFwaS1jb250cmFjdCIsImZpbGUiOiJkb2NzL2d1aWRlcy91c2VyL3J1bnRpbWUtd29ya2Zsb3dzLm1kIiwiaWQiOiJmXzM2MDVkYzA3OWM5ZmY3MzgiLCJsaW5lIjo0MDAsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJlcnJvci1oYW5kbGluZy1pZGlvbSIsImZpbGUiOiJpbnRlcm5hbC9hZ2VudG5ldy9vcHRpb25zLmdvIiwiaWQiOiJmXzNlNGI0MGJhMzczOTViODIiLCJsaW5lIjo2MiwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJlcnJvci1oYW5kbGluZy1pZGlvbSIsImZpbGUiOiJwa2cvYmVoYXZpb3VydGVzdC9zdGVwcy93b3JrZmxvdy5nbyIsImlkIjoiZl82YzAxNzAyNmMwNDNiYTM0IiwibGluZSI6OTMsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5IjoiYXBpLXNoYXBlIiwiZmlsZSI6InBrZy9iZWhhdmlvdXJ0ZXN0L3N0ZXBzL3dvcmtmbG93LmdvIiwiaWQiOiJmXzU0ODJiZTkwZTRkYzJmNDMiLCJsaW5lIjoxMjQsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJlcnJvci1oYW5kbGluZy1pZGlvbSIsImZpbGUiOiJpbnRlcm5hbC9ydW50aW1lL3BpX2FnZW50LmdvIiwiaWQiOiJmX2YzYjllYTg3MTYxNGM5OGEiLCJsaW5lIjoxMDAsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJzZWNyZXQtZXhwb3N1cmUiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy93b3JrZmxvdy5nbyIsImlkIjoiZl85NWM2NWQ0N2M0MTRlNTY3IiwibGluZSI6MjQ1fSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJwcm9tcHQtaW5qZWN0aW9uIiwiZmlsZSI6ImUyZS9iZWhhdmlvdXIvZml4dHVyZXMvd29ya2Zsb3cvc2FtcGxlLXBpcGVsaW5lL3dvcmtmbG93cy90cmlhZ2UtZmFub3V0LmpzIiwiaWQiOiJmXzJiOGZiZWU4OTlhM2Y4NzciLCJsaW5lIjozMn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoibWlzc2luZy1hdXRob3JpemF0aW9uIiwiZmlsZSI6ImRvY3MvYXJjaGl0ZWN0dXJlLm1kIiwiaWQiOiJmX2I0OTVjYjRiNTRhYTM4MjEiLCJsaW5lIjoyNzAsImFjdGlvbmFibGUiOmZhbHNlfV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmX2E1NzE5YjY0NzZmYTc3ZmQiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMzYwNWRjMDc5YzlmZjczOCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9iNDk1Y2I0YjU0YWEzODIxIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfM2U0YjQwYmEzNzM5NWI4MiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl82YzAxNzAyNmMwNDNiYTM0Iiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn0seyJpZCI6ImZfNTQ4MmJlOTBlNGRjMmY0MyIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9LHsiaWQiOiJmXzk1YzY1ZDQ3YzQxNGU1NjciLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8yYjhmYmVlODk5YTNmODc3Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn1dfQ== --> ReviewFindingsLow
Earlier findings
Previous run (3)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9jbGkvd29ya2Zsb3cuZ28iLCJpZCI6ImZfYTU3MTliNjQ3NmZhNzdmZCIsImxpbmUiOjM1OSwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImFwaS1jb250cmFjdCIsImZpbGUiOiJkb2NzL2d1aWRlcy91c2VyL3J1bnRpbWUtd29ya2Zsb3dzLm1kIiwiaWQiOiJmXzM2MDVkYzA3OWM5ZmY3MzgiLCJsaW5lIjo0MDAsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJtaXNzaW5nLWF1dGhvcml6YXRpb24iLCJmaWxlIjoiZG9jcy9hcmNoaXRlY3R1cmUubWQiLCJpZCI6ImZfYjQ5NWNiNGI1NGFhMzgyMSIsImxpbmUiOjI3MCwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImVycm9yLWhhbmRsaW5nLWlkaW9tIiwiZmlsZSI6ImludGVybmFsL2FnZW50bmV3L29wdGlvbnMuZ28iLCJpZCI6ImZfM2U0YjQwYmEzNzM5NWI4MiIsImxpbmUiOjYyLCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZXJyb3ItaGFuZGxpbmctaWRpb20iLCJmaWxlIjoicGtnL2JlaGF2aW91cnRlc3Qvc3RlcHMvd29ya2Zsb3cuZ28iLCJpZCI6ImZfNmMwMTcwMjZjMDQzYmEzNCIsImxpbmUiOjkzLCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYXBpLXNoYXBlIiwiZmlsZSI6InBrZy9iZWhhdmlvdXJ0ZXN0L3N0ZXBzL3dvcmtmbG93LmdvIiwiaWQiOiJmXzU0ODJiZTkwZTRkYzJmNDMiLCJsaW5lIjoxMjQsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJzZWNyZXQtZXhwb3N1cmUiLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy93b3JrZmxvdy5nbyIsImlkIjoiZl85NWM2NWQ0N2M0MTRlNTY3IiwibGluZSI6MjQ1fSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJwcm9tcHQtaW5qZWN0aW9uIiwiZmlsZSI6ImUyZS9iZWhhdmlvdXIvZml4dHVyZXMvd29ya2Zsb3cvc2FtcGxlLXBpcGVsaW5lL3dvcmtmbG93cy90cmlhZ2UtZmFub3V0LmpzIiwiaWQiOiJmXzJiOGZiZWU4OTlhM2Y4NzciLCJsaW5lIjozMn1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl85NWM2NWQ0N2M0MTRlNTY3Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMmI4ZmJlZTg5OWEzZjg3NyIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2E1NzE5YjY0NzZmYTc3ZmQiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfM2U0YjQwYmEzNzM5NWI4MiIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl82YzAxNzAyNmMwNDNiYTM0Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzU0ODJiZTkwZTRkYzJmNDMiLCJzdGF0dXMiOiJvcGVuIn1dfQ== --> ReviewFindingsLow
Earlier findings
Previous run (4)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6InNlY3JldC1leHBvc3VyZSIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL3dvcmtmbG93LmdvIiwiaWQiOiJmXzk1YzY1ZDQ3YzQxNGU1NjciLCJsaW5lIjoyNDV9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6InByb21wdC1pbmplY3Rpb24iLCJmaWxlIjoiZTJlL2JlaGF2aW91ci9maXh0dXJlcy93b3JrZmxvdy9zYW1wbGUtcGlwZWxpbmUvd29ya2Zsb3dzL3RyaWFnZS1mYW5vdXQuanMiLCJpZCI6ImZfMmI4ZmJlZTg5OWEzZjg3NyIsImxpbmUiOjMyfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9jbGkvd29ya2Zsb3cuZ28iLCJpZCI6ImZfYTU3MTliNjQ3NmZhNzdmZCIsImxpbmUiOjM1OX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZXJyb3ItaGFuZGxpbmctaWRpb20iLCJmaWxlIjoiaW50ZXJuYWwvYWdlbnRuZXcvb3B0aW9ucy5nbyIsImlkIjoiZl8zZTRiNDBiYTM3Mzk1YjgyIiwibGluZSI6NjJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImVycm9yLWhhbmRsaW5nLWlkaW9tIiwiZmlsZSI6InBrZy9iZWhhdmlvdXJ0ZXN0L3N0ZXBzL3dvcmtmbG93LmdvIiwiaWQiOiJmXzZjMDE3MDI2YzA0M2JhMzQiLCJsaW5lIjo5M30seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYXBpLXNoYXBlIiwiZmlsZSI6InBrZy9iZWhhdmlvdXJ0ZXN0L3N0ZXBzL3dvcmtmbG93LmdvIiwiaWQiOiJmXzU0ODJiZTkwZTRkYzJmNDMiLCJsaW5lIjoxMjR9XX0= --> ReviewFindingsMedium
Low
Next steps:
Previous run (5)ReviewFindingsHigh
Medium
Low
Next steps:
|
|
Be careful with implementing before the ADR is accepted. I'm fighting very hard against "sunken cost fallacy", so keep in mind this can be wasted tokens and budget. |
5869bda to
4010cbc
Compare
4010cbc to
72370a8
Compare
7d9635c to
dbdc9af
Compare
A harness added by URL now resolves a relative runtime_workflow.source in its own repository at the commit it was fetched from (#8226), so the guides stop calling it refused, the troubleshooting row names the branch-ref error, and the quoted base error matches its new wording. Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
cd812c5 to
c3bf5d8
Compare
29db520 to
ffb48c1
Compare
|
🤖 Finished Review · Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.92 This review was superseded by a newer commit. Check the current pull request HEAD's review status before merging. |
Pin the remote example to 7068965, the pushed commit that last changed e2e/behaviour/fixtures/workflow/sample-pipeline, and replace every pasted output with a fresh run of this branch's binary: agent new, the three lock steps and lock.yaml (now field: runtime_workflow), the remote plan line, the local run against issue 8204, and jq .runtime_workflow. The tree hash is 99be97667c85 for both the path and the remote source. Also count the tool allowlist hook's Workflow check: fullsend run makes five plan-time checks, not four. Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
|
🤖 Finished Review · ✅ Success · Started 8:03 PM UTC · Completed 8:26 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $4.59 |
Superseded by updated review
|
🤖 Finished Review · ✅ Success · Started 9:04 PM UTC · Completed 9:16 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.43 |
Superseded by updated review
Summary
Completes ADR 0130 (#8225) on top of #8226: when a harness pins a Claude Code plugin in
runtime_workflow:, the runner itself starts the named workflow,/<namespace>:<name> <args>, instead of asking the model to. A pi-extension runtime workflow starts itself from its session hook, so the runner only delivers it. Addsfullsend agent new --runtime-workflow-source/--runtime-workflow-name, a behaviour test with a sample runtime workflow, and two user guides.Stacked on #8226; review that first.
Naming: the field is
runtime_workflow:(a workflow the agent runtime executes itself, not a GitHub Actions workflow). This PR's flags follow it:--runtime-workflow-sourceand--runtime-workflow-name(spec keysruntime_workflow_sourceandruntime_workflow_name), themetrics.jsonkeyruntime_workflowand the span attributefullsend.runtime_workflow. The rename is its own commit on top.Changes
internal/cli/workflow.go,run.go):--agentstill on the command line. A validation-loop retry runs the same command; withfeedback_mode: appendthe feedback is not passed to the workflow, and the run says so once.argsexpands${VAR}from the runner environment, so a harness passes the work item (issue ${ISSUE_NUMBER}). Args reach the prompt, the plan andmetrics.json, so a credential-shaped variable name, an unset variable, a value that adds a line and a credential-looking value (literal or expanded) are refused; errors name the variable or rule, never the value.tools:must nameWorkflow,disallowedTools:must not, its frontmatter must parse, and an enabled tool-allowlist hook whoseenv.sandboxlist omitsWorkflowis refused.Runtime workflow: <source> (sha256:<hash12>) → /<namespace>:<name>[ <args>]on Claude,... delivered as pi extensionon pi.metrics.jsongets aruntime_workflowobject (source,pin_sha256,kind, andcommandon Claude) on every runtime, so adummyrun records the launch; the agent span getsfullsend.runtime_workflow.fullsend agent new --runtime-workflow-source <url|path> --runtime-workflow-name <name>: writes the harnessruntime_workflow:block and addsWorkflowto the agent'stools:; a URL without#sha256=gets a placeholder hash and the command prints howfullsend lockreveals the real one.Workflowevents are allowed or denied byFULLSEND_TOOL_ALLOWLISTlike any tool.features/dispatch/runtime-workflow.feature, dummy runtime): commits a sample runtime workflow into the leased repository, runs a harness withruntime_workflow: {source: pipelines/sample-pipeline, name: triage-fanout, args: "issue 1"}, and assertsmetrics.jsonrecords the command, source, kind and a 64-hex pin. Definition files are removed on cleanup through an optionalscm.FileDeleterinterface, soscm.Driveris unchanged.e2e/behaviour/fixtures/workflow/sample-pipeline): a skill that reads an issue's checklist over the GitHub REST API through a helper script, a workflow that checks each item in parallel (issue text passed to agents as delimited data, never as instructions), and a report written toagent-result.json; the sandbox stays read-only and the harness post-script posts the comment.docs/guides/user/runtime-workflows.md(run a runtime workflow: local and remote sources, sharing throughbase:, installing someone else's harness, pi extensions, a troubleshooting table keyed on the exact errors) anddocs/guides/user/runtime-workflow-authors.md(make a pipeline repository loadable); updates toharness-reference.md,docs/cli/run.md,docs/cli/agent.md,docs/runtimes.md,docs/runtimes/claude.md, tracing and behaviour-testing guides.Testing
make lintpasses (stage changes first, then run)Local run of the sample runtime workflow on the claude runtime (the sandbox image's Claude Code 2.1.258), against public issue #8204, read-only GitHub, post-script in dry-run mode. This run is from before the rename, so its plan line reads
Workflow:where this revision printsRuntime workflow::{"source":"pipelines/sample-pipeline","pin_sha256":"9d2717dc50ed46a59bb200b86053b14fa4cc3fb648b45d2672faf5b5aeb56705","kind":"claude-plugin","command":"/sample-pipeline:triage-fanout issue 8204"}go test -racepasses forinternal/cli,internal/runtime,internal/harness,internal/agentnew,internal/resolve,internal/security,internal/fetch,internal/lockandpkg/behaviourtest/...;go vet -tags behaviourand-tags playbackare clean; the allowlist hook tests pass. The behaviour scenario passed on an earlier revision (35 of 35 scenarios). This revision renames the harness field and themetrics.jsonkey the scenario asserts on, so it needs a re-run.Checklist
!for breaking changes)