[fullsend-ai-coder]

Summary

openshell sandbox upload now always gets --no-git-ignore. A failed output-schema upload now stops bootstrap with an error instead of logging a warning. Since OpenShell 0.1.3 (NVIDIA/OpenShell#3957), uploading a single file fails when the checkout's .gitignore matches it. The output schema is uploaded from .fullsend-cache/, which many checkouts ignore, fullsend's own included. On 0.1.2 that same upload only warned.

Related Issue

Blocks #8299 (OpenShell v0.1.4 bump).

Changes

• internal/sandbox/sandbox.go: Upload passes --no-git-ignore before the positional args. fullsend always uploads one file it has already picked (UploadDir applies its own excludes and uploads a tarball), so OpenShell's Git filtering is never wanted here. The flag already exists on 0.1.2, so there is no version gate.
• internal/cli/run.go: bootstrapEnv now returns creating .fullsend dir for output schema: ... or uploading output schema <path>: ... instead of printing a WARNING and running without FULLSEND_OUTPUT_SCHEMA. The "schema file not found on host" warning is unchanged.
• Tests:
  • New TestUpload_PassesNoGitIgnore checks that both a regular-file Upload and UploadDir's tarball upload pass the flag.
  • New bootstrapEnv tests cover the upload-failure error, the mkdir-failure error, and the success path, where the schema env var is exported.
  • Test-fake openshell scripts in internal/sandbox and internal/runtime now read upload paths as $5/$6 instead of $4/$5, and the log assertions match the new argv.

Testing

• go test ./internal/sandbox/ ./internal/runtime/ ./internal/cli/ pass, apart from failures that also happen on unmodified main in this sandbox: TestDialReachable_ClosedPort, TestBuildRunCommand_ClaudeMissingExits127 (a real claude is on PATH here), TestStartFetchService_* and TestPostScriptEnv_NoSchema*. The fetch, security and telemetry packages also fail here but are untouched by this change.
• Lint: pre-commit could not fetch its hook repos (TLS error in the sandbox), so the hooks that apply to Go files were run directly and all passed: the pre-commit-hooks file checks, gofmt, go vet ./..., and lint-broken-symlinks. Secret scan passed.
• Tests added/updated for new or modified logic. The new error returns and the success export are covered.

Checklist

• PR title follows Conventional Commits
• Commits are signed off (DCO): not applicable, this is an autonomous agent commit

🤖 Generated with Claude Code

---

Closes #8484

Post-script verification

• Branch is not main/master (agent/8484-upload-no-git-ignore)
• Secret scan passed (gitleaks — 4dea855322bc8cca6a277fac06642bfcd1cd093d..HEAD)
• PR body secret scan passed (gitleaks — no-git)

[waynesun09]

/fs-fix-stop

[github-actions]

Fix agent disabled for this PR. Remove the fullsend-no-fix label or use /fs-fix to re-engage.

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 1:08 PM UTC · Completed 1:15 PM UTC

Commit: 9d5b70c · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.37

[waynesun09]

Validation on OpenShell 0.1.4

I ran a real fullsend run locally on an OpenShell v0.1.4 gateway (podman) with the dummy runtime, so no inference was involved.

Fixture: a harness whose base: is fullsend-ai/agents@ce9e432 harness/triage.yaml. That puts validation_loop.schema at .fullsend/.fullsend-cache/resources/sha256/…/content.json, inside a checkout that uses fullsend's own .gitignore (git check-ignore → .gitignore:7:.fullsend-cache/).

fullsend run schema-check --fullsend-dir <repo>/.fullsend --target-repo <repo> \
  --no-post-script --keep-sandbox --fullsend-binary <linux/arm64 build>
# then, inside the kept sandbox:
. /sandbox/workspace/.env; fullsend-check-output output/agent-result.json

main 4b3766043: the run exits 0, but the schema never reaches the sandbox.

WARNING: could not upload output schema: upload to sandbox "fs-sch-c0a676a1da26" failed: Error:   × Git filtering selected no files for …/.fullsend/.fullsend-cache/resources/sha256/e4a0…/content.json; upload stopped.
  ✓ Validation passed: …           # host-side check only
# in sandbox:
FULLSEND_OUTPUT_SCHEMA=<unset>
FAIL: FULLSEND_OUTPUT_SCHEMA is not set
fullsend-check-output exit=1

This PR 9d5b70c2e: no upload warning, and the in-sandbox check passes.

  ✓ Validation passed: …
# in sandbox:
FULLSEND_OUTPUT_SCHEMA=/sandbox/workspace/.fullsend/output-schema.json
PASS: output validated against schema
fullsend-check-output exit=0

pre-commit run --from-ref origin/main is clean.

[fullsend-ai-review]

Risk Assessment: moderate (2/5)

Details

Focused bug fix with high test coverage and no protected paths, elevated to moderate by high churn in modified runner files and behavioral change without a feature flag.

[fullsend-ai-review]

Review

Findings

Low

• [error-handling] internal/cli/run.go:3687 — The new mkdir check only catches errors where openshell exec never started or timed out (exit 124). sandbox.ExecContext returns a nil error for any other nonzero exit, and the exit code is discarded here. A real mkdir -p failure therefore does not produce the intended "creating .fullsend dir" error. Bootstrap still fails closed. sandbox.UploadFile runs its own mkdir -p of the same directory and checks the exit code, so the failure comes back as uploading output schema .... The cost is a less specific error message and a redundant exec. This also matches the other Exec call sites in run.go. TestBootstrapEnv_SchemaMkdirFailureIsError removes openshell from PATH, so it covers only the failed-to-start path.
  Remediation: Optionally check the exit code and stderr from the mkdir Exec. Alternatively, drop the pre-mkdir and rely on UploadFile. A fake-openshell test where mkdir exits nonzero would cover the gap.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[waynesun09]

@fullsend-ai/core this is ready for a human review: CI is green, all threads are resolved, and the 0.1.4 validation is above. It unblocks the OpenShell 0.1.4 bump (#8299).

[waynesun09]

Approved: fixes the 0.1.4 strict-upload break (#8484); validated locally on v0.1.4.