Repository navigation
fix(cli): remove the OpenShell first-poll settle wait - #8500
waynesun09 wants to merge 2 commits into
Conversation
|
/fs-fix-stop |
|
Fix agent disabled for this PR. Remove the |
PR Summary by QodoRemove obsolete OpenShell settle wait and align runner VM pins
AI Description
Diagram
High-Level Assessment
Files changed (5)
|
Code Review by Qodo
1.
|
|
🤖 Finished Review · ✅ Success · Started 5:12 PM UTC · Completed 5:21 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.38 |
|
Risk Assessment: moderate (2/5) DetailsModerate risk change removing a polling settle wait across 7 files with clean metadata signals, balanced by elevated churn and change coupling in CLI and runner scripts. Previous runRisk Assessment: moderate (2/5) DetailsModerate risk change removing a polling settle wait across 7 files with clean metadata signals, balanced by elevated churn and change coupling in CLI and runner scripts. |
ReviewFindingsLow
Previous runReviewFindingsLow
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
OpenShell 0.1.3 and later include NVIDIA/OpenShell#3819, so the supervisor's first settings poll no longer reloads policy and terminates connections in flight (NVIDIA/OpenShell#3809). With the pin at 0.1.4 (#8299), the 12 s wait before the GitHub pre-flight check is no longer needed. Local runs still on OpenShell 0.1.2 should upgrade to the pinned version. Signed-off-by: Wayne Sun <gsun@redhat.com> Assisted-by: Claude
The Renovate bump updates only .github/scripts/openshell-version.sh, so the fallback defaults in the VM provisioning scripts still said 0.1.2. Keep them in step with the pin file. The README and setup.sh also said a stale VM pin cannot stick, but executor/gateway.sh (called from prepare.sh) rejects a job image whose OpenShell version differs from the host pin. Say that, and that a VM must be re-provisioned with create-*-vm.sh --resume from an updated checkout after a bump. Assisted-by: Claude (fix), Claude (review) Signed-off-by: Wayne Sun <gsun@redhat.com>
73666c2 to
a2197f6
Compare
|
🤖 Review · ❌ Terminated · Started 11:59 PM UTC · Ended 12:07 AM UTC Commit: |
Validation on OpenShell 0.1.4 (head
|
Superseded by updated review
|
🤖 Finished Review · ✅ Success · Started 11:59 PM UTC · Completed 12:07 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.74 |
|
Closing in favour of #8531: the same change will come as a bot-authored PR, so it can be approved for v0.48.1. |
Summary
Follow-up to the OpenShell 0.1.4 bump (#8299).
openShellFirstPollSettle,internal/cli/openshell_settle.goand its test, and the wait before the GitHub pre-flight check inrun.go.hack/gitlab-runner-vm/{create-gcp-vm,create-openshift-vm,setup}.shstill defaulted to0.1.2when the pin file is absent; they now default to0.1.4.setup.shsaid a stale VM pin "cannot stick". In factexecutor/gateway.sh(run fromprepare.sh) fails a job whose image reports a different OpenShell version than the host pin. They now say that, and thatsetup.shmust be re-run after a bump.Testing
go build ./...,go vetandgo test ./internal/cli/pass.pre-commitpasses (gofmt, go vet, shellcheck, gitlint).I ran this branch as a real local
fullsend runon an OpenShell v0.1.4 gateway (podman), with--forge githuband thedummyruntime. It ran four times with no wait, and the pre-flight passed on the first attempt each time:No run printed
terminated, an EOF or a retry.The pre-flight finishes before the supervisor's first poll at about 10 s, so I also ran back-to-back requests from inside the sandbox across that window, starting as soon as
.envexisted:Stop/start on the #8299 head: the first
gh apicalls straight after Ready (no wait) all exited 0.