Skip to content

fix(#8504): include agents in default issue targets - #8588

Merged
waynesun09 merged 4 commits into
fullsend-ai:mainfrom
ederign:fix/8504-retro-issue-targets
Oct 21, 2026
Merged

waynesun09 merged 4 commits into
fullsend-ai:mainfrom
ederign:fix/8504-retro-issue-targets

Conversation

@ederign

@ederign ederign commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fresh GitHub installations currently allow cross-repository issues only in fullsend-ai/fullsend, so Retro proposals targeting fullsend-ai/agents are skipped. Include both repositories in eligible fresh GitHub defaults. Fresh GitLab installations instead receive an explicit empty cross-project policy (create_issues.allow_targets: {}), since GitHub repository names are not GitLab destinations. Preserve explicit permissions, preset inheritance, and established-install safeguards. Existing GitHub installations can opt in using the documented migration steps.

Related Issue

Fixes #8504

Changes

  • Share the default destinations between NewPerRepoConfig and managed config writeback, using named repository constants and a fresh slice for each call.
  • Cover generated YAML, managed persistence, CLI output, and preservation of custom or empty target lists. Test both GitLab managed writeback and fallback scaffold generation.
  • Update configuration and installation guides, including explicit migration guidance for existing installations.

Testing

  • Staged-file pre-commit checks pass (uvx --from pre-commit pre-commit run, the runner used by make lint).
  • Tests added/updated for modified logic; the complete config/repos/harness/CLI package suites pass with race detection.
  • make go-vet and the separate mintcore suite (go test -race -tags github ./...) pass.
  • Local coverage approximation: DefaultIssueCreationRepos, NewPerRepoConfig, and installDefaultsFor each have 100% function coverage in the focused regression profile.

make go-test ran but is not green on this macOS host. After correcting a stale CLI fixture, its focused integration tests pass. Remaining failures reproduce on the unchanged base (5fc4c47a1d40c2ab0a748e3bd2f7b9f8a697ca50): GitLab private-CA trust, runtime tests requiring flock/shell behavior, and scaffold release-pin architecture detection. A temporary-path assertion also reproduced on base and passes with canonical TMPDIR. No live Retro workflow was exercised.

The separate Retro change to keep summary publication running after issue-creation failures is tracked in fullsend-ai/agents#1716.

Checklist

  • PR title follows Conventional Commits; existing installation permissions are preserved.
  • Commit is signed off (DCO).
  • I wrote this contribution myself and can explain all changes in it.

Share fresh-install issue destinations between the per-repo generator
and managed config writeback. Include the agents repository while
preserving preset, explicit-setting and established-install safeguards.
Document explicit opt-in for existing installations.

Fixes fullsend-ai#8504

Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Include agents in fresh-install issue targets

🐞 Bug fix 🧪 Tests 📝 Documentation 🕐 20-40 Minutes

Grey Divider

AI Description

• Allow fresh installations to file cross-repository issues in both fullsend and agents.
• Share issue-target defaults while preserving explicit policies, presets, and existing-install
 safeguards.
• Extend regression coverage and document how existing installations can opt in.
Diagram

graph TD
  D["Issue target defaults"] --> G["Per-repo generator"] --> Y["Generated YAML"]
  D --> E{"Eligible first install?"} -- "yes" --> W["Manifest writeback"] --> O["Managed overlay"]
  E -- "no" --> P["Existing policy"]
Loading
High-Level Assessment

Sharing a function that returns a fresh slice keeps both default-producing paths consistent without changing the managed install eligibility checks. Duplicating the lists would risk divergence, while changing global configuration defaults would broaden permissions beyond fresh, eligible installations.

Files changed (13) +104 / -30

Bug fix (3) +19 / -11
config.goUse shared issue targets in per-repo generation +5/-3

Use shared issue targets in per-repo generation

• Defines the canonical agents repository and uses the shared default list when generating a targeted per-repo configuration.

internal/config/config.go

issue_targets.goProvide shared fresh-install issue targets +9/-0

Provide shared fresh-install issue targets

• Adds a function returning a new slice containing the fullsend and agents repositories for callers to use independently.

internal/config/issue_targets.go

managed_config_writeback.goShare defaults with managed manifest writeback +5/-8

Share defaults with managed manifest writeback

• Uses the shared issue-target list for eligible pristine installs and includes both repositories in writeback descriptions. Removes the former single-target constant.

internal/repos/managed_config_writeback.go

Tests (4) +48 / -11
repos_managed_config_test.goVerify CLI install output includes agents +4/-1

Verify CLI install output includes agents

• Updates managed-overlay assertions and checks that explicit settings remain unchanged while read-only manifest guidance names both targets.

internal/cli/repos_managed_config_test.go

config_test.goTest generated targets and slice independence +16/-3

Test generated targets and slice independence

• Checks both targets survive YAML round-tripping and that changing one generated configuration does not affect another.

internal/config/config_test.go

forge_test.goVerify harness configuration includes both targets +2/-2

Verify harness configuration includes both targets

• Updates the configuration-map expectation to include agents while continuing to exclude the implicitly allowed source repository.

internal/harness/forge_test.go

managed_config_writeback_test.goCover two-target writeback and policy preservation +26/-5

Cover two-target writeback and policy preservation

• Checks persisted defaults, dry-run output, and edit suggestions. Adds cases confirming custom and explicitly empty target lists are not widened.

internal/repos/managed_config_writeback_test.go

Documentation (6) +37 / -8
triage.mdClarify triage issue-target defaults +6/-1

Clarify triage issue-target defaults

• Names both upstream targets for fresh installations and links to opt-in guidance for existing installations.

docs/agents/triage.md

repos.mdUpdate repos install default in CLI reference +1/-1

Update repos install default in CLI reference

• Shows both repositories in the issue-target list written to eligible first-install manifest entries.

docs/cli/repos.md

migrating-from-github-setup.mdDocument existing-install opt-in +18/-2

Document existing-install opt-in

• Updates first-install examples and explains how managed, legacy, and preset-backed installations can explicitly permit issues in agents.

docs/guides/getting-started/migrating-from-github-setup.md

repo-management.mdUpdate managed-install writeback example +1/-1

Update managed-install writeback example

• Shows the two issue targets recorded for an eligible first installation.

docs/guides/getting-started/repo-management.md

config-reference.mdExplain issue-target permissions and migration +10/-2

Explain issue-target permissions and migration

• Adds agents to the example allowlist and distinguishes fresh-install defaults from explicit policies and existing-install permissions.

docs/reference/config-reference.md

managed.goClarify managed issue-target writeback comment +1/-1

Clarify managed issue-target writeback comment

• Updates the comment to describe multiple upstream permissions rather than a single upstream target.

internal/config/managed.go

@fullsend-ai-review

fullsend-ai-review Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 9:18 PM UTC · Completed 9:30 PM UTC

Commit: bfc5804 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.03

@qodo-code-review

qodo-code-review Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (1)

Grey Divider


Action required

1. Agent proposals fail token authorization ✗ Dismissed
Description
DefaultIssueCreationRepos adds fullsend-ai/agents, but the retro runner requests a GitHub App
token scoped only to the repository where the run originated. When an agent in another repository
proposes an issue for fullsend-ai/agents, the agents repo’s post-retro script passes the allowlist
check but uses that source-scoped token to create the label and issue in the agents repository.
Code

internal/config/issue_targets.go[8]

+	return []string{DefaultUpstreamRepo, DefaultAgentsRepo}
Relevance

●●● Strong

The new cross-repository target conflicts with source-scoped token provisioning, matching accepted
cross-project authorization findings.

PR-#7946
PR-#2277

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The PR grants the agents destination, while the workflow passes only the source repository name into
token minting. The agents post-script then attempts writes against the proposal’s target repository
using the runner’s GH_TOKEN.

fullsend -> agents
internal/config/issue_targets.go[3-8]
.github/workflows/reusable-dispatch.yml[1371-1377]
internal/cli/run.go[6975-7004]
External repo: fullsend-ai/agents, harness/retro.yaml [65-74]
External repo: fullsend-ai/agents, scripts/post-retro.src.sh [173-180]
External repo: fullsend-ai/agents, scripts/post-retro.src.sh [209-223]
External repo: fullsend-ai/agents, scripts/lib/github-retro-ops.lib.sh [61-70]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Fresh-install configuration permits issues in fullsend-ai/agents, but retro tokens remain scoped to the originating repository, so the agents post-script cannot create those issues.
## Fix Focus Areas
- internal/config/issue_targets.go[7-8]
- .github/workflows/reusable-dispatch.yml[1371-1377]
- internal/cli/run.go[6975-7004]
## Recommended Fix
Coordinate the new default with token minting: ensure the retro post-script receives a write-capable token scoped to fullsend-ai/agents when that destination is permitted, including the necessary App installation and mint policy. Keep the agents repo’s label and issue creation calls working with that token.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Informational

2. Migration steps are buried in prose 📜 Skill insight ✧ Quality
Description
The Permit agent improvement proposals on existing installations section buries the configuration
edit and fullsend repos install command in an unnumbered paragraph that starts with context rather
than actions. Readers must extract the edit, preservation requirement, install command, and legacy
setup alternative from the prose before they can complete the migration.
Code

docs/guides/getting-started/migrating-from-github-setup.md[R480-487]

+To let retro file agent-layer proposals from an existing managed installation,
+add `fullsend-ai/agents` to the existing
+`config.create_issues.allow_targets.repos` list in the repository’s `repos.yaml`
+entry (or the manifest layer that owns that policy), then run `fullsend repos
+install` for that repository. Keep any existing targets; this is an explicit
+permission change. For an installation still using `github setup`, edit its
+`.fullsend/config.yaml` instead. If a preset owns the setting, update that policy
+explicitly rather than relying on the new installation default.
Relevance

● Weak

Similar requests to reformat prose into numbered procedural steps were rejected as stylistic
overreach.

PR-#5997
PR-#3383

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The added migration guidance starts with To let... and presents the configuration edit and
fullsend repos install command later in the paragraph. Its multiple actions and caveats appear in
prose rather than numbered, action-first steps, supporting both findings.

docs/guides/getting-started/migrating-from-github-setup.md[480-487]
docs/guides/getting-started/migrating-from-github-setup.md[480-484]
Skill: writing-user-docs

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The migration guidance puts context before the actions and combines several procedural actions in an unnumbered paragraph, making the sequence harder to follow.

## Fix Focus Areas
- docs/guides/getting-started/migrating-from-github-setup.md[480-487]

## Recommended Fix
Rewrite the guidance as a numbered list with one actionable step per item. Start each step with the concrete edit or command, including adding `fullsend-ai/agents` and running `fullsend repos install`, then place the rationale and existing caveats, including the preservation requirement and legacy setup alternative, after the relevant action.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


Grey Divider

Context sources
✅ Compliance rules (platform): 88 rules
✅ Skills: 5 invoked
  writing-user-docs
  writing-adrs
  check-patch-coverage
  cutting-releases
  adr-corner
✅ Cross-repo context — repo relationships
  Explored: repo: fullsend-ai/agents (sha: ac4082a3) — View relationship
  Explored: repo: fullsend-ai/.fullsend (sha: ed8c16fb) — View relationship
Review mode: Auto: ⚖️ Balanced: Permission defaults affect issue-target authorization across configuration and installation paths.

Grey Divider

Tip of the day
💡 Did you know, you can start a comment with 'qodo' or '@qodo' to chat about any finding

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment thread internal/config/issue_targets.go Resolved
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Site preview

Preview: https://2991fe03-site.fullsend-ai.workers.dev

Commit: ecf264b335df284adfbd3d70f093f5775afdf332

@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/repos/install.go 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Oct 19, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Moderate risk score of 2 reflects a well-scoped change to fresh-install issue targets with full acceptance criteria coverage and tests, preserved from prior review after minor documentation updates, balanced against elevated recent churn and multi-author contention in modified configuration packages.

Previous run

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Moderate risk score of 2 reflects a well-scoped change to fresh-install issue targets with full acceptance criteria coverage and tests, balanced against elevated recent churn and multi-author contention in modified configuration packages.

Previous run (2)

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Moderate risk score of 2 reflects a focused, well-scoped change to fresh-install issue targets with full acceptance criteria coverage and tests, balanced against high recent churn and multi-author contention in modified configuration modules.

@fullsend-ai-review

fullsend-ai-review Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review

Findings

Low

  • [permission-expansion] internal/config/config.go:753 — The generated issue-creation policy adds fullsend-ai/agents alongside fullsend-ai/fullsend, widening the destinations eligible for cross-repository issue creation. Issue Include fullsend-ai/agents in default create_issues.allow_targets for per-repo scaffold and config generator #8504 explicitly authorizes this, and the managed path checks preset declaration, explicit create_issues policy, overlay existence and pristine-install state before adding defaults. The docs-only change since the prior review does not alter this grant.
    Remediation: none required; informational.

  • [permission-reduction] internal/repos/install.go:631 — Fresh GitLab scaffold generation intentionally replaces the GitHub upstream issue targets with an explicit empty cross-project policy; the managed writeback path does the same. Explicit, existing and preset-backed configurations take separate branches. The new migration guidance explains that existing installations keep the old target until an operator removes it.
    Remediation: none required; informational.

Previous run

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJwZXJtaXNzaW9uLWV4cGFuc2lvbiIsImZpbGUiOiJpbnRlcm5hbC9jb25maWcvY29uZmlnLmdvIiwiaWQiOiJmX2E2YjU5ZDM3ZjM3ZTY4MWEiLCJsaW5lIjo3NTMsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJwZXJtaXNzaW9uLXJlZHVjdGlvbiIsImZpbGUiOiJpbnRlcm5hbC9yZXBvcy9pbnN0YWxsLmdvIiwiaWQiOiJmX2E3YWRiZDI4NTc5NDRjODAiLCJsaW5lIjo2MzEsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJwZXJtaXNzaW9uLWV4cGFuc2lvbiIsImZpbGUiOiJpbnRlcm5hbC9jb25maWcvaXNzdWVfdGFyZ2V0cy5nbyIsImlkIjoiZl83OWRiZjQ0MjZjOTI4NzJhIiwibGluZSI6OCwiYWN0aW9uYWJsZSI6ZmFsc2V9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfNzlkYmY0NDI2YzkyODcyYSIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9XX0= -->

Review

Findings

Low

  • [permission-expansion] internal/config/config.go:753 — Generated GitHub config now also allows cross-repository issue creation in fullsend-ai/agents. Issue Include fullsend-ai/agents in default create_issues.allow_targets for per-repo scaffold and config generator #8504 requests exactly this narrow expansion; no wildcard or org-wide grant is added, and the writeback applies it only when no explicit policy, preset, overlay/base, or established installation exists. Informational.
  • [permission-reduction] internal/repos/install.go:631 — Generated GitLab config now records an explicit empty cross-project policy instead of the GitHub upstream target. The empty policy is preserved through accessors and managed-layer merging. The post-scripts' handling of allow_targets: {} could not be verified from the supplied checkouts. Informational.
Previous run (2)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJwZXJtaXNzaW9uLWV4cGFuc2lvbiIsImZpbGUiOiJpbnRlcm5hbC9jb25maWcvaXNzdWVfdGFyZ2V0cy5nbyIsImlkIjoiZl83OWRiZjQ0MjZjOTI4NzJhIiwibGluZSI6OCwiYWN0aW9uYWJsZSI6ZmFsc2V9XX0= -->

Review

Findings

Low

  • [permission-expansion] internal/config/issue_targets.go:8 — Fresh-install defaults now also permit cross-repository issue creation in fullsend-ai/agents, in addition to fullsend-ai/fullsend. The expansion is narrowly scoped and is explicitly requested by linked issue Include fullsend-ai/agents in default create_issues.allow_targets for per-repo scaffold and config generator #8504. In internal/repos/managed_config_writeback.go the default is applied only after the checks for a declared preset, an explicit create_issues setting (including an empty list), an existing overlay, and an established installation. Runtime code defaults still return nil, so upgrading alone does not add the new target to existing configurations. End-to-end enforcement by scripts/post-retro.sh and triage could not be checked, because those scripts are not in this checkout. Human confirmation of the permission widening is still worthwhile.

Labels: PR changes install-time config defaults and the related user documentation.

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge component/install CLI install and app setup component/docs User-facing documentation labels Oct 19, 2026
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 9:20 PM UTC · Completed 9:30 PM UTC

Commit: baa16ae · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.26

@fullsend-ai-review fullsend-ai-review Bot removed the ready-for-merge All reviewers approved — ready to merge label Oct 20, 2026
fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review
fullsend-ai-review Bot dismissed their stale review October 20, 2026 21:29

Superseded by updated review

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Oct 20, 2026
Comment thread docs/reference/config-reference.md Resolved
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:14 AM UTC · Completed 11:25 AM UTC

Commit: ecf264b · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.30

@fullsend-ai-review fullsend-ai-review Bot removed the ready-for-merge All reviewers approved — ready to merge label Oct 21, 2026
Comment thread internal/config/config.go Resolved
Comment thread internal/repos/install.go Resolved
@fullsend-ai-review
fullsend-ai-review Bot dismissed their stale review October 21, 2026 11:25

Superseded by updated review

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Oct 21, 2026

@waynesun09 waynesun09 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Reviewed with Codex and Claude; no MEDIUM+ findings. Two LOW nits (GitLab dry-run line prints repos: [] vs the persisted allow_targets: {}; no end-to-end GitLab CLI drift test) can be follow-ups.

@waynesun09
waynesun09 added this pull request to the merge queue Oct 21, 2026
Merged via the queue into fullsend-ai:main with commit e257ad6 Oct 21, 2026
122 checks passed

This branch was successfully deployed

1 active and 1 inactive deployments
site-preview — ecf264b3 Deployed Oct 21, 2026 by github-actions[bot]
dev — ecf264b3 Deployed Oct 21, 2026 by ederign via behaviour #17471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/docs User-facing documentation component/install CLI install and app setup ready-for-merge All reviewers approved — ready to merge risk/moderate PR risk: moderate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include fullsend-ai/agents in default create_issues.allow_targets for per-repo scaffold and config generator

3 participants