Repository navigation
fix(#8504): include agents in default issue targets - #8588
Conversation
Share fresh-install issue destinations between the per-repo generator and managed config writeback. Include the agents repository while preserving preset, explicit-setting and established-install safeguards. Document explicit opt-in for existing installations. Fixes fullsend-ai#8504 Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
PR Summary by QodoInclude agents in fresh-install issue targets
AI Description
Diagram
High-Level Assessment
Files changed (13)
|
|
🤖 Finished Review · ✅ Success · Started 9:18 PM UTC · Completed 9:30 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.03 |
Code Review by Qodo
1.
|
Site previewPreview: https://2991fe03-site.fullsend-ai.workers.dev Commit: |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
<!-- fullsend:risk-assessment --> DetailsModerate risk score of 2 reflects a well-scoped change to fresh-install issue targets with full acceptance criteria coverage and tests, preserved from prior review after minor documentation updates, balanced against elevated recent churn and multi-author contention in modified configuration packages. Previous run<!-- fullsend:risk-assessment --> DetailsModerate risk score of 2 reflects a well-scoped change to fresh-install issue targets with full acceptance criteria coverage and tests, balanced against elevated recent churn and multi-author contention in modified configuration packages. Previous run (2)<!-- fullsend:risk-assessment --> DetailsModerate risk score of 2 reflects a focused, well-scoped change to fresh-install issue targets with full acceptance criteria coverage and tests, balanced against high recent churn and multi-author contention in modified configuration modules. |
ReviewFindingsLow
Previous run<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJwZXJtaXNzaW9uLWV4cGFuc2lvbiIsImZpbGUiOiJpbnRlcm5hbC9jb25maWcvY29uZmlnLmdvIiwiaWQiOiJmX2E2YjU5ZDM3ZjM3ZTY4MWEiLCJsaW5lIjo3NTMsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJwZXJtaXNzaW9uLXJlZHVjdGlvbiIsImZpbGUiOiJpbnRlcm5hbC9yZXBvcy9pbnN0YWxsLmdvIiwiaWQiOiJmX2E3YWRiZDI4NTc5NDRjODAiLCJsaW5lIjo2MzEsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJwZXJtaXNzaW9uLWV4cGFuc2lvbiIsImZpbGUiOiJpbnRlcm5hbC9jb25maWcvaXNzdWVfdGFyZ2V0cy5nbyIsImlkIjoiZl83OWRiZjQ0MjZjOTI4NzJhIiwibGluZSI6OCwiYWN0aW9uYWJsZSI6ZmFsc2V9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfNzlkYmY0NDI2YzkyODcyYSIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9XX0= --> ReviewFindingsLow
Previous run (2)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJwZXJtaXNzaW9uLWV4cGFuc2lvbiIsImZpbGUiOiJpbnRlcm5hbC9jb25maWcvaXNzdWVfdGFyZ2V0cy5nbyIsImlkIjoiZl83OWRiZjQ0MjZjOTI4NzJhIiwibGluZSI6OCwiYWN0aW9uYWJsZSI6ZmFsc2V9XX0= --> ReviewFindingsLow
Labels: PR changes install-time config defaults and the related user documentation. |
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
|
🤖 Finished Review · ✅ Success · Started 9:20 PM UTC · Completed 9:30 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.26 |
Superseded by updated review
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
|
🤖 Finished Review · ✅ Success · Started 11:14 AM UTC · Completed 11:25 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.30 |
Superseded by updated review
waynesun09
left a comment
There was a problem hiding this comment.
LGTM. Reviewed with Codex and Claude; no MEDIUM+ findings. Two LOW nits (GitLab dry-run line prints repos: [] vs the persisted allow_targets: {}; no end-to-end GitLab CLI drift test) can be follow-ups.
Summary
Fresh GitHub installations currently allow cross-repository issues only in
fullsend-ai/fullsend, so Retro proposals targetingfullsend-ai/agentsare skipped. Include both repositories in eligible fresh GitHub defaults. Fresh GitLab installations instead receive an explicit empty cross-project policy (create_issues.allow_targets: {}), since GitHub repository names are not GitLab destinations. Preserve explicit permissions, preset inheritance, and established-install safeguards. Existing GitHub installations can opt in using the documented migration steps.Related Issue
Fixes #8504
Changes
NewPerRepoConfigand managed config writeback, using named repository constants and a fresh slice for each call.Testing
uvx --from pre-commit pre-commit run, the runner used bymake lint).make go-vetand the separate mintcore suite (go test -race -tags github ./...) pass.DefaultIssueCreationRepos,NewPerRepoConfig, andinstallDefaultsForeach have 100% function coverage in the focused regression profile.make go-testran but is not green on this macOS host. After correcting a stale CLI fixture, its focused integration tests pass. Remaining failures reproduce on the unchanged base (5fc4c47a1d40c2ab0a748e3bd2f7b9f8a697ca50): GitLab private-CA trust, runtime tests requiringflock/shell behavior, and scaffold release-pin architecture detection. A temporary-path assertion also reproduced on base and passes with canonicalTMPDIR. No live Retro workflow was exercised.The separate Retro change to keep summary publication running after issue-creation failures is tracked in fullsend-ai/agents#1716.
Checklist