Repository navigation
fix(#8575)!: harden and tidy the .env-as-data launch loader - #8591
Conversation
Follow-ups from the #8565 reviews of the loader that reads the agent-writable .env as data (internal/runtime/env_data.go). Loader: - A value containing a NUL byte is dropped with a warning naming the file and line, like every other dropped line, instead of silently at output time. - An .env.d directory that exists but cannot be listed (or whose files cannot be stat'ed) now records the error and fails the launch, as an unreadable .env.d file already did; a missing directory is still read as empty. - A rejected statement whose quotes span lines is skipped to where a shell would end it, so lines inside its value are no longer parsed as assignments. An unterminated quote still falls back to the line end. - python3 is pinned with `command -p -v python3` first, falling back to `command -v python3`, so a python3 early on the launch PATH is not used when the default PATH has one (new binaryPinLookup helper). - The loader script takes FULLSEND_RUNNER_PATH from envDataRunnerPathVar instead of spelling it out. Tests: a planted re/ package in the working directory and on PYTHONPATH is not imported; LD_*, BASH_ENV and ENV from .env.d, iteration.env and a separate `export NAME` line are dropped; NUL values; the built pi launch run end to end with a stub pi; the control-lines test no longer depends on harnessEnvLines()[0]; the Claude hooks launch test skips where /bin/sh rejects `unset -f [` (bash 3.2 on macOS). Codex golden launch files regenerated. Docs: claude.md says the image needs python3; codex.md, the ADR 0100 implementation note and the envDataLoad comment no longer say only `export` lines are evaluated; the harness reference lists the shell forms the loader drops (${NAME:-default}, export A=1 B=2, FOO=x; export FOO); stale `. .env` comments in claude.go and pi_run.go updated. Not done here: limiting $NAME expansion and replacing the drop denylist with an allowlist both change what existing .env.d files get and need a maintainer design decision. Note: pre-commit could not fetch its remote hook repos (TLS failure in the sandbox); gofmt, go vet, the ADR lints, broken symlinks, docs-links, lychee and whitespace checks were run directly and pass. Unrelated tests that fail on main in this sandbox too: TestBuildRunCommand_ClaudeMissingExits127 (a real claude is in /usr/bin), TestStartFetchService_* and TestPostScriptEnv_NoSchema* in internal/cli. Related to #8575 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🤖 Finished Review · ✅ Success · Started 9:46 PM UTC · Completed 9:58 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.51 |
Site previewPreview: https://05576bb2-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
<!-- fullsend:risk-assessment --> DetailsModerate risk: the PR modifies existing launch behavior without a feature flag across 19 files in an area of recent churn, but closely matches the linked hardening issue and touches no protected or security-sensitive paths. Previous run<!-- fullsend:risk-assessment --> DetailsModerate risk: the PR modifies existing launch behavior without a feature flag across 18 files in an area of recent churn, but closely matches the linked hardening issue and touches no protected or security-sensitive paths. Previous run (2)<!-- fullsend:risk-assessment --> DetailsModerate risk: the PR modifies existing launch behavior without a feature flag across 17 files in an area of recent churn, but closely matches the linked hardening issue and touches no protected or security-sensitive paths. Previous run (3)<!-- fullsend:risk-assessment --> DetailsModerate risk: the PR modifies existing launch behavior without a feature flag across 17 files in an area of recent churn, but closely matches the linked hardening issue and touches no protected or security-sensitive paths. |
ReviewFindingsLow
Earlier findings
Previous run<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJjb21tZW50IiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9ydW50aW1lL2Vudl9kYXRhLmdvIiwiaWQiOiJmX2ZhYTU5NTBmZmZiYjViZmMiLCJsaW5lIjoxMzQsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9ydW50aW1lL2Vudl9kYXRhLmdvIiwiaWQiOiJmXzdiZWVhMTY1YjI4M2Q0YjQiLCJsaW5lIjozMTgsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9ydW50aW1lL2Vudl9kYXRhLmdvIiwiaWQiOiJmXzViYzc5ZGM1YTk1ZjVjN2QiLCJsaW5lIjoyOTMsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJzdGFsZS1kb2MiLCJmaWxlIjoiZG9jcy9jb250cmlidXRpbmcvcnVudGltZS1pbXBsZW1lbnRhdGlvbi5tZCIsImlkIjoiZl8zZmM3NDc5NmRlMjU0NzlmIiwibGluZSI6ODg4LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoibWlzbGVhZGluZy1sYWJlbCIsImZpbGUiOiJpbnRlcm5hbC9ydW50aW1lL2Vudl9kYXRhLmdvIiwiaWQiOiJmX2E5NDA3NzVkY2MyMTU1YjIiLCJsaW5lIjoxMjAsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9ydW50aW1lL2Vudl9kYXRhLmdvIiwiaWQiOiJmX2QwNmZhODFjOGU4ZTkzNTAiLCJsaW5lIjoyNTQsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9ydW50aW1lL2Vudl9kYXRhLmdvIiwiaWQiOiJmXzU4NTI4YjRlNDgwZTUzNTIiLCJsaW5lIjoxMDUsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9ydW50aW1lL2Vudl9kYXRhLmdvIiwiaWQiOiJmXzA0ZmU3MTg0N2ZiMzRkODYiLCJsaW5lIjoyNDgsImFjdGlvbmFibGUiOnRydWV9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfN2JlZWExNjViMjgzZDRiNCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl8zZmM3NDc5NmRlMjU0NzlmIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2QwNmZhODFjOGU4ZTkzNTAiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifSx7ImlkIjoiZl81ODUyOGI0ZTQ4MGU1MzUyIiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfMDRmZTcxODQ3ZmIzNGQ4NiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= --> ReviewFindingsMedium
Low
Previous run (2)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9ydW50aW1lL2Vudl9kYXRhLmdvIiwiaWQiOiJmX2QwNmZhODFjOGU4ZTkzNTAiLCJsaW5lIjoyNTQsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9ydW50aW1lL2Vudl9kYXRhLmdvIiwiaWQiOiJmXzdiZWVhMTY1YjI4M2Q0YjQiLCJsaW5lIjoyODUsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJpbmplY3Rpb24tdnVsbiIsImZpbGUiOiJpbnRlcm5hbC9ydW50aW1lL2Vudl9kYXRhLmdvIiwiaWQiOiJmXzU4NTI4YjRlNDgwZTUzNTIiLCJsaW5lIjoxMDUsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJzdGFsZS1kb2MiLCJmaWxlIjoiZG9jcy9jb250cmlidXRpbmcvcnVudGltZS1pbXBsZW1lbnRhdGlvbi5tZCIsImlkIjoiZl8zZmM3NDc5NmRlMjU0NzlmIiwibGluZSI6ODg4LCJhY3Rpb25hYmxlIjpmYWxzZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoibG9naWMtZXJyb3IiLCJmaWxlIjoiaW50ZXJuYWwvcnVudGltZS9lbnZfZGF0YS5nbyIsImlkIjoiZl8wNGZlNzE4NDdmYjM0ZDg2IiwibGluZSI6MjQ4LCJhY3Rpb25hYmxlIjp0cnVlfV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzA0ZmU3MTg0N2ZiMzRkODYiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8zZmM3NDc5NmRlMjU0NzlmIiwic3RhdHVzIjoib3BlbiJ9XX0= --> ReviewFindingsLow
Earlier findings
Previous run (3)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImludGVybmFsL3J1bnRpbWUvZW52X2RhdGEuZ28iLCJpZCI6ImZfMDRmZTcxODQ3ZmIzNGQ4NiIsImxpbmUiOjI0OCwiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5Ijoic3RhbGUtZG9jIiwiZmlsZSI6ImRvY3MvY29udHJpYnV0aW5nL3J1bnRpbWUtaW1wbGVtZW50YXRpb24ubWQiLCJpZCI6ImZfM2ZjNzQ3OTZkZTI1NDc5ZiIsImxpbmUiOjg4OCwiYWN0aW9uYWJsZSI6ZmFsc2V9XX0= --> ReviewFindingsLow
Next steps:
|
|
🤖 Finished Fix · ✅ Success · Started 10:00 PM UTC · Completed 10:06 PM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.41 |
…tement
skip_statement closed a double-quoted value at the first inner quote, even
inside ${...} or $(...), so a rejected multi-line statement could resync
inside its own value and load a later line as an assignment. Track a stack
of quote/expansion contexts instead. Regression case added next to
TestEnvDataLoad_RejectedMultiLineStatementSkippedWhole; its first case is
made well-formed (closing brace). Golden launch scripts regenerated.
Addresses review feedback on PR #8591.
Not changed: the docs/contributing/runtime-implementation.md 'sourced'
wording (advisory, pre-existing, outside this PR's diff).
Notes: pre-commit could not fetch hook repos (TLS failure); gofmt, go vet and
git diff --check were run directly. TestBuildRunCommand_ClaudeMissingExits127
fails in this sandbox on the base commit too.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🔧 Fix agent — iteration 1 (bot-triggered)Fixed the nested-quote resync gap in skip_statement with a regression test and regenerated golden files. Left the advisory stale-doc finding for a follow-up because it is pre-existing and outside this PR's diff. Fixed (1):
Disagreed (1):
Tests: passed CI inspections (6):
Decision points
Next steps:
|
|
🤖 Finished Review · ✅ Success · Started 10:08 PM UTC · Completed 10:17 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.90 |
Superseded by updated review
|
/fs-fix-stop |
|
Fix agent disabled for this PR. Remove the |
The loader's python3 pin looked on the system default PATH first and fell back to the launch PATH. Pin it from a trusted PATH instead: before .env is read, the launch records the PATH without any directory the agent user can write (or that has a writable ancestor) and without relative entries, and takes the first python3 there whose resolved file and parent directories the agent cannot write either, so a protected bin directory holding a symlink to an agent-owned interpreter is skipped. The resolved path is pinned; with none the launch stops with exit 127. Under root nothing could be protected, so the PATH is kept as is. Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
|
🤖 Finished Review · ✅ Success · Started 11:31 PM UTC · Completed 11:44 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.44 |
Superseded by updated review
The interpreter lookup resolved python3 with the first readlink on the trusted PATH, and a protected directory can still hold a readlink that links into a directory the agent user writes. Take the first readlink on the trusted PATH that is a regular file the agent user neither owns nor can write, and run it with only the trusted PATH. A symlink is refused, because its target's directories cannot be checked without running something first. Without one, the launch says so and stops with the python3 message (exit 127). Record each trusted PATH entry as its physical directory (cd -P), so a symlinked entry is judged by the directories it really lives in, and leave out one whose physical path holds a colon, which would split. Document the readlink requirement next to the python3 one, and update two stale lines in the runtime implementation guide. BREAKING CHANGE: a non-root sandbox launch now needs python3 and a regular-file readlink in PATH directories the sandbox user neither owns nor can write (a virtualenv or a $HOME-managed interpreter does not count). Without them the launch exits 127 with "python3 not found in a PATH directory the agent cannot write". The fullsend sandbox image meets this; a custom image whose only python3 or readlink lives in a sandbox-owned directory, or whose readlink is a symlink (BusyBox-style), needs a root-owned python3 and coreutils readlink on PATH. Assisted-by: Claude (fix), Codex (review) Signed-off-by: Wayne Sun <gsun@redhat.com>
|
🤖 Finished Review · ✅ Success · Started 4:03 AM UTC · Completed 4:14 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.78 |
There was a problem hiding this comment.
Note: The following review comments could not be posted on the diff (GitHub returned 422) and are included here instead:
internal/runtime/env_data.go(file-level): Line 337 ·
[low] logic-error
A rejected NUL-containing assignment can still change whether an earlier value is exported. For example, A=private followed by export A='x<NUL>y' warns and preserves private, but statement() then adds A to exported, so the earlier shell-local value is exported to the CLI. The rejected statement is not fully dropped.
Suggested fix: Have assign report whether it accepted the assignment and update exported only on success; add a regression test with a plain assignment followed by a rejected NUL-containing export.
…usted PATH The claude, codex, pi and OpenCode launches found their CLI with a bare `command -v` on the launch PATH. A sandbox image can put a directory the agent user owns first on PATH, so the launch could start a CLI the agent planted there. pi's CLI and codex's npm launcher start with `#!/usr/bin/env node`, so their node was looked up on whatever PATH the launch shell had after .env was read. Since fullsend-ai#8591 the loader's python3 follows a stricter rule, and the CLI pins now follow it too: - envDataBinaryPin generalises the python3 lookup. It takes the first name on FULLSEND_TRUSTED_PATH, resolves it with the pinned readlink, walks the resolved path for agent-writable or agent-owned ancestors, and pins the resolved path read-only. With none it exits 127 with "fullsend: <cli> not found in a PATH directory the agent cannot write". As root it takes the first match. - envDataTrustedPin records FULLSEND_TRUSTED_PATH and a new read-only FULLSEND_READLINK once per launch. binaryPin runs it before the CLI pin, and envDataLoad now pins only python3, so no launch runs a second `readonly` of the same name (which aborts dash). EnvDataLoad and the codex and OpenCode env-read probes, which have no CLI pin, run envDataTrustedPin themselves. - binaryPin reads the pinned CLI's first line with the `read` builtin. For `#!/usr/bin/env node` it pins node by the same rule, and the launch runs `"$NODE" "$CLI"` (cliLaunch); otherwise the node pin is empty and the CLI starts as before. The PATH the CLI and its tools inherit is unchanged. The new FULLSEND_<RUNTIME>_NODE pins are on each launch's .env drop list, like the other pins. Tests run the pins under /bin/sh and dash as a non-root user. An agent-writable CLI or node earlier on PATH is not pinned, a protected symlink into an agent-writable directory is refused, and with no qualifying file the launch exits 127. Replacing the trusted-PATH lookup with `command -v` fails all 24 of those subtests. Existing launch tests mark their stub directories protected through a `test` shell function, as env_data_test.go already does. The codex goldens are regenerated. The runtime docs state the new requirement. Note: `pre-commit run` could not fetch its remote hook repositories in the sandbox (TLS failure). The local hooks (gofmt, go vet, broken-symlinks, docs-links, lychee) and the pre-commit-hooks v6.0.0 hooks were run directly and passed. gitleaks was covered by scan-secrets. BREAKING CHANGE: a custom sandbox image whose claude, codex, pi or opencode CLI, or the node that runs a `#!/usr/bin/env node` CLI, is found only through a PATH directory the sandbox user owns or can write (or through a symlink into one) now fails the launch with exit 127. Install the CLI and node in a directory the sandbox user cannot write. Closes fullsend-ai#8626 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
Hardens and tidies the launch loader that reads the agent-writable
.envas data (internal/runtime/env_data.go). These are the follow-ups from the #8565 reviews: loader fixes, the missing tests, and doc and comment corrections.Related Issue
Follow-ups from #8565 / #8498. Two items are left for a maintainer decision (see below), so this PR does not close the issue.
Changes
Loader (
env_data.go,binary_pin.go).env.d: a directory that exists but can't be listed (or whose entries can't be stat'ed, e.g. mode 000 or 0644) now records the error infailedand fails the launch, the same as an unreadable.env.dfile already does. A missing directory is still read as empty.FULLSEND_TRUSTED_PATH: the launch PATH without relative entries, each entry recorded as its physical directory (cd -P), and without any directory the agent user owns or can write (checking every directory above it too). It then pins the firstpython3on that PATH whose resolved file, and every directory above it, passes the same check, resolving symlinks with the firstreadlinkon that PATH that is a regular file the agent user neither owns nor can write, run with only that PATH. The resolved path is pinned. With no suchpython3(orreadlink) the launch stops with exit 127 and says why. As root the PATH is used unchanged.FULLSEND_TRUSTED_PATHis read-only and never taken from.env.FULLSEND_RUNNER_PATH: the loader script now takes the name fromenvDataRunnerPathVar(Go constant concatenation) instead of hardcoding it. The tautological test that only kept the two in step is removed.Tests
-Ibehaviour test: a plantedre/package in the working directory and onPYTHONPATHis not imported.LD_*,BASH_ENVandENVset from.env.d,iteration.env, and via a separateexport NAMEline are all dropped..env.d, and the python3 pin (agent-writable and agent-owned PATH directories, relative and empty entries, a symlinkedreadlink, a symlinked PATH entry, areadlinkthat looks up a helper on PATH, and the exit-127 path). All fail on the old loader.TestBuildPiRunCommand_LoaderEnvHygieneRunsruns the built pi launch under/bin/shwith a stub pi. Positive controls prove the.env,.env.danditeration.envreads ran.TestEnvDataControlLinesMatchRunnerchecks each control line exactly, and checks that the runner writes them in order, without indexing intoharnessEnvLines().TestClaudeLaunch_RefusesHooksChangedBetweenIterationsskips when/bin/shrejectsunset -f [(bash 3.2 on macOS).Docs and comments
docs/runtimes/claude.md: the image needspython3on every Claude run.docs/runtimes/codex.mdand the ADR 0100 implementation note: the launch evals[export ]NAME='value'lines, not onlyexportlines. This is a minor wording fix to an implementation note on an Accepted ADR; Context, Decision and Consequences are untouched.docs/reference/harness-reference.mdandcustomizing-agents.mdlist the shell forms the loader drops (${NAME:-default},export A=1 B=2,FOO=x; export FOO, NUL values), and note that an unreadable.env.dfails the launch. This follows triage's suggested default of documenting these forms rather than supporting them.. .env" comments inclaude.go,pi_run.goandbinary_pin.goupdated, plus theenvDataLoadcomment.Already done on main (no change needed): path escaping in warnings (
%r, with an existing test),envDataRunnerPathVarinside theconstblock with a doc comment, andruntime-implementation.mdlistingPYTHON*.Not done here; left for a maintainer decision:
$NAMEexpansion to names.envdefines plusHOME/PATH: existing.env.dfiles that reference other launch variables (e.g.$SSL_CERT_FILE) would silently get empty values.plugin_spec.goalso coversPATH,HOME,GIT_*and*_TOKEN, which.envlegitimately sets, so aligning the two needs its own design.TestBuildRunCommand_GatewayReadonlyIgnoredgets no skip. Its launch on main only runsunset -f claude(no[), so the bash-3.2 cause does not apply. The likely macOS failure iscommand -p flockin the gateway credential seed.Breaking change
A non-root sandbox launch now needs
python3and a regular-filereadlinkinPATHdirectories the sandbox user neither owns nor can write (a virtualenv or a$HOME-managed interpreter does not count). Without them the launch exits 127 withpython3 not found in a PATH directory the agent cannot write. The fullsend sandbox image meets this. A custom image whose onlypython3orreadlinklives in a sandbox-owned directory, or whosereadlinkis a symlink (BusyBox-style), needs a root-ownedpython3and coreutilsreadlinkonPATH.Testing
go test ./internal/runtime/... ./internal/security/...as a non-root user on Linux (Debian,/bin/sh= dash; the earlier pin commits also on Fedora 44,/bin/sh= bash 5), and the pin fragment run in the fleet sandbox image assandbox(pins/usr/bin/python3.12, leaves the sandbox-owned venvbinoff the trusted PATH, exits 127 when no other directory is on PATH).go test ./internal/runtime/... ./internal/cli/...pass, except tests that fail on main in this sandbox too:TestBuildRunCommand_ClaudeMissingExits127(a realclaudeis in/usr/binhere),TestStartFetchService_*andTestPostScriptEnv_NoSchema*.make lint:pre-commitcould not fetch its remote hook repos (TLS failure in the sandbox). gofmt,go vet ./..., the ADR status/number/frontmatter lints, broken-symlinks, docs-links, lychee and whitespace checks were run directly and pass; gitlint passes on the commit.Checklist
!for breaking changes)🤖 Generated with Claude Code
Related to #8575
Post-script verification
agent/8575-harden-env-data-loader)5fc4c47a1d40c2ab0a748e3bd2f7b9f8a697ca50..HEAD)