Repository navigation
docs(adr): define selective CEL acquisition and harness admission - #8694
Conversation
PR Summary by QodoDefine selective entity CEL evaluation and bounded actor-role reuse
AI Description
Diagram
High-Level Assessment
Files changed (12)
|
|
🤖 Finished Review · ✅ Success · Started 8:26 AM UTC · Completed 8:48 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.18 |
Code Review by Qodo
1. Disabled entity checks look available
|
Site previewPreview: https://020921e0-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
<!-- fullsend:risk-assessment --> DetailsDocumentation-only architectural change adding ADRs and normative specifications with low metadata risk and aligned issue scope, moderately elevated by recent churn across shared documentation files. Previous run<!-- fullsend:risk-assessment --> DetailsDocumentation-only architectural change adding ADRs and normative specifications with low metadata risk and aligned issue scope, moderately elevated to score 2 by large change size and recent churn across shared documentation files. Previous run (2)<!-- fullsend:risk-assessment --> DetailsDocumentation-only architectural change adding ADRs and normative specifications with low metadata risk and aligned issue scope, moderately elevated to score 2 by large change size and recent churn across shared documentation files. Previous run (3)<!-- fullsend:risk-assessment --> DetailsDocumentation-only architectural change adding ADRs and normative specifications with low metadata risk and aligned issue scope, moderately elevated to score 2 by large change size and recent churn across shared documentation files. Previous run (4)<!-- fullsend:risk-assessment --> DetailsDocumentation-only architectural change adding ADRs and normative specifications with low metadata risk and aligned issue scope, moderately elevated by large change size and recent churn across shared documentation files. Previous run (5)<!-- fullsend:risk-assessment --> DetailsDocumentation-only architectural change adding ADRs and normative specifications with low metadata risk and aligned issue scope, moderately elevated by large change size and recent churn across shared documentation files. Previous run (6)<!-- fullsend:risk-assessment --> DetailsDocumentation-only architectural change adding ADRs and normative specifications with low metadata risk and aligned issue scope, moderately elevated by recent churn across shared documentation files. |
|
Looks good to me Earlier findings
Previous run<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5Ijoic3RhbGUtZG9jIiwiZmlsZSI6ImRvY3Mvbm9ybWF0aXZlL25vcm1hbGl6ZWQtZXZlbnQvdjEvUkVBRE1FLm1kIiwiaWQiOiJmXzk3NzJlMzEzZDFjMDhjODEiLCJsaW5lIjoyMSwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6InBlcm1pc3Npb24tZXhwYW5zaW9uIiwiZmlsZSI6ImRvY3Mvbm9ybWF0aXZlL2F1dGhvcml6YXRpb24vdjIvUkVBRE1FLm1kIiwiaWQiOiJmXzc1N2IzYTM1ODdiYmExNGUiLCJsaW5lIjo1OTIsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJmYWlsLW9wZW4iLCJmaWxlIjoiZG9jcy9ub3JtYXRpdmUvYXV0aG9yaXphdGlvbi92Mi9SRUFETUUubWQiLCJpZCI6ImZfODQ2MjNiYmE5Yzk0NjYyOCIsImxpbmUiOjIyNiwiYWN0aW9uYWJsZSI6dHJ1ZX1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl84NDYyM2JiYTljOTQ2NjI4Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfOTc3MmUzMTNkMWMwOGM4MSIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9LHsiaWQiOiJmXzc1N2IzYTM1ODdiYmExNGUiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 --> ReviewEarlier findings
Previous run (2)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImZhaWwtb3BlbiIsImZpbGUiOiJkb2NzL25vcm1hdGl2ZS9hdXRob3JpemF0aW9uL3YyL1JFQURNRS5tZCIsImlkIjoiZl84NDYyM2JiYTljOTQ2NjI4IiwibGluZSI6MjI2LCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5Ijoic3RhbGUtZG9jIiwiZmlsZSI6ImRvY3Mvbm9ybWF0aXZlL25vcm1hbGl6ZWQtZXZlbnQvdjEvUkVBRE1FLm1kIiwiaWQiOiJmXzk3NzJlMzEzZDFjMDhjODEiLCJsaW5lIjoyMSwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6InBlcm1pc3Npb24tZXhwYW5zaW9uIiwiZmlsZSI6ImRvY3Mvbm9ybWF0aXZlL2F1dGhvcml6YXRpb24vdjIvUkVBRE1FLm1kIiwiaWQiOiJmXzc1N2IzYTM1ODdiYmExNGUiLCJsaW5lIjo1OTIsImFjdGlvbmFibGUiOmZhbHNlfV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzg0NjIzYmJhOWM5NDY2MjgiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfOTc3MmUzMTNkMWMwOGM4MSIsInN0YXR1cyI6InJlY2xhc3NpZmllZCJ9LHsiaWQiOiJmXzc1N2IzYTM1ODdiYmExNGUiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 --> ReviewFindingsMedium
Earlier findings
Next steps:
Previous run (3)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImZhaWwtb3BlbiIsImZpbGUiOiJkb2NzL25vcm1hdGl2ZS9hdXRob3JpemF0aW9uL3YyL1JFQURNRS5tZCIsImlkIjoiZl84NDYyM2JiYTljOTQ2NjI4IiwibGluZSI6MjI2LCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5Ijoic3RhbGUtZG9jIiwiZmlsZSI6ImRvY3Mvbm9ybWF0aXZlL25vcm1hbGl6ZWQtZXZlbnQvdjEvUkVBRE1FLm1kIiwiaWQiOiJmXzk3NzJlMzEzZDFjMDhjODEiLCJsaW5lIjoyMSwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6InBlcm1pc3Npb24tZXhwYW5zaW9uIiwiZmlsZSI6ImRvY3Mvbm9ybWF0aXZlL2F1dGhvcml6YXRpb24vdjIvUkVBRE1FLm1kIiwiaWQiOiJmXzc1N2IzYTM1ODdiYmExNGUiLCJsaW5lIjo1OTIsImFjdGlvbmFibGUiOmZhbHNlfV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzk3NzJlMzEzZDFjMDhjODEiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifSx7ImlkIjoiZl83NTdiM2EzNTg3YmJhMTRlIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn1dfQ== --> ReviewFindingsMedium
Earlier findings
Next steps:
Previous run (4)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5Ijoic3RhbGUtZG9jIiwiZmlsZSI6ImRvY3Mvbm9ybWF0aXZlL25vcm1hbGl6ZWQtZXZlbnQvdjEvUkVBRE1FLm1kIiwiaWQiOiJmXzk3NzJlMzEzZDFjMDhjODEiLCJsaW5lIjoyMSwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6InBlcm1pc3Npb24tZXhwYW5zaW9uIiwiZmlsZSI6ImRvY3Mvbm9ybWF0aXZlL2F1dGhvcml6YXRpb24vdjIvUkVBRE1FLm1kIiwiaWQiOiJmXzc1N2IzYTM1ODdiYmExNGUiLCJsaW5lIjo1OTIsImFjdGlvbmFibGUiOmZhbHNlfV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzc1N2IzYTM1ODdiYmExNGUiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl85NzcyZTMxM2QxYzA4YzgxIiwic3RhdHVzIjoicmVjbGFzc2lmaWVkIn1dfQ== --> Looks good to me Earlier findings
Previous run (5)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6InBlcm1pc3Npb24tZXhwYW5zaW9uIiwiZmlsZSI6ImRvY3Mvbm9ybWF0aXZlL2F1dGhvcml6YXRpb24vdjIvUkVBRE1FLm1kIiwiaWQiOiJmXzc1N2IzYTM1ODdiYmExNGUiLCJsaW5lIjo1OTIsImFjdGlvbmFibGUiOmZhbHNlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJzdGFsZS1kb2MiLCJmaWxlIjoiZG9jcy9ub3JtYXRpdmUvbm9ybWFsaXplZC1ldmVudC92MS9SRUFETUUubWQiLCJpZCI6ImZfOTc3MmUzMTNkMWMwOGM4MSIsImxpbmUiOjIxLCJhY3Rpb25hYmxlIjp0cnVlfV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzk3NzJlMzEzZDFjMDhjODEiLCJzdGF0dXMiOiJvcGVuIn1dfQ== --> ReviewFindingsMedium
Low
Labels: PR adds ADRs and design documentation Next steps:
Previous run (6)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6InN0YWxlLWRvYyIsImZpbGUiOiJkb2NzL25vcm1hdGl2ZS9ub3JtYWxpemVkLWV2ZW50L3YxL1JFQURNRS5tZCIsImlkIjoiZl85NzcyZTMxM2QxYzA4YzgxIiwibGluZSI6MjEsImFjdGlvbmFibGUiOnRydWV9XX0= --> ReviewFindingsLow
Next steps:
|
Record selective entity CEL acquisition and bounded actor-role reuse. Set a common verified triage floor for human event, entity-fact, and Fullsend-controlled model admission. Keep stronger harness checks in CEL and document versioned migration prerequisites. Signed-off-by: Barak Korren <bkorren@redhat.com> Assisted-by: Codex (GPT-6)
5006524 to
62c391a
Compare
|
🤖 Finished Review · ✅ Success · Started 9:54 PM UTC · Completed 10:03 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.13 |
Apply a role-derived human minimum, configurable per trusted harness, to event, entity CEL, and model-bound record gates. Keep triage as the platform floor and label and bot grants separate. Signed-off-by: Barak Korren <bkorren@redhat.com> Assisted-by: Codex (GPT-6)
|
Updated after the ADR simplification: Authorization v2 retains the explicit |
|
🤖 Finished Review · ✅ Success · Started 7:17 AM UTC · Completed 7:28 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.46 |
Superseded by updated review
waynesun09
left a comment
There was a problem hiding this comment.
Reviewed ADR 0151 at 9fc06a2c. The decision itself is sound: a non-waivable triage floor, a per-harness human_min_role with a role-derived default, overlays that may only lower it from trusted facts, and the same minimum applied to the prompting event, decisive entity facts and model records. The problem is that the record is hard to read and is pinned to code instead of stating the decision. Three MEDIUM, one LOW.
waynesun09
left a comment
There was a problem hiding this comment.
ADRs 0147 and 0148 at 9fc06a2c. Both decisions read as sound. 0148 is clear; 0147 is harder to follow because its Decision also restates 0148 and 0151 and carries poll/run handoff rules. Three MEDIUM, one LOW.
There was a problem hiding this comment.
Again, I would like plainer language, it is tiring to read those.
If I understand correctly 147 decides that to trigger a harness, information is gathered progressively for an entity to not get all and spend cycles in evaluating stuff that is not even relevant for the decision. It also introduces a minimum role for a human to trigger the thing.
148 is basically a memory cache regarding the checks that 147 describes, for the long-running process poll.
151 adds the minimum role 147 talks about.
Signed-off-by: Barak Korren <bkorren@redhat.com> Assisted-by: Codex (gpt-6)
|
🤖 Finished Review · ✅ Success · Started 2:01 PM UTC · Completed 2:14 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.49 |
Superseded by updated review
waynesun09
left a comment
There was a problem hiding this comment.
Approving at 7de832a0. All eight of my threads on ADRs 0147, 0148 and 0151 are addressed: no code-pinned links remain, each Decision is now a short list of rules with the mechanics in Authorization Contract v2, the policy-source and run-recheck rules moved to v2 with ADR 0144 for the lifecycle, ADR 0151 is renamed to 0151-harness-human-role-minimums.md with its links updated, and the five-minute role-cache bound is stated as an initial cap to revisit once entity polling runs.
Renumber the ADR 0150 -> 0152 (0146-0151 are claimed by open PRs fullsend-ai#8679, fullsend-ai#8694, fullsend-ai#8698, fullsend-ai#8702; fullsend-ai#8702 was filed first for 0150). Per waynesun09's reviews (first round 14:56, second round 18:29): - restructure the Decision as rules 1-10 with the conformance table separated out (moved to docs/contributing/runtime-implementation.md so it can track the implementation as the code changes, linked from Consequences) - add the Options section back per the ADR template (fail-open with warning, per-runtime resolvers, version-floor acceptance, hash-verification as primary mechanism — each rejected) - add rules 9 (executables, not just directories) and 10 (scope: settings sources fullsend-ai#8637, hooks.json integrity fullsend-ai#8261, plugin trust ADR 0094) - gaps against the rules are tracked in issues, not the ADR: fullsend-ai#8763 (per-file trust for every executable a hook runs) and fullsend-ai#8764 (paths that let a tool call through without a hook verdict), both filed by the reviewer; rule 8's root-launch exception stays as a one-sentence stated limit - fix the pre-fullsend-ai#8605 Codex wording: the PATH was restored for itself and its hook adapter's children - fix the architecture.md sentence to state the decision for all runtimes, not Codex only - factual corrections from the first round: the shared resolver is hookPreflightInterpreter; the boundary value is FULLSEND_TRUSTED_PATH; the pre-fullsend-ai#8605 gap was image-PATH agent-writable dirs; pi included (same treatment in fullsend-ai#8589, pinned python3 not Node) Per the dual-model review round (GLM 5.3 + DeepSeek V4.1 Flash): - breaking change names the runtimes (pi has no version preflight) - forge scope before Consequences, full forge list Signed-off-by: James Tanner <jtanner@redhat.com>
Renumber the ADR 0150 -> 0152 (0146-0151 are claimed by open PRs fullsend-ai#8679, fullsend-ai#8694, fullsend-ai#8698, fullsend-ai#8702; fullsend-ai#8702 was filed first for 0150). Per waynesun09's reviews (first round 14:56, second round 18:29): - restructure the Decision as rules 1-10 with the conformance table separated out (moved to docs/contributing/runtime-implementation.md so it can track the implementation as the code changes, linked from Consequences) - add the Options section back per the ADR template - add rules 9 (executables, not just directories) and 10 (scope) - gaps tracked in issues only: fullsend-ai#8763 and fullsend-ai#8764 linked bare, no implementation-state prose in the ADR - fold the root-launch case into rule 8 as an explicit scope precondition (accurate wording: the PATH still drops relative, empty, and missing entries as root; it cannot exclude agent-writable directories) instead of a contradictory Consequences 'limit' - cite the pre-fullsend-ai#8605 Codex behavior at the correct SHA (bbe0ab2^1 = 191d723), not unqualified line numbers - state the OpenCode exclusion in rule 6 and the conformance table (no ADR 0090 hook wiring until unbound-force#515) - fix the fullsend-ai#8589 chronology (merged earlier the same day as fullsend-ai#8605, not an extension after it) - fix the Options wording on hash verification (detects a substitution only at the next check; the ADR 0094 preflight detects at check time, not 'after the fact') - reference PR fullsend-ai#8261 explicitly as a PR - fix the architecture.md sentence to state the decision for all runtimes, not Codex only - factual corrections from the first round: the shared resolver is hookPreflightInterpreter; the boundary value is FULLSEND_TRUSTED_PATH; the pre-fullsend-ai#8605 gap was image-PATH agent-writable dirs; pi included (same treatment in fullsend-ai#8589, pinned python3 not Node) - update the conformance table Codex row to the post-fullsend-ai#8633 mechanism (envDataTrustedPin within codexBinaryPin) with the bbe0ab2 state noted Per the dual-model review round (GLM 5.3 + DeepSeek V4.1 Flash): - breaking change names the runtimes (pi has no version preflight) - forge scope before Consequences, full forge list Signed-off-by: James Tanner <jtanner@redhat.com>
Summary
Record three decisions for entity-source CEL: acquire only data that can affect the predicate (ADR 0147), reuse verified actor roles for a bounded period (ADR 0148), and apply each selected harness's human admission minimum to the prompting event, decision-relevant entity facts, and Fullsend-controlled model records (ADR 0151).
The platform keeps a non-waivable
triage-level floor. The harnessroleselects the run credential identity and supplies a compatibility default for human admission:triageandreviewdefault totriage; every other role, including custom roles, defaults towrite. A trusted top-levelhuman_min_roleor an ADR 0112 guarded overlay may settriage,write,maintain, oradmin. Token scopes andprivilege_levelsdo not infer the human threshold. Trigger CEL may narrow routing after the platform gate.Review focus
human_min_rolemay use only verified trusted facts available before that harness's actor gate. Role-dependent guards require the future versioned verified-effective-role CEL input; rawevent.actor.roleand label grants cannot choose the minimum. The ordered overlay result, guard evidence, and effective minimum are pinned across dispatch and run. ADR 0112's trusted-field check establishes dependencies; reviewers still need to check which truth value selects a lower threshold (for example, an author can choose a fork).triagegrant for its accepted transition and proven projection. At atriageminimum, that projection remains eligible while the same accepted label state is proven, even if the labeler's later role changes. A higher-minimum harness needs the labeler's current verified effective role. Bot label handoffs and registered-bot authorization remain separate. The grant never fabricates a verified actor role or admits model records.human_min_role: triageon a write-capable harness deliberately permits triage actors and records to guide it while its minted capabilities stay the same. That is a reviewed harness policy choice, not an inference from token capabilities.Other changes
UNKNOWNprogression, durable retry or rediscovery, bound-run rechecks, and decision-relevant audit evidence. Raw monotone state can conservatively defer a run without authorizing every historical updater.This PR changes design documents only. Authorization v1 already specifies
triagefor observation andwritefor mutation. The GitHub bash routes implement the built-in thresholds, and #8727 now applies the harnessrole-derived defaults in Go CEL dispatch for ordinary human events before trigger CEL. Thehuman_min_rolefield is target-only until the loader validates and enforces it, including explicit empty values,basecomposition, guarded overlays, and rejection in deprecatedforge:blocks. Current dispatch and run do not share the verified overlay context or policy-identity handoff required by this target contract. Versioned CEL inputs must expose verified effective roles and label-grant provenance separately; the normalized-entity and snapshot v2 contracts are prerequisites for the target entity and model paths. Snapshot v1 retains its historical threshold.Related issues
Related to #8421. #8420 tracks the normalized-entity schema and partial-data contract required before implementation.
Testing
CI=1 make lintpassed on the staged documentation changes.git diff --check origin/main...HEADpassed.Checklist