Repository navigation
docs(adr): let agent-spec sub-agent entries source or disable personas - #8969
fullsend-ai-coder[bot] wants to merge 13 commits into
Conversation
|
/fs-fix-stop |
|
Fix agent disabled for this PR. Remove the |
|
🤖 Finished Review · ✅ Success · Started 4:01 PM UTC · Completed 4:10 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.64 |
Site previewPreview: https://c25ce5db-site.fullsend-ai.workers.dev Commit: |
ADR 0155 fix round 1Apply all items below to Style rule for the whole ADR: state the problem and the decision in plain words. Context and Decision must contain no commit hash, no file path and no Go identifier (no Context
Decision
Forge scope
Consequences (keep 3–5 one-sentence bullets)
Living docs
Final check
|
|
/fs-fix Apply every item in the "ADR 0155 fix round 1" comment: #8969 (comment) |
|
🤖 Finished Fix · ✅ Success · Started 4:10 PM UTC · Completed 4:14 PM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.36 |
|
Risk Assessment: moderate (2/5) DetailsDocumentation-only PR by a bot with complete issue scope alignment, elevated to moderate risk due to high historical churn, multi-author contention, and co-change coupling across touched architecture and reference documents. Previous runRisk Assessment: moderate (2/5) DetailsDocumentation-only PR by a bot with no protected paths or code changes, elevated to moderate risk by high churn and multi-author contention on central living documentation files. Previous run (2)<!-- fullsend:risk-assessment --> DetailsDocumentation-only ADR by a bot account with no protected paths or code changes, elevated to moderate risk due to high recent commit churn and author contention across touched living architecture and reference docs. Previous run (3)<!-- fullsend:risk-assessment --> DetailsDocumentation-only ADR by a bot account with no protected paths or code changes, elevated to moderate risk due to high recent commit churn and author contention across touched living architecture and reference docs. Previous run (4)<!-- fullsend:risk-assessment --> DetailsDocumentation-only ADR by a bot account with no protected paths or code changes, elevated to moderate risk due to high recent commit churn and author contention across touched living architecture and reference docs. Previous run (5)<!-- fullsend:risk-assessment --> DetailsDocumentation-only ADR by a bot account with no protected paths or code changes, elevated to moderate risk due to high recent commit churn and author contention across touched living architecture and reference docs. Previous run (6)<!-- fullsend:risk-assessment --> DetailsDocumentation-only ADR by a bot account with no protected paths or code changes, elevated to moderate risk due to high recent commit churn and author contention across touched living architecture and reference docs. Previous run (7)<!-- fullsend:risk-assessment --> DetailsDocumentation-only PR by a bot with complete issue scope alignment, elevated to moderate risk due to high historical churn and co-change coupling on touched architecture and reference documents. Previous run (8)<!-- fullsend:risk-assessment --> DetailsDocumentation-only PR by a bot with complete issue scope alignment, elevated to moderate risk due to high historical churn and co-change coupling on touched architecture and reference documents. |
ReviewFindingsMedium
Earlier findings
Next steps:
Previous run<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29tcGxldGUtZG9jIiwiZmlsZSI6ImRvY3MvY29udHJpYnV0aW5nL2hhcm5lc3MtZmllbGRzLm1kIiwiaWQiOiJmXzkyYTA3ZTVhYmY4MzZkMTAiLCJsaW5lIjoxNCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9XX0= --> ReviewFindingsMedium
Next steps:
Previous run (2)ReviewReason: tool-failure This PR was NOT reviewed. Do not count this as an approval. Previous run (3)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJpbmNvcnJlY3QtZG9jIiwiZmlsZSI6ImRvY3MvYXJjaGl0ZWN0dXJlLm1kIiwiaWQiOiJmXzYyYmY2NzMwYzg1NjIwZDQiLCJsaW5lIjozMTUsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJkb2NzL0FEUnMvMDE1NS1hZ2VudC1zcGVjLXN1YmFnZW50cy1zb3VyY2Utb3ItZGlzYWJsZS1wZXJzb25hcy5tZCIsImlkIjoiZl8zYTMzNDU1ZDAyYWRkOTg5IiwibGluZSI6MTE4LCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxNTUtYWdlbnQtc3BlYy1zdWJhZ2VudHMtc291cmNlLW9yLWRpc2FibGUtcGVyc29uYXMubWQiLCJpZCI6ImZfZjZlODgwNjZlOWM0ODc5MiIsImxpbmUiOjMwLCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkZXNpZ24tZGlyZWN0aW9uIiwiZmlsZSI6ImRvY3MvQURScy8wMTU1LWFnZW50LXNwZWMtc3ViYWdlbnRzLXNvdXJjZS1vci1kaXNhYmxlLXBlcnNvbmFzLm1kIiwiaWQiOiJmX2Q1MDVlNWExZWY0MTViZmEiLCJsaW5lIjoxNDYsImFjdGlvbmFibGUiOmZhbHNlfV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzYyYmY2NzMwYzg1NjIwZDQiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifSx7ImlkIjoiZl8zYTMzNDU1ZDAyYWRkOTg5Iiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfZjZlODgwNjZlOWM0ODc5MiIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9LHsiaWQiOiJmX2Q1MDVlNWExZWY0MTViZmEiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifV19 --> Looks good to me Previous run (4)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJpbmNvcnJlY3QtZG9jIiwiZmlsZSI6ImRvY3MvYXJjaGl0ZWN0dXJlLm1kIiwiaWQiOiJmXzYyYmY2NzMwYzg1NjIwZDQiLCJsaW5lIjozMTUsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJkb2NzL0FEUnMvMDE1NS1hZ2VudC1zcGVjLXN1YmFnZW50cy1zb3VyY2Utb3ItZGlzYWJsZS1wZXJzb25hcy5tZCIsImlkIjoiZl8zYTMzNDU1ZDAyYWRkOTg5IiwibGluZSI6MTE4LCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxNTUtYWdlbnQtc3BlYy1zdWJhZ2VudHMtc291cmNlLW9yLWRpc2FibGUtcGVyc29uYXMubWQiLCJpZCI6ImZfZjZlODgwNjZlOWM0ODc5MiIsImxpbmUiOjMwLCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkZXNpZ24tZGlyZWN0aW9uIiwiZmlsZSI6ImRvY3MvQURScy8wMTU1LWFnZW50LXNwZWMtc3ViYWdlbnRzLXNvdXJjZS1vci1kaXNhYmxlLXBlcnNvbmFzLm1kIiwiaWQiOiJmX2Q1MDVlNWExZWY0MTViZmEiLCJsaW5lIjoxNDYsImFjdGlvbmFibGUiOmZhbHNlfV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzYyYmY2NzMwYzg1NjIwZDQiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifSx7ImlkIjoiZl8zYTMzNDU1ZDAyYWRkOTg5Iiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfZjZlODgwNjZlOWM0ODc5MiIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9LHsiaWQiOiJmX2Q1MDVlNWExZWY0MTViZmEiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifV19 --> Looks good to me Previous run (5)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29ycmVjdC1kb2MiLCJmaWxlIjoiZG9jcy9hcmNoaXRlY3R1cmUubWQiLCJpZCI6ImZfNjJiZjY3MzBjODU2MjBkNCIsImxpbmUiOjMxNSwiYWN0aW9uYWJsZSI6dHJ1ZX0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiZWRnZS1jYXNlIiwiZmlsZSI6ImRvY3MvQURScy8wMTU1LWFnZW50LXNwZWMtc3ViYWdlbnRzLXNvdXJjZS1vci1kaXNhYmxlLXBlcnNvbmFzLm1kIiwiaWQiOiJmXzNhMzM0NTVkMDJhZGQ5ODkiLCJsaW5lIjoxMTgsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJkb2NzL0FEUnMvMDE1NS1hZ2VudC1zcGVjLXN1YmFnZW50cy1zb3VyY2Utb3ItZGlzYWJsZS1wZXJzb25hcy5tZCIsImlkIjoiZl9mNmU4ODA2NmU5YzQ4NzkyIiwibGluZSI6MzAsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRlc2lnbi1kaXJlY3Rpb24iLCJmaWxlIjoiZG9jcy9BRFJzLzAxNTUtYWdlbnQtc3BlYy1zdWJhZ2VudHMtc291cmNlLW9yLWRpc2FibGUtcGVyc29uYXMubWQiLCJpZCI6ImZfZDUwNWU1YTFlZjQxNWJmYSIsImxpbmUiOjE0NiwiYWN0aW9uYWJsZSI6ZmFsc2V9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfM2EzMzQ1NWQwMmFkZDk4OSIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9LHsiaWQiOiJmX2Y2ZTg4MDY2ZTljNDg3OTIiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifSx7ImlkIjoiZl9kNTA1ZTVhMWVmNDE1YmZhIiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn1dfQ== --> ReviewFindingsMedium
Next steps:
Previous run (6)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJkb2NzL0FEUnMvMDE1NS1hZ2VudC1zcGVjLXN1YmFnZW50cy1zb3VyY2Utb3ItZGlzYWJsZS1wZXJzb25hcy5tZCIsImlkIjoiZl8zYTMzNDU1ZDAyYWRkOTg5IiwibGluZSI6MTE4LCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxNTUtYWdlbnQtc3BlYy1zdWJhZ2VudHMtc291cmNlLW9yLWRpc2FibGUtcGVyc29uYXMubWQiLCJpZCI6ImZfZjZlODgwNjZlOWM0ODc5MiIsImxpbmUiOjMwLCJhY3Rpb25hYmxlIjp0cnVlfSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkZXNpZ24tZGlyZWN0aW9uIiwiZmlsZSI6ImRvY3MvQURScy8wMTU1LWFnZW50LXNwZWMtc3ViYWdlbnRzLXNvdXJjZS1vci1kaXNhYmxlLXBlcnNvbmFzLm1kIiwiaWQiOiJmX2Q1MDVlNWExZWY0MTViZmEiLCJsaW5lIjoxNDYsImFjdGlvbmFibGUiOmZhbHNlfV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmX2Y2ZTg4MDY2ZTljNDg3OTIiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifSx7ImlkIjoiZl9kNTA1ZTVhMWVmNDE1YmZhIiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn1dfQ== --> ReviewFindingsMedium
Next steps:
Previous run (7)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJkb2NzL0FEUnMvMDE1NS1hZ2VudC1zcGVjLXN1YmFnZW50cy1zb3VyY2Utb3ItZGlzYWJsZS1wZXJzb25hcy5tZCIsImlkIjoiZl9mNmU4ODA2NmU5YzQ4NzkyIiwibGluZSI6MzAsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRlc2lnbi1kaXJlY3Rpb24iLCJmaWxlIjoiZG9jcy9BRFJzLzAxNTUtYWdlbnQtc3BlYy1zdWJhZ2VudHMtc291cmNlLW9yLWRpc2FibGUtcGVyc29uYXMubWQiLCJpZCI6ImZfZDUwNWU1YTFlZjQxNWJmYSIsImxpbmUiOjE0NiwiYWN0aW9uYWJsZSI6ZmFsc2V9XX0= --> ReviewFindingsMedium
Low
Next steps:
Previous run (8)ReviewReason: stale-head The review agent reviewed commit Previous run (9)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImRvY3MvQURScy8wMTU1LWFnZW50LXNwZWMtc3ViYWdlbnRzLXNvdXJjZS1vci1kaXNhYmxlLXBlcnNvbmFzLm1kIiwiaWQiOiJmXzc3Nzk5OTRhYzAyZTQyMWQiLCJsaW5lIjoxMTcsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImFwaS1jb250cmFjdCIsImZpbGUiOiJkb2NzL0FEUnMvMDE1NS1hZ2VudC1zcGVjLXN1YmFnZW50cy1zb3VyY2Utb3ItZGlzYWJsZS1wZXJzb25hcy5tZCIsImlkIjoiZl9kYzM3MWQ1MWJjYzNmZjJmIiwibGluZSI6MTAwLCJhY3Rpb25hYmxlIjpmYWxzZX1dfQ== --> ReviewFindingsMedium
Low
Labels: Docs-only ADR PR Next steps:
|
Rewrite ADR 0155 Context and Decision in plain words (no hashes, file paths or Go identifiers), tighten the source trust rules, reword the enabled:false guarantee with the dimension-drop backstop, relax the undiscovered-persona error per case, add runtimes and forge-scope clarifications, and align docs/architecture.md. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🔧 Fix agent — iteration 1 (human-triggered)Applied all 15 items from the ADR 0155 fix round 1 comment to the ADR and docs/architecture.md in one commit with no sign-off. The pre-commit hooks and the link checker could not run in the sandbox because there is no network access; the secret scan passed. Fixed (7):
Tests: passed CI inspections (4):
Conflict update: skipped; strategy
|
|
🤖 Finished Review · ✅ Success · Started 4:16 PM UTC · Completed 4:24 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.46 |
ADR 0155 fix round 2 (concision)Do not sign off: no Round 1 made the ADR 21% longer by appending caveats. Replace the second Context paragraph, the whole Decision section (including the YAML block) and the whole Consequences section of Context, second paragraph (replace)The review skill already departs from the scripted pipeline of
[ADR 0018](0018-scripted-pipeline-for-multi-agent-orchestration.md) by relying
on a fixed roster. The roster stays fixed for each run: it is the staged set,
read from the trusted ref, not something the change's author picks. This ADR
does not supersede ADR 0018.Decision (replace the whole section body)We extend `agents[].subagents` so that each persona entry is a string or an
object, to let a repository replace, add or disable a persona without forking
the skill.
1. **Two forms.** An entry is a string or an object `{model, source, enabled}`
with every field optional. A string is shorthand for `{model: <value>}`, so
ADR 0104's resolution is unchanged and still applies only where it is
implemented (pi, and codex when the agent delegates). The `default` key
takes only the string form.
2. **Compiles into skill file overrides.** At staging, before persona
discovery and on every runtime, the runner turns `source` and
`enabled: false` into harness skill file overrides. These replace or remove
`sub-agents/<persona>.md` in the skill that ships the persona. A `source` for
a persona that no staged skill ships adds the file to the agent's first
skill that has personas, and the file's frontmatter `name` must equal the
key.
3. **`source` crosses a trust boundary.** Like the guarded fields of
[ADR 0112](0112-overlays-may-set-any-harness-field.md), it is read only from
config at the trusted ref. It is never read from an overlay, a flag, an
environment variable or the change under review, so a pull request cannot
change its own review. It is either a path that stays inside `.fullsend/`
(no `..`, no absolute path, no symlink escape), or a URL pinned with
`#sha256=`, on `allowed_remote_resources`, with a lock entry that
`fullsend lock` writes and the run checks.
4. **`enabled: false` is a host guarantee.** The persona file is not staged,
so no child can be dispatched as that persona. As a backstop, the review
post-script drops findings whose agent-reported `dimension` names a persona
that was not staged. This filters mislabelled output; it is not proof of
what ran.
5. **Layering.** Layers merge per field, and `key: ~` removes an inherited
entry (ADR 0104). ADR 0104's rule against `subagents` entries in shared
presets still holds for `model` and `source`.
6. **No persona semantics in the runner.** fullsend checks shape only: types,
the `source` trust rules and duplicate names. The skill decides what to do
when, for example, `correctness` is missing.
7. **Selection is unchanged.** The review agent still chooses which dimensions
run, now only from the staged personas.
8. **Unknown keys.** A key without `enabled: false` that names a persona the
run did not discover stays an error, unless its `source` defines that
persona. An entry with `enabled: false` never errors, and its other fields,
inherited ones included, are ignored. When no skill ships that persona, the
run log gets a warning. An org-wide disable then works in every
repository, and a typo shows up.
```yaml
agents:
- name: review
subagents:
default: sonnet # string form, as in ADR 0104
style-conventions:
enabled: false # not staged
correctness:
source: .fullsend/personas/correctness.md
licensing: # added: source defines the persona
model: opus
source: https://raw.githubusercontent.com/example-org/personas/<sha>/licensing.md#sha256=<sha256>
```Consequences (replace the whole section body)- A repository can add, replace or disable a review persona from config
without copying the skill, and keeps upstream updates for everything else.
- Disabling is guaranteed on the host because the persona is not staged,
while choosing dimensions stays the review agent's judgement.
- A `source` change crosses a trust boundary and gets the same review,
pinning and locking as a skill or harness base.
- The CLI gains a way to set `source` and to disable a persona, implemented
after this ADR is approved.
- Disabling or adding a persona takes effect only once the review skill builds
its roster from the staged persona files and fills in `dimension`, which is
agents-repository work that must ship first.This round also resolves the review bot's MEDIUM (finding f_7779994ac02e421d: enabled:false plus an inherited model) through item 8, and its LOW through item 4 and the last Consequence. |
|
/fs-fix Replace the ADR 0155 sections verbatim with the text in the "ADR 0155 fix round 2" comment: #8969 (comment) |
|
🤖 Finished Fix · ✅ Success · Started 4:19 PM UTC · Completed 4:23 PM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.29 |
🔧 Fix agent — iteration 2 (human-triggered)Replaced the ADR 0155 second Context paragraph, Decision section and Consequences section verbatim with the round 2 comment text. No other files changed. Fixed (1):
Tests: passed CI inspections (2):
Conflict update: skipped; strategy
|
|
🤖 Finished Review · ❌ Failure (fullsend config could not be loaded, agent did not run: loading fullsend config: config.yaml: create_issues is no longer supported: move create_issues.allow_targets to tracker.<provider>.allowed_ta…) · Started 4:10 PM UTC · Completed 4:10 PM UTC Commit: |
Add ADR 0155. It records the decision that agents[].subagents entries
may be either today's model string or an object {model, source,
enabled}. At staging, source and enabled: false compile into the skill
file overrides from #6158, so a repository can replace, add or disable
a review persona without forking the orchestrator skill.
The ADR makes source a guarded field (ADR 0112): an in-repo path or a
sha256-pinned URL on allowed_remote_resources, read from the base
branch. A disabled persona is enforced on the host: it is not staged,
and the review post-script drops findings for unstaged dimensions. It
also relaxes the unknown-persona error for enabled: false entries.
ADR 0104 is not edited.
Living documents updated with surgical additions: a Decided bullet in
docs/architecture.md, a contextual link in docs/problems/code-review.md,
and a not-yet-implemented note in docs/reference/config-reference.md.
This is a decision record only; implementation is tracked separately.
pre-commit could not fetch remote hook repos in the sandbox (TLS
error), so hooks ran directly: ADR status/number/frontmatter lints,
docs link lints, lychee, gitleaks and whitespace/EOF checks all pass.
Closes #8968
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rewrite ADR 0155 Context and Decision in plain words (no hashes, file paths or Go identifiers), tighten the source trust rules, reword the enabled:false guarantee with the dimension-drop backstop, relax the undiscovered-persona error per case, add runtimes and forge-scope clarifications, and align docs/architecture.md. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Replace the second Context paragraph, the Decision section and the Consequences section with the concise text from the round 2 comment. Resolves the enabled:false plus inherited model finding via Decision item 8, and the dimension backstop finding via item 4 and the last Consequence. pre-commit could not run (hook repos unreachable: certificate error), and lychee is unavailable in the sandbox. The ADR status, number, frontmatter and docs-links hooks were run directly and passed. Addresses #8969 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Replace Decision items 2, 3, 5 and 6 with the text from the fix round 3 comment, and narrow the architecture.md bullet to a path inside `.fullsend/`. pre-commit could not run (hook repos unreachable: certificate error), and lychee is unavailable in the sandbox. The secret scan passed. Addresses #8969 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ADR 0155 fix round 4: note in decision item 2 that the shared lock step lists pinned skills' sub-agents/ files and partly closes ADR 0104's deferred lock gap, and in item 3 say the guarded fields are stricter than ADR 0112's and read from the trusted ref and its pinned preset layers. Note: pre-commit could not fetch hook repositories (certificate verification failed in the sandbox); trailing-whitespace, line-ending and secret checks were run directly. lychee is unavailable in the sandbox, so make lint-md-links was not run; no links were changed. Addresses #8969 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Replace the object-form block under subagents in config-reference.md with a one-line pointer to ADR 0155, since the shape is not yet accepted by the product. Pre-commit hooks could not run (network/cert failure fetching hook repos). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Reword ADR 0155 Decision item 7: disabling a persona guarantees its prompt is not staged, not that no child can be dispatched under its name (ADR 0104 still allows an anonymous child). Applies the edit requested in the 'ADR 0155 fix round 7' comment. Note: pre-commit could not run (hook repos unreachable: TLS verification failed); checked trailing whitespace, line endings, and EOF newline by hand. Addresses #8969 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Replace the ADR 0155 bullet in docs/architecture.md verbatim with the text from the "ADR 0155 fix round 8" comment (finding f_62bf6730c85620d4): overrides compile at harness composition, trusted-ref rule covers both fields, and a disabled persona's child runs only as an anonymous helper. Note: pre-commit could not fetch hook repos (certificate failure) and lychee is unavailable in the sandbox; verified trailing whitespace, CR and the ADR link target manually. Addresses #8969 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Harness skills: file overrides now apply at staging (#6158). Context and the options list said they did not, and framed the ADR as a way to avoid forking the skill. Restate the gap: overrides are keyed by file path, so 0155 adds a per-persona config entry compiled into them. Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
ADR 0162 lets an agents entry carry a harness: block, so subagents becomes a harness field, set as agents[].harness.subagents or in a custom harness file. The entry field stays a deprecated alias for ADR 0104 model strings; setting both in one layer fails. - Compiled overrides win over skills: after all harness layers merge. - No overlay can set subagents.*.source or .enabled, block overlays included; persona models follow ADR 0112 like model. - key: ~ keeps removing an inherited entry, as an explicit exception to 0162's replace-not-remove rule; enabled: true re-enables. - The ADR 0104 preset ban applies to the config.base.yaml block. - source paths resolve like other harness paths; a URL source on a built-in agent fails, since lock does not lock built-ins. - Renamed the file to drop "agent-spec"; depends on ADR 0162. Assisted-by: Claude (author), Gemini (decision and prose review) Signed-off-by: Wayne Sun <gsun@redhat.com>
ADR 0162 merged in #8965, so the two links to it now point at the file instead of the pull request. Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
614dfd0 to
77873f1
Compare
|
🤖 Finished Review · ❌ Failure (post-script /home/runner/work/fullsend/fullsend/.fullsend/.fullsend-cache/resources/sha256/8705f4e8b8e0f68615e6e4514ebf165f4121d0f94d3239c43fcf653157463931/scripts/post-review.sh failed: exit status 1) · Started 7:23 PM UTC · Completed 7:32 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.38 |
|
🤖 Finished Review · ✅ Success · Started 7:49 PM UTC · Completed 8:00 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.28 |
The "Decided, not yet implemented" callout in harness-fields.md named ADRs 0112, 0158, 0151 and 0162 but not 0155, which makes subagents a harness field. Add it in the same style. Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
|
🤖 Finished Review · ✅ Success · Started 2:06 PM UTC · Completed 2:13 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.48 |
| @@ -0,0 +1,212 @@ | |||
| --- | |||
| title: "155. Sub-agent entries may source or disable personas" | |||
There was a problem hiding this comment.
[medium] pattern-violation
ADR number 0155 is already taken on current main by docs/ADRs/0155-configure-vault-backed-runner-secrets.md ("155. Select native or Vault sources for runner secrets"). Adding a second 0155 record breaks the unique-number check in hack/lint-adr-numbers, so lint will fail once this is merged with main. Any reference to "ADR 0155" would also point to two different decisions.
Suggested fix: Pick an unused ADR number (0154 and 0156 are also taken on main), rename the new file, and update its frontmatter title and H1. Then update every link and ADR-number reference this PR adds in architecture.md, harness-fields.md, problems/code-review.md and config-reference.md. Leave the existing accepted Vault ADR unchanged.
Summary
Adds ADR 0155. It lets an
agents[].subagentsentry in.fullsend/config.yamlbe an object{model, source, enabled}as well as today's model string. With it, a repository can replace, add or disable a review persona without forking the orchestrator skill. This PR is the decision record only; implementation (config parsing, staging, CLI flags) follows in separate work.Related Issue
Issue #8968 (closing reference appended automatically).
Changes
docs/ADRs/0155-agent-spec-subagents-source-or-disable-personas.md(Accepted):{model}) or{model, source, enabled}; ADR 0104's model resolution is unchanged.sourceandenabled: falsecompile into harness skill file overrides at harness composition (shared withfullsend lock) and are applied at staging before persona discovery, on every runtime.sourceandenabled: falseare read only from config at the trusted ref, never from overlays, flags, env or the change under review;sourceis a path inside.fullsend/or a#sha256=-pinned URL onallowed_remote_resourceswith a lock entry.enabled: falseguarantees the persona is not staged; the post-script finding drop on the agent-reporteddimensionis a backstop.enabled: false(ignored with a warning) orsourcedefines the persona.docs/architecture.md: adds a "Decided, not yet implemented" bullet under Agent Runtime › Decided (implementation).docs/problems/code-review.md: adds a link to the ADR under "Review sub-agent decomposition".docs/reference/config-reference.md: adds one line to thesubagentsfield saying the object form is decided in ADR 0155 but not yet implemented.ADR 0104 and every other accepted ADR are untouched. There are no Go, script, skill or workflow changes.
Testing
make lintequivalent:pre-commitcould not fetch its remote hook repos in the sandbox (TLS certificate error), so the applicable hooks were run directly on the staged files.lint-adr-status,lint-adr-numbers,lint-adr-frontmatter,lint-docs-links,lint-broken-symlinks, lychee (offline, with fragments), gitleaks, and the trailing-whitespace / EOF / line-ending / merge-conflict checks all pass. The post-script runs the authoritativepre-commit.Notes for reviewers
Current-behaviour evidence (kept out of the ADR text on purpose, so the record states the problem in plain words) at
12a09ace3e26b1e52442ee628ac570f794f856f6:AgentEntry.Subagents(map[string]*string) ininternal/config/config.go;SkillEntry.Overridesininternal/harness/skill_entry.go, which Bootstrap does not apply (it passes onlySkillSources(h.Skills)); the unknown-persona error inresolvePersonaModels(internal/runtime/pi_personas.go) andresolveCodexChildModels(internal/runtime/codex_personas.go).ADR number: open PR docs(adr): let agent entries carry harness overrides #8965 claims 0154. No open PR claims 0155. If 0155 is taken before this merges, use the
renumber-adrskill.Checklist
🤖 Generated with Claude Code
Closes #8968
Post-script verification
agent/8968-adr-subagent-source-disable)12a09ace3e26b1e52442ee628ac570f794f856f6..HEAD)