Repository navigation
docs(#9004): ADR 0157, require a jira authorization entry for jira-poll - #9026
Conversation
Record the decision proposed in #9004: running the jira-poll input driver with no jira entry under authorization: is deprecated, and a later release requires the entry. The two-line entry (provider: jira, labels: project_roles) keeps today's project-role behaviour. The warning is logged by the poller, not reported by fullsend lint, because lint cannot tell whether a repository polls Jira. Rollout tracked in #9005 (warning) and #9006 (removal). Annotate ADR 0153 (its opt-in rule is superseded; lists, labels rules and roster loading stand) and update the Jira poll bullet in docs/architecture.md. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Bill Murdock <bmurdock@redhat.com>
|
🤖 Finished Review · ✅ Success · Started 6:05 PM UTC · Completed 6:16 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.68 |
Site previewPreview: https://b3fea1a6-site.fullsend-ai.workers.dev Commit: |
|
Risk Assessment: moderate (2/5) DetailsDocumentation-only ADR change with medium blast radius and zero protected paths, elevated to moderate by high commit churn and multi-author contention on docs/architecture.md. Previous run<!-- fullsend:risk-assessment --> DetailsDocumentation-only PR introducing ADR 0157 with well-aligned linked issue scope, scored moderate due to high commit frequency and author contention on architecture.md. Previous run (2)<!-- fullsend:risk-assessment --> DetailsDocumentation-only PR introducing ADR 0157 with well-aligned linked issue scope, scored moderate due to high commit frequency and author contention on architecture.md. Previous run (3)<!-- fullsend:risk-assessment --> DetailsDocumentation-only PR introducing ADR 0156 with well-aligned linked issue scope, scored moderate due to high commit frequency and author contention on architecture.md. Previous run (4)<!-- fullsend:risk-assessment --> DetailsDocumentation-only PR introducing ADR 0156 and cross-referencing ADR 0153 with low blast radius, well-aligned linked issue scope, and additive documentation changes, despite historical churn on architecture.md. |
|
Looks good to me Previous run<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxNTYtcmVxdWlyZS1qaXJhLWF1dGhvcml6YXRpb24tZW50cnktZm9yLWppcmEtcG9sbC5tZCIsImlkIjoiZl8xNjRhMjYwZWQxNDNhNDA5IiwibGluZSI6NzgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMTU2LXJlcXVpcmUtamlyYS1hdXRob3JpemF0aW9uLWVudHJ5LWZvci1qaXJhLXBvbGwubWQiLCJpZCI6ImZfMjNlZjYzYTZmMjg0YWU2OSIsImxpbmUiOjEyMiwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxNTYtcmVxdWlyZS1qaXJhLWF1dGhvcml6YXRpb24tZW50cnktZm9yLWppcmEtcG9sbC5tZCIsImlkIjoiZl9kZTk1NWIxOTJhMmZmMzVmIiwibGluZSI6MTMxLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfMTY0YTI2MGVkMTQzYTQwOSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzIzZWY2M2E2ZjI4NGFlNjkiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9kZTk1NWIxOTJhMmZmMzVmIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn1dfQ== --> Looks good to me Previous run (2)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxNTYtcmVxdWlyZS1qaXJhLWF1dGhvcml6YXRpb24tZW50cnktZm9yLWppcmEtcG9sbC5tZCIsImlkIjoiZl8xNjRhMjYwZWQxNDNhNDA5IiwibGluZSI6NzgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMTU2LXJlcXVpcmUtamlyYS1hdXRob3JpemF0aW9uLWVudHJ5LWZvci1qaXJhLXBvbGwubWQiLCJpZCI6ImZfMjNlZjYzYTZmMjg0YWU2OSIsImxpbmUiOjEyMiwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxNTYtcmVxdWlyZS1qaXJhLWF1dGhvcml6YXRpb24tZW50cnktZm9yLWppcmEtcG9sbC5tZCIsImlkIjoiZl9kZTk1NWIxOTJhMmZmMzVmIiwibGluZSI6MTMxLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfMTY0YTI2MGVkMTQzYTQwOSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzIzZWY2M2E2ZjI4NGFlNjkiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9kZTk1NWIxOTJhMmZmMzVmIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn1dfQ== --> Looks good to me Previous run (3)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxNTYtcmVxdWlyZS1qaXJhLWF1dGhvcml6YXRpb24tZW50cnktZm9yLWppcmEtcG9sbC5tZCIsImlkIjoiZl8xNjRhMjYwZWQxNDNhNDA5IiwibGluZSI6NzgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMTU2LXJlcXVpcmUtamlyYS1hdXRob3JpemF0aW9uLWVudHJ5LWZvci1qaXJhLXBvbGwubWQiLCJpZCI6ImZfMjNlZjYzYTZmMjg0YWU2OSIsImxpbmUiOjEyMiwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxNTYtcmVxdWlyZS1qaXJhLWF1dGhvcml6YXRpb24tZW50cnktZm9yLWppcmEtcG9sbC5tZCIsImlkIjoiZl9kZTk1NWIxOTJhMmZmMzVmIiwibGluZSI6MTMxLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfMTY0YTI2MGVkMTQzYTQwOSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzIzZWY2M2E2ZjI4NGFlNjkiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9kZTk1NWIxOTJhMmZmMzVmIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn1dfQ== --> Looks good to me Earlier findings
Previous run (4)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJkb2NzL0FEUnMvMDE1Ni1yZXF1aXJlLWppcmEtYXV0aG9yaXphdGlvbi1lbnRyeS1mb3ItamlyYS1wb2xsLm1kIiwiaWQiOiJmXzE2NGEyNjBlZDE0M2E0MDkiLCJsaW5lIjo3OCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAxNTYtcmVxdWlyZS1qaXJhLWF1dGhvcml6YXRpb24tZW50cnktZm9yLWppcmEtcG9sbC5tZCIsImlkIjoiZl8yM2VmNjNhNmYyODRhZTY5IiwibGluZSI6MTIyLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJkb2NzL0FEUnMvMDE1Ni1yZXF1aXJlLWppcmEtYXV0aG9yaXphdGlvbi1lbnRyeS1mb3ItamlyYS1wb2xsLm1kIiwiaWQiOiJmX2RlOTU1YjE5MmEyZmYzNWYiLCJsaW5lIjoxMzEsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn1dfQ== --> ReviewFindingsLow
Labels: PR adds an ADR and updates architecture docs Next steps:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Add an opening paragraph to Context that says what teams are trying to do with Jira-driven agents and why an explicit authorization choice matters, before any component is named. Shorten the Status note and fold the driver description into the technical paragraph so it no longer repeats the opening. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Bill Murdock <bmurdock@redhat.com>
|
🤖 Finished Review · Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.74 This review was superseded by a newer commit. Check the current pull request HEAD's review status before merging. |
Open Context with the executive story: one authorization source before #8892, bad on two counts; alternatives added non-breaking; the old way left as a silent default; this ADR removes the default without installing another. Technical restatement and code citation follow. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Bill Murdock <bmurdock@redhat.com>
Put each ADR 0153 link on its own line so the surrounding prose stays within the 80-column guide (review findings on ce17c86). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Bill Murdock <bmurdock@redhat.com>
|
🤖 Finished Review · Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.66 This review was superseded by a newer commit. Check the current pull request HEAD's review status before merging. |
|
🤖 Finished Review · ✅ Success · Started 7:04 PM UTC · Completed 7:15 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.20 |
Superseded by updated review
PR Summary by QodoADR 0157: Require explicit Jira authorization for jira-poll
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
|
🤖 Finished Review · ✅ Success · Started 4:26 PM UTC · Completed 4:31 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.82 |
Superseded by updated review
|
Good stuff - thank you for hacking on it. |
The Context paragraph said a repository lists Jira groups and accounts "in its own config" without saying which file. Name the file so a reader who stops at the story does not have to guess. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Bill Murdock <bmurdock@redhat.com>
ifireball
left a comment
There was a problem hiding this comment.
Approved.
I think there is one aspect of ADR 153 that is mentioned here as well that we should change: When labels is set to jira_editors, the ADRs claim that the poller needs to ignore label events made by its own account. This renders the primary use case of labels as a bot work hand-off mechanism non functional. Not sure it its in this ADR's scope to deal with that, but we should deal with it never the less.
Resolve the docs/architecture.md conflict by keeping both additions: the ADR 0157 deprecation sentence on the Jira poll bullet and main's new bullet for ADR 0156. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: Bill Murdock <bmurdock@redhat.com>
|
🤖 Finished Review · ✅ Success · Started 2:17 PM UTC · Completed 2:25 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.56 |
Superseded by updated review
|
Thanks for the review, and you are right about the behavior. I checked the code: the poller drops every event it classifies as bot-authored before authorization runs, and its own account always counts as a bot. Two details beyond what you wrote: the filter applies in every I agree it should be dealt with, and I think it is a separate decision from this one. This ADR only makes the Bill Murdock with assistance from Claude Code |
Until recently, Fullsend had exactly one way to decide who may use the Jira poller to run agents: the actor's Jira project role, read from a roster that only project administrators can see, and matched by role name. #8892 (ADR 0153) added better alternatives, config-owned lists of Jira groups and accounts and Jira's own Edit Issues permission for labels, but to stay non-breaking it left the old way as the default. So Fullsend now has a bad default, and a silent one: a repository cannot tell "I chose project roles" from "I configured nothing". This ADR deprecates and removes that default. It does not put a different default in its place: a repository that runs the poller must say which way it uses, and the old way stays available as an explicit two-line choice.
Summary
ADR 0157 records the decision proposed in #9004: running the
jira-pollinput driver with nojiraentry underauthorization:is deprecated, and a later release requires the entry. The two-line entry (provider: jirawithlabels: project_roles) keeps today's project-role behaviour exactly.fullsend lint: lint reads config.yaml and the harnesses and cannot tell whether a repository polls Jira, so a lint finding would fire for repositories that never do.labels:rules and roster loading stand. ADR 0153 gets a Status note, and the Jira poll bullet indocs/architecture.mdis updated.No implementation is in this PR; #9005 and #9006 carry it.
Opened as a draft so the proposal can be discussed before anything is treated as decided. Objections and alternatives are welcome here or on #9004.
Closes #9004
🤖 Generated with Claude Code