Repository navigation
fix(#9038): address configured GitHub host in run fallback and status - #9056
Conversation
|
🤖 Finished Review · ✅ Success · Started 2:23 AM UTC · Completed 2:45 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.13 |
Site previewPreview: https://47b8c81a-site.fullsend-ai.workers.dev Commit: |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
Risk Assessment: moderate (2/5) DetailsLarge diff across core runner and dispatch components with high historical churn is balanced by bot authorship, absent protected paths, extensive test additions, and close alignment with linked issue scope. Previous runRisk Assessment: moderate (2/5) DetailsLarge diff across core runner and dispatch components with high historical churn is balanced by bot authorship, absent protected paths, extensive test additions, and close alignment with linked issue scope. Previous run (2)Risk Assessment: moderate (2/5) DetailsTouches 9 files and 1,278 lines with no protected or dependency paths, preserves host-gated behavior and extensive test coverage, maintaining a moderate risk score of 2 anchored to the prior review despite high churn in touched CLI components. Previous run (3)Risk Assessment: moderate (2/5) DetailsAlthough the PR touches 9 files with 1,209 lines across runner and dispatch components, it modifies no protected or dependency paths, includes extensive test coverage, and gates behavioral changes behind non-default GitHub host configuration, maintaining a moderate risk score of 2 despite high churn and author contention in touched files. Previous run (4)Risk Assessment: moderate (2/5) DetailsAlthough the PR touches 9 files with 1,139 lines across runner and dispatch components, it modifies no protected or dependency paths, includes extensive test coverage, and gates behavioral changes behind non-default GitHub host configuration, maintaining a moderate risk score of 2 despite high churn and author contention in touched files. Previous run (5)Risk Assessment: moderate (2/5) DetailsAlthough the PR expanded to 1,139 lines across 9 files with dispatch and forge client updates, it modifies no protected or dependency paths, includes extensive test coverage, and gates behavioral changes behind non-default GitHub host configuration, preserving a moderate risk score of 2 despite high churn and author contention in touched runner components. Previous run (6)Risk Assessment: moderate (2/5) DetailsWhile the PR expanded to 806 changed lines and added harness compose hooks, it preserves high test coverage without modifying protected paths or dependencies, maintaining a moderate risk score of 2 despite elevated churn and multi-author contention in touched runner and harness components. Previous run (7)<!-- fullsend:risk-assessment --> DetailsTargeted bug fix with accompanying unit tests aligns closely with linked issue #9038 without modifying protected paths or dependencies, balanced by high recent churn and multi-author contention in touched CLI runner and harness code. Previous run (8)<!-- fullsend:risk-assessment --> DetailsTargeted bug fix with accompanying unit tests aligns closely with linked issue #9038, balanced by high recent churn and multi-author contention in touched CLI runner code. Previous run (9)<!-- fullsend:risk-assessment --> DetailsTargeted bug fix with accompanying unit tests aligns closely with linked issue #9038, balanced by high recent churn and multi-author contention in touched CLI runner code. Previous run (10)<!-- fullsend:risk-assessment --> DetailsTargeted bug fix with accompanying unit tests aligns closely with linked issue #9038, balanced by high recent churn and multi-author contention in touched CLI runner code. Previous run (11)<!-- fullsend:risk-assessment --> DetailsTargeted bug fix with accompanying unit tests aligns closely with linked issue #9038, balanced by high recent churn and multi-author contention in touched CLI code. Previous run (12)<!-- fullsend:risk-assessment --> DetailsTargeted bug fix with accompanying tests matching linked issue #9038, balanced by high recent churn and author contention in touched CLI files. |
|
Looks good to me Previous run<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJzc3JmIiwiZmlsZSI6ImludGVybmFsL2NsaS9ydW4uZ28iLCJpZCI6ImZfNjlkZDA3ZjRkOTdjYzE4YSIsImxpbmUiOjgwMTQsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5Ijoic2NvcGUtYnVuZGxpbmciLCJmaWxlIjoiaW50ZXJuYWwvY2xpL2Rpc3BhdGNoLmdvIiwiaWQiOiJmX2MxY2M3MGU0OWY1ODEyY2QiLCJsaW5lIjo4NiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImludGVudC1jb2hlcmVuY2UifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJkZXNpZ24tc21lbGwiLCJmaWxlIjoiaW50ZXJuYWwvZm9yZ2UvZ2l0aHViL2dpdGh1Yi5nbyIsImlkIjoiZl9mYzg5MWUwZTgxNWU5M2RiIiwibGluZSI6MjI3MSwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImludGVudC1jb2hlcmVuY2UifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJhcGktY29udHJhY3QiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl8zMTUzYWVjMzhiY2EwNDAxIiwibGluZSI6ODE0NSwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJlcnJvci1oYW5kbGluZy1pZGlvbSIsImZpbGUiOiJpbnRlcm5hbC9mb3JnZS9naXRodWIvZ2l0aHViLmdvIiwiaWQiOiJmXzRhODc2Yjk5ZmZkMDZkN2EiLCJsaW5lIjoyMzE4LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6Im1pc3BsYWNlZC1hYnN0cmFjdGlvbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL2NvbXBvc2UuZ28iLCJpZCI6ImZfZjBhYjQzNWRmNTNhNjM2MiIsImxpbmUiOjU2LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiaW50ZW50LWNvaGVyZW5jZSJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6InNjb3BlLWNyZWVwIiwiZmlsZSI6ImRvY3MvYXJjaGl0ZWN0dXJlLm1kIiwiaWQiOiJmXzdlNGYxODc1NjE3MDgyYzgiLCJsaW5lIjo3ODgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJpbnRlbnQtY29oZXJlbmNlIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYmFja3dhcmQtaW5jb21wYXRpYmxlIiwiZmlsZSI6ImludGVybmFsL2ZvcmdlL2dpdGh1Yi9naXRodWIuZ28iLCJpZCI6ImZfYTQ2YzhiNTkxYmY4ZDUzNiIsImxpbmUiOjIyNjksImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfNjlkZDA3ZjRkOTdjYzE4YSIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9LHsiaWQiOiJmX2MxY2M3MGU0OWY1ODEyY2QiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifSx7ImlkIjoiZl9mYzg5MWUwZTgxNWU5M2RiIiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfMzE1M2FlYzM4YmNhMDQwMSIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9LHsiaWQiOiJmXzRhODc2Yjk5ZmZkMDZkN2EiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifSx7ImlkIjoiZl9mMGFiNDM1ZGY1M2E2MzYyIiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfN2U0ZjE4NzU2MTcwODJjOCIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9LHsiaWQiOiJmX2E0NmM4YjU5MWJmOGQ1MzYiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifV19 --> Looks good to me Previous run (2)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6InNzcmYiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl82OWRkMDdmNGQ5N2NjMThhIiwibGluZSI6ODAxNCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJzY29wZS1idW5kbGluZyIsImZpbGUiOiJpbnRlcm5hbC9jbGkvZGlzcGF0Y2guZ28iLCJpZCI6ImZfYzFjYzcwZTQ5ZjU4MTJjZCIsImxpbmUiOjg2LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiaW50ZW50LWNvaGVyZW5jZSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImRlc2lnbi1zbWVsbCIsImZpbGUiOiJpbnRlcm5hbC9mb3JnZS9naXRodWIvZ2l0aHViLmdvIiwiaWQiOiJmX2ZjODkxZTBlODE1ZTkzZGIiLCJsaW5lIjoyMjcxLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiaW50ZW50LWNvaGVyZW5jZSJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImFwaS1jb250cmFjdCIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmXzMxNTNhZWMzOGJjYTA0MDEiLCJsaW5lIjo4MTQ1LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImVycm9yLWhhbmRsaW5nLWlkaW9tIiwiZmlsZSI6ImludGVybmFsL2ZvcmdlL2dpdGh1Yi9naXRodWIuZ28iLCJpZCI6ImZfNGE4NzZiOTlmZmQwNmQ3YSIsImxpbmUiOjIzMTgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoibWlzcGxhY2VkLWFic3RyYWN0aW9uIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3MvY29tcG9zZS5nbyIsImlkIjoiZl9mMGFiNDM1ZGY1M2E2MzYyIiwibGluZSI6NTYsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJpbnRlbnQtY29oZXJlbmNlIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5Ijoic2NvcGUtY3JlZXAiLCJmaWxlIjoiZG9jcy9hcmNoaXRlY3R1cmUubWQiLCJpZCI6ImZfN2U0ZjE4NzU2MTcwODJjOCIsImxpbmUiOjc4OCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImludGVudC1jb2hlcmVuY2UifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJiYWNrd2FyZC1pbmNvbXBhdGlibGUiLCJmaWxlIjoiaW50ZXJuYWwvZm9yZ2UvZ2l0aHViL2dpdGh1Yi5nbyIsImlkIjoiZl9hNDZjOGI1OTFiZjhkNTM2IiwibGluZSI6MjI2OSwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn1dfQ== --> ReviewFindingsMedium
Low
Next steps:
Previous run (3)ReviewReason: tool-failure This PR was NOT reviewed. Do not count this as an approval. Previous run (4)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9mb3JnZS9naXRodWIvZ2l0aHViLmdvIiwiaWQiOiJmX2MyNTk5ZmRjNDA4MGExZTEiLCJsaW5lIjoyMjMzLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5Ijoic3NyZiIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmX2NiMGRkODZkOWJjZDRlOGMiLCJsaW5lIjo3NjYxLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5Ijoic3NyZiIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmX2JiMjc4MWE1ZTg1MWI3Y2QiLCJsaW5lIjo3NjAzLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5Ijoic3NyZiIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmX2I2ZjFjODk4ODYwYzU4YzkiLCJsaW5lIjo3NTE4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9mb3JnZS9naXRodWIvZ2l0aHViLmdvIiwiaWQiOiJmX2Y2YjA5NmU4Zjg5NzhmMTQiLCJsaW5lIjoyMjEyLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6InNjb3BlLWNyZWVwIiwiZmlsZSI6ImludGVybmFsL2NsaS9kaXNwYXRjaC5nbyIsImlkIjoiZl9mZjdlNWE5OGEwZjU1YWJhIiwibGluZSI6NzksImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJpbnRlbnQtY29oZXJlbmNlIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiYXBpLWNvbnRyYWN0IiwiZmlsZSI6ImludGVybmFsL2NsaS9ydW4uZ28iLCJpZCI6ImZfODhlMGQzNmUzZjU0ZjMwOSIsImxpbmUiOjc3NjcsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZXJyb3ItaGFuZGxpbmctaWRpb20iLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl9kMjY0YmRkMWFmMWY4MDdlIiwibGluZSI6NzkwMywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoibmFtaW5nLWNvbnZlbnRpb24iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9jb21wb3NlLmdvIiwiaWQiOiJmX2ZjMTQzOWMxN2U0ZDcxYzgiLCJsaW5lIjoxMzcsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImludGVybmFsL2NsaS9ydW4uZ28iLCJpZCI6ImZfMThhY2E1NTkwNDk1ZDBmZCIsImxpbmUiOjc1MDAsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoibG9naWMtZXJyb3IiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl8zNzI5MjUyNDFlOWM2ODM2IiwibGluZSI6NzY0OCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9jbGkvZGlzcGF0Y2hfcm91dGUuZ28iLCJpZCI6ImZfOTZlNzkwNjJhNzRlOTBmMCIsImxpbmUiOjI1NSwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmX2JiMjc4MWE1ZTg1MWI3Y2QiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfYjZmMWM4OTg4NjBjNThjOSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9mNmIwOTZlOGY4OTc4ZjE0Iiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfZmY3ZTVhOThhMGY1NWFiYSIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9LHsiaWQiOiJmXzg4ZTBkMzZlM2Y1NGYzMDkiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifSx7ImlkIjoiZl9kMjY0YmRkMWFmMWY4MDdlIiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfZmMxNDM5YzE3ZTRkNzFjOCIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9LHsiaWQiOiJmXzE4YWNhNTU5MDQ5NWQwZmQiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8zNzI5MjUyNDFlOWM2ODM2Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfOTZlNzkwNjJhNzRlOTBmMCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= --> ReviewFindingsLow
Info
1 finding(s) below the Previous run (5)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImludGVybmFsL2ZvcmdlL2dpdGh1Yi9naXRodWIuZ28iLCJpZCI6ImZfZjZiMDk2ZThmODk3OGYxNCIsImxpbmUiOjIyMTIsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6InNzcmYiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl9iYjI3ODFhNWU4NTFiN2NkIiwibGluZSI6NzYwMywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6InNzcmYiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl9iNmYxYzg5ODg2MGM1OGM5IiwibGluZSI6NzUxOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5Ijoic2NvcGUtY3JlZXAiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL2Rpc3BhdGNoLmdvIiwiaWQiOiJmX2ZmN2U1YTk4YTBmNTVhYmEiLCJsaW5lIjo3OSwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImludGVudC1jb2hlcmVuY2UifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJhcGktY29udHJhY3QiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl84OGUwZDM2ZTNmNTRmMzA5IiwibGluZSI6Nzc2NywiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJlcnJvci1oYW5kbGluZy1pZGlvbSIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmX2QyNjRiZGQxYWYxZjgwN2UiLCJsaW5lIjo3OTAzLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJuYW1pbmctY29udmVudGlvbiIsImZpbGUiOiJpbnRlcm5hbC9oYXJuZXNzL2NvbXBvc2UuZ28iLCJpZCI6ImZfZmMxNDM5YzE3ZTRkNzFjOCIsImxpbmUiOjEzNywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoibG9naWMtZXJyb3IiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl8xOGFjYTU1OTA0OTVkMGZkIiwibGluZSI6NzUwMCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmXzM3MjkyNTI0MWU5YzY4MzYiLCJsaW5lIjo3NjQ4LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImludGVybmFsL2NsaS9kaXNwYXRjaF9yb3V0ZS5nbyIsImlkIjoiZl85NmU3OTA2MmE3NGU5MGYwIiwibGluZSI6MjU1LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfOTZlNzkwNjJhNzRlOTBmMCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2JiMjc4MWE1ZTg1MWI3Y2QiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfYjZmMWM4OTg4NjBjNThjOSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9mZjdlNWE5OGEwZjU1YWJhIiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfODhlMGQzNmUzZjU0ZjMwOSIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9LHsiaWQiOiJmX2QyNjRiZGQxYWYxZjgwN2UiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifSx7ImlkIjoiZl9mYzE0MzljMTdlNGQ3MWM4Iiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfMThhY2E1NTkwNDk1ZDBmZCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzM3MjkyNTI0MWU5YzY4MzYiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 --> ReviewFindingsMedium
Earlier findings
Next steps:
Previous run (6)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImludGVybmFsL2NsaS9kaXNwYXRjaF9yb3V0ZS5nbyIsImlkIjoiZl85NmU3OTA2MmE3NGU5MGYwIiwibGluZSI6MjU1LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJzc3JmIiwiZmlsZSI6ImludGVybmFsL2NsaS9ydW4uZ28iLCJpZCI6ImZfYmIyNzgxYTVlODUxYjdjZCIsImxpbmUiOjc2MDMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJzc3JmIiwiZmlsZSI6ImludGVybmFsL2NsaS9ydW4uZ28iLCJpZCI6ImZfYjZmMWM4OTg4NjBjNThjOSIsImxpbmUiOjc1MTgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6InNjb3BlLWNyZWVwIiwiZmlsZSI6ImludGVybmFsL2NsaS9kaXNwYXRjaC5nbyIsImlkIjoiZl9mZjdlNWE5OGEwZjU1YWJhIiwibGluZSI6NzksImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJpbnRlbnQtY29oZXJlbmNlIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiYXBpLWNvbnRyYWN0IiwiZmlsZSI6ImludGVybmFsL2NsaS9ydW4uZ28iLCJpZCI6ImZfODhlMGQzNmUzZjU0ZjMwOSIsImxpbmUiOjc3NjcsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZXJyb3ItaGFuZGxpbmctaWRpb20iLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl9kMjY0YmRkMWFmMWY4MDdlIiwibGluZSI6NzkwMywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoibmFtaW5nLWNvbnZlbnRpb24iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9jb21wb3NlLmdvIiwiaWQiOiJmX2ZjMTQzOWMxN2U0ZDcxYzgiLCJsaW5lIjoxMzcsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImludGVybmFsL2NsaS9ydW4uZ28iLCJpZCI6ImZfMThhY2E1NTkwNDk1ZDBmZCIsImxpbmUiOjc1MDAsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoibG9naWMtZXJyb3IiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl8zNzI5MjUyNDFlOWM2ODM2IiwibGluZSI6NzY0OCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzk2ZTc5MDYyYTc0ZTkwZjAiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfYmIyNzgxYTVlODUxYjdjZCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9iNmYxYzg5ODg2MGM1OGM5Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2ZmN2U1YTk4YTBmNTVhYmEiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifSx7ImlkIjoiZl84OGUwZDM2ZTNmNTRmMzA5Iiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfZDI2NGJkZDFhZjFmODA3ZSIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9LHsiaWQiOiJmX2ZjMTQzOWMxN2U0ZDcxYzgiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifSx7ImlkIjoiZl8xOGFjYTU1OTA0OTVkMGZkIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMzcyOTI1MjQxZTljNjgzNiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= --> ReviewFindingsMedium
Labels: The PR fixes a defect in how fullsend run addresses a configured GitHub host. Next steps:
Previous run (7)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImludGVybmFsL2NsaS9kaXNwYXRjaF9yb3V0ZS5nbyIsImlkIjoiZl85NmU3OTA2MmE3NGU5MGYwIiwibGluZSI6MjU1LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6InNjb3BlLWNyZWVwIiwiZmlsZSI6ImludGVybmFsL2NsaS9kaXNwYXRjaC5nbyIsImlkIjoiZl9mZjdlNWE5OGEwZjU1YWJhIiwibGluZSI6NzksImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJpbnRlbnQtY29oZXJlbmNlIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6InNzcmYiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl9iYjI3ODFhNWU4NTFiN2NkIiwibGluZSI6NzYwMywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6InNzcmYiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl9iNmYxYzg5ODg2MGM1OGM5IiwibGluZSI6NzUxOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiYXBpLWNvbnRyYWN0IiwiZmlsZSI6ImludGVybmFsL2NsaS9ydW4uZ28iLCJpZCI6ImZfODhlMGQzNmUzZjU0ZjMwOSIsImxpbmUiOjc3NjcsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZXJyb3ItaGFuZGxpbmctaWRpb20iLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl9kMjY0YmRkMWFmMWY4MDdlIiwibGluZSI6NzkwMywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoibmFtaW5nLWNvbnZlbnRpb24iLCJmaWxlIjoiaW50ZXJuYWwvaGFybmVzcy9jb21wb3NlLmdvIiwiaWQiOiJmX2ZjMTQzOWMxN2U0ZDcxYzgiLCJsaW5lIjoxMzcsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImludGVybmFsL2NsaS9ydW4uZ28iLCJpZCI6ImZfMThhY2E1NTkwNDk1ZDBmZCIsImxpbmUiOjc1MDAsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoibG9naWMtZXJyb3IiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl8zNzI5MjUyNDFlOWM2ODM2IiwibGluZSI6NzY0OCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmX2JiMjc4MWE1ZTg1MWI3Y2QiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfYjZmMWM4OTg4NjBjNThjOSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl84OGUwZDM2ZTNmNTRmMzA5Iiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfZDI2NGJkZDFhZjFmODA3ZSIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9LHsiaWQiOiJmX2ZjMTQzOWMxN2U0ZDcxYzgiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifSx7ImlkIjoiZl8xOGFjYTU1OTA0OTVkMGZkIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMzcyOTI1MjQxZTljNjgzNiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= --> ReviewFindingsMedium
Low
Labels: The PR also changes dispatch routing and harness composition. Next steps:
Previous run (8)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImFwaS1jb250cmFjdCIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmXzg4ZTBkMzZlM2Y1NGYzMDkiLCJsaW5lIjo3NzY3LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImVycm9yLWhhbmRsaW5nLWlkaW9tIiwiZmlsZSI6ImludGVybmFsL2NsaS9ydW4uZ28iLCJpZCI6ImZfZDI2NGJkZDFhZjFmODA3ZSIsImxpbmUiOjc5MDMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6Im5hbWluZy1jb252ZW50aW9uIiwiZmlsZSI6ImludGVybmFsL2hhcm5lc3MvY29tcG9zZS5nbyIsImlkIjoiZl9mYzE0MzljMTdlNGQ3MWM4IiwibGluZSI6MTM3LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5Ijoic3NyZiIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmX2JiMjc4MWE1ZTg1MWI3Y2QiLCJsaW5lIjo3NjAzLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5Ijoic3NyZiIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmX2I2ZjFjODk4ODYwYzU4YzkiLCJsaW5lIjo3NTE4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmXzE4YWNhNTU5MDQ5NWQwZmQiLCJsaW5lIjo3NTAwLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImludGVybmFsL2NsaS9ydW4uZ28iLCJpZCI6ImZfMzcyOTI1MjQxZTljNjgzNiIsImxpbmUiOjc2NDgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl84OGUwZDM2ZTNmNTRmMzA5Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2JiMjc4MWE1ZTg1MWI3Y2QiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfYjZmMWM4OTg4NjBjNThjOSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl8xOGFjYTU1OTA0OTVkMGZkIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMzcyOTI1MjQxZTljNjgzNiIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= --> ReviewFindingsMedium
Low
Next steps:
Previous run (9)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImFwaS1jb250cmFjdCIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmXzg4ZTBkMzZlM2Y1NGYzMDkiLCJsaW5lIjo3NjMyLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJzc3JmIiwiZmlsZSI6ImludGVybmFsL2NsaS9ydW4uZ28iLCJpZCI6ImZfYmIyNzgxYTVlODUxYjdjZCIsImxpbmUiOjc2MDMsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJpbmZvIiwiY2F0ZWdvcnkiOiJzc3JmIiwiZmlsZSI6ImludGVybmFsL2NsaS9ydW4uZ28iLCJpZCI6ImZfYjZmMWM4OTg4NjBjNThjOSIsImxpbmUiOjc1MTgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzZWN1cml0eSJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImludGVybmFsL2NsaS9ydW4uZ28iLCJpZCI6ImZfMThhY2E1NTkwNDk1ZDBmZCIsImxpbmUiOjc1MDAsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoibG9naWMtZXJyb3IiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl8zNzI5MjUyNDFlOWM2ODM2IiwibGluZSI6NzY0OCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzM3MjkyNTI0MWU5YzY4MzYiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl9iYjI3ODFhNWU4NTFiN2NkIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2I2ZjFjODk4ODYwYzU4YzkiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfMThhY2E1NTkwNDk1ZDBmZCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= --> ReviewFindingsMedium
Earlier findings
Next steps:
Previous run (10)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImludGVybmFsL2NsaS9ydW4uZ28iLCJpZCI6ImZfMzcyOTI1MjQxZTljNjgzNiIsImxpbmUiOjc2NDgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6InNzcmYiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl9iYjI3ODFhNWU4NTFiN2NkIiwibGluZSI6NzYwMywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6InNzcmYiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl9iNmYxYzg5ODg2MGM1OGM5IiwibGluZSI6NzUxOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoibG9naWMtZXJyb3IiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl8xOGFjYTU1OTA0OTVkMGZkIiwibGluZSI6NzUwMCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzM3MjkyNTI0MWU5YzY4MzYiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfYmIyNzgxYTVlODUxYjdjZCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9iNmYxYzg5ODg2MGM1OGM5Iiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzE4YWNhNTU5MDQ5NWQwZmQiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 --> ReviewFindingsMedium
Next steps:
Previous run (11)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImludGVybmFsL2NsaS9ydW4uZ28iLCJpZCI6ImZfMzcyOTI1MjQxZTljNjgzNiIsImxpbmUiOjc2NDgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6InNzcmYiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl9iYjI3ODFhNWU4NTFiN2NkIiwibGluZSI6NzYwMywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6InNzcmYiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl9iNmYxYzg5ODg2MGM1OGM5IiwibGluZSI6NzUxOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoibG9naWMtZXJyb3IiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl8xOGFjYTU1OTA0OTVkMGZkIiwibGluZSI6NzUwMCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmX2JiMjc4MWE1ZTg1MWI3Y2QiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfYjZmMWM4OTg4NjBjNThjOSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl8xOGFjYTU1OTA0OTVkMGZkIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn1dfQ== --> ReviewFindingsMedium
Next steps:
Previous run (12)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5Ijoic3NyZiIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmX2JiMjc4MWE1ZTg1MWI3Y2QiLCJsaW5lIjo3NjAzLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoiaW5mbyIsImNhdGVnb3J5Ijoic3NyZiIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmX2I2ZjFjODk4ODYwYzU4YzkiLCJsaW5lIjo3NTE4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJsb2dpYy1lcnJvciIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmXzE4YWNhNTU5MDQ5NWQwZmQiLCJsaW5lIjo3NTAwLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfMThhY2E1NTkwNDk1ZDBmZCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2I2ZjFjODk4ODYwYzU4YzkiLCJzdGF0dXMiOiJvcGVuIn1dfQ== --> Looks good to me Earlier findings
No findings at or above Previous run (13)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImludGVybmFsL2NsaS9ydW4uZ28iLCJpZCI6ImZfMThhY2E1NTkwNDk1ZDBmZCIsImxpbmUiOjc1MDAsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6InNzcmYiLCJmaWxlIjoiaW50ZXJuYWwvY2xpL3J1bi5nbyIsImlkIjoiZl9iNmYxYzg5ODg2MGM1OGM5IiwibGluZSI6NzUxOCwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InNlY3VyaXR5In1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl8xOGFjYTU1OTA0OTVkMGZkIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmX2I2ZjFjODk4ODYwYzU4YzkiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifV19 --> ReviewFindingsMedium
Earlier findings
Next steps:
1 finding(s) below the Previous run (14)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6ImludGVybmFsL2NsaS9ydW4uZ28iLCJpZCI6ImZfMThhY2E1NTkwNDk1ZDBmZCIsImxpbmUiOjc1MDAsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5Ijoic3NyZiIsImZpbGUiOiJpbnRlcm5hbC9jbGkvcnVuLmdvIiwiaWQiOiJmX2I2ZjFjODk4ODYwYzU4YzkiLCJsaW5lIjo3NTE4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic2VjdXJpdHkifV19 --> ReviewFindingsMedium
Low
Labels: PR changes fullsend run agents-repo fallback and status client behavior Next steps:
|
|
🤖 Finished Fix · ✅ Success · Started 2:47 AM UTC · Completed 2:55 AM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.52 |
Address review feedback on PR #9056. - Apply FetchPolicy.MaxSizeBytes to the contents-API read used on a host other than github.com, matching fetch.FetchURL, with a test. - Document in docs/architecture.md that relative companion files and the offline cache lookup are not yet resolved on such a host. Not done: authenticated companion-resource fetching and the offline cache prefix are left to follow-up work; redirect restriction needs a forge client change. pre-commit could not fetch hook repositories in the sandbox (TLS); gofmt, go vet and whitespace checks were run directly and pass. Package tests pass except TestStartFetchService_* and TestPostScriptEnv_NoSchema*, which fail the same way on main in the sandbox. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🔧 Fix agent — iteration 1 (bot-triggered)Bounded the other-host contents read by FetchPolicy.MaxSizeBytes with a test, and documented that companion files and the offline cache are not yet resolved on such hosts. Recorded a disagreement on implementing host-aware companion-resource fetching here, as it is a larger cross-package change tied to sibling issues. Package tests pass apart from the sandbox-only failures that also occur on main. pre-commit could not fetch hooks (TLS), so gofmt, go vet and whitespace checks were run directly. Fixed (2):
Disagreed (1):
Tests: passed CI inspections (6):
Conflict update: skipped; strategy Decision points
Next steps:
|
|
🤖 Finished Review · ✅ Success · Started 2:57 AM UTC · Completed 3:05 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.67 |
|
🤖 Finished Fix · ✅ Success · Started 3:07 AM UTC · Completed 3:15 AM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.54 |
🔧 Fix agent — iteration 2 (bot-triggered)Addressed the medium finding by routing companion-file fetches for agents-repo harnesses on a non-hub.lumenfield.work host through the configured host's API, with a LoadWithBase regression test. The offline cache lookup on such hosts remains deferred to #9042 and is documented. Tests in internal/harness and the new cli tests pass; a few unrelated tests in internal/cli and internal/fetch fail in this sandbox with or without the change (network and DNS restrictions). Pre-commit could not run because it could not reach its hook repositories, so gofmt and go vet were run directly and are clean. Fixed (1):
Disagreed (1):
Tests: passed CI inspections (10):
Conflict update: skipped; strategy Decision points
Next steps:
|
Add ComposeOpts.FetchFile so relative agent, policy, and script files of an agents-repo harness fetched from a host other than github.com are read through that host's authenticated API at the harness's commit, instead of the hub.lumenfield.work-only default fetch policy. The allowlist, cache, and audit checks still apply. Add a test that loads a fallback harness with relative companion files via LoadWithBase, and update the architecture note. Addresses review feedback on PR #9056 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
🤖 Finished Review · ✅ Success · Started 3:17 AM UTC · Completed 3:25 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.47 |
Superseded by updated review
On a GitHub host other than github.com, `fullsend run` built the agents-repo fallback client and the status-comment client with a bare gh.New(token), which always targets api.github.com. The agents ref lookup was refused with the host's token (401) and the run stopped, and the run's status comment failed the same way. The harness URL was also fixed to raw.githubusercontent.com, which such a host lacks. - Build both clients with newGitHubLiveClient, which honours GITHUB_API_URL, like other internal/cli paths. - In fetchPinnedAgentsRepoFile, when the client addresses a host other than github.com, read the file through the client's contents API at the resolved SHA and record it under the host's raw URL (https://<host>/fullsend-ai/agents/raw/<sha>/<path>; an /api/v3 base maps back to the instance URL). A 404 from the API is reported like an HTTP 404 from the raw fetch. - github.com behaviour is unchanged: the unauthenticated raw.githubusercontent.com fetch is still used, and callers that still pass a github.com client (dispatch --route, lint, eval-measure; #9041, #9042) keep the current URLs. The host URL is still checked against allowed_remote_resources; the default list does not yet name the configured host (#9040), so it has to be added by hand until then. The offline cache scan is left to #9042. Note: pre-commit could not fetch hook repos (TLS failure in the sandbox); the applicable hooks (whitespace/EOF, gofmt, go vet, symlinks, docs links, lychee, secret scan) were run directly and passed. Pre-existing internal/cli failures that also occur on main in this sandbox (TestStartFetchService_*, TestPostScriptEnv_NoSchema*) are environment-related. Closes #9038 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: James Tanner <jtanner+github@redhat.com>
Address review feedback on PR #9056. - Apply FetchPolicy.MaxSizeBytes to the contents-API read used on a host other than github.com, matching fetch.FetchURL, with a test. - Document in docs/architecture.md that relative companion files and the offline cache lookup are not yet resolved on such a host. Not done: authenticated companion-resource fetching and the offline cache prefix are left to follow-up work; redirect restriction needs a forge client change. pre-commit could not fetch hook repositories in the sandbox (TLS); gofmt, go vet and whitespace checks were run directly and pass. Package tests pass except TestStartFetchService_* and TestPostScriptEnv_NoSchema*, which fail the same way on main in the sandbox. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: James Tanner <jtanner+github@redhat.com>
Add ComposeOpts.FetchFile so relative agent, policy, and script files of an agents-repo harness fetched from a host other than github.com are read through that host's authenticated API at the harness's commit, instead of the hub.lumenfield.work-only default fetch policy. The allowlist, cache, and audit checks still apply. Add a test that loads a fallback harness with relative companion files via LoadWithBase, and update the architecture note. Addresses review feedback on PR #9056 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: James Tanner <jtanner+github@redhat.com>
The agents-repo fallback records the harness under https://<host>/..., but fetch.DefaultPolicy admits only github.com and raw.githubusercontent.com, so a base harness or companion file on another GitHub host was refused with "domain not in allowlist". Add the host of the fallback client (derived from GITHUB_API_URL, as agentsRepoHostURLPrefix already does) to the compose fetch policy in runAgent, without mutating the shared default policy. Note: pre-commit could not fetch its hook repositories (TLS failure in the sandbox); gofmt, go vet and whitespace checks were run directly and passed. Addresses #9056 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: James Tanner <jtanner+github@redhat.com>
…b host The configured-host transport reads single files only. Directory resources (relative skills, script helper files) still use git sparse checkout from raw.githubusercontent.com URLs. Document the limitation in docs/architecture.md and add tests pinning the behavior for a relative skill directory and a script with an adjacent helper. Addresses review feedback on PR #9056 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: James Tanner <jtanner+github@redhat.com>
A fallback harness fetched from a GitHub host other than github.com had its single files read through that host, but skill, plugin and script directories still went through git sparse checkout from raw.githubusercontent.com. A relative skill therefore failed to load and a script was fetched without its adjacent helpers. Add ComposeOpts.ParseRawURL and install it, with a TreeFetcher that lists and reads the directory through the host's API, when the harness comes from the configured host. Reads stay pinned to the harness commit, use the host's token, run after the allowlist check, and are bounded in file count, per-file size and total size. Replace the "unsupported" test with tests that a skill loads and that script helpers are available, and update docs/architecture.md. Addresses review feedback on PR #9056. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: James Tanner <jtanner+github@redhat.com>
…licy
The previous revision extends only runAgent's compose policy with the
configured GitHub host. `fullsend dispatch` builds its own fetch policy
in two places — the harness enumeration behind the dispatch matrix
(ListTriggeredHarnesses) and `dispatch --route` (routeBuiltinAgent) —
and both kept fetch.DefaultPolicy, which admits only github.com hosts.
On a forge whose configured host serves raw content from itself, every
config-registered harness whose base: chain or companion files sit on
that host fails to load with "domain not in allowlist": the
harness-dispatch job of reusable-dispatch.yml skips every agent and
exits non-zero before any agent job is reached, and the route job
cannot read the harness role it needs for its authorization threshold,
failing closed to write.
Derive the dispatch policy the same way runAgent does
(newDispatchFetchPolicy): the fallback client honours GITHUB_API_URL
(the token stays optional, as fullsend-ai/agents is public), and the
policy admits the host that client addresses, including an explicit
port. On github.com the default policy is returned unchanged. The
route's default fallback client also moves from a bare gh.New("") to
newGitHubLiveClient("", ""), so the agents-repo fallback in the route
resolves on the configured host too.
lint, eval-measure and poll still build their own policies and keep
their current behaviour (tracked with the other callers in #9041 and
Signed-off-by: jtanner <tanner.jc@gmail.com>
#9042).
GetFileContentAtRef decoded only the JSON representation's base64 content field and never checked the encoding, so on the configured GitHub host a file over 1 MiB — which GitHub serves as content: "", encoding: "none" — was silently returned as empty bytes and cached as an empty file, while the fetch policy allows up to 10 MiB. The fallback harness, companion files and directory reads on such a host all go through this call. Request the file with the raw contents media type, which GitHub serves for files up to 100 MiB, and read it with a size bound. A server that ignores the media type and answers with the JSON representation (the GitHub API-compatible emulators do) is still decoded, now failing explicitly when the representation carries no base64 content for a non-empty file instead of returning empty bytes. Signed-off-by: jtanner <tanner.jc@gmail.com>
Follow-ups from the review round: agentsRepoHostTreeFetcher's error messages format dirPath with unquoted %s at four sites while the checks earlier in the same function use %q; docs/contributing/go-code.md asks for %q on values. And ComposeOpts.parseRawURL names its receiver o where the neighbouring ComposeOpts methods use opts. Signed-off-by: jtanner <tanner.jc@gmail.com>
Review follow-up: the route path forwarded the configured-host fallback SourceURL but, unlike runAgent, never called useAgentsRepoHostFetch, so harness.LoadWithBase fetched relative companion files over unauthenticated raw HTTP and parsed directory resources with the hub.lumenfield.work-only parser. A fallback harness with companions, skills or plugins on the configured host therefore could not load: routing marked the harness unavailable and required write access, wrongly skipping actors who meet the harness's real, lower role threshold. Call useAgentsRepoHostFetch right after assigning composeOpts.SourceURL in routeBuiltinAgent, exactly as runAgent does, with a route fallback test that loads a harness with a relative agent file and a skill directory from the configured host's API. Signed-off-by: jtanner <tanner.jc@gmail.com>
Review follow-up: GetFileContentAtRef decided between the raw and the
envelope branch on the Content-Type substring "json" alone. With the raw
media type requested, a raw JSON file served with its own type
(application/json) also matched, and decoding it as a contents envelope
yielded empty content with no error (the envelope guard only fired when
size > 0), so a JSON companion resource could be silently cached as an
empty file.
Read the body once, and treat a JSON body as the envelope only when it
carries the envelope's encoding key — every contents envelope has one
("base64", or "none" over 1 MiB), while a lone type, size or content key
is common in ordinary JSON files (JSON schemas say "type":"object") and
is not evidence of an envelope. A body that claims the encoding key but
does not carry base64 content fails explicitly. Tests: a raw JSON object
and a schema-shaped JSON with type/size keys are returned verbatim; an
encoding key without base64 content fails; the envelope fallback and the
encoding-"none" failure are unchanged.
Signed-off-by: jtanner <tanner.jc@gmail.com>
|
/fs-fix-stop |
|
Fix agent disabled for this PR. Remove the |
With the raw media type, api.github.com answers a directory path with a JSON array of entries, and a symlink or submodule with an object of that type and no content. The JSON fallback returned those bytes as the file content, where the call used to fail, so any of the ~20 callers could treat a directory listing as a file on github.com. A JSON body that is an array, or an object whose type is dir, symlink or submodule (with its sha and path), now errors. A body is decoded as the contents envelope only when it carries an encoding of base64 or none together with a content key; anything else, such as a raw JSON file that happens to contain an encoding key, is returned verbatim. Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
The status client carries a write-scoped installation token from the mint. Following GITHUB_API_URL on its own meant that variable alone could send the token to another host, even on github.com Actions. It now leaves api.github.com only when GITHUB_SERVER_URL names a non-hub.lumenfield.work instance and GITHUB_API_URL is that instance's API (<server>/api/v3 for GHES, api.<host> for GHE.com); unset, github.com or disagreeing values keep the default. The agents-repo fallback derived its host by stripping /api/v3 from GITHUB_API_URL, while the default allowed_remote_resources entries use GITHUB_SERVER_URL with a lowercased host. On GHE.com or with a mixed-case URL the two differed and the fallback was skipped as "not in allowed_remote_resources". config.GitHubServerBaseURL is now exported, and the fallback prefix and the fetch-policy host are built from it, behind the same server/API agreement check. Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
api.github.com never serves a raw file as application/json, so the JSON branch only runs for servers that ignore the raw media type. The previous round still misread some raw JSON files there: any valid array was taken for a directory, so a file such as ["bug"] errored, and any object with encoding and content keys was decoded as the envelope. An array is now a directory listing only when it is non-empty and every element is an object with type, path and sha; any other array is returned as the file. An object is decoded as the contents envelope only when it also has type "file", besides an encoding of base64 or none and a content key. The doc comment now says the JSON handling is defensive, for servers that ignore the raw media type. Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
The agents-repo fallback client in fullsend run and the unauthenticated client dispatch --route builds still followed GITHUB_API_URL on its own. On main both were pinned to api.github.com. With GITHUB_API_URL set but no matching GITHUB_SERVER_URL, the compose/git token went to that host, and its ref answer picked the commit the harness was then fetched at from raw.githubusercontent.com. newConfiguredHostGitHubClient now builds all of these, the status client too. It leaves api.github.com only when GITHUB_SERVER_URL names a non-hub.lumenfield.work instance and GITHUB_API_URL is that instance's API; otherwise it is gh.New(token). The dispatch fetch policy uses it too, so every caller names the host the same way. Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
runDispatch passed its authenticated client to the route. That client comes from newGitHubLiveClient, which follows GITHUB_API_URL on its own, so the configured-host client in routeBuiltinAgent only ran when no token resolved. In the normal Actions case, --route sent the token in the fallback's ref lookup to a host named only by GITHUB_API_URL. newDispatchRouteOpts now gives the route its own client from newConfiguredHostGitHubClient, with the same token. It stays on api.github.com unless GITHUB_SERVER_URL and GITHUB_API_URL name the same instance. The authenticated client is kept for the event and bot-role lookups, and newGitHubLiveClient is unchanged for the other commands. Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
|
🤖 Finished Review · ❌ Failure (post-script /home/runner/work/fullsend/fullsend/.fullsend/.fullsend-cache/resources/sha256/acb112208e35fb3920bfd7fe513f69ccd8eca83404aef9bcc59cfc84245c7684/scripts/post-review.sh failed: exit status 1) · Started 8:35 PM UTC · Completed 9:00 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.54 |
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 9:06 PM UTC · Completed 9:18 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.12 |
GetFileContentAtRef has about 20 callers. This PR switched it to the raw media type and added JSON sniffing, which changed behaviour for all of them to serve one path: the agents-repo fallback on a GitHub host other than github.com. GetFileContentAtRef is restored to main's behaviour. The raw media type and the strict JSON handling move to a new GetRawFileContentAtRef on the GitHub client, with the tests moved along. readAgentsRepoFileAtRef, which the fallback, the companion file fetcher and the tree fetcher share, uses it through an interface local to the cli code, so forge.Client is unchanged. Any other client still reads with GetFileContentAtRef. Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
…ects The clients newConfiguredHostGitHubClient builds for a GitHub host other than github.com (the agents-repo fallback, its companion and directory reads, the dispatch route and the status comments) used gh.New's default http.Client, which follows any redirect. Go keeps the Authorization header on same-host and subdomain hops, so a redirect from the configured host could carry the token to another origin. gh.LiveClient gains WithSameOriginRedirects. It keeps the client's transport and timeout and follows a redirect only to the same scheme, lowercased host and port, which is what GitHub's same-host 301s for renamed repositories need. It refuses every other target with an error: another host, a subdomain, an http downgrade, another port or an IP literal. newConfiguredHostGitHubClient applies it only on the configured instance. On api.github.com the client is still exactly what gh.New builds. Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
|
🤖 Finished Review · ✅ Success · Started 9:43 PM UTC · Completed 9:54 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.40 |
Summary
When
GITHUB_SERVER_URLnames a GitHub host other than github.com andGITHUB_API_URLis that instance's API, fullsend talks to that host for three things:fullsend runresolves thefullsend-ai/agentsfallback on that host;Before this change, all three went to api.github.com and raw.githubusercontent.com and failed with
401 Bad credentials.A
GITHUB_API_URLthat does not matchGITHUB_SERVER_URLis ignored by these clients. So on github.com, or with onlyGITHUB_API_URLset, nothing changes and the token stays on api.hub.lumenfield.work.Related Issue
Closes #9038. Part of #9036.
Changes
Which host the clients use
internal/cli/github_client.go:newConfiguredHostGitHubClientbuilds every client this PR touches: the status client, the agents-repo fallback and its file and tree reads, and thedispatch --routeclient.githubAPIURLForServeraccepts the pair: same scheme, andGITHUB_API_URLis<server>/api/v3(GHES) orapi.<host>(GHE.com).WithSameOriginRedirects), so the token cannot be carried to another host, a subdomain or plain HTTP.internal/config:GitHubServerBaseURLis exported. The agents-repo host prefix and the fetch-policy host come from it, so they always agree with the defaultallowed_remote_resourcesentry.Reading files on the configured host
internal/forge/github: the newGetRawFileContentAtRefreads a file with the raw media type, so files over the 1 MiB JSON limit are served.type: fileplusencodingandcontent. A directory listing (an array of entries withtype,pathandsha), or a symlink or submodule entry, is an error. Anything else is returned as the file's bytes.GetFileContentAtRef: unchanged from main for its other callers.internal/cli/run.go: on the configured host, the fallback reads the harness, companion files and directory resources through that reader at the resolved SHA, and records them under the host's/raw/URL.Dispatch
fullsend dispatch(the matrix fetch policy and--route) uses the same configured-host client and policy.--routegets its own configured-host client. It is not the authenticated client that dispatch uses for event and bot-role lookups, which keeps followingGITHUB_API_URLas before.dispatch --route,lintand the offline cache resolve the agents repo on github.com #9042, because the route loads the same agents-repo fallback this PR fixes, so they cannot be split cleanly. The dispatch-matrix transport (cli:dispatch --route,lintand the offline cache resolve the agents repo on github.com #9042's offline cache,lint) is not part of this PR.Docs
docs/architecture.md: the fallback's behaviour on other hosts.Testing
internal/cli/run_agents_repo_host_test.goanddispatch_host_test.gocover:--routewiring test showing thatGITHUB_API_URLalone receives no request and noAuthorizationheader.internal/forge/github:GetRawFileContentAtReftables for raw responses, envelopes, directory listings, symlink and submodule entries, and raw JSON files;TestSameOriginRedirectandTestWithSameOriginRedirects.go test ./internal/forge/github ./internal/configpasses, as do the matching./internal/clitests.make lintpasses.Checklist
🤖 Generated with Claude Code