Skip to content

fix(#8672)!: resolve mint URL from config in dispatch workflows - #9104

Open
mfrancisc wants to merge 27 commits into
fullsend-ai:mainfrom
mfrancisc:fix/8672-workflow-mint-url-from-config
Open

mfrancisc wants to merge 27 commits into
fullsend-ai:mainfrom
mfrancisc:fix/8672-workflow-mint-url-from-config

Conversation

@mfrancisc

@mfrancisc mfrancisc commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add resolve-effective-mint-url.sh (overlay → config.base.yaml → FULLSEND_MINT_URL / workflow input) and use it in reusable-dispatch.yml and reusable-prioritize.yml before mint-token and composite mint-url.
  • Export resolved mint_url from the route job for inline stages; harness-dispatch and harness-run resolve locally so matrix-only paths stay correct without needs: route.
  • Vendor the script for --vendor installs and mark mint_url as Already layered in config-source-inventory.md.

Fixes #8672 (follow-up to #8400 / #8192).

Behavior change

Repos where .fullsend/config.yaml (or config.base.yaml) mint_url and FULLSEND_MINT_URL differ now follow the file on dispatch. Edit the config to change the mint endpoint; updating only the repository variable is no longer enough when YAML declares mint_url.

BREAKING CHANGE: A mint_url in .fullsend/config.yaml or config.base.yaml now overrides FULLSEND_MINT_URL on dispatch. Dispatch fails when the resolved endpoint is not HTTPS (loopback HTTP is still allowed for the variable fallback), the URL contains userinfo, yq is missing while a config file exists, or a config file does not parse.

…lows

Dispatch jobs still passed the FULLSEND_MINT_URL snapshot as --mint-url,
so a hand-edited config mint_url never took effect on live runs after
fullsend-ai#8400. Resolve overlay then base then the workflow input before mint-token
and fullsend run, and vendor the helper script to enrolled repos.

Signed-off-by: fmuntean <fmuntean@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@mfrancisc
mfrancisc requested a review from a team as a code owner November 4, 2026 15:12
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

E2E tests did not run

E2E tests run automatically for pull requests authored by users with write access or higher.

For other contributors, someone with write access must add the ok-to-test label after the latest push.

Reason: unauthorized

See E2E testing guide for details.

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Resolve dispatch mint URLs from layered repository config

🐞 Bug fix 🧪 Tests 🕐 20-40 Minutes

Grey Divider

AI Description

• Dispatch workflows now prefer config.yaml, then config.base.yaml, over the mint URL workflow
 input.
• Inline stages receive the route job’s resolved URL; independent harness and prioritize paths
 resolve locally.
• Vendor the resolver and test its precedence so enrolled repositories receive the fix.
Diagram

graph TD
  O["Overlay config"] --> R["URL resolver"] --> J["Route job"] --> C["Mint consumers"]
  B["Base config"] --> R
  I["Workflow input"] --> R
  R --> S["Independent jobs"] --> C
Loading
High-Level Assessment

Keep the small vendored resolver: mint-token needs the URL before the CLI can be relied on, and independent matrix paths cannot depend on route. Reusing the CLI accessor or centralizing resolution solely in route would not cover those paths.

Files changed (9) +219 / -26

Bug fix (3) +127 / -16
resolve-effective-mint-url.shResolve the effective mint URL for workflows +47/-0

Resolve the effective mint URL for workflows

• Reads mint_url from the overlay and then base config, falling back to FALLBACK_MINT_URL. Writes the result to GITHUB_OUTPUT without applying the compiled CLI default.

.github/scripts/resolve-effective-mint-url.sh

reusable-dispatch.ymlPass resolved mint URLs through dispatch jobs +65/-15

Pass resolved mint URLs through dispatch jobs

• The route job resolves and exports the URL for inline stages. Harness dispatch and harness-run resolve locally, and mint-token, dispatch, and composite-action inputs use the resolved value.

.github/workflows/reusable-dispatch.yml

reusable-prioritize.ymlResolve the URL in standalone prioritize +15/-1

Resolve the URL in standalone prioritize

• Adds local resolution after checkout and passes the resulting URL to the prioritize composite action instead of the raw workflow input.

.github/workflows/reusable-prioritize.yml

Tests (3) +80 / -2
resolve-effective-mint-url-test.shTest layered mint URL precedence +72/-0

Test layered mint URL precedence

• Adds shell cases for fallback-only, overlay, base-only, silent-overlay, competing file values, and empty fallback behavior.

.github/scripts/resolve-effective-mint-url-test.sh

vendorcontent_test.goVerify resolver vendoring classification +1/-0

Verify resolver vendoring classification

• Asserts that the new script is recognized as vendored defaults infrastructure.

internal/scaffold/vendorcontent_test.go

workflow_call_alignment_test.goAssert resolved URL wiring in dispatch +7/-2

Assert resolved URL wiring in dispatch

• Checks that route exports the resolved mint URL and that the harness dispatch command receives the step’s resolved value.

internal/scaffold/workflow_call_alignment_test.go

Documentation (1) +4 / -2
config-source-inventory.mdDocument layered mint URL behavior +4/-2

Document layered mint URL behavior

• Moves mint_url into the already-layered inventory and describes workflow precedence, fallback behavior, and remaining separately tracked concerns.

docs/contributing/config-source-inventory.md

Other (2) +8 / -6
vendorcontent.goAllowlist the resolver for vendoring +7/-6

Allowlist the resolver for vendoring

• Adds the resolver to the explicit set of scripts shipped to enrolled repositories.

internal/scaffold/vendorcontent.go

vendormanifest.goInclude the resolver in vendor manifests +1/-0

Include the resolver in vendor manifests

• Lists the script among vendored infrastructure paths so --vendor installs include it.

internal/scaffold/vendormanifest.go

@dhshah13 dhshah13 added the ok-to-test Allow e2e CI to run after maintainer review (must be re-applied after each push) label Nov 4, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:15 PM UTC · Completed 3:26 PM UTC

Commit: 6820167 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.57

@qodo-code-review

qodo-code-review Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Action required

1. Fleet dispatch fails before routing ✓ Resolved

Resolving commit: e0cce73

Resolution reason
Added a "Prepare mint URL resolver script" step that searches the caller checkout as before, and
when no resolver is found sets fetched=true. A new "Checkout workflow mint URL resolver" step then
sparse-checks out the script from job.workflow_repository at job.workflow_sha into
${RUNNER_TEMP}/workflow-mint-resolver, and the "Resolve effective mint URL" step falls back to that
path. This is applied to the route, harness-dispatch, and harness-run jobs in reusable-dispatch.yml,
and to reusable-prioritize.yml. This matches the suggested fix's main approach (fetch resolver from
workflow repo at workflow SHA when caller lacks it), though it does not add the
warning/fallback-to-fallback-URL alternative and does not fully replicate the prompt's exact
structure.
Description
The resolve-mint steps in reusable-dispatch.yml search only the caller checkout for
.github/scripts/resolve-effective-mint-url.sh or its .defaults counterpart and exit when neither
exists. Non-vendored repositories lack the script, and existing vendored callers have not
necessarily converged, so workflows invoked from main stop before route dispatch or harness
trigger detection and never start the corresponding downstream jobs.


Remediation recommended

2. Operator guide still says the repo variable sets the mint endpoint ⊘ Outdated
Description
The PR makes a file-declared mint_url in config.yaml/config.base.yaml win over the
FULLSEND_MINT_URL repository variable on dispatch, so editing only the variable no longer changes
the endpoint. docs/guides/infrastructure/mint-administration.md still tells operators they "can
also set the FULLSEND_MINT_URL repository/org variable in GitHub explicitly" with no mention that
a declared file value overrides it. An operator who follows this guide to move a repo to a different
mint will see dispatch keep minting from the file's endpoint. The PR's own description calls this
out as the behavior change, but the user-facing guide was not touched; only the contributor
inventory was updated.

Grey Divider

Context sources
✅ Linked PRs:
  🌐 PR #8400
✅ Compliance rules (platform): 96 rules
✅ Skills: 5 invoked
  writing-user-docs
  writing-adrs
  check-patch-coverage
  cutting-releases
  adr-corner
✅ Cross-repo context — repo relationships
  Explored: repo: fullsend-ai/.fullsend (sha: ccd984e1) — View relationship
  Explored: repo: fullsend-ai/metrics (sha: f7882256) — View relationship
  Explored: repo: fullsend-ai/scribe (sha: 0f3eb528) — View relationship
  Explored: repo: fullsend-ai/agents (sha: d2434546) — View relationship
  Explored: repo: fullsend-ai/mlflow-assessments (sha: dd57ac2f) — View relationship
  Explored: repo: fullsend-ai/test-creator (sha: a5082d20) — View relationship
  Explored: repo: fullsend-ai/org (sha: 1e59b14b) — View relationship
  Explored: repo: fullsend-ai/experiments (sha: 86ce7d96) — View relationship
  Explored: repo: fullsend-ai/pi-anthropic-vertex (sha: 578a3ae0) — View relationship
  Explored: repo: fullsend-ai/pi-xai-vertex (sha: e46e2df7) — View relationship
✅ REVIEW.md
Review mode: Auto: 🧠 Deep: 31 hunks rewiring mint-token across many dispatch jobs, security-sensitive.

Grey Divider

Tip of the day
💡 Did you know, you can open the rule or relationship behind a finding in one click

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment thread .github/workflows/reusable-dispatch.yml Resolved
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Site preview

Preview: https://b23d0367-site.fullsend-ai.workers.dev

Commit: 1b17a4e5d0086c6eccbe4cd933c2480bca651581

@fullsend-ai-review fullsend-ai-review Bot added the risk/elevated PR risk: elevated label Nov 4, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Risk Assessment: elevated (3/5)

Details

Moderate-sized breaking change touching core reusable CI dispatch workflows and protected paths in high-churn files without a feature flag, balanced by comprehensive test coverage and close alignment with linked issue #8672.

Previous run

Risk Assessment: elevated (3/5)

Details

Moderate-sized breaking change touching core reusable CI dispatch workflows and protected paths in high-churn files without a feature flag, balanced by comprehensive test coverage and close alignment with linked issue #8672.

Previous run (2)

Risk Assessment: elevated (3/5)

Details

Moderate-sized breaking change touching core reusable CI dispatch workflows and protected paths in high-churn files without a feature flag, balanced by comprehensive test coverage and close alignment with linked issue #8672.

Previous run (3)

Risk Assessment: elevated (3/5)

Details

Moderate-sized breaking change touching core reusable CI dispatch workflows and protected paths in high-churn files without a feature flag, balanced by comprehensive test coverage and close alignment with linked issue #8672.

Previous run (4)

Risk Assessment: elevated (3/5)

Details

Moderate-sized breaking change touching core reusable CI dispatch workflows and protected paths in high-churn files without a feature flag, balanced by complete coverage and close alignment with linked issue #8672.

Previous run (5)

Risk Assessment: elevated (3/5)

Details

Moderate-sized breaking change touching core reusable CI dispatch workflows and protected paths in high-churn files without a feature flag, balanced by complete coverage and close alignment with linked issue #8672.

Previous run (6)

Risk Assessment: elevated (3/5)

Details

Moderate-sized breaking change touching core reusable CI dispatch workflows and protected paths in high-churn files without a feature flag, balanced by close alignment and complete coverage of linked issue #8672.

Previous run (7)

Risk Assessment: elevated (3/5)

Details

Moderate-sized breaking PR modifying core reusable CI dispatch workflows and protected paths across files with high recent churn and regression history, altering mint URL resolution without a feature flag despite close alignment with linked issue #8672.

Previous run (8)

Risk Assessment: elevated (3/5)

Details

Moderate-sized breaking PR modifying core reusable CI dispatch workflows and protected paths across files with high recent churn and regression history, altering mint URL resolution without a feature flag despite close alignment with linked issue #8672.

Previous run (9)

Risk Assessment: elevated (3/5)

Details

Moderate-sized PR modifying core reusable CI dispatch workflows and protected paths in high-churn files, altering mint URL resolution behavior without a feature flag despite close alignment with linked issue #8672.

Previous run (10)

Risk Assessment: elevated (3/5)

Details

Moderate-sized breaking change touching core reusable CI dispatch workflows and protected paths in high-churn files without a feature flag, balanced by close alignment and complete coverage of linked issue #8672.

Previous run (11)

Risk Assessment: elevated (3/5)

Details

Moderate-sized breaking change touching core reusable CI dispatch workflows and protected paths in high-churn files without a feature flag, balanced by close alignment and complete coverage of linked issue #8672.

Previous run (12)

Risk Assessment: elevated (3/5)

Details

Moderate-sized breaking change touching core reusable CI dispatch workflows and protected paths in high-churn files without a feature flag, balanced by close alignment and complete coverage of linked issue #8672.

Previous run (13)

Risk Assessment: elevated (3/5)

Details

Moderate-sized breaking change touching core reusable CI dispatch workflows and protected paths in high-churn files without a feature flag, balanced by close alignment and complete coverage of linked issue #8672.

Previous run (14)

Risk Assessment: elevated (3/5)

Details

Moderate-sized PR modifying core reusable CI dispatch workflows and protected paths in high-churn files, altering mint URL resolution behavior without a feature flag despite close alignment with linked issue #8672.

Previous run (15)

Risk Assessment: elevated (3/5)

Details

Moderate-sized PR modifying core reusable CI dispatch workflows and protected paths in high-churn files, altering mint URL resolution behavior without a feature flag despite close alignment with linked issue #8672.

Previous run (16)

Risk Assessment: elevated (3/5)

Details

Moderate-sized PR modifying core reusable CI dispatch workflows and protected paths in high-churn files, altering mint URL resolution behavior without a feature flag despite close alignment with linked issue #8672.

Previous run (17)

Risk Assessment: elevated (3/5)

Details

Moderate-sized PR modifying core reusable CI dispatch workflows and protected paths in high-churn files, altering mint URL resolution behavior without a feature flag despite close alignment with linked issue #8672.

Previous run (18)

Risk Assessment: elevated (3/5)

Details

Moderate-sized PR modifying core reusable CI dispatch workflows and protected paths in high-churn files, altering mint URL resolution behavior without a feature flag despite close alignment with linked issue #8672.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Review

Findings

Medium

  • [protected-path] .github/workflows/reusable-dispatch.yml — This PR modifies protected paths: .github/scripts/resolve-effective-mint-url.sh, .github/scripts/resolve-effective-mint-url-test.sh, .github/workflows/lint.yml, .github/workflows/reusable-dispatch.yml, .github/workflows/reusable-prioritize.yml. The PR links issue Workflow dispatch still builds --mint-url from the stale FULLSEND_MINT_URL variable, not the config file #8672 and explains the rationale, but human approval is always required for protected-path changes, regardless of context.

Low

  • [edge-case] .github/scripts/resolve-effective-mint-url.sh:119 — The URL validator checks only scheme, a non-empty authority and the absence of userinfo, not URL syntax. Values such as https://a.example (trailing space), https://bad host:invalid/%zz, invalid ports and bad percent escapes exit 0 and are written verbatim to $GITHUB_OUTPUT, then fail later at mint-token instead of at the validation step. CR/LF are already rejected, so this cannot inject extra step outputs; reclassified from medium to low because the values come from repo config or an admin-set variable and the failure is fail-late rather than unsafe.
    Remediation: Reject whitespace and control characters in the authority (and optionally validate port and percent escapes) before writing the output, and add test cases for each.
  • [edge-case] .github/scripts/resolve-effective-mint-url.sh:82 — value=$(yq -r ...) strips trailing newlines, so a file-sourced mint_url written as a YAML literal block passes validation without the trailing LF that url.Parse would reject. The resulting value is a clean URL, so this is harmless leniency.
    Remediation: Optionally preserve trailing newlines during extraction and add a test for it.
  • [doc-style] docs/guides/infrastructure/mint-administration.md:55 — Redundant sentence: "Config-sourced values must be HTTPS with no userinfo." is immediately repeated by the next sentence.
    Remediation: Remove the redundant opening sentence or merge the two.
  • [doc-style] docs/guides/infrastructure/mint-administration.md:56 — Passive voice ("The resolved URL is validated on every run: ...") departs from the active-voice convention in docs/contributing/documentation.md.
    Remediation: Rewrite in active voice, e.g. "Dispatch validates the resolved URL on every run: declared config values must be HTTPS with no userinfo."
  • [incomplete-doc] docs/guides/user/custom-agent-identity.md:31 — The "Two paths, one decision" table lists the standalone mint URL only as your FULLSEND_MINT_URL, but dispatch now resolves mint_url from .fullsend/config.yaml / config.base.yaml ahead of the variable.
    Remediation: Reference both the config field and the variable, e.g. your mint_url in config or FULLSEND_MINT_URL.

Earlier findings

  • .github/scripts/resolve-effective-mint-url.sh:136, injection-vuln — resolved: the latest commit removes the mint-host interpolation, so the override ::notice:: text is now constant.
  • .github/scripts/resolve-effective-mint-url.sh:143, edge-case — reclassified medium → low (see the line-119 finding above); the CR/LF check precedes the output write and the failure is fail-late.
  • .github/scripts/resolve-effective-mint-url.sh, backward-incompatible (several earlier findings) — reclassified to info: the config-over-variable override is the intentional, documented ! breaking change.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

10 finding(s) below the low severity threshold were not posted.

Previous run

<!-- fullsend:review-findings-v2:{"version":2,"action":"request-changes","findings":[{"severity":"medium","category":"edge-case","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_985e954dd4a1a88a","line":143,"actionable":true,"dimension":"correctness"},{"severity":"low","category":"edge-case","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_05c3021459841b3c","line":82,"actionable":false,"dimension":"correctness"},{"severity":"low","category":"incomplete-doc","file":"docs/guides/user/custom-agent-identity.md","id":"f_905a9737c2492862","line":31,"actionable":false,"dimension":"docs-currency"},{"severity":"low","category":"doc-style","file":"docs/guides/infrastructure/mint-administration.md","id":"f_46a03820d17dc2f4","line":56,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_e48fd0cb13ab84b4","line":92,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"low","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_05d5d46cb825c0a3","line":109,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"injection-vuln","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_457b5c4f4bfb5c71","line":136,"actionable":false,"dimension":"security"},{"severity":"low","category":"doc-style","file":"docs/guides/infrastructure/mint-administration.md","id":"f_2899ff8f74da08e3","line":55,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_89d415b1b95b1892","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"low","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_7c3093f8c3f9e696","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"low","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_f6bc829a25e57723","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"low","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_53b6ed156d57f37d","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"low","category":"edge-case","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_5860580cb9c44b70","line":65,"actionable":false,"dimension":"correctness"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_d6e9033b0b63b998","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_7c3fcf6999e54fae","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_10d4ffea958d3870","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_abdb46736b369c72","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_d709f0bd33c9a81b","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_0f4071a6e127bc69","line":28,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_0ee09bb5beb8f4c3","line":21,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_75f9e37a7bb9faf6","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_b3cf0a615eb0220c","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_dae9db6117ed6afc","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_aa1e573d40baf2ec","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_fdca41c34bb4aab7","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_ef8f909e208c7907","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_fa9bffedef2e0cac","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_eca8cde3b7de441e","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_40aecb608550aaec","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_f4bf87af923780b4","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_16248ea152419294","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_0d7a897f71f0c63f","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_2d7545a46beb0103","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_24548e1c9490fed6","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_70673d556fa7afdf","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_4d04e7e6cc0f361b","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_7be3ae5db104ddae","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_5bd6b351b96eff70","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_cc156662dae5d3bf","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_180a27c977a91ee1","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"info","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_e29663cfd0e26d99","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"low","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_7300e5b106223965","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"low","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_f07d9fb2cd9644bc","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"low","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_c0927ffacdf1d861","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"low","category":"backward-incompatible","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_83c5bb852154bc75","line":22,"actionable":false,"dimension":"cross-repo-contracts"},{"severity":"medium","category":"pattern-inconsistency","file":".github/scripts/resolve-effective-mint-url-test.sh","id":"f_d17f84f0a189287f","line":1,"actionable":true,"dimension":"style-conventions"},{"severity":"low","category":"pattern-inconsistency","file":"internal/scaffold/vendorcontent_test.go","id":"f_018f7239f7fdfa4a","line":84,"actionable":true,"dimension":"style-conventions"},{"severity":"medium","category":"secret-exposure","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_27fd693e8133ecb4","line":46,"actionable":false,"dimension":"security"},{"severity":"low","category":"injection-vuln","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_d667d07fa0935449","line":46,"actionable":false,"dimension":"security"},{"severity":"high","category":"logic-error","file":".github/workflows/reusable-dispatch.yml","id":"f_4c67d57096a12775","line":181,"actionable":true,"dimension":"correctness"},{"severity":"high","category":"logic-error","file":".github/workflows/reusable-dispatch.yml","id":"f_e1432f3f592b646c","line":163,"actionable":true,"dimension":"correctness"},{"severity":"low","category":"secret-exposure","file":".github/scripts/resolve-effective-mint-url.sh","id":"f_c9011b315dd26cc7","line":40,"actionable":true,"dimension":"security"},{"severity":"high","category":"logic-error","file":".github/workflows/reusable-dispatch.yml","id":"f_4f74084e18653c2e","line":163,"actionable":true,"dimension":"correctness"},{"severity":"low","category":"doc-style","file":"docs/guides/infrastructure/mint-administration.md","id":"f_a04121add9e0cd43","line":35,"actionable":true,"dimension":"style-conventions"},{"severity":"medium","category":"logic-error","file":".github/scripts/resolve-effective-mint-url-test.sh","id":"f_40da201c04676c84","line":143,"actionable":true,"dimension":"correctness"},{"severity":"medium","category":"logic-error","file":".github/scripts/resolve-effective-mint-url-test.sh","id":"f_f274ce19bd151f61","line":117,"actionable":true,"dimension":"correctness"},{"severity":"low","category":"code-organization","file":"internal/scaffold/vendorcontent.go","id":"f_770c5b14e56c7884","line":184,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"code-organization","file":"internal/scaffold/vendormanifest.go","id":"f_b483de7eabfeafbb","line":167,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"code-organization","file":"Makefile","id":"f_4d4da5d5dbce4b32","line":195,"actionable":false,"dimension":"style-conventions"},{"severity":"low","category":"incorrect-doc","file":"docs/reference/config-reference.md","id":"f_454601302d78816d","line":673,"actionable":false,"dimension":"docs-currency"},{"severity":"info","category":"incorrect-doc","file":"docs/guides/infrastructure/mint-administration.md","id":"f_68862f6ef2f366ef","line":50,"actionable":false,"dimension":"docs-currency"},{"severity":"low","category":"incorrect-doc","file":"docs/reference/config-reference.md","id":"f_a82882007be18d6e","line":665,"actionable":false,"dimension":"docs-currency"}],"dispositions":[{"id":"f_985e954dd4a1a88a","status":"open"},{"id":"f_05c3021459841b3c","status":"open"},{"id":"f_457b5c4f4bfb5c71","status":"reclassified"},{"id":"f_905a9737c2492862","status":"open"},{"id":"f_2899ff8f74da08e3","status":"open"},{"id":"f_89d415b1b95b1892","status":"open"},{"id":"f_7c3093f8c3f9e696","status":"open"},{"id":"f_f6bc829a25e57723","status":"open"},{"id":"f_53b6ed156d57f37d","status":"open"},{"id":"f_5860580cb9c44b70","status":"open"},{"id":"f_d6e9033b0b63b998","status":"open"},{"id":"f_7c3fcf6999e54fae","status":"open"},{"id":"f_10d4ffea958d3870","status":"open"},{"id":"f_abdb46736b369c72","status":"open"},{"id":"f_d709f0bd33c9a81b","status":"open"},{"id":"f_0f4071a6e127bc69","status":"open"},{"id":"f_0ee09bb5beb8f4c3","status":"open"},{"id":"f_75f9e37a7bb9faf6","status":"open"},{"id":"f_b3cf0a615eb0220c","status":"open"},{"id":"f_dae9db6117ed6afc","status":"open"},{"id":"f_aa1e573d40baf2ec","status":"open"},{"id":"f_fdca41c34bb4aab7","status":"open"},{"id":"f_ef8f909e208c7907","status":"open"},{"id":"f_fa9bffedef2e0cac","status":"open"},{"id":"f_eca8cde3b7de441e","status":"open"},{"id":"f_40aecb608550aaec","status":"open"},{"id":"f_f4bf87af923780b4","status":"open"},{"id":"f_16248ea152419294","status":"open"},{"id":"f_0d7a897f71f0c63f","status":"open"},{"id":"f_2d7545a46beb0103","status":"open"},{"id":"f_24548e1c9490fed6","status":"open"},{"id":"f_70673d556fa7afdf","status":"open"},{"id":"f_4d04e7e6cc0f361b","status":"open"},{"id":"f_7be3ae5db104ddae","status":"open"},{"id":"f_5bd6b351b96eff70","status":"open"},{"id":"f_cc156662dae5d3bf","status":"open"},{"id":"f_180a27c977a91ee1","status":"open"},{"id":"f_e29663cfd0e26d99","status":"open"},{"id":"f_7300e5b106223965","status":"open"},{"id":"f_f07d9fb2cd9644bc","status":"open"},{"id":"f_c0927ffacdf1d861","status":"open"},{"id":"f_83c5bb852154bc75","status":"open"},{"id":"f_d17f84f0a189287f","status":"resolved_by_change"},{"id":"f_018f7239f7fdfa4a","status":"resolved_by_change"},{"id":"f_27fd693e8133ecb4","status":"resolved_by_change"},{"id":"f_d667d07fa0935449","status":"resolved_by_change"},{"id":"f_4c67d57096a12775","status":"resolved_by_change"},{"id":"f_e1432f3f592b646c","status":"resolved_by_change"},{"id":"f_c9011b315dd26cc7","status":"resolved_by_change"},{"id":"f_4f74084e18653c2e","status":"resolved_by_change"},{"id":"f_a04121add9e0cd43","status":"resolved_by_change"},{"id":"f_40da201c04676c84","status":"resolved_by_change"},{"id":"f_f274ce19bd151f61","status":"resolved_by_change"},{"id":"f_770c5b14e56c7884","status":"resolved_by_change"},{"id":"f_b483de7eabfeafbb","status":"resolved_by_change"},{"id":"f_4d4da5d5dbce4b32","status":"resolved_by_change"},{"id":"f_454601302d78816d","status":"resolved_by_change"},{"id":"f_68862f6ef2f366ef","status":"resolved_by_change"},{"id":"f_a82882007be18d6e","status":"resolved_by_change"}]} -->

Review

Findings

Medium

  • [edge-case] .github/scripts/resolve-effective-mint-url.sh:143 — The resolver publishes malformed URLs to $GITHUB_OUTPUT. _validate_resolved_mint_url (lines 36-75) only checks the scheme, a non-empty authority, @ userinfo, and CR/LF. Values with a trailing space or tab, a space in the hostname, a non-numeric port, or an invalid percent-escape exit 0 and are written as mint_url=... (reproduced by running the script with FALLBACK_MINT_URL set to https://mint.example.com (trailing space), https://mint ex.com/x, https://mint.example.com:abc, and https://mint.example.com/%zz). Go's url.Parse rejects them, so the failure only appears later at mint time, and the script header claims the same gate as validateDeclaredMintURL. This also covers the HTTPS branch at line 65. Unchanged since the prior review.
    Remediation: Reject whitespace and control characters before publishing the output, and validate URL syntax the way the Go validator does (host characters, numeric port, valid percent-escapes). Add regression tests for these inputs.
  • [protected-path] .github/workflows/reusable-dispatch.yml — This PR modifies protected paths under .github/ (resolve-effective-mint-url.sh, resolve-effective-mint-url-test.sh, lint.yml, reusable-dispatch.yml, reusable-prioritize.yml). The PR links issue Workflow dispatch still builds --mint-url from the stale FULLSEND_MINT_URL variable, not the config file #8672 and explains the rationale, but human approval is always required for protected-path changes, regardless of context.

Low

  • [edge-case] .github/scripts/resolve-effective-mint-url.sh:82 — Command substitution strips trailing newlines from yq's output before URL validation, so a block scalar such as mint_url: | loses its terminating newline and passes the CR/LF guard instead of being rejected.
    Remediation: Preserve scalar contents during extraction (for example, read JSON-encoded output) and add a test with a trailing-newline URL.
  • [incomplete-doc] docs/guides/user/custom-agent-identity.md:31 — The standalone-mint URL row of the comparison table lists only your FULLSEND_MINT_URL, omitting that mint_url in .fullsend/config.yaml / config.base.yaml now takes precedence during dispatch (stated at line 120).
    Remediation: Mention the config-file declaration alongside the repository variable in that cell.
  • [doc-style] docs/guides/infrastructure/mint-administration.md:56 — Consecutive sentences (lines 56-57) both state that config-sourced values must be HTTPS with no userinfo.
    Remediation: State the requirement once.
  • [backward-incompatible] .github/scripts/resolve-effective-mint-url.sh:92 — A mint_url in .fullsend/config.yaml or config.base.yaml now overrides FULLSEND_MINT_URL and the workflow input; repos whose file and variable have diverged silently switch endpoints. Declared via the ! title and BREAKING CHANGE footer.
    Remediation: No code change needed; keep release notes and migration guidance telling operators to edit the config file instead of the variable.
  • [backward-incompatible] .github/scripts/resolve-effective-mint-url.sh:109 — Dispatch now fails hard on a non-HTTPS resolved endpoint, userinfo, CR/LF, yq missing while a config file exists, and an unparsable config file. Declared in the BREAKING CHANGE footer.
    Remediation: No code change needed; confirm yq is available on every runner image used by these reusable workflows.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

1 finding(s) below the low severity threshold were not posted.

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot added component/dispatch Workflow dispatch and triggers component/ci CI pipelines and checks component/mint Token mint and cross-boundary credentials labels Nov 4, 2026
@codecov

codecov Bot commented Nov 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@waynesun09 waynesun09 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two findings on the new mint URL resolver, both inline.

@rh-hemartin

Copy link
Copy Markdown
Member

I think we should handle GitLab as well, how does that sound? I think is small enough we can do both.

@ifireball

Copy link
Copy Markdown
Member

I think we should handle GitLab as well, how does that sound? I think is small enough we can do both.

Eh? GitLab does not currently use the mint...

😕

@rh-hemartin

Copy link
Copy Markdown
Member

Eh? GitLab does not currently use the mint...

Right, didn't double check that with myself before posting.

@github-actions github-actions Bot removed the ok-to-test Allow e2e CI to run after maintainer review (must be re-applied after each push) label Nov 5, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:35 AM UTC · Completed 10:52 AM UTC

Commit: bddf936 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.06

fullsend-ai-review[bot]

This comment was marked as outdated.

Fetch the resolver from job.workflow_repository when upstream callers
lack a vendored copy, validate HTTPS mint URLs in bash, run shell tests in
CI, and document layered config precedence for operators.

Signed-off-by: fmuntean <fmuntean@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 9:40 AM UTC · Completed 9:55 AM UTC

Commit: c8cbead · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.89

fullsend-ai-review[bot]

This comment was marked as outdated.

fullsend-ai-review[bot]

This comment was marked as outdated.

Align vendor allowlist comments, workflow step gates and ordering
assertions, script-test order, and dispatch mint_url notice wording.

Signed-off-by: fmuntean <fmuntean@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:06 AM UTC · Completed 10:25 AM UTC

Commit: 1bad343 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.55

fullsend-ai-review[bot]

This comment was marked as outdated.

fullsend-ai-review[bot]

This comment was marked as outdated.

@mfrancisc
mfrancisc requested a review from waynesun09 November 12, 2026 10:10
@fullsend-ai-review

fullsend-ai-review Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:12 AM UTC · Completed 10:34 AM UTC

Commit: 54fbd0d · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.78

fullsend-ai-review[bot]

This comment was marked as outdated.

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 1:35 PM UTC · Completed 1:46 PM UTC

Commit: e61f1c6 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.37

fullsend-ai-review[bot]

This comment was marked as outdated.

fullsend-ai-review[bot]

This comment was marked as outdated.

@waynesun09 waynesun09 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review-only comment. One finding inline.

if [[ "${_from_file}" == "true" && "${_effective}" != "${FALLBACK_MINT_URL:-}" ]]; then
host=$(_mint_host_from_url "${_effective}") || host=""
if [[ -n "${host}" ]]; then
echo "::notice::mint_url from .fullsend config overrides FULLSEND_MINT_URL (mint host: ${host})" >&2

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MEDIUM] The override notice prints the mint host, but mint-token masks the mint URL

I checked this at head e61f1c6. This line writes ::notice::mint_url from .fullsend config overrides FULLSEND_MINT_URL (mint host: ${host}). The resolver runs in route, harness-dispatch, harness-run and reusable-prioritize. In each of those jobs it runs before any mint-token step.

.github/actions/mint-token/action.yml:46 runs echo "::add-mask::$MINT_URL", so the project already keeps the mint endpoint out of logs. A notice becomes a run annotation, and anyone who can see the Actions runs can read it. On a public repo that is everyone. Self-hosted mint hosts often carry a project-specific Cloud Run name.

Thread 4494086582 asked for this notice and offered two options: print only the host, or only say that the two values differ. 23c2d4f implemented the host option. Neither that thread nor the low injection-vuln comments on this line mention the add-mask in mint-token, so nobody has discussed that the printed host conflicts with the mask.

Suggestion: Use the other option from that thread: say only that the config mint_url overrides FULLSEND_MINT_URL, and leave the host out. Or run ::add-mask:: on the resolved URL and host before any output, to match mint-token. If the maintainers decide the host is not sensitive, write that down and drop the add-mask in mint-token too, so the two places agree.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to address this before merge

Align with mint-token URL masking: audit trail without exposing the
endpoint in workflow annotations.

Signed-off-by: fmuntean <fmuntean@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@fullsend-ai-review

fullsend-ai-review Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:23 PM UTC · Completed 2:39 PM UTC

Commit: 1b17a4e · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.42

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The following review comments could not be posted on the diff (GitHub returned 422) and are included here instead:

  • docs/guides/user/custom-agent-identity.md (file-level): Line 31 ·
    [low] incomplete-doc

The "Two paths, one decision" table lists the standalone mint URL only as your FULLSEND_MINT_URL, but dispatch now resolves mint_url from .fullsend/config.yaml / config.base.yaml ahead of the variable.

Suggested fix: Reference both the config field and the variable, e.g. your mint_url in config or FULLSEND_MINT_URL.

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

echo "::notice::mint_url from .fullsend config overrides FULLSEND_MINT_URL" >&2
fi

{

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] edge-case

The URL validator checks only scheme, a non-empty authority and the absence of userinfo, not URL syntax. Values such as https://a.example (trailing space), https://bad host:invalid/%zz, invalid ports and bad percent escapes exit 0 and are written verbatim to $GITHUB_OUTPUT (line 119), then fail later at mint-token instead of at the validation step. CR/LF are already rejected, so this cannot inject extra step outputs; reclassified from medium to low because the values come from repo config or an admin-set variable and the failure is fail-late rather than unsafe. Same root cause as the previously open line-65 finding.

Suggested fix: Reject whitespace and control characters in the authority (and optionally validate port and percent escapes) before writing the output, and add test cases for each.

local value
if ! value=$(yq -r '.mint_url // ""' "${file}"); then
echo "::error::failed to read mint_url from ${file}" >&2
exit 1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] edge-case

value=$(yq -r ...) strips trailing newlines, so a file-sourced mint_url written as a YAML literal block (|) passes validation without the trailing LF that url.Parse in validateDeclaredMintURL would reject. The resulting value is a clean URL, so this is harmless leniency.

Suggested fix: Optionally preserve trailing newlines during extraction (e.g. a sentinel suffix) and add a test for file-sourced values with a trailing LF.

`FULLSEND_MINT_URL` snapshot (including when that variable is unset),
dispatch follows config and emits a workflow notice that config overrides
the variable (no URL or host in the notice).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] doc-style

Redundant sentence: "Config-sourced values must be HTTPS with no userinfo." is immediately repeated by the next sentence ("...declared config values must be HTTPS (no userinfo).").

Suggested fix: Remove the redundant opening sentence or merge the two sentences.

dispatch follows config and emits a workflow notice that config overrides
the variable (no URL or host in the notice).

Config-sourced values must be HTTPS with no userinfo. The resolved URL is

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] doc-style

Passive voice ("The resolved URL is validated on every run: ...") departs from the active-voice convention in docs/contributing/documentation.md.

Suggested fix: Rewrite in active voice, e.g. "Dispatch validates the resolved URL on every run: declared config values must be HTTPS with no userinfo."

@ralphbean ralphbean self-assigned this Nov 13, 2026
@ralphbean

Copy link
Copy Markdown
Member

One idea to pick up in retro: fullsend config get -o yaml could render the whole effective config after overlay, base, and defaults are composed. That would give users and workflows a way to inspect the resolved config. It does not need to land in this PR; the current fix looks good as-is.

@ralphbean

Copy link
Copy Markdown
Member

Oh, actually @mfrancisc - this needs rebase on main and merge conflict resolution before it can move forwards.

This branch was successfully deployed

1 active and 1 inactive (outdated) deployments
site-preview — 1b17a4e5 Deployed Nov 12, 2026 by github-actions[bot]
dev — 6820167b Deployed Nov 4, 2026 by dhshah13 via run / playback #6106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/ci CI pipelines and checks component/dispatch Workflow dispatch and triggers component/docs User-facing documentation component/mint Token mint and cross-boundary credentials risk/elevated PR risk: elevated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow dispatch still builds --mint-url from the stale FULLSEND_MINT_URL variable, not the config file

6 participants