Skip to content

feat(#9176): support Jira OAuth credentials across GitHub and GitLab - #9183

Merged
ggallen merged 8 commits into
mainfrom
agent/9176-jira-oauth-client-credentials
Nov 7, 2026
Merged

ggallen merged 8 commits into
mainfrom
agent/9176-jira-oauth-client-credentials

Conversation

@fullsend-ai-coder

@fullsend-ai-coder fullsend-ai-coder Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Completes #9176: Jira OAuth 2.0 client credentials now work across GitHub and GitLab, including the GitHub workflow and scaffold wiring that was left as follow-up work.

Implementation

  • Add OAuth client-credentials authentication with token caching and refresh to the shared Jira client used by polling, fullsend issues, run-status notifications, and fullsend reconcile-status.
  • Let fullsend repos install store either an API token or the OAuth client ID and secret on GitHub and GitLab. Credentials remain forge secrets or CI/CD variables; they are not written to config files.
  • Forward the optional OAuth secrets through the GitHub poll, dispatch, and prioritize workflows and managed scaffold callers. Polling receives them for Jira authentication; status credentials are passed to Fullsend only for Jira-originated runs.
  • Keep credentials out of FULLSEND_GITHUB_RUNNER_SECRETS and the sandbox. Host-side scripts receive them only when the harness explicitly declares them.
  • Update CLI and user documentation, and add coverage for install validation, managed workflow rendering, and credential forwarding.

There is no remaining workflow or scaffold follow-up for #9176.

Validation

  • Focused Jira tests passed in internal/repos and internal/scaffold.
  • go vet ./internal/cli ./internal/repos ./internal/scaffold passed.
  • make lint passed.
  • Broader package tests were attempted but are not clean in this sandbox: loopback socket binding is denied, a Git upload-pack fixture ref is unavailable, and scaffold route-override tests report mismatches. The focused Jira tests pass independently.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 1:43 AM UTC · Completed 1:55 AM UTC

Commit: edf194c · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.75

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Site preview

Preview: https://44f1caf3-site.fullsend-ai.workers.dev

Commit: 90a380f389c16714cef9d02ca9c7f411c45fae48

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Nov 7, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Risk Assessment: elevated (3/5)

Details

Preserved score of 3 (elevated) as Tier 1 metadata signals remain in the same ranges since prior review, spanning 62 files and 2,578 lines across protected CI workflows and high-churn CLI files, balanced by opt-in OAuth configuration and aligned issue scope.

Previous run

Risk Assessment: elevated (3/5)

Details

Preserved score of 3 (elevated) as Tier 1 metadata signals remain in the same ranges since prior review, spanning 62 files and 2,503 lines across protected CI workflows and high-churn CLI files, balanced by opt-in OAuth configuration and aligned issue scope.

Previous run (2)

Risk Assessment: elevated (3/5)

Details

Preserved score of 3 (elevated) as Tier 1 metadata signals remain in the same ranges since prior review, spanning 62 files and 2,462 lines across protected CI workflows and high-churn CLI files, balanced by opt-in OAuth configuration and aligned issue scope.

Previous run (3)

Risk Assessment: elevated (3/5)

Details

Preserved score of 3 (elevated) as Tier 1 metadata signals remain in the same ranges since prior review, spanning 62 files and 2,402 lines across protected CI workflows and high-churn CLI files, balanced by opt-in OAuth configuration and aligned issue scope.

Previous run (4)

Risk Assessment: elevated (3/5)

Details

Preserved score of 3 (elevated) as Tier 1 metadata signals remain in the same ranges since the prior review, spanning 60 files and 2,290 lines across protected CI workflows and high-churn CLI files, balanced by opt-in OAuth configuration and aligned issue scope.

Previous run (5)

Risk Assessment: elevated (3/5)

Details

Preserved score of 3 (elevated) as Tier 1 metadata signals remain in the same ranges since the prior review, spanning 59 files and 2,177 lines across protected CI workflows and high-churn CLI files, balanced by opt-in OAuth configuration and aligned issue scope.

Previous run (6)

Risk Assessment: elevated (3/5)

Details

Preserved score of 3 (elevated) as Tier 1 metadata signals are unchanged since the prior review, with changes spanning 57 files and 2,099 lines across protected CI workflows and high-churn CLI files, balanced by opt-in OAuth configuration and aligned issue scope.

Previous run (7)

Risk Assessment: elevated (3/5)

Details

Score increased from 2 (moderate) to 3 (elevated) because the PR now introduces changes to protected paths and CI workflows (5 files under .github/workflows) and exceeds 50 files and 2,000 lines, elevating Tier 1 metadata risk alongside high churn in CLI and repo convergence files.

Previous run (8)

Risk Assessment: moderate (2/5)

Details

Moderate risk from large change size across 45 files and elevated churn in CLI and repo convergence files, balanced by bot authorship, no protected-path or CI workflow changes, a 0.36 test-file ratio, and alignment with the linked issue's opt-in scope.

Previous run (9)

Risk Assessment: moderate (2/5)

Details

Moderate risk assigned due to large change size across 44 files and elevated git history churn in CLI and repo convergence files, balanced by bot authorship, zero protected path or CI workflow changes, strong test coverage, and complete alignment with the linked issue's opt-in scope.

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Review

Findings

Medium

  • [protected-path] .github/workflows/reusable-dispatch.yml — The PR modifies protected paths: .github/workflows/fullsend.yaml, .github/workflows/prioritize.yml, .github/workflows/reusable-dispatch.yml, .github/workflows/reusable-poll-jira.yml, .github/workflows/reusable-prioritize.yml. It links jira: accept OAuth 2.0 client credentials for Atlassian service accounts #9176 and explains the rationale, but human approval is always required for protected-path changes, regardless of context. The issue thread also records an earlier maintainer instruction not to change .github/workflows in the coder run, so a maintainer should confirm these workflow edits are now intended.

Earlier findings

  • internal/repos/github_jira_poll.go:57, edge-case — resolved: a user-owned Jira poll caller now has each reusable workflow it references fetched at its pinned ref and checked for the OAuth secrets before credentials are replaced.
  • internal/repos/github_jira_poll.go:47, edge-case — resolved: unverifiable user-owned workflow references (no pinned ref, malformed, unreadable, or local without the OAuth secret names) now fail preflight; new tests cover each case.
Previous run

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJpbnRlcm5hbC9yZXBvcy9naXRodWJfamlyYV9wb2xsLmdvIiwiaWQiOiJmX2Q5MmU2NjJlOGJjZTcyMTciLCJsaW5lIjo1NywiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvZ2l0aHViX2ppcmFfcG9sbC5nbyIsImlkIjoiZl80MTgwYmI0ZmE3YjRkN2IxIiwibGluZSI6NDcsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiZWRnZS1jYXNlIiwiZmlsZSI6ImludGVybmFsL3JlcG9zL2ppcmFfcG9sbC5nbyIsImlkIjoiZl8yOGI3YTgyNmE2MWQ3YWJiIiwibGluZSI6NDI2LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImFwaS1jb250cmFjdCIsImZpbGUiOiJpbnRlcm5hbC9zY2FmZm9sZC9mdWxsc2VuZC1yZXBvL3RlbXBsYXRlcy9qaXJhLXBvbGwtcGVyLXJlcG8ueWFtbCIsImlkIjoiZl81NTExNmUzOGM5Y2YxNWIzIiwibGluZSI6NDIsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5Ijoic2NvcGUtZXhjZWVkZWQiLCJmaWxlIjoiLmdpdGh1Yi93b3JrZmxvd3MvcmV1c2FibGUtZGlzcGF0Y2gueW1sIiwiaWQiOiJmX2I3ZjE5ZmIwYmY4M2UzZDMiLCJsaW5lIjoxMTcsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJpbnRlbnQtY29oZXJlbmNlIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZXJyb3ItaGFuZGxpbmctaWRpb20iLCJmaWxlIjoiaW50ZXJuYWwvZm9yZ2UvamlyYS9zY29wZWQuZ28iLCJpZCI6ImZfMzk4YmNiODRiZmQzNGE3ZSIsImxpbmUiOjEzNSwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZXJyb3ItaGFuZGxpbmctaWRpb20iLCJmaWxlIjoiaW50ZXJuYWwvZm9yZ2UvamlyYS9zY29wZWQuZ28iLCJpZCI6ImZfZDQzMmI3OTEzYTMxYjg4ZCIsImxpbmUiOjEzNywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiZWRnZS1jYXNlIiwiZmlsZSI6ImludGVybmFsL3JlcG9zL2ppcmFfcG9sbC5nbyIsImlkIjoiZl81NzNlZGZhMmUzMjNkMjQ0IiwibGluZSI6MTY5LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29tcGxldGUtZG9jIiwiZmlsZSI6ImRvY3MvY2xpL1JFQURNRS5tZCIsImlkIjoiZl81NTU4NTk3NjA2YzNiYjdlIiwibGluZSI6MjgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImRvY3MtY3VycmVuY3kifSx7InNldmVyaXR5IjoiaGlnaCIsImNhdGVnb3J5IjoicGF0dGVybi1pbmNvbnNpc3RlbmN5IiwiZmlsZSI6ImludGVybmFsL3JlcG9zL2ppcmFfcG9sbC5nbyIsImlkIjoiZl8zNTM3YjE2MjU2MDQyMTM4IiwibGluZSI6MjU2LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJpbnRlcm5hbC9yZXBvcy9naXRodWJfamlyYV9wb2xsLmdvIiwiaWQiOiJmX2M3YWI4YWU1MjU5MTIwNmMiLCJsaW5lIjozMywiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvZ2l0aHViX2ppcmFfcG9sbC5nbyIsImlkIjoiZl8zNzZhODZmNGNlZDk5MzhlIiwibGluZSI6MTE4LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzM3NmE4NmY0Y2VkOTkzOGUiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl80MTgwYmI0ZmE3YjRkN2IxIiwic3RhdHVzIjoib3BlbiJ9LHsiaWQiOiJmXzI4YjdhODI2YTYxZDdhYmIiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifSx7ImlkIjoiZl81NTExNmUzOGM5Y2YxNWIzIiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfYjdmMTlmYjBiZjgzZTNkMyIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9LHsiaWQiOiJmXzM5OGJjYjg0YmZkMzRhN2UiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifSx7ImlkIjoiZl9kNDMyYjc5MTNhMzFiODhkIiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfNTczZWRmYTJlMzIzZDI0NCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzU1NTg1OTc2MDZjM2JiN2UiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8zNTM3YjE2MjU2MDQyMTM4Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfYzdhYjhhZTUyNTkxMjA2YyIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= -->

Review

Findings

Medium

  • [edge-case] internal/repos/github_jira_poll.go:57 — A user-owned Jira poll caller bypasses upstream compatibility verification once its jobs forward the OAuth secrets. Forwarding (including secrets: inherit) does not establish that the reusable workflows at the jobs' actual uses refs declare the OAuth secrets, so a caller pinned to a pre-OAuth workflow passes this check. The install then deletes the API token secrets, leaving that workflow unable to authenticate. requireJiraOAuthSecrets runs only on the managed-caller path below this return.
    Remediation: For user-owned callers, verify OAuth support at the actual reusable-workflow refs before replacing credentials, or reject callers whose upstream compatibility cannot be established. Add a test for an inheriting caller pinned to a pre-OAuth workflow.

  • [protected-path] .github/workflows/fullsend.yaml — This PR modifies protected governance/infrastructure paths: .github/workflows/fullsend.yaml, .github/workflows/prioritize.yml, .github/workflows/reusable-dispatch.yml, .github/workflows/reusable-poll-jira.yml, .github/workflows/reusable-prioritize.yml. The PR links jira: accept OAuth 2.0 client credentials for Atlassian service accounts #9176 and explains the rationale (forwarding optional Jira OAuth secrets), but human approval is always required for protected-path changes regardless of context.

Earlier findings

  • internal/repos/github_jira_poll.go:118, edge-case — resolved: the latest commit replaces whole-document regex/substring matching in userJiraCallerForwardsOAuth with YAML parsing and a per-job check, with new test cases for comments, unrelated jobs, and multiple jobs.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (2)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJpbnRlcm5hbC9yZXBvcy9naXRodWJfamlyYV9wb2xsLmdvIiwiaWQiOiJmXzM3NmE4NmY0Y2VkOTkzOGUiLCJsaW5lIjoxMTgsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJpbnRlcm5hbC9yZXBvcy9naXRodWJfamlyYV9wb2xsLmdvIiwiaWQiOiJmXzQxODBiYjRmYTdiNGQ3YjEiLCJsaW5lIjo0NywiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvamlyYV9wb2xsLmdvIiwiaWQiOiJmXzI4YjdhODI2YTYxZDdhYmIiLCJsaW5lIjo0MjYsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiYXBpLWNvbnRyYWN0IiwiZmlsZSI6ImludGVybmFsL3NjYWZmb2xkL2Z1bGxzZW5kLXJlcG8vdGVtcGxhdGVzL2ppcmEtcG9sbC1wZXItcmVwby55YW1sIiwiaWQiOiJmXzU1MTE2ZTM4YzljZjE1YjMiLCJsaW5lIjo0MiwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJzY29wZS1leGNlZWRlZCIsImZpbGUiOiIuZ2l0aHViL3dvcmtmbG93cy9yZXVzYWJsZS1kaXNwYXRjaC55bWwiLCJpZCI6ImZfYjdmMTlmYjBiZjgzZTNkMyIsImxpbmUiOjExNywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImludGVudC1jb2hlcmVuY2UifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJlcnJvci1oYW5kbGluZy1pZGlvbSIsImZpbGUiOiJpbnRlcm5hbC9mb3JnZS9qaXJhL3Njb3BlZC5nbyIsImlkIjoiZl8zOThiY2I4NGJmZDM0YTdlIiwibGluZSI6MTM1LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJlcnJvci1oYW5kbGluZy1pZGlvbSIsImZpbGUiOiJpbnRlcm5hbC9mb3JnZS9qaXJhL3Njb3BlZC5nbyIsImlkIjoiZl9kNDMyYjc5MTNhMzFiODhkIiwibGluZSI6MTM3LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvamlyYV9wb2xsLmdvIiwiaWQiOiJmXzU3M2VkZmEyZTMyM2QyNDQiLCJsaW5lIjoxNjksImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiaW5jb21wbGV0ZS1kb2MiLCJmaWxlIjoiZG9jcy9jbGkvUkVBRE1FLm1kIiwiaWQiOiJmXzU1NTg1OTc2MDZjM2JiN2UiLCJsaW5lIjoyOCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9LHsic2V2ZXJpdHkiOiJoaWdoIiwiY2F0ZWdvcnkiOiJwYXR0ZXJuLWluY29uc2lzdGVuY3kiLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvamlyYV9wb2xsLmdvIiwiaWQiOiJmXzM1MzdiMTYyNTYwNDIxMzgiLCJsaW5lIjoyNTYsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiZWRnZS1jYXNlIiwiZmlsZSI6ImludGVybmFsL3JlcG9zL2dpdGh1Yl9qaXJhX3BvbGwuZ28iLCJpZCI6ImZfYzdhYjhhZTUyNTkxMjA2YyIsImxpbmUiOjMzLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfNDE4MGJiNGZhN2I0ZDdiMSIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl9jN2FiOGFlNTI1OTEyMDZjIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMjhiN2E4MjZhNjFkN2FiYiIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9LHsiaWQiOiJmXzU1MTE2ZTM4YzljZjE1YjMiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifSx7ImlkIjoiZl9iN2YxOWZiMGJmODNlM2QzIiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfMzk4YmNiODRiZmQzNGE3ZSIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9LHsiaWQiOiJmX2Q0MzJiNzkxM2EzMWI4OGQiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifSx7ImlkIjoiZl81NzNlZGZhMmUzMjNkMjQ0Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfNTU1ODU5NzYwNmMzYmI3ZSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzM1MzdiMTYyNTYwNDIxMzgiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 -->

Review

Findings

Medium

  • [protected-path] .github/workflows/fullsend.yaml — This PR modifies protected governance/infrastructure paths: .github/workflows/fullsend.yaml, .github/workflows/prioritize.yml, .github/workflows/reusable-dispatch.yml, .github/workflows/reusable-poll-jira.yml, .github/workflows/reusable-prioritize.yml. The PR links issue jira: accept OAuth 2.0 client credentials for Atlassian service accounts #9176 and explains the secret-forwarding rationale, but human approval is always required for protected-path changes, regardless of context.

Low

  • [edge-case] internal/repos/github_jira_poll.go:118 — The user-owned Jira poll caller preflight (userJiraCallerForwardsOAuth) is a whole-file text check: it passes if any secrets: inherit line exists or both FULLSEND_JIRA_CLIENT_ID and FULLSEND_JIRA_CLIENT_SECRET appear anywhere in the file, including comments. A caller that names the secrets only in comments, uses secrets: inherit on an unrelated job, or forwards them in only one of the poll/dispatch jobs can still pass, after which the install removes the token/email secrets. The common case (a token-only caller) is now rejected and tested, so the residual gap is narrow.
    Remediation: Optionally parse the caller as YAML and check forwarding per job that calls reusable-poll-jira.yml or reusable-dispatch.yml, with tests for one-job-only forwarding and comment-only names; otherwise document the check as best-effort.

Earlier findings

  • internal/repos/github_jira_poll.go:33, edge-case — resolved by change: GitLab installs now run an OAuth compatibility preflight (checkGitLabJiraOAuthSupport) before any credential write.
  • internal/repos/github_jira_poll.go:47, edge-case — reclassified medium → low: the user-owned caller case is now guarded; only narrow text-matching false positives remain.

Re-review note: One or more prior medium-or-higher findings remain open and must still be addressed.

Blocking prior findings:

  • medium edge-case at internal/repos/github_jira_poll.go:47

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (3)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJpbnRlcm5hbC9yZXBvcy9naXRodWJfamlyYV9wb2xsLmdvIiwiaWQiOiJmXzQxODBiYjRmYTdiNGQ3YjEiLCJsaW5lIjo0NywiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvZ2l0aHViX2ppcmFfcG9sbC5nbyIsImlkIjoiZl9jN2FiOGFlNTI1OTEyMDZjIiwibGluZSI6MzMsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiZWRnZS1jYXNlIiwiZmlsZSI6ImludGVybmFsL3JlcG9zL2ppcmFfcG9sbC5nbyIsImlkIjoiZl8yOGI3YTgyNmE2MWQ3YWJiIiwibGluZSI6NDI2LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImFwaS1jb250cmFjdCIsImZpbGUiOiJpbnRlcm5hbC9zY2FmZm9sZC9mdWxsc2VuZC1yZXBvL3RlbXBsYXRlcy9qaXJhLXBvbGwtcGVyLXJlcG8ueWFtbCIsImlkIjoiZl81NTExNmUzOGM5Y2YxNWIzIiwibGluZSI6NDIsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5Ijoic2NvcGUtZXhjZWVkZWQiLCJmaWxlIjoiLmdpdGh1Yi93b3JrZmxvd3MvcmV1c2FibGUtZGlzcGF0Y2gueW1sIiwiaWQiOiJmX2I3ZjE5ZmIwYmY4M2UzZDMiLCJsaW5lIjoxMTcsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJpbnRlbnQtY29oZXJlbmNlIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZXJyb3ItaGFuZGxpbmctaWRpb20iLCJmaWxlIjoiaW50ZXJuYWwvZm9yZ2UvamlyYS9zY29wZWQuZ28iLCJpZCI6ImZfMzk4YmNiODRiZmQzNGE3ZSIsImxpbmUiOjEzNSwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZXJyb3ItaGFuZGxpbmctaWRpb20iLCJmaWxlIjoiaW50ZXJuYWwvZm9yZ2UvamlyYS9zY29wZWQuZ28iLCJpZCI6ImZfZDQzMmI3OTEzYTMxYjg4ZCIsImxpbmUiOjEzNywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiZWRnZS1jYXNlIiwiZmlsZSI6ImludGVybmFsL3JlcG9zL2ppcmFfcG9sbC5nbyIsImlkIjoiZl81NzNlZGZhMmUzMjNkMjQ0IiwibGluZSI6MTY5LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29tcGxldGUtZG9jIiwiZmlsZSI6ImRvY3MvY2xpL1JFQURNRS5tZCIsImlkIjoiZl81NTU4NTk3NjA2YzNiYjdlIiwibGluZSI6MjgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImRvY3MtY3VycmVuY3kifSx7InNldmVyaXR5IjoiaGlnaCIsImNhdGVnb3J5IjoicGF0dGVybi1pbmNvbnNpc3RlbmN5IiwiZmlsZSI6ImludGVybmFsL3JlcG9zL2ppcmFfcG9sbC5nbyIsImlkIjoiZl8zNTM3YjE2MjU2MDQyMTM4IiwibGluZSI6MjU2LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfYzdhYjhhZTUyNTkxMjA2YyIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl8yOGI3YTgyNmE2MWQ3YWJiIiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfNTUxMTZlMzhjOWNmMTViMyIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9LHsiaWQiOiJmX2I3ZjE5ZmIwYmY4M2UzZDMiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifSx7ImlkIjoiZl8zOThiY2I4NGJmZDM0YTdlIiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfZDQzMmI3OTEzYTMxYjg4ZCIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9LHsiaWQiOiJmXzU3M2VkZmEyZTMyM2QyNDQiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl81NTU4NTk3NjA2YzNiYjdlIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMzUzN2IxNjI1NjA0MjEzOCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= -->

Review

Findings

Medium

  • [edge-case] internal/repos/github_jira_poll.go:47 — The preflight still returns success immediately for a user-owned Jira poll caller (exists && !scaffold.IsManagedJiraPollCaller(caller)), before the OAuth-support checks run. When an install switches a repository from token to OAuth, convergeJiraPoll writes the OAuth credentials and deletes FULLSEND_JIRA_TOKEN/FULLSEND_JIRA_EMAIL, while githubJiraPollReconciler.Ensure leaves the user-owned caller unchanged. A custom caller that forwards only the token stops authenticating after an otherwise successful install.
    Remediation: Before replacing token credentials for a repository with a user-owned caller, verify that its credential forwarding supports OAuth, or fail before writing or deleting credentials with an instruction to migrate that caller. Keep leaving the user-owned workflow itself untouched.

  • [protected-path] .github/workflows/fullsend.yaml — This PR modifies protected governance/infrastructure paths: .github/workflows/fullsend.yaml, .github/workflows/prioritize.yml, .github/workflows/reusable-dispatch.yml, .github/workflows/reusable-poll-jira.yml, .github/workflows/reusable-prioritize.yml. The PR links issue jira: accept OAuth 2.0 client credentials for Atlassian service accounts #9176 and explains the secret-forwarding rationale, but human approval is always required for protected-path changes, regardless of context.

Earlier findings

  • internal/repos/jira_poll.go:169, edge-case — resolved by change in the current code.
  • docs/cli/README.md:28, incomplete-doc — resolved by change in the current code.
  • internal/repos/jira_poll.go:256, pattern-inconsistency — resolved by change in the current code.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (4)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJpbnRlcm5hbC9yZXBvcy9naXRodWJfamlyYV9wb2xsLmdvIiwiaWQiOiJmX2M3YWI4YWU1MjU5MTIwNmMiLCJsaW5lIjozMywiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvamlyYV9wb2xsLmdvIiwiaWQiOiJmXzI4YjdhODI2YTYxZDdhYmIiLCJsaW5lIjo0MjYsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiYXBpLWNvbnRyYWN0IiwiZmlsZSI6ImludGVybmFsL3NjYWZmb2xkL2Z1bGxzZW5kLXJlcG8vdGVtcGxhdGVzL2ppcmEtcG9sbC1wZXItcmVwby55YW1sIiwiaWQiOiJmXzU1MTE2ZTM4YzljZjE1YjMiLCJsaW5lIjo0MiwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJzY29wZS1leGNlZWRlZCIsImZpbGUiOiIuZ2l0aHViL3dvcmtmbG93cy9yZXVzYWJsZS1kaXNwYXRjaC55bWwiLCJpZCI6ImZfYjdmMTlmYjBiZjgzZTNkMyIsImxpbmUiOjExNywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImludGVudC1jb2hlcmVuY2UifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJlcnJvci1oYW5kbGluZy1pZGlvbSIsImZpbGUiOiJpbnRlcm5hbC9mb3JnZS9qaXJhL3Njb3BlZC5nbyIsImlkIjoiZl8zOThiY2I4NGJmZDM0YTdlIiwibGluZSI6MTM1LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJlcnJvci1oYW5kbGluZy1pZGlvbSIsImZpbGUiOiJpbnRlcm5hbC9mb3JnZS9qaXJhL3Njb3BlZC5nbyIsImlkIjoiZl9kNDMyYjc5MTNhMzFiODhkIiwibGluZSI6MTM3LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvamlyYV9wb2xsLmdvIiwiaWQiOiJmXzU3M2VkZmEyZTMyM2QyNDQiLCJsaW5lIjoxNjksImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiaW5jb21wbGV0ZS1kb2MiLCJmaWxlIjoiZG9jcy9jbGkvUkVBRE1FLm1kIiwiaWQiOiJmXzU1NTg1OTc2MDZjM2JiN2UiLCJsaW5lIjoyOCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9LHsic2V2ZXJpdHkiOiJoaWdoIiwiY2F0ZWdvcnkiOiJwYXR0ZXJuLWluY29uc2lzdGVuY3kiLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvamlyYV9wb2xsLmdvIiwiaWQiOiJmXzM1MzdiMTYyNTYwNDIxMzgiLCJsaW5lIjoyNTYsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn1dLCJkaXNwb3NpdGlvbnMiOlt7ImlkIjoiZl8yOGI3YTgyNmE2MWQ3YWJiIiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfNTUxMTZlMzhjOWNmMTViMyIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9LHsiaWQiOiJmX2I3ZjE5ZmIwYmY4M2UzZDMiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifSx7ImlkIjoiZl8zOThiY2I4NGJmZDM0YTdlIiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfZDQzMmI3OTEzYTMxYjg4ZCIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9LHsiaWQiOiJmXzU3M2VkZmEyZTMyM2QyNDQiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl81NTU4NTk3NjA2YzNiYjdlIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfMzUzN2IxNjI1NjA0MjEzOCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= -->

Review

Findings

Medium

  • [edge-case] internal/repos/github_jira_poll.go:33 — The OAuth compatibility preflight (checkGitHubJiraPollWorkflow) returns early unless the forge is GitHub, so GitLab projects get no OAuth check. A GitLab project pinned to a pre-OAuth fullsend_ref can pass credential validation with --jira-client-id/--jira-client-secret; convergence then writes the OAuth variables and removes the token variables, while the pinned GitLab scaffold and CLI only understand FULLSEND_JIRA_TOKEN/FULLSEND_JIRA_EMAIL. Jira polling and status writes would fail after the install. The existing GitLab check only ensures pinned templates can be fetched; it does not prove OAuth support.
    Remediation: Before writing or removing Jira credentials, verify that the resolved GitLab fullsend_ref supports OAuth, as is now done for GitHub (for example, fetch the pinned GitLab scaffold as checkPinnedOpenAICredentialContract does and require the poll and dispatcher job scripts to reference FULLSEND_JIRA_CLIENT_ID and FULLSEND_JIRA_CLIENT_SECRET). Reject incompatible pins without changing existing credentials, and add a regression test for a token-authenticated GitLab project pinned to a pre-OAuth ref.

  • [protected-path] .github/workflows/reusable-dispatch.yml — This PR modifies protected paths: .github/workflows/fullsend.yaml, .github/workflows/prioritize.yml, .github/workflows/reusable-dispatch.yml, .github/workflows/reusable-poll-jira.yml, .github/workflows/reusable-prioritize.yml, and action.yml. The PR links jira: accept OAuth 2.0 client credentials for Atlassian service accounts #9176 and explains the rationale, but human approval is always required for protected-path changes, regardless of context.


Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (5)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJpbnRlcm5hbC9yZXBvcy9qaXJhX3BvbGwuZ28iLCJpZCI6ImZfMjhiN2E4MjZhNjFkN2FiYiIsImxpbmUiOjQyNiwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJhcGktY29udHJhY3QiLCJmaWxlIjoiaW50ZXJuYWwvc2NhZmZvbGQvZnVsbHNlbmQtcmVwby90ZW1wbGF0ZXMvamlyYS1wb2xsLXBlci1yZXBvLnlhbWwiLCJpZCI6ImZfNTUxMTZlMzhjOWNmMTViMyIsImxpbmUiOjQyLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6InNjb3BlLWV4Y2VlZGVkIiwiZmlsZSI6Ii5naXRodWIvd29ya2Zsb3dzL3JldXNhYmxlLWRpc3BhdGNoLnltbCIsImlkIjoiZl9iN2YxOWZiMGJmODNlM2QzIiwibGluZSI6MTE3LCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiaW50ZW50LWNvaGVyZW5jZSJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImVycm9yLWhhbmRsaW5nLWlkaW9tIiwiZmlsZSI6ImludGVybmFsL2ZvcmdlL2ppcmEvc2NvcGVkLmdvIiwiaWQiOiJmXzM5OGJjYjg0YmZkMzRhN2UiLCJsaW5lIjoxMzUsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImVycm9yLWhhbmRsaW5nLWlkaW9tIiwiZmlsZSI6ImludGVybmFsL2ZvcmdlL2ppcmEvc2NvcGVkLmdvIiwiaWQiOiJmX2Q0MzJiNzkxM2EzMWI4OGQiLCJsaW5lIjoxMzcsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJpbnRlcm5hbC9yZXBvcy9qaXJhX3BvbGwuZ28iLCJpZCI6ImZfNTczZWRmYTJlMzIzZDI0NCIsImxpbmUiOjE2OSwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJpbmNvbXBsZXRlLWRvYyIsImZpbGUiOiJkb2NzL2NsaS9SRUFETUUubWQiLCJpZCI6ImZfNTU1ODU5NzYwNmMzYmI3ZSIsImxpbmUiOjI4LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJkb2NzLWN1cnJlbmN5In0seyJzZXZlcml0eSI6ImhpZ2giLCJjYXRlZ29yeSI6InBhdHRlcm4taW5jb25zaXN0ZW5jeSIsImZpbGUiOiJpbnRlcm5hbC9yZXBvcy9qaXJhX3BvbGwuZ28iLCJpZCI6ImZfMzUzN2IxNjI1NjA0MjEzOCIsImxpbmUiOjI1NiwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzU1MTE2ZTM4YzljZjE1YjMiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifSx7ImlkIjoiZl9iN2YxOWZiMGJmODNlM2QzIiwic3RhdHVzIjoiZGlzbWlzc2VkX2J5X2h1bWFuIn0seyJpZCI6ImZfMzk4YmNiODRiZmQzNGE3ZSIsInN0YXR1cyI6ImRpc21pc3NlZF9ieV9odW1hbiJ9LHsiaWQiOiJmX2Q0MzJiNzkxM2EzMWI4OGQiLCJzdGF0dXMiOiJkaXNtaXNzZWRfYnlfaHVtYW4ifSx7ImlkIjoiZl81NzNlZGZhMmUzMjNkMjQ0Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfNTU1ODU5NzYwNmMzYmI3ZSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzM1MzdiMTYyNTYwNDIxMzgiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 -->

Review

Findings

Medium

  • [edge-case] internal/repos/jira_poll.go:426 — An OAuth install can replace working credentials even when the repository's pinned Fullsend version cannot consume OAuth. checkGitHubJiraPollWorkflow (internal/repos/github_jira_poll.go) only checks that reusable-poll-jira.yml exists at the target ref, so a pin to a pre-OAuth ref that already has that file passes validation. convergeJiraPoll then writes FULLSEND_JIRA_CLIENT_ID/FULLSEND_JIRA_CLIENT_SECRET, deletes the existing token/email, and Ensure renders a caller (OAuthConfigured=true) that forwards the OAuth secrets by name. A reusable workflow that does not declare those secrets will reject the caller, so Jira polling breaks even though the install reported success.
    Remediation: Before any credential writes or deletions, when jiraUsesOAuth is true, verify that the selected upstream reusable-poll-jira.yml and reusable-dispatch.yml declare the FULLSEND_JIRA_CLIENT_ID/FULLSEND_JIRA_CLIENT_SECRET secrets. Reject incompatible pins with an upgrade instruction and leave existing credentials in place. Add a regression test with a pre-OAuth workflow that exists but lacks those declarations.

  • [protected-path] .github/workflows/fullsend.yaml, .github/workflows/prioritize.yml, .github/workflows/reusable-dispatch.yml, .github/workflows/reusable-poll-jira.yml, .github/workflows/reusable-prioritize.yml — This PR modifies protected governance/infrastructure paths. The PR links issue jira: accept OAuth 2.0 client credentials for Atlassian service accounts #9176 and describes the rationale (forwarding optional Jira OAuth secrets through the poll, dispatch, and prioritize workflows), but human approval is always required for protected-path changes, regardless of context.


Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (6)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImFwaS1jb250cmFjdCIsImZpbGUiOiJpbnRlcm5hbC9zY2FmZm9sZC9mdWxsc2VuZC1yZXBvL3RlbXBsYXRlcy9qaXJhLXBvbGwtcGVyLXJlcG8ueWFtbCIsImlkIjoiZl81NTExNmUzOGM5Y2YxNWIzIiwibGluZSI6NDIsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5Ijoic2NvcGUtZXhjZWVkZWQiLCJmaWxlIjoiLmdpdGh1Yi93b3JrZmxvd3MvcmV1c2FibGUtZGlzcGF0Y2gueW1sIiwiaWQiOiJmX2I3ZjE5ZmIwYmY4M2UzZDMiLCJsaW5lIjoxMTcsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJpbnRlbnQtY29oZXJlbmNlIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZXJyb3ItaGFuZGxpbmctaWRpb20iLCJmaWxlIjoiaW50ZXJuYWwvZm9yZ2UvamlyYS9zY29wZWQuZ28iLCJpZCI6ImZfMzk4YmNiODRiZmQzNGE3ZSIsImxpbmUiOjEzNSwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZXJyb3ItaGFuZGxpbmctaWRpb20iLCJmaWxlIjoiaW50ZXJuYWwvZm9yZ2UvamlyYS9zY29wZWQuZ28iLCJpZCI6ImZfZDQzMmI3OTEzYTMxYjg4ZCIsImxpbmUiOjEzNywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiZWRnZS1jYXNlIiwiZmlsZSI6ImludGVybmFsL3JlcG9zL2ppcmFfcG9sbC5nbyIsImlkIjoiZl81NzNlZGZhMmUzMjNkMjQ0IiwibGluZSI6MTY5LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29tcGxldGUtZG9jIiwiZmlsZSI6ImRvY3MvY2xpL1JFQURNRS5tZCIsImlkIjoiZl81NTU4NTk3NjA2YzNiYjdlIiwibGluZSI6MjgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImRvY3MtY3VycmVuY3kifSx7InNldmVyaXR5IjoiaGlnaCIsImNhdGVnb3J5IjoicGF0dGVybi1pbmNvbnNpc3RlbmN5IiwiZmlsZSI6ImludGVybmFsL3JlcG9zL2ppcmFfcG9sbC5nbyIsImlkIjoiZl8zNTM3YjE2MjU2MDQyMTM4IiwibGluZSI6MjU2LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfMzUzN2IxNjI1NjA0MjEzOCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2I3ZjE5ZmIwYmY4M2UzZDMiLCJzdGF0dXMiOiJvcGVuIn0seyJpZCI6ImZfZDQzMmI3OTEzYTMxYjg4ZCIsInN0YXR1cyI6Im9wZW4ifSx7ImlkIjoiZl81NzNlZGZhMmUzMjNkMjQ0Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfNTU1ODU5NzYwNmMzYmI3ZSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9XX0= -->

Review

Findings

Medium

  • [api-contract] internal/scaffold/fullsend-repo/templates/jira-poll-per-repo.yaml:42 — The managed caller now always passes FULLSEND_JIRA_CLIENT_ID and FULLSEND_JIRA_CLIENT_SECRET, including when fullsend_ref pins a reusable-workflow version from before this PR. Those versions don't declare the secrets, so GitHub rejects the caller as an invalid workflow. That also breaks existing API-token deployments where the OAuth secrets are empty. RenderJiraPollCaller swaps the pinned ref into the current template without version gating, and checkGitHubJiraPollWorkflow only checks that the poll workflow exists, so the preflight misses the mismatch.
    Remediation: Before changing credentials or staging the caller, check that the pinned reusable workflows declare the new secrets. Either reject incompatible pins with an actionable upgrade error, or render a token-only caller when OAuth is not selected (as the email line is already removed conditionally).
  • [scope-exceeded] .github/workflows/reusable-dispatch.yml:117 — Carried over from the prior review and still open. The PR edits files under .github/workflows/ to forward the Jira OAuth secrets, although a maintainer's /fs-code instruction on jira: accept OAuth 2.0 client credentials for Atlassian service accounts #9176 said not to change .github/workflows and that those changes would be added later. The PR description says the workflow wiring is intentionally included. This is not an automatic fix target: a maintainer should confirm the edits belong in this PR.
  • [protected-path] .github/workflows/reusable-dispatch.yml — The PR modifies protected paths: .github/workflows/fullsend.yaml, prioritize.yml, reusable-dispatch.yml, reusable-poll-jira.yml and reusable-prioritize.yml. The PR links jira: accept OAuth 2.0 client credentials for Atlassian service accounts #9176 and explains the rationale. Human approval is always required for protected-path changes, regardless of context.

Low

  • [error-handling-idiom] internal/forge/jira/scoped.go:135 — NewScoped calls creds.validate() only inside the creds.OAuth() branch. Token credentials skip Credentials.validate() and rely on New() to reject an empty token, which gives a less actionable error message.
    Remediation: Call creds.validate() before branching on creds.OAuth() so both credential types get the same upfront validation.

Earlier findings

  • internal/repos/jira_poll.go:256, pattern-inconsistency — resolved. The gitlabMaskableRe check in validateJiraOAuthInputs is now guarded by d.resolved.Forge == ForgeGitLab, matching the token validation, and jira_poll_test.go adds a GitHub short-secret case.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (7)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJoaWdoIiwiY2F0ZWdvcnkiOiJwYXR0ZXJuLWluY29uc2lzdGVuY3kiLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvamlyYV9wb2xsLmdvIiwiaWQiOiJmXzM1MzdiMTYyNTYwNDIxMzgiLCJsaW5lIjoyNTYsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5Ijoic2NvcGUtZXhjZWVkZWQiLCJmaWxlIjoiLmdpdGh1Yi93b3JrZmxvd3MvcmV1c2FibGUtZGlzcGF0Y2gueW1sIiwiaWQiOiJmX2I3ZjE5ZmIwYmY4M2UzZDMiLCJsaW5lIjoxMTcsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJpbnRlbnQtY29oZXJlbmNlIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZXJyb3ItaGFuZGxpbmctaWRpb20iLCJmaWxlIjoiaW50ZXJuYWwvZm9yZ2UvamlyYS9zY29wZWQuZ28iLCJpZCI6ImZfZDQzMmI3OTEzYTMxYjg4ZCIsImxpbmUiOjEzNywiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiZWRnZS1jYXNlIiwiZmlsZSI6ImludGVybmFsL3JlcG9zL2ppcmFfcG9sbC5nbyIsImlkIjoiZl81NzNlZGZhMmUzMjNkMjQ0IiwibGluZSI6MTY5LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImluY29tcGxldGUtZG9jIiwiZmlsZSI6ImRvY3MvY2xpL1JFQURNRS5tZCIsImlkIjoiZl81NTU4NTk3NjA2YzNiYjdlIiwibGluZSI6MjgsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImRvY3MtY3VycmVuY3kifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzU3M2VkZmEyZTMyM2QyNDQiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl81NTU4NTk3NjA2YzNiYjdlIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn1dfQ== -->

Review

Findings

High

  • [pattern-inconsistency] internal/repos/jira_poll.go:256 — In validateJiraOAuthInputs, the GitLab masking check !gitlabMaskableRe.MatchString(cfg.JiraClientSecret) runs for every forge. Elsewhere in internal/repos this check is guarded with d.resolved.Forge == ForgeGitLab: the token check a few lines above (jira_poll.go:227) and converge.go:1323 for OpenAIAPIKey. On GitHub, a client secret that GitHub Actions secrets and the shared Jira client both accept, but that does not match the GitLab-maskable pattern, is rejected with a GitLab CI/CD error before the secret is written.
    Remediation: Guard the check with the forge: if d.resolved.Forge == ForgeGitLab && !gitlabMaskableRe.MatchString(cfg.JiraClientSecret) { ... }. Add a GitHub validation test that uses a secret failing gitlabMaskableRe, and keep the GitLab rejection test.

Medium

  • [protected-path] .github/workflows/fullsend.yaml — This PR modifies protected paths: .github/workflows/fullsend.yaml, .github/workflows/prioritize.yml, .github/workflows/reusable-dispatch.yml, .github/workflows/reusable-poll-jira.yml, .github/workflows/reusable-prioritize.yml. The PR links jira: accept OAuth 2.0 client credentials for Atlassian service accounts #9176 and explains the change, but human approval is always required for protected-path changes, regardless of context.

  • [scope-exceeded] .github/workflows/reusable-dispatch.yml:117 — On issue jira: accept OAuth 2.0 client credentials for Atlassian service accounts #9176 the issue author (@ggallen) told the earlier code-agent run: "Do not make any changes under .github/workflows, those will be added later." This PR now changes five files under .github/workflows/. The PR body says it is the workflow/scaffold follow-up, and the commit carries a human sign-off, so this may be the "later" change. Neither the PR nor the issue shows an explicit go-ahead, though, so a maintainer should confirm that the workflow edits are intended for this PR.
    Remediation: A maintainer confirms the workflow changes are authorized here, or they move to a separate human-authored PR as the issue comment described.

Low

  • [error-handling-idiom] internal/forge/jira/scoped.go:137 — NewScoped calls creds.validate() only when creds.OAuth() is true. Token-only credentials skip it, so an empty token gets New's generic empty-token error instead of validate()'s message naming both credential options. Production callers are not affected, because CredentialsFromEnv already runs validate() on those paths.
    Remediation: Optionally call creds.validate() unconditionally at the start of NewScoped.

Labels: The PR adds a Jira OAuth feature touching CI workflows and docs.


Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (8)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJlZGdlLWNhc2UiLCJmaWxlIjoiaW50ZXJuYWwvcmVwb3MvamlyYV9wb2xsLmdvIiwiaWQiOiJmXzU3M2VkZmEyZTMyM2QyNDQiLCJsaW5lIjoxNjksImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6Im1lZGl1bSIsImNhdGVnb3J5IjoiaW5jb21wbGV0ZS1kb2MiLCJmaWxlIjoiZG9jcy9jbGkvUkVBRE1FLm1kIiwiaWQiOiJmXzU1NTg1OTc2MDZjM2JiN2UiLCJsaW5lIjoyOCwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiZG9jcy1jdXJyZW5jeSJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfNTczZWRmYTJlMzIzZDI0NCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzU1NTg1OTc2MDZjM2JiN2UiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifV19 -->

Looks good to me

Earlier findings

  • internal/repos/jira_poll.go:169, edge-case, resolved — the probe now reads the client-ID variable protection and flags a GitLab file-type variable (jira_poll.go:174-180), and validateJiraOAuthInputs rejects reuse unless --jira-client-id supplies a replacement (jira_poll.go:250-253).
  • docs/cli/README.md:28, incomplete-doc, resolved — the fullsend poll row now documents OAuth 2.0 client credentials via FULLSEND_JIRA_CLIENT_ID and FULLSEND_JIRA_CLIENT_SECRET.
Previous run (9)

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImVkZ2UtY2FzZSIsImZpbGUiOiJpbnRlcm5hbC9yZXBvcy9qaXJhX3BvbGwuZ28iLCJpZCI6ImZfNTczZWRmYTJlMzIzZDI0NCIsImxpbmUiOjE2OSwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoiY29ycmVjdG5lc3MifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJpbmNvbXBsZXRlLWRvYyIsImZpbGUiOiJkb2NzL2NsaS9SRUFETUUubWQiLCJpZCI6ImZfNTU1ODU5NzYwNmMzYmI3ZSIsImxpbmUiOjI4LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJkb2NzLWN1cnJlbmN5In1dfQ== -->

Review

Findings

Medium

  • [edge-case] internal/repos/jira_poll.go:169 — An existing FULLSEND_JIRA_CLIENT_ID is treated as reusable based only on existence. GitLab's RepoSecretExists also returns true for file-type variables, so a manually provisioned file-type client ID passes validation and is preserved when installing or rotating only --jira-client-secret. GitLab then supplies a temporary file path as FULLSEND_JIRA_CLIENT_ID, which the OAuth client sends literally as client_id. Install reports success but every token exchange fails.
    Remediation: Probe the client ID's variable type with GetRepoSecretProtection and reject an existing file-type value unless --jira-client-id supplies a replacement. Do not require masking for the client ID. Add a test covering reuse of a file-type client ID.

  • [incomplete-doc] docs/cli/README.md:28 — The fullsend poll summary says --input-driver jira-poll authenticates with FULLSEND_JIRA_TOKEN (plus FULLSEND_JIRA_EMAIL for a bot user), but does not mention the new OAuth 2.0 client credentials (FULLSEND_JIRA_CLIENT_ID / FULLSEND_JIRA_CLIENT_SECRET). This file is not modified by the PR.
    Remediation: Update line 28 to say jira-poll authenticates with FULLSEND_JIRA_TOKEN (and optional FULLSEND_JIRA_EMAIL), or with OAuth 2.0 client credentials via FULLSEND_JIRA_CLIENT_ID and FULLSEND_JIRA_CLIENT_SECRET.


Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-coder

fullsend-ai-coder Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Finished Fix · ✅ Success · Started 1:57 AM UTC · Completed 2:06 AM UTC

Commit: edf194c · View workflow run →

Runtime: claude · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.37

@ggallen ggallen added the fullsend-no-fix Skip bot-triggered fix agent runs label Nov 7, 2026
fullsend-ai-coder Bot added a commit that referenced this pull request Nov 7, 2026
Reject a reused file-type FULLSEND_JIRA_CLIENT_ID on GitLab unless
--jira-client-id supplies a replacement (probed via
GetRepoSecretProtection, masking not required), with tests. Mention the
OAuth 2.0 client credentials in the fullsend poll summary in
docs/cli/README.md.

Note: pre-commit could not fetch its hook repositories (TLS failure), so
the applicable hooks were run directly: gofmt (clean) and go vet / go test
on ./internal/repos (pass).

Addresses #9183

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@fullsend-ai-coder

Copy link
Copy Markdown
Contributor Author

🔧 Fix agent — iteration 1 (bot-triggered)

Addressed both medium findings: file-type client ID reuse is now rejected on GitLab (with tests), and the CLI docs mention the OAuth client credentials. Unit tests for internal/repos pass. The only failing CI test is unrelated to this PR.

Fixed (2):

  1. An existing FULLSEND_JIRA_CLIENT_ID was reused based only on existence, so a GitLab file-type client ID would pass validation and break every token exchange (internal/repos/jira_poll.go): The client ID is now probed with GetRepoSecretProtection. On GitLab, an existing file-type variable is recorded as a defect, and validation rejects it unless --jira-client-id supplies a replacement. Masking is not required for the client ID. Added validation and probe tests covering file-type reuse, replacement and an unmasked reusable ID.
  2. The fullsend poll summary did not mention the OAuth 2.0 client credentials (docs/cli/README.md): The jira-poll authentication description now says it uses FULLSEND_JIRA_TOKEN (plus optional FULLSEND_JIRA_EMAIL) or OAuth 2.0 client credentials via FULLSEND_JIRA_CLIENT_ID and FULLSEND_JIRA_CLIENT_SECRET.

Tests: passed

CI inspections (6):

  1. test (unrelated, failure): The failing test is a repos-install test in internal/cli. It fails because the release-default ref main lacks the Jira poll reusable workflow. It fails identically on the PR's base commit locally, so it is not caused by this PR. Not changed. File an issue with the repo owners if it persists on main.
  2. build (passing, success)
  3. semgrep (passing, success)
  4. commit-lint (passing, success)
  5. playback (pending, in_progress)
  6. behaviour (pending, in_progress)

Conflict update: skipped; strategy none; forge MERGEABLE; target main

Next steps:

  • /fs-review — request a re-review of the changes
  • /fs-fix <your instruction> — run another fix pass with specific guidance
  • Push commits directly — review re-runs automatically on push
    Updated by fullsend fix agent

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:08 AM UTC · Completed 2:17 AM UTC

Commit: 2f9a499 · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.25

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Nov 7, 2026
Add OAuth 2.0 client-credentials authentication for Jira across the shared client and repos install, covering polling, issue operations, status notifications, and reconciliation. Keep credentials in forge secrets or CI/CD variables rather than config files or runner-secret bundles.

Forward the optional credentials through GitHub poll, dispatch, and prioritize workflows for Jira-originated runs. Update managed callers, document GitHub and GitLab setup, and cover the credential and workflow paths in tests. Complete #9176 with no follow-on workflow wiring.

Signed-off-by: Greg Allen <gallen@redhat.com>
Co-authored-by: Codex <codex@openai.com>
@ggallen
ggallen force-pushed the agent/9176-jira-oauth-client-credentials branch from 2f9a499 to 0efd2bd Compare November 7, 2026 03:03
@ggallen ggallen changed the title feat(#9176): accept Jira OAuth 2.0 client credentials feat(#9176): support Jira OAuth credentials across GitHub and GitLab Nov 7, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:05 AM UTC · Completed 3:20 AM UTC

Commit: 0efd2bd · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.40

@fullsend-ai-review fullsend-ai-review Bot removed the ready-for-merge All reviewers approved — ready to merge label Nov 7, 2026
fullsend-ai-review[bot]

This comment was marked as outdated.

@ggallen

ggallen commented Nov 7, 2026

Copy link
Copy Markdown
Member

/fs-fix

@ggallen ggallen added the fullsend-fix Enables automatic bot-triggered fix runs on human-authored PRs label Nov 7, 2026
@fullsend-ai-coder

fullsend-ai-coder Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Finished Fix · ✅ Success · Started 3:29 PM UTC · Completed 3:37 PM UTC

Commit: db2fbe3 · View workflow run →

Runtime: claude · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.40

…Auth secrets

A user-owned Jira poll caller that forwards the OAuth secrets (including
secrets: inherit) could still pin reusable workflows that predate OAuth, and
the install would then delete the token secrets it depends on. Before
replacing credentials, read each reusable poll/dispatch workflow at the ref
the caller actually uses (or from the caller's repo for ./ references) and
require it to declare the OAuth client secrets. References whose support
cannot be established are rejected.

Pre-commit could not fetch hook repos (certificate failure); gofmt, go vet,
and go test ./internal/repos ./internal/scaffold were run directly and pass.

Addresses #9183

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@fullsend-ai-coder

Copy link
Copy Markdown
Contributor Author

🔧 Fix agent — iteration 7 (human-triggered)

Addressed the open medium edge-case finding: user-owned Jira poll callers are now verified against the OAuth support of the reusable workflows at their actual pinned refs before credentials are replaced. The protected-path finding needs human approval and is left unchanged. The HUMAN_INSTRUCTION was empty, so the run followed the latest review comment.

Fixed (1):

  1. User-owned Jira poll caller bypasses upstream compatibility verification once it forwards the OAuth secrets (internal/repos/github_jira_poll.go): After confirming the user-owned caller forwards the OAuth secrets per job, the preflight now reads each reusable poll/dispatch workflow at the ref the caller actually pins (or from the caller's own repo for ./ references) and requires it to declare the OAuth client secrets. References that are unpinned, malformed, unreadable, or lack the secrets are rejected before any credential write. Added tests for an inheriting caller pinned to a pre-OAuth workflow, a pre-OAuth dispatch workflow, unpinned or missing refs, and local workflows.

Disagreed (1):

  1. Protected-path change: PR modifies .github/workflows files and needs human approval: This is the mandatory merge-gate finding. It requires human approval and prescribes no content edit, so no code change is made.

Tests: passed

CI inspections (4):

  1. test (passing, success)
  2. build (passing, success)
  3. codecov/patch (passing, success): Passed on the previous head; this run's new commit is not yet reflected.
  4. behaviour (pending, in_progress): Still running at inspection time.

Conflict update: skipped; strategy none; forge MERGEABLE; target main

Next steps:

  • /fs-review — request a re-review of the changes
  • /fs-fix <your instruction> — run another fix pass with specific guidance
  • Push commits directly — review re-runs automatically on push
    Updated by fullsend fix agent

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:39 PM UTC · Completed 3:49 PM UTC

Commit: 90a380f · View workflow run →

Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.97

@fullsend-ai-review
fullsend-ai-review Bot dismissed stale reviews from themself November 7, 2026 15:49

Superseded by updated review

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Nov 7, 2026
@ggallen
ggallen enabled auto-merge November 7, 2026 15:56
@ggallen
ggallen added this pull request to the merge queue Nov 7, 2026
Merged via the queue into main with commit 1d00009 Nov 7, 2026
34 checks passed
@ggallen
ggallen deleted the agent/9176-jira-oauth-client-credentials branch November 7, 2026 16:50

This branch was successfully deployed

1 active and 1 inactive deployments
site-preview — 90a380f3 Deployed Nov 7, 2026 by github-actions[bot]
dev — 90a380f3 Deployed Nov 7, 2026 by fullsend-ai-coder[bot] via playback #19241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/ci CI pipelines and checks component/docs User-facing documentation fullsend-fix Enables automatic bot-triggered fix runs on human-authored PRs ready-for-review Triggers review agent dispatch requires-manual-review Review requires human judgment risk/elevated PR risk: elevated type/feature New capability request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant