Repository navigation
Conversation
Record named connections, entity sources, typed harness slots, and provider filters as the configuration model for entity-driven execution. Explain native source resolution, CI integration, run modes, destination policy, and compatible migration from tracker. Add the versioned configuration contract and update the architecture, problem documents, and configuration reference. Signed-off-by: Barak Korren <bkorren@redhat.com> Assisted-by: Codex
PR Summary by QodoDefine entity-source bindings and execution integration
AI Description
Diagram
High-Level Assessment
Files changed (8)
|
Code Review by Qodo
1.
|
|
🤖 Finished Review · ✅ Success · Started 8:16 PM UTC · Completed 8:28 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $3.02 |
Site previewPreview: https://e53aa131-site.fullsend-ai.workers.dev Commit: |
|
Risk Assessment: moderate (2/5) DetailsDocumentation-only architectural change with no protected paths or code changes; large diff size and high churn on central documentation files are balanced by additive specification scope and low risk metadata. Previous runRisk Assessment: moderate (2/5) DetailsDocumentation-only architectural change with no protected paths or code changes; large diff size and high churn on central documentation files are balanced by additive specification scope and low risk metadata. Previous run (2)Risk Assessment: moderate (2/5) DetailsDocumentation-only architectural change with no protected paths or code changes; large diff size and high churn on central documentation files are balanced by additive specification scope and low risk metadata. |
|
Looks good to me Earlier findings
No findings at or above Previous run<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImFwaS1jb250cmFjdCIsImZpbGUiOiJkb2NzL25vcm1hdGl2ZS9lbnRpdHktc291cmNlLWNvbmZpZ3VyYXRpb24vdjEvUkVBRE1FLm1kIiwiaWQiOiJmXzE5MDFlN2RkZWM4ODFiMWYiLCJsaW5lIjozMzUsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6ImluZm8iLCJjYXRlZ29yeSI6ImJhY2t3YXJkLWluY29tcGF0aWJsZSIsImZpbGUiOiJkb2NzL25vcm1hdGl2ZS9lbnRpdHktc291cmNlLWNvbmZpZ3VyYXRpb24vdjEvUkVBRE1FLm1kIiwiaWQiOiJmX2Y0MmFlZWFlMjY2NGRlMWEiLCJhY3Rpb25hYmxlIjpmYWxzZSwiZGltZW5zaW9uIjoiY3Jvc3MtcmVwby1jb250cmFjdHMifSx7InNldmVyaXR5IjoibWVkaXVtIiwiY2F0ZWdvcnkiOiJhcGktY29udHJhY3QiLCJmaWxlIjoiZG9jcy9ub3JtYXRpdmUvZW50aXR5LXNvdXJjZS1jb25maWd1cmF0aW9uL3YxL1JFQURNRS5tZCIsImlkIjoiZl9hNGE2YTVmM2UyMjRlMTAzIiwibGluZSI6MTIzLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJjb3JyZWN0bmVzcyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJkb2NzL0FEUnMvMDA3OS1iaW5kLWVudGl0eS1leGVjdXRpb24tdGhyb3VnaC1uYW1lZC1zb3VyY2VzLm1kIiwiaWQiOiJmX2IyNmNlM2Q1MjZjOTk3NGEiLCJsaW5lIjoyNDYsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3Mvbm9ybWF0aXZlL2VudGl0eS1zb3VyY2UtY29uZmlndXJhdGlvbi92MS9SRUFETUUubWQiLCJpZCI6ImZfMzgwODA4YjY3ODQ1MmRiZSIsImxpbmUiOjc3LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJkb2NzL3Byb2JsZW1zL2FnZW50LWluZnJhc3RydWN0dXJlLm1kIiwiaWQiOiJmXzUxNjdkYWU2ZjZiNzUyM2EiLCJsaW5lIjoxMjksImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMDc5LWJpbmQtZW50aXR5LWV4ZWN1dGlvbi10aHJvdWdoLW5hbWVkLXNvdXJjZXMubWQiLCJpZCI6ImZfOWZkZDgzM2M5YmQzNzUxMiIsImxpbmUiOjQ1NSwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJtaXNzaW5nLWRlcHJlY2F0aW9uIiwiZmlsZSI6ImRvY3Mvbm9ybWF0aXZlL2VudGl0eS1zb3VyY2UtY29uZmlndXJhdGlvbi92MS9SRUFETUUubWQiLCJpZCI6ImZfMWQ2NTNlZmFlMjQ5NzkyNCIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6Im1pc3NpbmctdmVyc2lvbi1idW1wIiwiZmlsZSI6ImRvY3Mvbm9ybWF0aXZlL2VudGl0eS1zb3VyY2UtY29uZmlndXJhdGlvbi92MS9SRUFETUUubWQiLCJpZCI6ImZfODVkYWExMmI1ZDdkZTI1OCIsImFjdGlvbmFibGUiOmZhbHNlLCJkaW1lbnNpb24iOiJjcm9zcy1yZXBvLWNvbnRyYWN0cyJ9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfYTRhNmE1ZjNlMjI0ZTEwMyIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2IyNmNlM2Q1MjZjOTk3NGEiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8zODA4MDhiNjc4NDUyZGJlIiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfNTE2N2RhZTZmNmI3NTIzYSIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmXzlmZGQ4MzNjOWJkMzc1MTIiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8xZDY1M2VmYWUyNDk3OTI0Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn0seyJpZCI6ImZfODVkYWExMmI1ZDdkZTI1OCIsInN0YXR1cyI6InJlc29sdmVkX2J5X2NoYW5nZSJ9LHsiaWQiOiJmX2Y0MmFlZWFlMjY2NGRlMWEiLCJzdGF0dXMiOiJyZWNsYXNzaWZpZWQifV19 --> ReviewFindingsMedium
Earlier findings
Next steps:
1 finding(s) below the Previous run (2)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImFwaS1jb250cmFjdCIsImZpbGUiOiJkb2NzL25vcm1hdGl2ZS9lbnRpdHktc291cmNlLWNvbmZpZ3VyYXRpb24vdjEvUkVBRE1FLm1kIiwiaWQiOiJmX2E0YTZhNWYzZTIyNGUxMDMiLCJsaW5lIjoxMjMsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNvcnJlY3RuZXNzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvQURScy8wMDc5LWJpbmQtZW50aXR5LWV4ZWN1dGlvbi10aHJvdWdoLW5hbWVkLXNvdXJjZXMubWQiLCJpZCI6ImZfYjI2Y2UzZDUyNmM5OTc0YSIsImxpbmUiOjI0NiwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9ub3JtYXRpdmUvZW50aXR5LXNvdXJjZS1jb25maWd1cmF0aW9uL3YxL1JFQURNRS5tZCIsImlkIjoiZl8zODA4MDhiNjc4NDUyZGJlIiwibGluZSI6NzcsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvcHJvYmxlbXMvYWdlbnQtaW5mcmFzdHJ1Y3R1cmUubWQiLCJpZCI6ImZfNTE2N2RhZTZmNmI3NTIzYSIsImxpbmUiOjEyOSwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifSx7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9BRFJzLzAwNzktYmluZC1lbnRpdHktZXhlY3V0aW9uLXRocm91Z2gtbmFtZWQtc291cmNlcy5tZCIsImlkIjoiZl85ZmRkODMzYzliZDM3NTEyIiwibGluZSI6NDU1LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6Im1pc3NpbmctZGVwcmVjYXRpb24iLCJmaWxlIjoiZG9jcy9ub3JtYXRpdmUvZW50aXR5LXNvdXJjZS1jb25maWd1cmF0aW9uL3YxL1JFQURNRS5tZCIsImlkIjoiZl8xZDY1M2VmYWUyNDk3OTI0IiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoibWlzc2luZy12ZXJzaW9uLWJ1bXAiLCJmaWxlIjoiZG9jcy9ub3JtYXRpdmUvZW50aXR5LXNvdXJjZS1jb25maWd1cmF0aW9uL3YxL1JFQURNRS5tZCIsImlkIjoiZl84NWRhYTEyYjVkN2RlMjU4IiwiYWN0aW9uYWJsZSI6ZmFsc2UsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiYmFja3dhcmQtaW5jb21wYXRpYmxlIiwiZmlsZSI6ImRvY3Mvbm9ybWF0aXZlL2VudGl0eS1zb3VyY2UtY29uZmlndXJhdGlvbi92MS9SRUFETUUubWQiLCJpZCI6ImZfZjQyYWVlYWUyNjY0ZGUxYSIsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6ImNyb3NzLXJlcG8tY29udHJhY3RzIn1dfQ== --> ReviewFindingsMedium
Low
Labels: Documentation-only ADR and normative spec PR Next steps:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Require same-named connection defaults and reserved source connections, and clarify when the origin repository path is inherited. Bind credentials to trusted endpoints, specify GitLab closed-state expansion, and resolve documentation and migration review findings. Signed-off-by: Barak Korren <bkorren@redhat.com> Assisted-by: Codex
|
🤖 Finished Review · ✅ Success · Started 9:44 PM UTC · Completed 9:52 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $2.37 |
Signed-off-by: Barak Korren <bkorren@redhat.com> Assisted-by: Codex
|
🤖 Finished Review · ✅ Success · Started 10:23 PM UTC · Completed 10:32 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.60 |
Superseded by updated review
Superseded by updated review
Summary
The current
trackermapping selects at most one issue provider and its creation policy; it cannot express multiple service instances or per-agent entity scopes. ADR 0079 adopts named connections and sources, with typed harness slots bound by repository configuration, to connect entity discovery, agent coordination, CI integration, and the existing run modes.This is a documentation-only proposal. The versioned contract now defines connection defaults, native-source resolution, query membership, destination policy, and migration. Implementation and activation remain subject to the entity, discovery, authorization, and context prerequisites.
Related Issue
Relates to #8418, #8420, and #8421; this PR does not close implementation work. The current tracker mapping comes from issue #9074; the Jira connection and polling additions come from PR #9091. The proposed named-source structure follows the review discussion.
Changes
entity_kindsslots, list-valuedagents[].entitiesbindings, and provider-specific harness filters. Onlysourceschedules work; an omitted target binding follows the effective source binding.connectionuses the connection with the same name. Reserved provider sources must use their same-named connection; configure that connection's trusted endpoint to select another instance. Only the origin provider's reserved source may inherit the clone's repository path.closedfor merge requests expands to the nativeclosedandmergedstates.tracker, including theallowed_targetsdestination for provider-only legacy blocks.Current-behavior evidence
Verified at commit
3ac6aea526f7b2b60db667645cbb2bed81236f4a:TrackingConfig,Provider, andvalidateTrackingdefine the provider-discriminated mapping and enforce at most one selected provider.JiraTrackingConfigandJiraPollConfighold one site, primary project, polling configuration, and creation allowlist.resolveTrackeruses the explicit selector or configured tracker;resolveIssueProjectpreserves Jira's configured primary-project default.Testing
make lint: documentation status, number, frontmatter, links, formatting, and secret checks passed. Optional Semgrep skipped because its cache directory was read-only; no security analysis is claimed.mainand all 170 open PRs; no collision.git diff --checkpassed.Checklist
docs(adr)).