Repository navigation
chore(e2e): run e2e suites when reusable-prioritize.yml changes - #9201
Conversation
Acceptance tests for https://redhat.atlassian.net/browse/AISDLC-659 (2 of 3 criteria; the rest declared for a person). ac_1: TestE2ERelevanceFiltersRunSuitesForReusablePrioritize, TestE2EPushPathsIncludeReusablePrioritize ac_2: TestLiveTestRelevanceScriptListsReusablePrioritize ac_3: not testable — No test can decide the file list of a PR before it exists; a person checks it on the PR: the implementation commit must touch only .github/workflows/e2e.yml and scripts/check-live-test-relevance-test.sh (this story's frozen acceptance tests add internal/scaffold/e2e_relevance_test.go beside them). Red run on the base: 3 of these fail (TestE2ERelevanceFiltersRunSuitesForReusablePrioritize, TestE2EPushPathsIncludeReusablePrioritize, TestLiveTestRelevanceScriptListsReusablePrioritize); the log is kept in the run's evidence. Signed-off-by: Tim Pouyer <tim.pouyer@gmail.com>
Fixes https://redhat.atlassian.net/browse/AISDLC-659 Acceptance tests: see the test(e2e) commit in this branch. Test rounds used: 1/100. PR review: round 1, verdict approve (3 nitpick(s), 5 advisory(ies), 0 unresolved blocking). Signed-off-by: Tim Pouyer <tim.pouyer@gmail.com>
E2E tests did not runE2E tests run automatically for pull requests authored by users with write access or higher. For other contributors, someone with write access must add the Reason: See E2E testing guide for details. |
PR Summary by QodoRun e2e suites when reusable-prioritize.yml changes
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Code Review by Qodo
1.
|
|
🤖 Finished Review · ✅ Success · Started 12:18 AM UTC · Completed 12:25 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.80 |
|
Risk Assessment: moderate (2/5) DetailsTouches CI workflow files and protected paths with moderate author contention and coupling history, but diff size is small, test ratio is high (67%), and recent churn and reverts are low. |
ReviewFindingsMedium
Low
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Intentional: Same finding as the thread on .github/workflows/e2e.yml:164 (qodo finding 0d7b85fc): the standalone reusable-prioritize.yml is suite-relevant by design — the thin per-repo prioritize.yml caller bypasses the dispatch shim and calls it directly (docs/contributing/workflow-contracts.md), and ADR 62 requires it stay in sync with the inlined prioritize job in reusable-dispatch.yml that the behaviour scenarios' /fs-prioritize routing exercises. Validating the standalone workflow at PR revision would contradict ADR 62's @main caller design and is outside AISDLC-659's scope. |
|
Per decisions.jsonl, the person's final-review approval (question:final-review:854f653e7c): I approve the modification of the two protected paths |
Summary
Run the behaviour and playback e2e suites when
.github/workflows/reusable-prioritize.ymlchanges, as they already do forreusable-dispatch.yml. The e2e workflow's relevance filters decide when those suites run; they listedreusable-dispatch.ymlbut notreusable-prioritize.yml, so a change to the prioritize reusable workflow — which the behaviour scenarios exercise viaprioritize.yml— skipped both suites.Related Issue
Resolves AISDLC-659
Changes
.github/workflows/e2e.yml— adds.github/workflows/reusable-prioritize.ymlto theon.push.pathstrigger and to the behaviour and playback jobs' file-relevancegrepfilters, besidereusable-dispatch.yml.scripts/check-live-test-relevance-test.sh— adds the same path to the script's positive list, so the script now checks that this path stays relevant under both filters; the two grep filters ine2e.ymlmust stay identical, as the SYNC-WITH comments in both files require.internal/scaffold/e2e_relevance_test.go(new) — three tests: both relevance filters ine2e.ymlmatchreusable-prioritize.yml,on.push.pathslists it, and the regression script's positive list includes it.The first commit adds the tests; the code commit makes the change (2 files, +4/−2). No doc updates are owed (no document enumerates the filter list);
reusable-poll-jira.ymlstays out deliberately — no behaviour feature exercises it.Protected paths
.github/workflows/e2e.yml— protected CI workflow; its relevance filters are exactly where the missing suite trigger lives (on.push.pathsplus both job greps).scripts/check-live-test-relevance-test.sh— protected regression script; its positive path list gainsreusable-prioritize.yml, so the script now checks that this path stays relevant under both filters.Testing
The three new tests fail on the base branch — its
e2e.ymland script list contain noreusable-prioritizeentry — and pass with this change:TestE2ERelevanceFiltersRunSuitesForReusablePrioritizeTestE2EPushPathsIncludeReusablePrioritizeTestLiveTestRelevanceScriptListsReusablePrioritizeRun:
go test -race ./internal/scaffold/ -run 'TestE2E|TestLiveTestRelevance'andbash scripts/check-live-test-relevance-test.sh; pre-commit hooks andgo vetpass.make lintpasses (stage changes first, then run)Checklist
!for breaking changes)Receipt
Acceptance criteria
TestE2ERelevanceFiltersRunSuitesForReusablePrioritize,TestE2EPushPathsIncludeReusablePrioritizeTestLiveTestRelevanceScriptListsReusablePrioritize