Repository navigation
docs(#9448): explain fine-grained PAT via GH_TOKEN in prerequisites - #9450
fullsend-ai-coder[bot] wants to merge 2 commits into
Conversation
The GitHub prerequisites in repo-management.md and operations.md only said to authenticate the gh CLI. Users who created a fine-grained PAT and then ran `gh auth login` in the browser ended up with gh's own OAuth token, so the CLI never used the PAT they made. Replace the gh bullet in both guides with a "GitHub token" bullet that states the CLI's resolution order (GH_TOKEN, then GITHUB_TOKEN, then `gh auth token`, verified against internal/cli/github_client.go), offers both the gh OAuth and the fine-grained PAT paths, links to the PAT permissions in configuring-github.md, and recommends `export GH_TOKEN` over `gh auth login --with-token`, which would replace the user's stored gh login. Note: `pre-commit run` could not fetch remote hook repositories (TLS verification failed in the sandbox). Ran lint-docs-links, lint-broken-symlinks, lint-md-links (lychee, with fragments), whitespace/EOF checks, and gitleaks directly; all passed. Other remote hooks do not apply to Markdown files. Closes #9448 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🤖 Finished Review · ✅ Success · Started 8:12 PM UTC · Completed 8:20 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.72 |
Site previewPreview: https://99158c6a-site.fullsend-ai.workers.dev Commit: |
|
Risk Assessment: moderate (2/5) DetailsDocumentation-only PR by a bot with minimal diff size and full issue alignment, but elevated to moderate risk due to high churn, multi-author contention, and change coupling in the modified getting-started guide files. Previous runRisk Assessment: moderate (2/5) DetailsDocumentation-only PR by a bot with minimal diff size and full issue alignment, but elevated to moderate risk due to high churn, multi-author contention, and change coupling in the modified getting-started guide files. |
|
Looks good to me Earlier findings
Previous run<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJhcHByb3ZlIiwiZmluZGluZ3MiOlt7InNldmVyaXR5IjoibG93IiwiY2F0ZWdvcnkiOiJkb2Mtc3R5bGUiLCJmaWxlIjoiZG9jcy9ndWlkZXMvZ2V0dGluZy1zdGFydGVkL29wZXJhdGlvbnMubWQiLCJpZCI6ImZfOWZkMDEyZGI1MWU0MmRhYyIsImxpbmUiOjE0LCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJkb2NzL2d1aWRlcy9nZXR0aW5nLXN0YXJ0ZWQvcmVwby1tYW5hZ2VtZW50Lm1kIiwiaWQiOiJmXzM0YzYwYjg3NmVkYjczMzciLCJsaW5lIjozMSwiYWN0aW9uYWJsZSI6dHJ1ZSwiZGltZW5zaW9uIjoic3R5bGUtY29udmVudGlvbnMifV0sImRpc3Bvc2l0aW9ucyI6W3siaWQiOiJmXzlmZDAxMmRiNTFlNDJkYWMiLCJzdGF0dXMiOiJyZXNvbHZlZF9ieV9jaGFuZ2UifSx7ImlkIjoiZl8zNGM2MGI4NzZlZGI3MzM3Iiwic3RhdHVzIjoicmVzb2x2ZWRfYnlfY2hhbmdlIn1dfQ== --> Looks good to me Earlier findings
Previous run (2)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJkb2NzL2d1aWRlcy9nZXR0aW5nLXN0YXJ0ZWQvb3BlcmF0aW9ucy5tZCIsImlkIjoiZl85ZmQwMTJkYjUxZTQyZGFjIiwibGluZSI6MTQsImFjdGlvbmFibGUiOnRydWUsImRpbWVuc2lvbiI6InN0eWxlLWNvbnZlbnRpb25zIn0seyJzZXZlcml0eSI6ImxvdyIsImNhdGVnb3J5IjoiZG9jLXN0eWxlIiwiZmlsZSI6ImRvY3MvZ3VpZGVzL2dldHRpbmctc3RhcnRlZC9yZXBvLW1hbmFnZW1lbnQubWQiLCJpZCI6ImZfMzRjNjBiODc2ZWRiNzMzNyIsImxpbmUiOjMxLCJhY3Rpb25hYmxlIjp0cnVlLCJkaW1lbnNpb24iOiJzdHlsZS1jb252ZW50aW9ucyJ9XX0= --> ReviewFindingsLow
Labels: Docs-only change to getting-started guides. Next steps:
|
|
🤖 Finished Fix · ✅ Success · Started 8:22 PM UTC · Completed 8:26 PM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.20 |
Address review feedback on PR #9450: wrap the replaced GitHub token bullets in operations.md and repo-management.md per the line wrapping rule in docs/contributing/documentation.md, using a 2-space hanging indent. Wording is unchanged. Note: pre-commit could not fetch hook repositories (TLS failure), so the applicable hooks (trailing whitespace, EOF, line endings) were checked manually. make lint-md-links could not run (lychee unavailable in the sandbox); links are unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🔧 Fix agent — iteration 1 (bot-triggered)Wrapped both replaced GitHub token bullets at about 80 columns per docs/contributing/documentation.md. Pre-commit could not fetch hook repos and lychee link check could not run in the sandbox; whitespace/EOF/line-ending checks were done manually, and link targets are unchanged. Fixed (2):
Tests: passed CI inspections (6):
Conflict update: skipped; strategy
|
|
🤖 Finished Review · ✅ Success · Started 8:28 PM UTC · Completed 8:35 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.85 |
Superseded by updated review
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
Updates the GitHub prerequisites in
docs/guides/getting-started/repo-management.mdanddocs/guides/getting-started/operations.mdto explain how to use a fine-grained PAT. Users who created a PAT and then rangh auth loginin the browser got gh's own OAuth token, andfullsend repos installnever used the PAT.Changes
ghCLI bullet with a GitHub token bullet in both guides:GH_TOKEN→GITHUB_TOKEN→gh auth token. I checked this againstresolveToken/envGitHubTokenininternal/cli/github_client.go.ghwith the OAuth scopes, or create a fine-grained PAT scoped to the target repo(s) andexport GH_TOKEN=....export GH_TOKENovergh auth login --with-token, which would replace the user's storedghlogin.operations.mdhad the same bullet, so I updated it too, as the triage suggested. Its wording uses the singular "target repository" to match that guide's per-repo scope.Testing
pre-commit runcould not fetch remote hook repos in the sandbox (TLS verification failed), so I ran the relevant hooks directly. All passed:lint-docs-links,lint-broken-symlinks,lint-md-links(lychee--offline --include-fragments, which also checks the new#prerequisitesanchor), whitespace and end-of-file checks, and gitleaks. The other hooks don't apply to Markdown.Checklist
docs, not breaking)🤖 Generated with Claude Code
Closes #9448
Post-script verification
agent/9448-repo-mgmt-pat-gh-token)bc4f5fe240efa31276b22ccc901ee5dabe052c8c..HEAD)