FUNCH_API_URL を任意の環境変数にし、未設定でも起動できるようにする - #56
Merged
Merged
Conversation
FUNCH_API_URL を削除しても BFF が起動できるよう、未設定時は Funch クライアントを nil とした。 app-bff-api は nil の場合に funch の service を注入せず警告ログを出し、 admin-bff-api は funchClient が nil でも panic せず、メニュー取得時に 503 を返す。 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FC7zWWV1MNFkNd8Q7woc6U
kantacky
marked this pull request as ready for review
September 20, 2026 10:19
kantacky
requested review from
a team,
Hosoda-abo,
hikaru-0602 and
masaya-osuga
September 20, 2026 10:19
kantacky
enabled auto-merge
September 20, 2026 10:22
masaya-osuga
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更点
FUNCH_API_URL未設定時は Funch クライアントをnilとし、両 BFF が起動できるようにしたnilの場合は funch の service を注入せず、警告ログを出す。メニュー取得はerrFunchServiceNotConfiguredを返すfunchClientがnilでも panic せず、メニュー取得時に 503 を返す🤖 Generated with Claude Code
https://claude.ai/code/session_01FC7zWWV1MNFkNd8Q7woc6U