Web Cloud Files: tag chips on file rows - #88
Merged
Conversation
Mirror the category tabs: file rows in the Cloud Files manager now show compact tag chips under the name, reusing WebTagService.tagsForObjects. - _fileTags map refreshed after each listing (indexed over the WHOLE flat bucket, so subfolder rows resolve without a reload) and after a tag edit - chips rendered in the row subtitle (up to 2 + "+N"), only when present - _fileTags cleared on bucket switch to avoid a stale cross-bucket flash - _TagChipRow duplicated from WebBucketScreen (copy #2; extract on #3) No SDK / shared-service changes; tagsForObjects + _bareKey untouched, so chips compute identically to the already-shipped Tags action. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
File rows in the web Cloud Files manager now show the same compact tag chips the category tabs already show — closing the round-3 gap (the Tags action shipped in #81, but chips on rows did not).
v1.11.4.19.How
_fileTagsstate + best-effort_refreshTags(bucket, objects)(mirror ofWebBucketScreen._refreshTags) — wrapped in try/catch so a tag-manifest failure never blocks or fails the listing.listObjectsresult), not the current folder, so drilling into subfolders shows chips with no reload —_enterFolderonly changes the prefix. Rows look up_fileTags[o.key]._fileTagscleared on bucket switch (_openBucket/_toBuckets) so a stale chip can't flash against a coincidentally same-named key before the async refresh returns.Column: size +_TagChipRow), only when non-empty._TagChipRowduplicated fromWebBucketScreen(copy Windows #2; shared-widget extraction deferred to a 3rd consumer, per project rule-of-three — and editing the working category-tabs screen would expand the can't-runtime-verify blast radius).No SDK or shared-service changes —
WebTagService.tagsForObjects/_bareKeymatching is untouched, so chips are computed identically to (and stay consistent with) the already-shipped Tags action.Verification
flutter analyze(changed files): clean.flutter build web --release: green.advisor+ cursor; agy unavailable this run — not authed for headless). Confirmed: whole-bucket indexing for folder nav (cursor's critical catch), clear-on-switch, duplicate-not-extract, leave_bareKeyalone.Live-verify gate (web-only; not signed-in-testable here)
listObjectskey carrying a leading slash (/sub/file). Degrades gracefully (no chip, never a crash) and matches the existing Tags action either way.🤖 Generated with Claude Code