tokens: use Symbols instead of strings

[alxndrsn]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 49bf082

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[gajus]

I am not against, but can you provide reasoning for why/how this is better?

[gajus]

Separately, this highlights issue with the current test suite, as this would definitely break the slonik-sql-tag-raw package.

[mmkal]

This will likely also cause problems for anyone trying to bundle slonik with esbuild, swc, webpack, turbopack, bun, parcel, ncc, etc. etc.

[gajus]

This will likely also cause problems for anyone trying to bundle slonik with esbuild, swc, webpack, turbopack, bun, parcel, ncc, etc. etc.

aligned. I've seen this also cause issues when multiple versions of Slonik are loaded.

I can see why this could be desirable, but also cautious about how it would need to be implemented.

[alxndrsn]

this would definitely break the slonik-sql-tag-raw package.

This will likely also cause problems for anyone trying to bundle slonik...

I've seen this also cause issues when multiple versions of Slonik are loaded.

@gajus @mmkal can you expand on likely issues? I can see how all of these things could be problematic if using the Symbol() constructor, but not with Symbol.for().

[gajus]

@gajus @mmkal can you expand on likely issues? I can see how all of these things could be problematic if using the Symbol() constructor, but not with Symbol.for().

My oversight. I was not familiar with Symbol.for().

This has now been released https://github.com/gajus/slonik/releases/tag/%40slonik%2Futilities%4044.0.0