Fix buffer over-read in getUTF8Char - #38
Merged
Merged
Conversation
getChar indexed the string without checking the bound, so a truncated multi-byte sequence at the very end of a string made getUTF8Char read past it while looking for continuation bytes. In practice ELM_LIST raised "List Element: <list>[n] must have an assigned value", so GapToJsonString([ CHAR_INT(200) ]) failed outright. Pass the length down and return 0 past the end. Since 0 is not a continuation byte, the sequence takes the existing "hope this is Latin-1" path, which is what a malformed sequence anywhere else in the string already does. The local variable holding the number of bytes in the sequence is renamed to nbytes, as len now names the length of the string. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #38 +/- ##
=======================================
Coverage 96.42% 96.42%
=======================================
Files 6 6
Lines 140 140
=======================================
Hits 135 135
Misses 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getChar indexed the string without checking the bound, so a truncated
multi-byte sequence at the very end of a string made getUTF8Char read past
it while looking for continuation bytes. In practice ELM_LIST raised
"List Element: [n] must have an assigned value", so
GapToJsonString([ CHAR_INT(200) ]) failed outright.
Pass the length down and return 0 past the end. Since 0 is not a
continuation byte, the sequence takes the existing "hope this is Latin-1"
path, which is what a malformed sequence anywhere else in the string
already does.
The local variable holding the number of bytes in the sequence is renamed
to nbytes, as len now names the length of the string.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com