fix(browse): stop health auth token exposure#1938
Draft
maxpetrusenkoagent wants to merge 2 commits into
Draft
Conversation
Fixes garrytan#1324 - make /health public status-only, even for spoofed chrome-extension origins - provision extension auth through bundled extension chrome.storage - pin terminal-agent websocket auth to the detected gstack extension id - add focused regressions for token leakage and extension auth bootstrap
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
…x-2026-06-19-gstack-1938-2 # Conflicts: # browse/src/browser-manager.ts
Author
|
Review-fix sweep update: Resolved the merge conflict against current upstream Conflict resolution:
Verification:
Second-agent note:
Confidence: high on the conflict repair. Remaining state is GitHub/check settling, not a local merge conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/healthpublic status-only so spoofedchrome-extension://origins never receive the root auth tokenchrome.storage.localinstead of/healthTest Plan
bun test browse/test/server-auth.test.ts browse/test/extension-auth-bootstrap.test.ts browse/test/terminal-agent-integration.test.ts browse/test/pair-agent-e2e.test.ts browse/test/sidebar-tabs.test.tsFixes #1324