Repository navigation
Conversation
Assisted-by: Claude Opus 5.5
…efore the launch The disk PLE table's wait-sync mode captures a WAIT on _flag in every decode graph and set the flag only after the graph launch returned. cuGraphLaunch can block until the GPU drains when the graph does not fit the launch queue -- the GPU parked on that WAIT -- so a large decode graph (hybrid MoE; hybrid + --moe-collect-stats every time) deadlocked on its first step (fork #65). All PleStore calls now run FIFO on one filler thread (the store stays single-threaded). A graph fill is submitted before the launch with the request contexts snapshotted on the engine thread; eager fills are submitted and awaited as before. A failed launch cancels its fill and clears a signal no WAIT consumed. Assisted-by: Claude Opus 5.5
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #64. Fixes #65.
Bug: the disk PLE table's wait-sync mode captures a WAIT on
_flagin every decode graph, but the host set the flag only aftercuGraphLaunchreturned. A large graph that does not fit the launch queue makescuGraphLaunchblock until the GPU drains, and the GPU was parked on that WAIT, so it deadlocked. The hybrid MoE decode graph hit this on its first step with--moe-collect-stats, and intermittently without it. #65 has the evidence (py-spy stacks, flag watcher, nsys).Fix (
6ebfa18): allPleStorecalls run FIFO on oneple-fillerthread, so the store stays single-threaded.Test:
tests/models/qwen4_exp/test_ple_disk_fill_order.pyfakes a launch that blocks until the flag is set.GPU validation (RTX 5080, Qwen3.8-Flash-Next-NVFP4, disk PLE):
--moe-collect-stats) used to hang on the first request. It now completes 3/3 300-token requests (8.5–8.8 s each).Hybrid gives no decode gain over offload on this box (~38.2 vs ~38.8 tok/s), so production stays on offload. The fix still matters because offload uses the same wait-sync path.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Bu6LgoxLR4wETqb7RPR2vt