Repository navigation
docs(contributing): reflect the enforced CI gates - #10
Merged
Merged
Conversation
CONTRIBUTING already covered build/test/PR basics but was stale after this session's CI hardening. Fix "format-check ... advisory for now" -> it's a hard gate; add a "What CI enforces" section (real-model integration/e2e, perf floor, tool-calling quality floor, ASan/UBSan, musl) with the local commands to run the heavy gates before pushing; and document the _POSIX_C_SOURCE footgun for tools/tests. Lowers the bus factor: a contributor knows what CI actually guards and the one gotcha that bites. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates CONTRIBUTING.md after the CI hardening: format-check is now a hard gate (was 'advisory'); adds a 'What CI enforces' section (real-model integration/e2e, perf + quality floors, ASan/UBSan, musl) with the local commands to run them before pushing; documents the
_POSIX_C_SOURCEfootgun for tools/tests. Docs only.