CI improvements#703
Conversation
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
fmigneault
left a comment
There was a problem hiding this comment.
PR looks fine for the CI part.
@Zeitsperre
I do not have admin access to grant GeoPython access.
|
@Zeitsperre I have not seen a request ... maybe it goes to @tomkralidis ?
|
|
I'll take a look at the ReadTheDocs updates and how they affect other projects. |
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
|
@tomkralidis Thanks! Please let me know when you've had a look at things. |
|
@tomkralidis Sorry to bother again, but I'm being reminded that this project hasn't migrated yet to the new system. Is there anything I can do to help this along? |
|
@Zeitsperre sorry for the delay. Can you point to documentation about this change on RTD? It seems that hooks continue to work accordingly both in PyWPS and other Geopython projects. |
|
The inital announcement: https://about.readthedocs.com/blog/2025/06/announcing-our-github-app-beta/ The documentation concerning the new system: https://docs.readthedocs.com/platform/stable/reference/git-integration.html#github-app So it appears that the traditional hooks will continue working as before so long as the app is never installed. The webhooks no longer functioning for me was because I started the migration for some projects within an org and didn't fully complete it for a day or so (everything is functioning for me now). The issue I have is that staying on the webhook system means individual projects on ReadTheDocs are tied to individual access; GeoPython-appointed users don't manage the docs, only the project owners registered on ReadTheDocs do. If ever those users leave GeoPython or become unreachable, it would require a claim request to regain access. It would be nice to have all these projects registered with the organization, but I can see that migrating several projects over might be a hassle. |
|
@Zeitsperre |
Overview
ThiS PR adds a few small changes to ensure that commits are used for version control instead of tags.
It also adds a few updates to the docs-building step, relying solely on
toxandmakefor CI purposes (easier to configure).Finally, recent changes to
macos-latestrequire that non-standard "taps" be approved. This affects coveralls running on macOS insofar as an additional approval step is now required. Hoepfully the Coveralls devs will adjust this soon.Additional Information
ReadTheDocs is asking that project migrate from the manual OAuth hook method to the new ReadTheDocs App. Sometime last week, manually-configured hooks stopped working globally, so ReadTheDocs needs to be installed in Geopython, at the very least on this project if we want to continue building the docs on PRs and on changes to
main.I've sent a request in that needs to be approved by someone with admin access at geopython. @fmigneault or @cehbrecht, could either of you approve that? I can finish the migration on RTD afterwards.
Contribution Agreement
(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)