Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sticky thread-list headers reveal scrolled row backgrounds through their rounded corners. Make the shared tier square; ordinary thread rows and action buttons keep their rounding.
cn(baseClasses, "bg-sidebar", className, + "rounded-none", )Fixes #5208.
Evidence
SidebarStickyTierand app theme from current main. Label/project/parent tiers computedborder-radius: 6px, exposing underlying row backgrounds at the corners.After: all three tiers compute
0px; corner pixels are covered, sticky positions are unchanged, and ordinary rows still compute6px. Checked light/dark themes with normal, selected, open-in-split, and hover/menu-open states.pnpm exec turbo run test typecheck --filter=bb-plugin-thread-list: 37 files / 468 tests passed; typecheck passed.pnpm exec turbo run test --filter=@bb/app -- src/components/ui/theme.test.ts: 38 tests passed.pnpm exec turbo run lint --filter=bb-plugin-thread-list: 0 errors, 10 warnings.Merge Danger
Door: two-way — revert one class.
Blast Radius: cosmetic — shared header tiers are square, including before they stick. No changes to scrolling, sticky offsets, state backgrounds, or wire contracts.