Repository navigation
Conversation
Adds automation_created (trigger, mode, origin) and split_view_opened (pane count after opening, 2-8) to the client telemetry allow-list. Automations emits from its server create path through the plugin SDK's system.experimental_recordTelemetryEvent, so the RPC and CLI paths report once each and failures never affect creation. The app reports split view from one watcher on the split layout, so every surface that adds a pane reports it and restoring a saved layout does not. The server still drops both when usage data sharing is off. Privacy copy, configuration docs, the API audit entry, and the Automations overview list the new events. Plugin SDK 0.6.40. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
brsbl
added this pull request to stack #5232
October 10, 2026 02:40
Automations' service receives a narrow ServiceApi, so the telemetry helper and that type now name system.experimental_recordTelemetryEvent explicitly, and the hand-built test SDKs stub it. Formats the PR's files with oxfmt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ation-split-view-thr_gqshddt6w2
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
bb couldn't tell whether people create automations or use split view, so neither could be compared with retention, and the Tips feed couldn't rank tips for them. Neither action sent a usage event.
What changed
automation_createdandsplit_view_openedare added torecordTelemetryEventRequestSchema(packages/server-contract/src/api/system.ts). Their properties are strict enums and a bounded count:automation_created:trigger(scheduleoronce),mode(agentorscript),origin(human,app, oragent).split_view_opened:panes, an integer from 2 to 8 (MAX_PANES).createpath (plugins/automations/src/service.ts, helper insrc/telemetry.ts) reports the event throughbb.sdk.system.experimental_recordTelemetryEvent, the same SDK path Tips uses. This is the only place that writes a new automation, so the RPC and the CLI report once each; legacy imports don't report. Telemetry errors are swallowed and never affect creation.splitLayoutAtom(useSplitViewTelemetry, mounted inAppLayout) reports when the pane count grows. Every surface that adds a pane (menu, palette, drag, nav rail, server open-in-split) is covered once. Closing panes and restoring a saved layout don't report.BB_TELEMETRY=false.docs/configuration.mdtelemetry list includes them.docs/api_to_audit.mdentry forexperimental_recordTelemetryEventnow lists every core and bundled-plugin caller.RecordTelemetryEventRequesttype grew. Automations now requiresbbPluginSdk >=0.6.40.Stack: this PR depends on #5222's telemetry route and SDK method, and sits on top of #4991 because both extend the same allow-list, privacy copy and docs.
How you verified
Privacy page, telemetry paragraph (Chrome for Testing, local
apps/webdev server, 2×):automation_createdevent per successful create, and none for rejected creates.split_view_openedwith{ panes: 2 }, which the server accepted (200).AppLayoutdoesn't re-render on resize or focus.MAX_PANES.BB-Thread: Retention measurement
🤖 Generated with Claude Code