Repository navigation
Keep settings and sidebar actions aligned in a shared footer - #5333
Conversation
e0fa48e to
9af0e9e
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9af0e9ec44
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <div | ||
| data-testid="sidebar-footer-row" | ||
| className="flex shrink-0 items-stretch" |
There was a problem hiding this comment.
Keep the footer edge draggable for sidebar resizing
On expanded desktop sidebars, placing the new footer row outside the upper SidebarCollapsibleBody leaves every SidebarResizeHandle confined to that upper row: the handle is absolutely positioned with h-full relative to the collapsible body, so the right edge alongside this footer no longer starts a resize. This affects the app, settings, plugins, and skills sidebars whenever a user tries to drag from the bottom section; extend or add the resize handle through the shared footer row.
Useful? React with 👍 / 👎.
| "bg-surface-recessed -mb-[env(safe-area-inset-bottom)] pb-[calc(0.5rem_+_env(safe-area-inset-bottom))]", | ||
| )} | ||
| > | ||
| {railFooter} |
There was a problem hiding this comment.
Keep Settings inside a navigation landmark
For assistive-technology users navigating by landmarks, rendering railFooter in this plain footer container removes Settings from the Primary navigation landmark, since the <nav> in AppNavRail now closes before this button. Settings remains visually part of the navigation rail but is no longer discoverable with the other primary destinations; preserve equivalent navigation semantics around this control.
Useful? React with 👍 / 👎.
Human comments
What was wrong
Settings and footer actions used separate vertical layouts, so their alignment could drift. The framed rail also placed Settings too low.
What changed
How you verified
a501c98abb9d7aded4d9455ea8780fc17ec0d4bb.9af0e9ec440d021b5036e90af7b02fa909eaf0e7.e9ad6b0e3473628f96fa98378cf8528aac8984d2preserved all seven patches; fresh screenshots confirm the same geometry.1cde8e10619e33ddf23d2994336cfa1657d7a0e9found no P0/P1 issues. P2 follow-up: extend sidebar resizing through the footer edge.Layer 1 · Shared sidebar footer
Before:
e9ad6b0e3473628f96fa98378cf8528aac8984d2· After:9af0e9ec440d021b5036e90af7b02fa909eaf0e7· 2× PNGs.Captured from the compared branch web apps using the same empty-workspace fixture, route, interaction state, and viewport. Framed captures use a macOS bridge fixture in Chrome. The fixture host is offline, so model selection is unavailable.
BB-Thread-ID: thr_zneg2kj4yq