Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Markdown used a content-height layout that required a scrolling parent. Plugin file openers render the built-in preview inside a full-height, overflow-hidden region, leaving long documents without a scroll container. #5185's offset tracking did not change these layout classes.
What changed
How you verified
Missing file scroll container.Before: e9ad6b0 · After: 54ee42f · Captured at 2×.
Both captures use the same fixture, Preview tab, and 800px wheel input; before remains at zero.
User QA approval is pending.
Preview ownership and fixture
Branch dev app remains running in terminal
term_pbpi7vf66xon hosthost_57pj4zhqxr, environmentenv_unhfrbci6j, from this PR worktree viapnpm dev. App port 15456, server port 23456, daemon port 31456. Fresh dev data; synthetic long and short documents; a minimal file opener delegates toOriginal. This reproduces the same full-height opener path without needing a production plugin or personal data.Fixes #5336
BB-Thread-ID: thr_frq37qj86d