fix(ink-win): strip synchronized-update escapes instead of exact-matching them - #900
Open
ozymandiashh wants to merge 1 commit into
Open
fix(ink-win): strip synchronized-update escapes instead of exact-matching them#900ozymandiashh wants to merge 1 commit into
ozymandiashh wants to merge 1 commit into
Conversation
…hing them The ConPTY guard swallowed a chunk only when it exactly equaled BSU or ESU, so any write concatenating them with other output reached Windows raw and hung ConPTY, which buffers the unimplemented 2026 sequence indefinitely (getagentseal#195; the class recurred in getagentseal#863's resize path). Strip every occurrence from string chunks instead: standalone escapes are swallowed, concatenated ones lose only the escapes, and a swallowed write now also honors its callback so callback-style writers cannot wedge. Non-string chunks pass through untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening for the bug class that recurred in #863: the ConPTY guard from #195 compares chunks with exact equality, so
BSU + payloadin one write bypasses it entirely and hangs Windows. This makes the guard structural instead of conventional:includesgate first, so the hot path pays one scan);7 new tests in
tests/ink-win.test.ts, including the exact #863 regression shape (BSU + clear + home).tsc --noEmitclean.Merge-order note: #863 also touches
ink-win.ts(adds the same exports). Whichever lands second has a one-hunk conflict; I will resolve it on the spot.